LBRYCommunity/lbrycrd
1
0
Fork 0
Code Issues 29 Pull requests 1 Projects Releases 32 Packages Wiki Activity

Merge #12182: Remove useless string initializations

Browse source 
19ac86e Remove useless string initialization. (Alin Rus)

Pull request description:

Tree-SHA512: 4273dd7e8ed083cc9d05fc70967465e405085b630c000f829648dd44dd0cfe2249f6af1498b02f54b4ca73833130b802488bae8eca0d4d0b803a6f0122b19e8f
This commit is contained in:
Wladimir J. van der Laan 2018-03-01 20:50:33 +01:00
commit 90a0aed511
No known key found for this signature in database
GPG key ID: 1E4AED62986CD25D
5 changed files with 7 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/netbase.cpp
View file

@ -139,7 +139,7 @@ bool Lookup(const char *pszName, std::vector<CService>& vAddr, int portDefault,
if (pszName[0] == 0) if (pszName[0] == 0)
return false; return false;
int port = portDefault; int port = portDefault;
std::string hostname = ""; std::string hostname;
SplitHostPort(std::string(pszName), port, hostname); SplitHostPort(std::string(pszName), port, hostname);
std::vector<CNetAddr> vIP; std::vector<CNetAddr> vIP;

2
src/rest.cpp
View file

@ -90,7 +90,7 @@ static enum RetFormat ParseDataFormat(std::string& param, const std::string& str
static std::string AvailableDataFormatsString() static std::string AvailableDataFormatsString()
{ {
std::string formats = ""; std::string formats;
for (unsigned int i = 0; i < ARRAYLEN(rf_names); i++) for (unsigned int i = 0; i < ARRAYLEN(rf_names); i++)
if (strlen(rf_names[i].name) > 0) { if (strlen(rf_names[i].name) > 0) {
formats.append("."); formats.append(".");

2
src/test/net_tests.cpp
View file

@ -171,7 +171,7 @@ BOOST_AUTO_TEST_CASE(cnode_simple_test)
ipv4Addr.s_addr = 0xa0b0c001; ipv4Addr.s_addr = 0xa0b0c001;
CAddress addr = CAddress(CService(ipv4Addr, 7777), NODE_NETWORK); CAddress addr = CAddress(CService(ipv4Addr, 7777), NODE_NETWORK);
std::string pszDest = ""; std::string pszDest;
bool fInboundIn = false; bool fInboundIn = false;
// Test that fFeeler is false by default. // Test that fFeeler is false by default.

4
src/utilstrencodings.cpp
View file

@ -127,7 +127,7 @@ std::string EncodeBase64(const unsigned char* pch, size_t len)
{ {
static const char *pbase64 = "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789+/"; static const char *pbase64 = "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789+/";
std::string strRet = ""; std::string strRet;
strRet.reserve((len+2)/3*4); strRet.reserve((len+2)/3*4);
int mode=0, left=0; int mode=0, left=0;
@ -267,7 +267,7 @@ std::string EncodeBase32(const unsigned char* pch, size_t len)
{ {
static const char *pbase32 = "abcdefghijklmnopqrstuvwxyz234567"; static const char *pbase32 = "abcdefghijklmnopqrstuvwxyz234567";
std::string strRet=""; std::string strRet;
strRet.reserve((len+4)/5*8); strRet.reserve((len+4)/5*8);
int mode=0, left=0; int mode=0, left=0;

4
src/wallet/rpcdump.cpp
View file

@ -279,7 +279,7 @@ UniValue importaddress(const JSONRPCRequest& request)
); );
std::string strLabel = ""; std::string strLabel;
if (!request.params[1].isNull()) if (!request.params[1].isNull())
strLabel = request.params[1].get_str(); strLabel = request.params[1].get_str();
@ -452,7 +452,7 @@ UniValue importpubkey(const JSONRPCRequest& request)
); );
std::string strLabel = ""; std::string strLabel;
if (!request.params[1].isNull()) if (!request.params[1].isNull())
strLabel = request.params[1].get_str(); strLabel = request.params[1].get_str();