Merge #12295: Enable flake8 warnings for all currently non-violated rules
a9d0ebc262
Enable flake8 warnings for all currently non-violated rules (practicalswift)4cbab15e75
tests: Fix accidental redefinition of previously defined variable via list comprehension (practicalswift)0b9207efbe
Enable flake8 warning for "list comprehension redefines 'foo' from line N" (F812) (practicalswift) Pull request description: * Enable `flake8` warnings for all currently non-violated rules * Fix accidental redefinition via list comprehension Tree-SHA512: 738b87789e99d02abb2c6b8ff58f65c0cbfeb93e3bf320763e033e510ebd0a4f72861bc8faaf42c14a056a5d4659c33dc70a63730a32cc15159559427bf21193
This commit is contained in:
commit
935eb8de03
2 changed files with 58 additions and 5 deletions
|
@ -6,5 +6,58 @@
|
|||
#
|
||||
# Check for specified flake8 warnings in python files.
|
||||
|
||||
# F401: module imported but unused
|
||||
flake8 --ignore=B,C,E,F,I,N,W --select=F401 .
|
||||
# E112 expected an indented block
|
||||
# E113 unexpected indentation
|
||||
# E115 expected an indented block (comment)
|
||||
# E116 unexpected indentation (comment)
|
||||
# E125 continuation line with same indent as next logical line
|
||||
# E131 continuation line unaligned for hanging indent
|
||||
# E133 closing bracket is missing indentation
|
||||
# E223 tab before operator
|
||||
# E224 tab after operator
|
||||
# E271 multiple spaces after keyword
|
||||
# E272 multiple spaces before keyword
|
||||
# E273 tab after keyword
|
||||
# E274 tab before keyword
|
||||
# E275 missing whitespace after keyword
|
||||
# E304 blank lines found after function decorator
|
||||
# E306 expected 1 blank line before a nested definition
|
||||
# E502 the backslash is redundant between brackets
|
||||
# E702 multiple statements on one line (semicolon)
|
||||
# E703 statement ends with a semicolon
|
||||
# E714 test for object identity should be "is not"
|
||||
# E721 do not compare types, use "isinstance()"
|
||||
# E741 do not use variables named "l", "O", or "I"
|
||||
# E742 do not define classes named "l", "O", or "I"
|
||||
# E743 do not define functions named "l", "O", or "I"
|
||||
# F401 module imported but unused
|
||||
# F402 import module from line N shadowed by loop variable
|
||||
# F404 future import(s) name after other statements
|
||||
# F406 "from module import *" only allowed at module level
|
||||
# F407 an undefined __future__ feature name was imported
|
||||
# F601 dictionary key name repeated with different values
|
||||
# F602 dictionary key variable name repeated with different values
|
||||
# F621 too many expressions in an assignment with star-unpacking
|
||||
# F622 two or more starred expressions in an assignment (a, *b, *c = d)
|
||||
# F631 assertion test is a tuple, which are always True
|
||||
# F701 a break statement outside of a while or for loop
|
||||
# F702 a continue statement outside of a while or for loop
|
||||
# F703 a continue statement in a finally block in a loop
|
||||
# F704 a yield or yield from statement outside of a function
|
||||
# F705 a return statement with arguments inside a generator
|
||||
# F706 a return statement outside of a function/method
|
||||
# F707 an except: block as not the last exception handler
|
||||
# F811 redefinition of unused name from line N
|
||||
# F812 list comprehension redefines 'foo' from line N
|
||||
# F822 undefined name name in __all__
|
||||
# F823 local variable name … referenced before assignment
|
||||
# F831 duplicate argument name in function definition
|
||||
# W292 no newline at end of file
|
||||
# W504 line break after binary operator
|
||||
# W601 .has_key() is deprecated, use "in"
|
||||
# W602 deprecated form of raising exception
|
||||
# W603 "<>" is deprecated, use "!="
|
||||
# W604 backticks are deprecated, use "repr()"
|
||||
# W605 invalid escape sequence "x"
|
||||
|
||||
flake8 --ignore=B,C,E,F,I,N,W --select=E112,E113,E115,E116,E125,E131,E133,E223,E224,E271,E272,E273,E274,E275,E304,E306,E502,E702,E703,E714,E721,E741,E742,E743,F401,F402,F404,F406,F407,F601,F602,F621,F622,F631,F701,F702,F703,F704,F705,F706,F707,F811,F812,F822,F823,F831,W292,W504,W601,W602,W603,W604,W605 .
|
||||
|
|
|
@ -223,8 +223,8 @@ class RawTransactionsTest(BitcoinTestFramework):
|
|||
assert_raises_rpc_error(-1, "JSON value is not a string as expected", self.nodes[2].fundrawtransaction, rawtx, {'change_type': None})
|
||||
assert_raises_rpc_error(-5, "Unknown change type", self.nodes[2].fundrawtransaction, rawtx, {'change_type': ''})
|
||||
rawtx = self.nodes[2].fundrawtransaction(rawtx, {'change_type': 'bech32'})
|
||||
tx = self.nodes[2].decoderawtransaction(rawtx['hex'])
|
||||
assert_equal('witness_v0_keyhash', tx['vout'][rawtx['changepos']]['scriptPubKey']['type'])
|
||||
dec_tx = self.nodes[2].decoderawtransaction(rawtx['hex'])
|
||||
assert_equal('witness_v0_keyhash', dec_tx['vout'][rawtx['changepos']]['scriptPubKey']['type'])
|
||||
|
||||
#########################################################################
|
||||
# test a fundrawtransaction with a VIN smaller than the required amount #
|
||||
|
@ -676,7 +676,7 @@ class RawTransactionsTest(BitcoinTestFramework):
|
|||
self.nodes[3].fundrawtransaction(rawtx, {"feeRate": 2*min_relay_tx_fee}),
|
||||
self.nodes[3].fundrawtransaction(rawtx, {"feeRate": 2*min_relay_tx_fee, "subtractFeeFromOutputs": [0]})]
|
||||
|
||||
dec_tx = [self.nodes[3].decoderawtransaction(tx['hex']) for tx in result]
|
||||
dec_tx = [self.nodes[3].decoderawtransaction(tx_['hex']) for tx_ in result]
|
||||
output = [d['vout'][1 - r['changepos']]['value'] for d, r in zip(dec_tx, result)]
|
||||
change = [d['vout'][r['changepos']]['value'] for d, r in zip(dec_tx, result)]
|
||||
|
||||
|
|
Loading…
Reference in a new issue