LBRYCommunity/lbrycrd
1
0
Fork 0
Code Issues 29 Pull requests 1 Projects Releases 32 Packages Wiki Activity

tiny refactor for ArgsManager

Browse source 
This commit contains 2 refactors.

1. mark "const" on ArgsManager::GetHelpMessage and IsArgKnown.
2. remove unused "error" argument from ArgsManager::IsArgKnown.

Firstly, I mark "const" on where it is possible to. It is mentioned
before (e.g. https://github.com/bitcoin/bitcoin/pull/13190#pullrequestreview-118823133).

And about 2nd change, ArgsManager::IsArgKnown was added at commit #4f8704d which was
merged at PR #13112. But from its beggining, "error" argument never be used.
I think it should be refactored.
This commit is contained in:
AtsukiTak 2018-07-21 18:53:54 +09:00
parent 07ce278455
commit 9544a3f3fc
2 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/util.cpp
View file

@ -446,7 +446,7 @@ bool ArgsManager::ParseParameters(int argc, const char* const argv[], std::strin
// Check that the arg is known // Check that the arg is known
if (!(IsSwitchChar(key[0]) && key.size() == 1)) { if (!(IsSwitchChar(key[0]) && key.size() == 1)) {
if (!IsArgKnown(key, error)) { if (!IsArgKnown(key)) {
error = strprintf("Invalid parameter %s", key.c_str()); error = strprintf("Invalid parameter %s", key.c_str());
return false; return false;
} }
@ -466,7 +466,7 @@ bool ArgsManager::ParseParameters(int argc, const char* const argv[], std::strin
return true; return true;
} }
bool ArgsManager::IsArgKnown(const std::string& key, std::string& error) bool ArgsManager::IsArgKnown(const std::string& key) const
{ {
size_t option_index = key.find('.'); size_t option_index = key.find('.');
std::string arg_no_net; std::string arg_no_net;
@ -591,7 +591,7 @@ void ArgsManager::AddHiddenArgs(const std::vector<std::string>& names)
} }
} }
std::string ArgsManager::GetHelpMessage() std::string ArgsManager::GetHelpMessage() const
{ {
const bool show_debug = gArgs.GetBoolArg("-help-debug", false); const bool show_debug = gArgs.GetBoolArg("-help-debug", false);
@ -859,7 +859,7 @@ bool ArgsManager::ReadConfigStream(std::istream& stream, std::string& error, boo
} }
// Check that the arg is known // Check that the arg is known
if (!IsArgKnown(strKey, error) && !ignore_invalid_keys) { if (!IsArgKnown(strKey) && !ignore_invalid_keys) {
error = strprintf("Invalid configuration value %s", option.first.c_str()); error = strprintf("Invalid configuration value %s", option.first.c_str());
return false; return false;
} }

4
src/util.h
View file

@ -276,12 +276,12 @@ public:
/** /**
* Get the help string * Get the help string
*/ */
std::string GetHelpMessage(); std::string GetHelpMessage() const;
/** /**
* Check whether we know of this arg * Check whether we know of this arg
*/ */
bool IsArgKnown(const std::string& key, std::string& error); bool IsArgKnown(const std::string& key) const;
}; };
extern ArgsManager gArgs; extern ArgsManager gArgs;