Merge pull request #6054

d1af89e use const reference as param in ConnectThroughProxy/Socks5 (Philip Kaufmann)
This commit is contained in:
Pieter Wuille 2015-04-28 07:00:31 -07:00
commit 9e06be2802
No known key found for this signature in database
GPG key ID: 57896D2FF8F0B657

View file

@ -293,7 +293,7 @@ struct ProxyCredentials
}; };
/** Connect using SOCKS5 (as described in RFC1928) */ /** Connect using SOCKS5 (as described in RFC1928) */
bool static Socks5(string strDest, int port, const ProxyCredentials *auth, SOCKET& hSocket) static bool Socks5(const std::string& strDest, int port, const ProxyCredentials *auth, SOCKET& hSocket)
{ {
LogPrintf("SOCKS5 connecting %s\n", strDest); LogPrintf("SOCKS5 connecting %s\n", strDest);
if (strDest.size() > 255) { if (strDest.size() > 255) {
@ -558,7 +558,7 @@ bool IsProxy(const CNetAddr &addr) {
return false; return false;
} }
static bool ConnectThroughProxy(const proxyType &proxy, const std::string strDest, int port, SOCKET& hSocketRet, int nTimeout, bool *outProxyConnectionFailed) static bool ConnectThroughProxy(const proxyType &proxy, const std::string& strDest, int port, SOCKET& hSocketRet, int nTimeout, bool *outProxyConnectionFailed)
{ {
SOCKET hSocket = INVALID_SOCKET; SOCKET hSocket = INVALID_SOCKET;
// first connect to proxy server // first connect to proxy server