LBRYCommunity/lbrycrd
1
0
Fork 0
Code Issues 29 Pull requests 1 Projects Releases 32 Packages Wiki Activity

doc: add note to contributor docs about warranted PR's

Browse source
This commit is contained in:
Karl-Johan Alm 2018-07-30 22:53:47 +09:00
parent 222e627322
commit db213aa47f
No known key found for this signature in database
GPG key ID: 5474FBF5227BEFAD
1 changed files with 2 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
CONTRIBUTING.md
View file

@ -119,6 +119,8 @@ At this stage one should expect comments and review from other contributors. You
can add more commits to your pull request by committing them locally and pushing can add more commits to your pull request by committing them locally and pushing
to your fork until you have satisfied all feedback. to your fork until you have satisfied all feedback.
Note: Code review is a burdensome but important part of the development process, and as such, certain types of pull requests are rejected. In general, if the **improvements** do not warrant the **review effort** required, the PR has a high chance of being rejected. It is up to the PR author to convince the reviewers that the changes warrant the review effort, and if reviewers are "Concept NAK'ing" the PR, the author may need to present arguments and/or do research backing their suggested changes.
Squashing Commits Squashing Commits
--------------------------- ---------------------------
If your pull request is accepted for merging, you may be asked by a maintainer If your pull request is accepted for merging, you may be asked by a maintainer