LBRYCommunity/lbrycrd
1
0
Fork 0
Code Issues 29 Pull requests 1 Projects Releases 32 Packages Wiki Activity

[doc] Remove outdated comment about mining code ignoring CPFP

Browse source 
BlockAssembler chooses transactions on the basis of packages (which incorporate
unconfirmed ancestors into feerate), so the specified RBF comment about mining
code ignoring CPFP is out of date.
This commit is contained in:
James O'Beirne 2018-07-16 18:34:28 -04:00
parent 88a15ebc8d
commit db6eb90094
1 changed files with 5 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
src/validation.cpp
View file

@ -806,13 +806,11 @@ static bool AcceptToMemoryPoolWorker(const CChainParams& chainparams, CTxMemPool
// be increased is also an easy-to-reason about way to prevent // be increased is also an easy-to-reason about way to prevent
// DoS attacks via replacements. // DoS attacks via replacements.
// //
// The mining code doesn't (currently) take children into // We only consider the feerates of transactions being directly
// account (CPFP) so we only consider the feerates of // replaced, not their indirect descendants. While that does
// transactions being directly replaced, not their indirect // mean high feerate children are ignored when deciding whether
// descendants. While that does mean high feerate children are // or not to replace, we do require the replacement to pay more
// ignored when deciding whether or not to replace, we do // overall fees too, mitigating most cases.
// require the replacement to pay more overall fees too,
// mitigating most cases.
CFeeRate oldFeeRate(mi->GetModifiedFee(), mi->GetTxSize()); CFeeRate oldFeeRate(mi->GetModifiedFee(), mi->GetTxSize());
if (newFeeRate <= oldFeeRate) if (newFeeRate <= oldFeeRate)
{ {