LBRYCommunity/lbrycrd
1
0
Fork 0
Code Issues 29 Pull requests 1 Projects Releases 32 Packages Wiki Activity

tests: Fix test_runner return value in case of skipped test

Browse source 
Currently test_runner reports an error if a test case is skipped.
This is not how it should be, only failed tests should cause it to fail.
This commit is contained in:
Wladimir J. van der Laan 2017-04-11 19:40:54 +02:00
parent 67023e9004
commit e96462fbec
1 changed files with 6 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
test/functional/test_runner.py
View file

@ -293,7 +293,7 @@ def run_tests(test_list, src_dir, build_dir, exeext, jobs=1, enable_coverage=Fal
logging.debug("Cleaning up coverage data") logging.debug("Cleaning up coverage data")
coverage.cleanup() coverage.cleanup()
all_passed = all(map(lambda test_result: test_result.status == "Passed", test_results)) all_passed = all(map(lambda test_result: test_result.was_successful, test_results))
sys.exit(not all_passed) sys.exit(not all_passed)
@ -305,7 +305,7 @@ def print_results(test_results, max_len_name, runtime):
time_sum = 0 time_sum = 0
for test_result in test_results: for test_result in test_results:
all_passed = all_passed and test_result.status != "Failed" all_passed = all_passed and test_result.was_successful
time_sum += test_result.time time_sum += test_result.time
test_result.padding = max_len_name test_result.padding = max_len_name
results += str(test_result) results += str(test_result)
@ -393,6 +393,10 @@ class TestResult():
return color[1] + "%s | %s%s | %s s\n" % (self.name.ljust(self.padding), glyph, self.status.ljust(7), self.time) + color[0] return color[1] + "%s | %s%s | %s s\n" % (self.name.ljust(self.padding), glyph, self.status.ljust(7), self.time) + color[0]
@property
def was_successful(self):
return self.status != "Failed"
def check_script_list(src_dir): def check_script_list(src_dir):
"""Check scripts directory. """Check scripts directory.