Do not add random inbound peers to addrman.
We should learn about new peers via address messages. An inbound peer connecting to us tells us nothing about its ability to accept incoming connections from us, so we shouldn't assume that we can connect to it based on this. The vast majority of nodes on the network do not accept incoming connections, adding them will only slow down the process of making a successful connection in the future. Nodes which have configured themselves to not announce would prefer we not violate their privacy by announcing them in GETADDR responses.
This commit is contained in:
parent
53f8f226bd
commit
eb3596f7c2
1 changed files with 0 additions and 6 deletions
|
@ -5029,12 +5029,6 @@ bool static ProcessMessage(CNode* pfrom, string strCommand, CDataStream& vRecv,
|
||||||
pfrom->fGetAddr = true;
|
pfrom->fGetAddr = true;
|
||||||
}
|
}
|
||||||
addrman.Good(pfrom->addr);
|
addrman.Good(pfrom->addr);
|
||||||
} else {
|
|
||||||
if (((CNetAddr)pfrom->addr) == (CNetAddr)addrFrom)
|
|
||||||
{
|
|
||||||
addrman.Add(addrFrom, addrFrom);
|
|
||||||
addrman.Good(addrFrom);
|
|
||||||
}
|
|
||||||
}
|
}
|
||||||
|
|
||||||
pfrom->fSuccessfullyConnected = true;
|
pfrom->fSuccessfullyConnected = true;
|
||||||
|
|
Loading…
Reference in a new issue