LBRYCommunity/lbrycrd
1
0
Fork 0
Code Issues 29 Pull requests 1 Projects Releases 32 Packages Wiki Activity

[test] Add tests for some walletmodel functions

Browse source 
Add unit tests for some walletmodel functions that will be refactored & moved
in the next commit.
This commit is contained in:
Russell Yanofsky 2017-04-28 13:59:25 -04:00
parent 526e8390e6
commit ef8ca179ef
2 changed files with 127 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/Makefile.qttest.include
View file

@ -46,7 +46,8 @@ qt_test_test_bitcoin_qt_SOURCES = \
if ENABLE_WALLET
qt_test_test_bitcoin_qt_SOURCES += \
qt/test/paymentservertests.cpp \
qt/test/wallettests.cpp
qt/test/wallettests.cpp \
wallet/test/wallet_test_fixture.cpp
endif
nodist_qt_test_test_bitcoin_qt_SOURCES = $(TEST_QT_MOC_CPP)

127
src/qt/test/wallettests.cpp
View file

@ -1,5 +1,6 @@
#include "wallettests.h"
#include "consensus/validation.h"
#include "qt/bitcoinamountfield.h"
#include "qt/callback.h"
#include "qt/optionsmodel.h"
@ -11,6 +12,8 @@
#include "qt/walletmodel.h"
#include "test/test_bitcoin.h"
#include "validation.h"
#include "wallet/test/wallet_test_fixture.h"
#include "wallet/coincontrol.h"
#include "wallet/wallet.h"
#include <QAbstractButton>
@ -20,6 +23,118 @@
namespace
{
void TestLoadReceiveRequests()
{
WalletTestingSetup test;
OptionsModel optionsModel;
WalletModel walletModel(nullptr, pwalletMain, &optionsModel);
CTxDestination dest = CKeyID();
pwalletMain->AddDestData(dest, "misc", "val_misc");
pwalletMain->AddDestData(dest, "rr0", "val_rr0");
pwalletMain->AddDestData(dest, "rr1", "val_rr1");
std::vector<std::string> values;
walletModel.loadReceiveRequests(values);
QCOMPARE((int)values.size(), 2);
QCOMPARE(QString::fromStdString(values[0]), QString("val_rr0"));
QCOMPARE(QString::fromStdString(values[1]), QString("val_rr1"));
}
class ListCoinsTestingSetup : public TestChain100Setup
{
public:
ListCoinsTestingSetup()
{
CreateAndProcessBlock({}, GetScriptForRawPubKey(coinbaseKey.GetPubKey()));
::bitdb.MakeMock();
wallet.reset(new CWallet(std::unique_ptr<CWalletDBWrapper>(new CWalletDBWrapper(&bitdb, "wallet_test.dat"))));
bool firstRun;
wallet->LoadWallet(firstRun);
LOCK(wallet->cs_wallet);
wallet->AddKeyPubKey(coinbaseKey, coinbaseKey.GetPubKey());
wallet->ScanForWalletTransactions(chainActive.Genesis());
}
~ListCoinsTestingSetup()
{
::bitdb.Flush(true);
::bitdb.Reset();
}
CWalletTx& AddTx(CRecipient recipient)
{
CWalletTx wtx;
CReserveKey reservekey(wallet.get());
CAmount fee;
int changePos = -1;
std::string error;
wallet->CreateTransaction({recipient}, wtx, reservekey, fee, changePos, error);
CValidationState state;
wallet->CommitTransaction(wtx, reservekey, nullptr, state);
auto it = wallet->mapWallet.find(wtx.GetHash());
CreateAndProcessBlock({CMutableTransaction(*it->second.tx)}, GetScriptForRawPubKey(coinbaseKey.GetPubKey()));
it->second.SetMerkleBranch(chainActive.Tip(), 1);
return it->second;
}
std::unique_ptr<CWallet> wallet;
};
void TestListCoins()
{
ListCoinsTestingSetup test;
OptionsModel optionsModel;
WalletModel walletModel(nullptr, test.wallet.get(), &optionsModel);
QString coinbaseAddress = QString::fromStdString(CBitcoinAddress(test.coinbaseKey.GetPubKey().GetID()).ToString());
LOCK(test.wallet->cs_wallet);
// Confirm ListCoins initially returns 1 coin grouped under coinbaseKey
// address.
std::map<QString, std::vector<COutput>> list;
walletModel.listCoins(list);
QCOMPARE((int)list.size(), 1);
QCOMPARE(list.begin()->first, coinbaseAddress);
QCOMPARE((int)list.begin()->second.size(), 1);
// Check initial balance from one mature coinbase transaction.
CCoinControl coinControl;
QCOMPARE(50 * COIN, walletModel.getBalance(&coinControl));
// Add a transaction creating a change address, and confirm ListCoins still
// returns the coin associated with the change address underneath the
// coinbaseKey pubkey, even though the change address has a different
// pubkey.
test.AddTx(CRecipient{GetScriptForRawPubKey({}), 1 * COIN, false /* subtract fee */});
list.clear();
walletModel.listCoins(list);
QCOMPARE((int)list.size(), 1);
QCOMPARE(list.begin()->first, coinbaseAddress);
QCOMPARE((int)list.begin()->second.size(), 2);
// Lock both coins. Confirm number of available coins drops to 0.
std::vector<COutput> available;
test.wallet->AvailableCoins(available);
QCOMPARE((int)available.size(), 2);
for (const auto& group : list) {
for (const auto& coin : group.second) {
test.wallet->LockCoin(COutPoint(coin.tx->GetHash(), coin.i));
}
}
test.wallet->AvailableCoins(available);
QCOMPARE((int)available.size(), 0);
// Confirm ListCoins still returns same result as before, despite coins
// being locked.
list.clear();
walletModel.listCoins(list);
QCOMPARE((int)list.size(), 1);
QCOMPARE(list.begin()->first, coinbaseAddress);
QCOMPARE((int)list.begin()->second.size(), 2);
}
//! Press "Yes" button in modal send confirmation dialog.
void ConfirmSend()
{
@ -65,7 +180,6 @@ QModelIndex FindTx(const QAbstractItemModel& model, const uint256& txid)
}
return {};
}
}
//! Simple qt wallet tests.
//
@ -80,7 +194,7 @@ QModelIndex FindTx(const QAbstractItemModel& model, const uint256& txid)
// src/qt/test/test_bitcoin-qt -platform xcb # Linux
// src/qt/test/test_bitcoin-qt -platform windows # Windows
// src/qt/test/test_bitcoin-qt -platform cocoa # macOS
void WalletTests::walletTests()
void TestSendCoins()
{
// Set up wallet and chain with 101 blocks (1 mature block for spending).
TestChain100Setup test;
@ -117,3 +231,12 @@ void WalletTests::walletTests()
bitdb.Flush(true);
bitdb.Reset();
}
}
void WalletTests::walletTests()
{
TestLoadReceiveRequests();
TestListCoins();
TestSendCoins();
}