LBRYCommunity/lbrycrd
1
0
Fork 0
Code Issues 29 Pull requests 1 Projects Releases 32 Packages Wiki Activity

http: use std::move to move HTTPRequest into HTTPWorkItem

Browse source 
Thanks to Cory Fields for the idea.
This commit is contained in:
Wladimir J. van der Laan 2016-05-04 16:05:17 +02:00
parent 37b21372a0
commit f0188f9178
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/httpserver.cpp
View file

@ -44,8 +44,8 @@ static const size_t MAX_HEADERS_SIZE = 8192;
class HTTPWorkItem : public HTTPClosure class HTTPWorkItem : public HTTPClosure
{ {
public: public:
HTTPWorkItem(HTTPRequest* req, const std::string &path, const HTTPRequestHandler& func): HTTPWorkItem(std::unique_ptr<HTTPRequest> req, const std::string &path, const HTTPRequestHandler& func):
req(req), path(path), func(func) req(std::move(req)), path(path), func(func)
{ {
} }
void operator()() void operator()()
@ -281,7 +281,7 @@ static void http_request_cb(struct evhttp_request* req, void* arg)
// Dispatch to worker thread // Dispatch to worker thread
if (i != iend) { if (i != iend) {
std::unique_ptr<HTTPWorkItem> item(new HTTPWorkItem(hreq.release(), path, i->handler)); std::unique_ptr<HTTPWorkItem> item(new HTTPWorkItem(std::move(hreq), path, i->handler));
assert(workQueue); assert(workQueue);
if (workQueue->Enqueue(item.get())) if (workQueue->Enqueue(item.get()))
item.release(); /* if true, queue took ownership */ item.release(); /* if true, queue took ownership */