Make sure we re-acquire lock if a task throws
This commit is contained in:
parent
1e92b27540
commit
fb08d92312
1 changed files with 7 additions and 5 deletions
|
@ -6,6 +6,7 @@
|
|||
|
||||
#include <assert.h>
|
||||
#include <boost/bind.hpp>
|
||||
#include <boost/thread/reverse_lock.hpp>
|
||||
#include <utility>
|
||||
|
||||
CScheduler::CScheduler() : nThreadsServicingQueue(0), stopRequested(false), stopWhenEmpty(false)
|
||||
|
@ -65,11 +66,12 @@ void CScheduler::serviceQueue()
|
|||
Function f = taskQueue.begin()->second;
|
||||
taskQueue.erase(taskQueue.begin());
|
||||
|
||||
// Unlock before calling f, so it can reschedule itself or another task
|
||||
// without deadlocking:
|
||||
lock.unlock();
|
||||
f();
|
||||
lock.lock();
|
||||
{
|
||||
// Unlock before calling f, so it can reschedule itself or another task
|
||||
// without deadlocking:
|
||||
boost::reverse_lock<boost::unique_lock<boost::mutex> > rlock(lock);
|
||||
f();
|
||||
}
|
||||
} catch (...) {
|
||||
--nThreadsServicingQueue;
|
||||
throw;
|
||||
|
|
Loading…
Reference in a new issue