Pieter Wuille
d5eb41fa08
Merge pull request #1129 from laanwj/2012_04_opcodes
...
Add explicit numeric constant value for all opcodes
2012-04-21 16:43:31 -07:00
Gavin Andresen
febe76e316
Merge pull request #1121 from gavinandresen/scripttest
...
Data-driven script evaluation unit tests (rebased to fix compiler warning).
2012-04-21 16:36:41 -07:00
Gavin Andresen
8449a8788a
Data-drive script evaluation unit tests.
2012-04-21 19:35:39 -04:00
Pieter Wuille
6a7a42be16
Merge pull request #1126 from drizztbsd/master
...
Fix build with gcc 4.7
2012-04-21 15:13:29 -07:00
Wladimir J. van der Laan
88dc2d6c6a
Integrate @JoelKatz's optimized ToHex ( #562 ) into current HexStr function
2012-04-21 20:37:50 +02:00
Wladimir J. van der Laan
b6c837cbe1
Remove no-longer used UI hints in bitcoin core
...
The Qt UI has its own associated structures for temporary transaction state / cache.
2012-04-21 18:21:19 +02:00
Wladimir J. van der Laan
cdcc319c2d
change type of various bare chars to bool that are only used as bool (and never serialized)
2012-04-21 18:16:11 +02:00
Wladimir J. van der Laan
7be8b2ff9c
Add explicit numeric constant value for all opcodes
...
- Easier for debugging (what opcode was 0x... again?)
- Clarifies that the opcodes are set in stone in the protocol, and signals that it is impossible to insert opcodes in between.
2012-04-21 10:34:18 +02:00
Pieter Wuille
e46704dd90
Expose CRPCTable via bitcoinrpc.h for testing
2012-04-21 01:37:34 +02:00
Pieter Wuille
9862229d4d
Encapsulate mapCommands in class CRPCTable
2012-04-21 01:20:05 +02:00
Jeff Garzik
dc42bf52c1
Encapsulate RPC command dispatch in an array of CRPCCommand's
2012-04-21 01:20:05 +02:00
Wladimir J. van der Laan
00b9c0f4b2
Merge pull request #1122 from dlitz/unsigned-char-fix
...
Unsigned char fix & fix undefined phexdigits[255]
2012-04-20 10:18:45 -07:00
Timothy Redaelli
9553c35d89
Add missing includes. (Fix bulding under GCC 4.7)
2012-04-20 12:50:57 +02:00
Pieter Wuille
3b9e6b7820
Merge pull request #959 from rebroad/LoadBlockIndexKillable
...
Added ability to respond to signals during Block Loading stage.
2012-04-19 04:33:04 -07:00
Pieter Wuille
c73ba23eb5
gettransaction RPC for non-wallet transactions
...
Works for wallet transactions, memory-pool transaction and block chain
transactions.
Available for all:
* txid
* version
* locktime
* size
* coinbase/inputs/outputs
* confirmations
Available only for wallet transactions:
* amount
* fee
* details
* blockindex
Available for wallet transactions and block chain transactions:
* blockhash
* time
2012-04-18 23:42:07 +02:00
R E Broadley
871c3557bf
Added ability to respond to signals during Block Loading stage.
2012-04-18 12:30:24 +01:00
Dwayne C. Litzenberger
8c8e8c2e93
Fix bugs on 'unsigned char' platforms.
...
In ISO C++, the signedness of 'char' is undefined. On some platforms (e.g.
ARM), 'char' is an unsigned type, but some of the code relies on 'char' being
signed (as it is on x86). This is indicated by compiler warnings like this:
bignum.h: In constructor 'CBigNum::CBigNum(char)':
bignum.h:81:59: warning: comparison is always true due to limited range of data type [-Wtype-limits]
util.cpp: In function 'bool IsHex(const string&)':
util.cpp:427:28: warning: comparison is always false due to limited range of data type [-Wtype-limits]
In particular, IsHex erroneously returned true regardless of the input
characters, as long as the length of the string was a positive multiple of 2.
Note: For testing, it's possible using GCC to force char to be unsigned by
adding the -funsigned-char parameter to xCXXFLAGS.
2012-04-18 00:33:32 -04:00
Dwayne C. Litzenberger
a6fa147c8d
Fix phexdigits[255] is undefined.
2012-04-18 00:33:32 -04:00
Wladimir J. van der Laan
ac4161e25d
Merge pull request #1118 from sipa/addbreaks
...
Add missing breaks in optionmodel's switch case
2012-04-17 14:33:26 -07:00
Pieter Wuille
559fc3c610
Add missing breaks in optionmodel's switch case
2012-04-17 23:27:59 +02:00
Pieter Wuille
031eae7864
Merge pull request #1114 from sipa/lesssync
...
Reduce sync frequency for blkindex.dat
2012-04-17 14:23:31 -07:00
Pieter Wuille
0a83c0fcef
Fix tests after recent refactors
2012-04-17 20:37:47 +02:00
Pieter Wuille
c23617fef3
Merge remote-tracking branch 'jgarzik/mempool'
2012-04-17 20:12:48 +02:00
Pieter Wuille
caeddc5d37
Merge pull request #1117 from sipa/deadlockfix
...
Fix potential deadlock
2012-04-17 11:05:02 -07:00
Pieter Wuille
1ffeb89a52
Merge pull request #1112 from sipa/saneserial
...
Further reduce header dependencies
2012-04-17 11:04:29 -07:00
Pieter Wuille
6b6aaa1698
Further reduce header dependencies
...
This commit removes the dependency of serialize.h on PROTOCOL_VERSION,
and makes this parameter required instead of implicit. This is much saner,
as it makes the places where changing a version number can have an
influence obvious.
2012-04-17 20:03:42 +02:00
Jeff Garzik
ccd65d4261
Move proto version to version.h. Reduce header deps a bit more.
2012-04-17 20:02:38 +02:00
Jeff Garzik
9eace6b113
Move CWalletDB code to new walletdb module.
...
In addition to standard code separation, this change opens the door
to fixing several include inter-dependencies.
2012-04-17 20:00:55 +02:00
Pieter Wuille
ed6d0b5f85
Remove headers.h
2012-04-17 20:00:55 +02:00
Gavin Andresen
b97d54355e
Merge pull request #1106 from jgarzik/sign-compare
...
Fix many sign-comparison warnings found in bitcoin codebase
2012-04-17 10:55:56 -07:00
Gavin Andresen
e873dc654c
Merge pull request #1115 from laanwj/2012_04_cleanupmisc
...
Delete unused, unreachable and commented code, add missing initializer
2012-04-17 10:12:33 -07:00
Pieter Wuille
c581cc16bb
Fix potential deadlock
...
Conflict:
* cs_main in ProcessMessages() (before calling ProcessMessages)
* cs_vSend in CNode::BeginMessage
versus:
* cs_vSend in ThreadMessageHandler2 (before calling SendMessages)
* cs_main in SendMessages
Even though cs_vSend is a try_lock, if it succeeds simultaneously with
the locking of cs_main in ProcessMessages(), it could cause a deadlock.
2012-04-17 18:50:52 +02:00
Jeff Garzik
ce8c93498a
main.cpp: replace tabs with spaces
...
Sometimes they sneak in through the 'vi' door
2012-04-17 12:31:51 -04:00
Jeff Garzik
8bff8ac079
AlreadyHave(): only hold lock during mapTransactions access
2012-04-17 12:30:00 -04:00
Wladimir J. van der Laan
7fa3ad83a9
Remove unused and unreachable code
2012-04-17 18:28:02 +02:00
Wladimir J. van der Laan
4941aad657
Add forgotten initializer
2012-04-17 18:27:55 +02:00
Pieter Wuille
8f2b50f178
Reduce sync frequency for blkindex.dat
...
Since auto-remove-db-logs was enabled, each time a CTxDB was closed
outside of the initial download window, it causes a checkpoint + log
cleanup. This is overkill, so reduce the sync frequency to once per
minute at most.
2012-04-17 18:27:18 +02:00
Jeff Garzik
dd21ce5f1b
Merge pull request #1094 from jgarzik/already-have-locking
...
Locking fix for AlreadyHave()
2012-04-17 09:23:49 -07:00
Jeff Garzik
ea9627979e
Bump PROTOCOL_VERSION to 60001, thereby enabling BIP31
2012-04-17 12:16:46 -04:00
Jeff Garzik
865a0c1674
Merge pull request #1081 from jgarzik/pong
...
BIP 0031: pong message
2012-04-17 08:51:17 -07:00
Wladimir J. van der Laan
7a5452ffb3
Merge pull request #1092 from laanwj/2012_04_sendcoins_setlabelfix
...
When sending coins, set label when selecting address that already has a label
2012-04-16 05:41:39 -07:00
Wladimir J. van der Laan
088a13331b
Merge pull request #1091 from Diapolo/GUI-BlockDL
...
revert to default OS theme for progressbar (fix #1071 )
2012-04-16 00:55:37 -07:00
Jeff Garzik
9fb89c26f3
Fix misc. minor sign-comparison warnings
2012-04-15 17:00:20 -04:00
Jeff Garzik
0dd710acb6
CNode's nHeaderStart may be negative, so change its type
2012-04-15 16:59:48 -04:00
Jeff Garzik
c3fad8350b
serialize.h: CAutoFile's read and write may take size_t nSize
2012-04-15 16:59:09 -04:00
Jeff Garzik
3a78f82a78
Fix sign-compare warnings: netbase's Lookup* max-solutions may be unsigned
2012-04-15 16:58:32 -04:00
Jeff Garzik
c376ac359e
Fix loop index var types, fixing many minor sign comparison warnings
...
foo.size() typically returns an unsigned integral type; make loop variables
match those types' signedness.
2012-04-15 16:52:09 -04:00
Jeff Garzik
ab9dc75a18
The string class returns string::npos, when find() fails.
...
Noticed when sign-comparison warnings were enabled.
2012-04-15 16:47:24 -04:00
Jeff Garzik
ca4c4c53a8
CTxMemPool: add helper methods, to reduce global mempool.mapTx accesses
2012-04-15 14:43:19 -04:00
Jeff Garzik
d01903e751
CTxMemPool: encapsulate AcceptToMemoryPool
2012-04-15 14:43:19 -04:00