lbrycrd

LBRYCommunity/lbrycrd

Fork 0

Commit graph

Author	SHA1	Message	Date
Daniel Kraft	60ebc7da4c	trivial: Mark overrides as such. This trivial change adds the "override" keyword to some methods of subclasses meant to override interface methods. This ensures that any future change to the interface' method signatures which are not correctly mirrored in the subclass will break at compile time with a clear error message, rather than fail at runtime (which is harder to debug).	2018-05-20 09:15:39 +02:00
Jesse Cohen	dd435ad402	Add unit tests for signals generated by ProcessNewBlock() After a recent bug discovered in callback ordering in MainSignals, this test checks invariants in ordering of BlockConnected / BlockDisconnected / UpdatedChainTip signals	2018-05-16 08:28:15 -04:00

Author

SHA1

Message

Date

Daniel Kraft

60ebc7da4c

trivial: Mark overrides as such.

This trivial change adds the "override" keyword to some methods of
subclasses meant to override interface methods.  This ensures that any
future change to the interface' method signatures which are not correctly
mirrored in the subclass will break at compile time with a clear error message,
rather than fail at runtime (which is harder to debug).

2018-05-20 09:15:39 +02:00

Jesse Cohen

dd435ad402

Add unit tests for signals generated by ProcessNewBlock()

After a recent bug discovered in callback ordering in MainSignals,
this test checks invariants in ordering of
BlockConnected / BlockDisconnected / UpdatedChainTip signals

2018-05-16 08:28:15 -04:00

2 commits