Peter Todd
005609539b
Show short scriptPubKeys correctly
...
Previously bitcoin-qt's -debug transaction info was showing CTxOut([error])
It is valid for a scriptPubKey to be any size, for example simply
OP_RETURN is valid and can be used to destroy a TXOUT to mining fees.
2013-10-24 04:52:16 -04:00
Peter Todd
22de68dffc
Relay OP_RETURN TxOut as standard transaction type
...
Also fix decoderawtransaction to not show reqSigs or addresses for
nulldata txouts. (Previous version also left reqSigs uninitialized
mistakenly)
2013-10-24 04:32:35 -04:00
Wladimir J. van der Laan
faf923f06a
Merge pull request #3135 from Diapolo/bitcoingui
...
bitcoingui: show main window (if hidden) on modal messages
2013-10-24 00:21:54 -07:00
Wladimir J. van der Laan
7ed1f6b421
Merge pull request #3139 from Diapolo/maturity
...
[Qt]: fix num Blocks to maturity in Tx description
2013-10-24 00:16:41 -07:00
Wladimir J. van der Laan
9d580b82c5
Merge pull request #3137 from Diapolo/RPC
...
RPC: error code changes and prevent crash with walletpassphrase
2013-10-24 00:13:18 -07:00
Philip Kaufmann
800d5b14c7
[Qt]: fix num Blocks to maturity in Tx description
...
- as we have main.h included in transactiondesc.cpp, we now also use
COINBASE_MATURITY + 1 for the descriptive string
- fixes #3131
2013-10-24 09:04:46 +02:00
Philip Kaufmann
4315ec1a72
RPC: error code changes and prevent crash with walletpassphrase
...
- fix crash with walletpassphrase by checking if RPC server is running and
give a friendly error message how to fix this (fixes #3100 )
- add 3 new RPCErrorCodes RPC_SERVER_NOT_STARTED, RPC_NODE_ALREADY_ADDED
and RCP_NODE_NOT_ADDED (I checked the source to not use a number already
in use for RPC_SERVER_NOT_STARTED)
- use the new codes where needed / missing
- add missing use of RPC_INVALID_PARAMETER
2013-10-24 09:03:02 +02:00
Philip Kaufmann
8abac716ea
bitcoingui: show main window (if hidden) on modal messages
2013-10-23 15:12:28 +02:00
Wladimir J. van der Laan
38fd110107
Merge pull request #3134 from laanwj/2013_10_format_monetary_test
...
Add test for monetary value parsing
2013-10-23 05:16:51 -07:00
Wladimir J. van der Laan
840905a8fd
Add test for monetary value parsing
...
Just-in-case sanity test for JSON spirit and AmountFromValue.
Also update rpc_format_monetary_values test to use ValueFromAmount,
so that ValueFromAmount is also tested.
2013-10-23 13:37:51 +02:00
Gavin Andresen
9bd5b0be53
Merge pull request #3133 from laanwj/2013_10_format_monetary_test
...
Add test for monetary value formatting
2013-10-23 02:13:18 -07:00
Wladimir J. van der Laan
4538130790
Add test for monetary value formatting
...
Tests for issue #3126 .
This problem pops up after upgrading json-spirit.
2013-10-23 09:42:48 +02:00
Wladimir J. van der Laan
33a2febf5d
qt: show payment information in one text area
...
Simplifies the dialog (makes it look less crowded) as well
as the code and makes it possible to copy multiple fields at once.
Also format bitcoin URI as URI, add copy button for URI.
2013-10-23 09:15:25 +02:00
Wladimir J. van der Laan
786b066f03
qt: move bitcoin URI formatting to guiutil
...
Follow the same pattern as the parseBitcoinURI function.
2013-10-23 09:15:25 +02:00
Wladimir J. van der Laan
8a7f37c797
qt: use SendCoinsRecipient for payment request information
...
This brings some symmetry into the design by using the same object
both for incoming URIs that are parsed as for outgoing URIs that
are formatted.
2013-10-23 09:15:25 +02:00
Wladimir J. van der Laan
03535acd05
qt: add message field to SendCoinsRecipient
...
Also update URI parsing to fill in this field.
Note that the message is not currently used in any way with the client.
It should be stored with the transaction.
2013-10-23 09:15:25 +02:00
Wladimir J. van der Laan
82095923bb
qt: allow dragging, copying and saving QR code
...
Add context menu and drag handling to QR code widget.
2013-10-23 09:15:25 +02:00
Wladimir J. van der Laan
864a6f790e
qt: remove verify/send message and send coins from address book
...
These no longer make sense in the new workflow. It's less
clicks to reach sign/verify message from the menu. And sending
from the address book is one kind of automatic address reuse
we're trying to avoid.
2013-10-23 09:15:25 +02:00
Wladimir J. van der Laan
74fb765e29
qt: rework "receive coins" workflow
2013-10-23 09:15:24 +02:00
Wladimir J. van der Laan
58daa0162c
Merge pull request #3129 from Diapolo/rem-dup-helpmsg
...
remove duplicate -rpcsslciphers help message from init
2013-10-22 11:52:59 -07:00
Philip Kaufmann
2e11999e2b
remove duplicate -rpcsslciphers help message from init
2013-10-22 20:43:19 +02:00
Wladimir J. van der Laan
9686459359
Merge pull request #3123 from super3/master
...
Prettify some /Contrib READMEs
2013-10-22 08:10:17 -07:00
Jeff Garzik
fcb9f26466
Merge pull request #3127 from jgarzik/smells-like-json-spirit
...
Revert recent json-spirit changes
2013-10-22 07:25:54 -07:00
Wladimir J. van der Laan
b3dd90c122
Merge pull request #3082 from laanwj/2013_10_rpccli3
...
Add separate bitcoin-rpc client
2013-10-22 07:18:19 -07:00
Jeff Garzik
406b1f05f6
Revert "JSON Spirit updated to v4.06"
...
This reverts commit 2227389fa8
.
2013-10-22 05:43:46 -04:00
Jeff Garzik
0db9a805bd
Revert "Switch to using raw_utf8"
...
This reverts commit 2ecb7555a9
.
2013-10-22 05:43:38 -04:00
Gavin Andresen
125bdead3e
Merge pull request #2740 from constantined/constantined
...
UTF-8 support for JSON-RPC
2013-10-22 01:20:02 -07:00
Wladimir J. van der Laan
8435f7b8ee
Merge pull request #3125 from Diapolo/splash_testnet
...
splashscreen: use TestNet() instead of unneeded string processing
2013-10-22 00:11:08 -07:00
Philip Kaufmann
81bdc9a512
splashscreen: use TestNet() instead of unneeded string processing
2013-10-22 09:03:50 +02:00
Gavin Andresen
be484db274
Merge pull request #2738 from jgarzik/op_return
...
Relay OP_RETURN data TxOut as standard transaction type.
2013-10-21 22:47:24 -07:00
Gavin Andresen
10dc3c7473
Merge branch 'bugfix_unknownoutputs' of git://github.com/luke-jr/bitcoin
...
Conflicts:
src/wallet.cpp
Fixed LogPrint/printf merge conflict.
2013-10-22 15:34:11 +10:00
super3
14f870cee5
Prettify some /Contrib READMEs
...
SYN
Remove Dead Readme-Qt Links.
2013-10-21 20:07:31 -04:00
Wladimir J. van der Laan
0c1222ff84
Merge pull request #2929 from Krellan/addrlocal
...
Additional field to RPC getpeerinfo output: addrlocal
2013-10-21 04:13:11 -07:00
Josh Lehan
547c61f8d8
Adding new "addrlocal" field to RPC getpeerinfo.
...
The existing CNode::addrLocal member is revealed to the user,
as an address string, similar to the existing "addr" field.
Instead of showing garbage or empty string,
it simply will not appear in the output if local address not known yet.
2013-10-21 02:23:05 -07:00
Wladimir J. van der Laan
2a03a39020
Add separate bitcoin-rpc client
...
This adds an executable `bitcoin-rpc` that only serves as a Bitcoin RPC
client.
The commit does not remove RPC functionality from the `bitcoind` yet,
this functionality should be deprecated but is left for a later version
to give users some time to switch.
2013-10-21 09:22:48 +02:00
Gavin Andresen
cc7562b7d2
Merge pull request #3104 from Diapolo/rpcssl-defaultciphers
...
update default -rpcsslciphers to include TLSv1.2
2013-10-20 19:50:11 -07:00
Gavin Andresen
496c2a3542
Merge pull request #3074 from laanwj/2013_10_remove_default_key_1
...
Remove automatic update of default key
2013-10-20 19:40:43 -07:00
Gavin Andresen
749230d05c
Merge pull request #2840 from sipa/nosendlock
...
Allow SendMessages to run partially without cs_main
2013-10-20 19:06:53 -07:00
Gavin Andresen
34f72ad6ef
Merge pull request #3046 from sarchar/lockedpage-change
...
Changing LockedPageManager to use a managed instance
2013-10-20 16:14:26 -07:00
Gavin Andresen
dc03c2d584
Merge pull request #3117 from gavinandresen/debuglockprint
...
Make -DDEBUGLOCKORDER + -debug less noisy
2013-10-20 14:26:21 -07:00
Pieter Wuille
9b1200c23b
Merge pull request #3119
...
db0e8cc
Bump Year Number to 2013 (super3)
2013-10-20 22:25:44 +02:00
super3
db0e8ccd90
Bump Year Number to 2013
2013-10-20 15:25:06 -04:00
Wladimir J. van der Laan
76eb192076
Merge pull request #3108 from Diapolo/paymentserver_style
...
paymentserver: style fixes / cleanup
2013-10-20 01:01:38 -07:00
Wladimir J. van der Laan
00f198c9a5
Merge pull request #3109 from laanwj/2013_10_remove_walletstack
...
qt: merge walletstack and walletframe
2013-10-20 00:29:38 -07:00
Chuck
0b8f47dc53
Changing LockedPageManager to use a managed instance
...
This ensures the allocator is ready no matter when it's needed (as
some STL implementations allocate in constructors -- i.e., MSVC's STL
in debug builds).
Using boost::call_once to guarantee thread-safe static initialization.
Adding some comments describing why the change was made.
Addressing deinitialization of the LockedPageManager object
by initializing it in a local static initializer and adding
an assert in the base's destructor.
2013-10-20 14:29:24 +07:00
Gavin Andresen
896853a011
Merge pull request #3106 from super3/master
...
Added better WalletTools description.
2013-10-19 23:13:42 -07:00
Gavin Andresen
bd48a4fe49
Merge pull request #2945 from gmaxwell/fee-logic_encourage_sweeping
...
[Fee logic] Don't count txins for priority to encourage sweeping.
2013-10-19 23:05:04 -07:00
Gavin Andresen
f90b690a0d
Merge pull request #2884 from gavinandresen/canonicalsizes2
...
Reject non-canonically-encoded CompactSize
2013-10-19 23:03:04 -07:00
Gavin Andresen
d3b0fa1d82
Merge pull request #3008 from gavinandresen/CENTrule
...
Two small free transaction policy changes
2013-10-19 23:01:47 -07:00
Gavin Andresen
3b9ecfed82
Make -DDEBUGLOCKORDER + -debug less noisy
...
Print out every mutex lock/unlock if compiled -DDEBUGLOCKORDER
only if -debug=lock is set.
2013-10-20 15:41:15 +10:00