Peter Todd
d78f0dafd5
Fix CScriptID(const CScript& in) in empty script case
...
Previously an empty script wouldn't be hashed, and CScriptID would be
assigned the incorrect value of 0 instead. This bug can be seen in the
RPC decodescript command:
$ btc decodescript ""
{
"asm" : "",
"type" : "nonstandard",
"p2sh" : "31h1vYVSYuKP6AhS86fbRdMw9XHieotbST"
}
Correct output:
$ btc decodescript ""
{
"asm" : "",
"type" : "nonstandard",
"p2sh" : "3J98t1WpEZ73CNmQviecrnyiWrnqRhWNLy"
}
2014-12-25 03:18:40 -05:00
Eric R. Schulz
2c14d1532f
bitcoin-tx: Add test case for signing a tx
2014-12-24 01:56:28 +00:00
Cory Fields
566c6cb8a2
gitian: attempt to fix tarball determinisim
2014-12-23 19:43:27 -05:00
Luke Dashjr
a15dba5dff
en: Avoid ambiguous language regarding when transactions confirm
2014-12-23 22:07:10 +00:00
Wladimir J. van der Laan
4312c8fc18
Merge pull request #5512
...
dd14a0e
docs: update gitian building docs (Cory Fields)
2014-12-23 14:16:38 +01:00
Wladimir J. van der Laan
844ace95de
Merge pull request #5507
...
c907704
DOS: Respect max per-peer blocks in flight limit (Adam Weiss)
2014-12-23 12:32:47 +01:00
Wladimir J. van der Laan
055f3ae9aa
Merge pull request #5481
...
6484930
Apply AreSane() checks to the fees from the network. (Gregory Maxwell)
2014-12-23 12:29:33 +01:00
Wladimir J. van der Laan
d01bcc446e
Merge pull request #5485
...
aa279d6
Enforce minRelayTxFee on wallet created tx and add a maxtxfee option. (Gregory Maxwell)
2014-12-23 12:12:05 +01:00
Wladimir J. van der Laan
4406c3e0f4
Merge pull request #5459
...
3497022
Reject headers that build on an invalid parent (Pieter Wuille)
2014-12-23 11:54:07 +01:00
Wladimir J. van der Laan
66ef824a9f
Merge pull request #5517
...
39c8099
contrib: make github-merge require signing (Wladimir J. van der Laan)
2014-12-23 11:28:08 +01:00
Everett Forth
7c5dd60306
Adding RPC tests for the following wallet related calls: getbalance,
...
listsinceblock, listtransactions, listlockunspent, listaccounts
listaddressgroupings
2014-12-23 02:27:17 -08:00
Adam Weiss
c90770430d
DOS: Respect max per-peer blocks in flight limit
...
Don't allow immediate inv driven block downloads if
a peer already has MAX_BLOCKS_IN_TRANSIT_PER_PEER
active downloads. Prevents bogus inv spam from
blowing up block transfer tracking data structures.
2014-12-23 02:19:34 -05:00
Eric R. Schulz
a089c50981
bitcoin-tx: Refer to the JSON fields rather than the whole object
2014-12-23 02:59:00 +00:00
Eric R. Schulz
2a3d988b80
bitcoin-tx: Fix JSON validation of prevtxs
2014-12-22 21:04:53 -05:00
Wladimir J. van der Laan
146e68059c
Merge pull request #5518
...
1e22d45
Add libbitcoinconsensus.pc to .gitignore (Michael Ford)
2014-12-22 15:13:31 +01:00
Pieter Wuille
3497022347
Reject headers that build on an invalid parent
2014-12-22 15:10:56 +01:00
Wladimir J. van der Laan
fcbc8bfa6d
Merge pull request #5523
...
4bc95c4
remove max orphan blocks config parameter since it is no longer functional (Jameson Lopp)
2014-12-22 15:02:42 +01:00
Wladimir J. van der Laan
203632d20b
Merge pull request #5253
...
7c041b3
Check against MANDATORY flags prior to accepting to mempool (Peter Todd)
2014-12-22 12:41:40 +01:00
Jameson Lopp
4bc95c4387
remove max orphan blocks config parameter since it is no longer functional
2014-12-21 09:10:43 -05:00
Matt Corallo
ff09e31a51
sleep-wait on genesis block during init with -reindex
2014-12-20 22:11:51 -05:00
Pavel Janík
bdb6a71d3d
IsNull doesn't change CBlockLocator, add const hint
2014-12-20 16:58:40 +01:00
Pavel Janík
1b37333a7f
Remove no longer needed declaration of CBlockLocator
2014-12-20 16:57:46 +01:00
Michael Ford
1e22d4594f
Add libbitcoinconsensus.pc to .gitignore
2014-12-20 21:26:31 +08:00
Wladimir J. van der Laan
39c809942d
contrib: make github-merge require signing
...
- Exit when there is no signing key configured
- Exit when user does not want to sign off
2014-12-20 13:58:51 +01:00
Matt Corallo
adaa568722
Add script to verify all merge commits are signed
2014-12-20 00:39:42 -05:00
Cory Fields
be43492945
build: fix 'make distcheck'
...
Rather than treating the .py as a regular built test, run it from check-local
so that we can better control the paths used.
2014-12-19 18:04:12 -05:00
Gregory Maxwell
aa279d6131
Enforce minRelayTxFee on wallet created tx and add a maxtxfee option.
...
Previously the minRelayTxFee was only enforced on user specified values.
It was possible for smartfee to produce a fee below minRelayTxFee which
would just result in the transaction getting stuck because it can't be
relayed.
This also introduces a maxtxfee option which sets an absolute maximum
for any fee created by the wallet, with an intention of increasing
user confidence that the automatic fees won't burn them. This was
frequently a concern even before smartfees.
If the configured fee policy won't even allow the wallet to meet the relay
fee the transaction creation may be aborted.
2014-12-19 12:05:10 -08:00
Cory Fields
dd14a0e799
docs: update gitian building docs
2014-12-19 14:44:23 -05:00
sandakersmann
f914f1a746
Added "Core" to copyright headers
...
Github-Pull: #5494
Rebased-From: 15de949bb9277e442302bdd8dee299a8d6deee60
2014-12-19 19:55:32 +01:00
Wladimir J. van der Laan
111a7d45f1
Merge pull request #5470
...
78253fc
Remove references to X11 licence (Michael Ford)
2014-12-19 19:23:23 +01:00
Wladimir J. van der Laan
811c71d287
Merge pull request #2340
...
ba7fcc8
Discourage fee sniping with nLockTime (Peter Todd)
2014-12-19 18:54:51 +01:00
Philip Kaufmann
84857e87e4
add missing CAutoFile::IsNull() check in main
...
Rebased-From: ccd056a30db0ba5e04b858a682907b378e464d34
Github-Pull: #5437
2014-12-19 18:47:00 +01:00
Wladimir J. van der Laan
cf875367d2
Merge pull request #5334
...
eef747b
libbitcoinconsensus: Add pkg-config support (Luke Dashjr)
2014-12-19 18:05:04 +01:00
Wladimir J. van der Laan
c63b47df11
Merge pull request #5341
...
4709160
[Qt] fix a translation that occurs 2 times but was a little different (Philip Kaufmann)
50db7d9
[Qt] change some strings to reflect name change to Bitcoin Core (Philip Kaufmann)
2747f7c
[Qt] fix missing plural form for a string in sendcoinsdialog (Philip Kaufmann)
2014-12-19 18:02:24 +01:00
Wladimir J. van der Laan
87a5270d58
Merge pull request #5413
...
88eb44d
Revised translation process doc (Blake Jakopovic)
2014-12-19 17:55:46 +01:00
Wladimir J. van der Laan
886eb57507
Merge pull request #5421
...
cac15be
Test unexecuted OP_CODESEPARATOR (Peter Todd)
2014-12-19 17:54:21 +01:00
Wladimir J. van der Laan
07c31466c9
Merge pull request #5500
...
e85855f
Drop beta suffixes from readmes (Michael Ford)
2014-12-19 17:49:40 +01:00
Wladimir J. van der Laan
94736e312e
Merge pull request #5504
...
7a3b832
[QA] fix httpbasics RPC test typo (Jonas Schnelli)
2014-12-19 17:48:39 +01:00
Wladimir J. van der Laan
6e718f9435
Remove outdated comment about NTP
...
The comment has been around since 0.1, but NTP inside the client
isn't deemed necessary so remove the comment to avoid confusion.
2014-12-19 16:26:27 +01:00
Wladimir J. van der Laan
c76c9d2e7f
Merge pull request #5501
...
e36e619
Add mips, mipsel and aarch64 to depends platforms (Wladimir J. van der Laan)
2014-12-19 12:01:54 +01:00
Michael Ford
3bf5f52808
Create developer-notes.md
...
Moves coding guidelines and development tips/tricks into a single file.
Also adds a section explaining pull request terminology.
2014-12-19 10:58:56 +08:00
21E14
146c0a7c5a
Add RandAddSeedPerfmon to MakeNewKey
2014-12-18 20:25:04 -05:00
Pavel Janík
469d564951
Build winshutdownmonitor.cpp on Windows only.
2014-12-18 13:34:16 +01:00
Jonas Schnelli
7a3b83269e
[QA] fix httpbasics RPC test typo
2014-12-17 22:40:20 +01:00
Wladimir J. van der Laan
4444b879bc
Merge pull request #5484
...
7c8e4c5
Make pass-by-ref arguments const. (Daniel Kraft)
2014-12-17 19:21:48 +01:00
Wladimir J. van der Laan
89802fe3ee
Merge pull request #5438
...
27df412
make all catch() arguments const (Philip Kaufmann)
2014-12-17 18:13:28 +01:00
Wladimir J. van der Laan
e36e619886
Add mips, mipsel and aarch64 to depends platforms
2014-12-17 13:20:11 +01:00
Michael Ford
e85855fa55
Drop beta suffixes from readmes
2014-12-17 19:36:20 +08:00
Luke Dashjr
7f71813919
Bugfix: prioritisetransaction: Do some basic sanity checking on txid
...
Besides giving a nicer error, this also prevents logging arbitrary data (which could have been used to exploit log readers) into debug.log
2014-12-17 09:37:58 +00:00
Philip Kaufmann
27df4123c4
make all catch() arguments const
...
- I saw this on http://en.cppreference.com/w/cpp/language/try_catch and
thought it would be a good idea
- also unify used format to better be able to search for exception
uses in our codebase
2014-12-17 09:39:24 +01:00