Pieter Wuille
7aa700424c
Merge #9243 : Clean up mapArgs and mapMultiArgs Usage
...
c2f61be
Add a ForceSetArg method for testing (Matt Corallo)
4e04814
Lock mapArgs/mapMultiArgs access in util (Matt Corallo)
4cd373a
Un-expose mapArgs from utils.h (Matt Corallo)
71fde55
Get rid of mapArgs direct access in ZMQ construction (Matt Corallo)
0cf86a6
Introduce (and use) an IsArgSet accessor method (Matt Corallo)
2b5f085
Fix non-const mapMultiArgs[] access after init. (Matt Corallo)
c8042a4
Remove arguments to ParseConfigFile (Matt Corallo)
2016-12-27 10:17:11 -08:00
MarcoFalke
dbc8a8c86a
Merge #9435 : Removed unused variable in test, fixing warning.
...
35356b4
Remove unused variable in test, fixing warning. (Russell Yanofsky)
2016-12-27 18:51:36 +01:00
Matt Corallo
c2f61bebb1
Add a ForceSetArg method for testing
2016-12-27 13:52:07 +01:00
Russell Yanofsky
35356b40ef
Remove unused variable in test, fixing warning.
...
Pointed out by Pavel Janík <Pavel@Janik.cz> in
https://github.com/bitcoin/bitcoin/pull/9308 .
2016-12-27 07:35:39 -05:00
Matt Corallo
4cd373aea8
Un-expose mapArgs from utils.h
2016-12-24 11:29:33 -05:00
Matt Corallo
0cf86a6678
Introduce (and use) an IsArgSet accessor method
2016-12-23 21:30:16 -05:00
Matt Corallo
2b5f085ad1
Fix non-const mapMultiArgs[] access after init.
...
Swap mapMultiArgs for a const-reference to a _mapMultiArgs which is
only accessed in util.cpp
2016-12-23 21:30:15 -05:00
Pieter Wuille
2ddfcfd2d6
Make CScript (and prevector) c++11 movable.
...
Such moves are used when reallocating vectors that contain them,
for example.
2016-12-21 18:28:33 -08:00
Pieter Wuille
6713f0f142
Make FillBlock consume txn_available to avoid shared_ptr copies
2016-12-21 18:18:28 -08:00
Pieter Wuille
62607d796c
Convert COrphanTx to keep a CTransactionRef
2016-12-21 18:18:28 -08:00
Pieter Wuille
c44e4c467c
Make AcceptToMemoryPool take CTransactionRef
2016-12-21 18:18:23 -08:00
Douglas Roark
b3717326c1
Re-enable a blank v1 Tx JSON test
2016-12-21 13:41:47 -08:00
Wladimir J. van der Laan
e8cfe1ee2d
Merge #8589 : Inline CTxInWitness inside CTxIn
...
f6fb7ac
Move CTxInWitness inside CTxIn (Pieter Wuille)
2016-12-21 14:04:06 +01:00
Wladimir J. van der Laan
0698639a38
Merge #9308 : [test] Add CCoinsViewCache Access/Modify/Write tests
...
07df40b
[test] Add CCoinsViewCache Access/Modify/Write tests (Russell Yanofsky)
2016-12-21 12:23:31 +01:00
Wladimir J. van der Laan
8dfe9fcb90
Merge #9376 : Remove unused test files and references
...
9cb6624
Fix testfile reference (BtcDrak)
23208ac
Remove unused test files and references (BtcDrak)
2016-12-21 09:26:11 +01:00
Karl-Johan Alm
280a5599eb
Added some simple tests for the RAII-style events.
2016-12-21 16:49:21 +09:00
Wladimir J. van der Laan
b416095371
Merge #9354 : Make fuzzer actually test CTxOutCompressor
...
5dd626a
Make fuzzer actually test CTxOutCompressor (Pieter Wuille)
2016-12-19 08:50:27 +01:00
BtcDrak
23208ac81b
Remove unused test files and references
2016-12-19 07:43:12 +00:00
Karl-Johan Alm
815f4148b2
Uses built-in byte swap if available (Apple) and if bswap_XX is undefined.
...
Defers to pre-defined version if found (e.g. protobuf). For protobuf case, the definitions are identical and thus include order should not affect results.
2016-12-17 12:27:00 +09:00
Chris Stewart
988ce2ddef
Adding 'amount' label to tx_valid/tx_invalid.json files
2016-12-15 19:04:56 -06:00
Pieter Wuille
5dd626a6d3
Make fuzzer actually test CTxOutCompressor
2016-12-15 09:18:31 -08:00
Wladimir J. van der Laan
1eef038b1b
Merge #7562 : Bump transaction version default to 2
...
c5c92c4
Update python tests for default tx version=2 (BtcDrak)
dab207e
Preserve tx version=1 for certain tests (BtcDrak)
c5d746a
tiny test fix for mempool_tests (Alex Morcos)
1f0ca1a
Bump default transaction version to 2 (BtcDrak)
2016-12-15 17:03:31 +01:00
Wladimir J. van der Laan
5bc209c73f
Merge #9172 : Resurrect pstratem's "Simple fuzzing framework"
...
8b15434
doc: Add bare-bones documentation for fuzzing (Wladimir J. van der Laan)
a4153e2
Simple fuzzing framework (Patrick Strateman)
2016-12-15 16:57:06 +01:00
Patrick Strateman
a4153e20ec
Simple fuzzing framework
2016-12-15 13:29:03 +01:00
Pieter Wuille
b83264d9c7
Merge #8895 : Better SigCache Implementation
...
67dac4e
Add unit tests for the CuckooCache (Jeremy Rubin)
c9e69fb
Add CuckooCache implementation and replace the sigcache map_type with it (Jeremy Rubin)
2016-12-14 18:14:02 -08:00
Jeremy Rubin
67dac4e193
Add unit tests for the CuckooCache
...
SQUASHME: Update Tests for other SQUASHMEs
2016-12-14 16:02:22 -05:00
Jeremy Rubin
c9e69fbf39
Add CuckooCache implementation and replace the sigcache map_type with it
...
SQUASHME: Change cuckoocache to only work for powers of two, to avoid mod operator
SQUASHME: Update Documentation and simplify logarithm logic
SQUASHME: OSX Build Errors
SQUASHME: minor Feedback from sipa + bluematt
SQUASHME: DOCONLY: Clarify a few comments.
2016-12-14 16:02:05 -05:00
Wladimir J. van der Laan
b68685a16a
Merge #9273 : Remove unused CDiskBlockPos* argument from ProcessNewBlock
...
a13fa4c
Remove unused CDiskBlockPos* argument from ProcessNewBlock (Matt Corallo)
2016-12-14 10:56:28 +01:00
Wladimir J. van der Laan
5233aefa3f
Merge #9305 : Refactor: Removed begin/end_ptr functions.
...
8c1dbc5
Refactor: Removed begin/end_ptr functions. (Karl-Johan Alm)
2016-12-13 12:21:18 +01:00
Richard Kiss
e49a252bae
Fix spelling.
2016-12-12 16:06:59 -05:00
Pieter Wuille
a1dcf2e108
Merge #9240 : Remove txConflicted
...
a874ab5
remove internal tracking of mempool conflicts for reporting to wallet (Alex Morcos)
bf663f8
remove external usage of mempool conflict tracking (Alex Morcos)
2016-12-09 16:31:03 -08:00
Karl-Johan Alm
8c1dbc5e9d
Refactor: Removed begin/end_ptr functions.
2016-12-09 13:15:19 +09:00
BtcDrak
c5c92c46fb
Update python tests for default tx version=2
2016-12-08 20:12:00 +00:00
BtcDrak
dab207e4e6
Preserve tx version=1 for certain tests
...
Without this change, the tests would be affected by default
tx version increases.
2016-12-08 20:11:51 +00:00
Alex Morcos
c5d746ace7
tiny test fix for mempool_tests
2016-12-08 20:11:39 +00:00
Pieter Wuille
819ca3f18e
Remove mapOrphanTransactionsByPrev from DoS_tests
...
This is another violation of the one definition rule, as the type
for mapOrphanTransactionsByPrev did not match the one in
net_processing.cpp anymore. As it now depends on a custom Iterator,
it seems too much hassle to correctly expose it to the tests.
Instead, this commit just removes the one test it was referenced in.
2016-12-05 23:04:50 -08:00
Russell Yanofsky
07df40babb
[test] Add CCoinsViewCache Access/Modify/Write tests
...
Add more comprehensive unit tests for CCoinsViewCache. Right now it is hard to
refactor caching code or fix bugs in the caching logic because you have to try
to mentally enumerate all the different states the cache might be in to make
sure a change doesn't cause unintended consequences. The new tests explicitly
enumerate relevant cache states, documenting and verifying the behavior in each
state, so it will be safer and easier to make changes to the caching code in
the future.
2016-12-05 18:30:46 -05:00
Alex Morcos
a874ab5ccf
remove internal tracking of mempool conflicts for reporting to wallet
2016-12-05 13:41:25 -05:00
Alex Morcos
bf663f8e93
remove external usage of mempool conflict tracking
2016-12-05 13:41:25 -05:00
Pavel Janík
9de90bb749
Do not shadow variables (gcc set)
2016-12-05 11:41:46 +01:00
Wladimir J. van der Laan
43e8150ef6
Merge #9269 : Align struct COrphan definition
...
2efc438
Align struct COrphan definition (Pieter Wuille)
2016-12-05 11:09:26 +01:00
Pieter Wuille
2efc43874c
Align struct COrphan definition
2016-12-05 00:35:07 -08:00
Pieter Wuille
f6fb7acda4
Move CTxInWitness inside CTxIn
2016-12-04 23:47:12 -08:00
Wladimir J. van der Laan
d04aebaec7
Merge #9014 : Fix block-connection performance regression
...
dd0df81
Document ConnectBlock connectTrace postconditions (Matt Corallo)
2d6e561
Switch pblock in ProcessNewBlock to a shared_ptr (Matt Corallo)
2736c44
Make the optional pblock in ActivateBestChain a shared_ptr (Matt Corallo)
ae4db44
Create a shared_ptr for the block we're connecting in ActivateBCS (Matt Corallo)
fd9d890
Keep blocks as shared_ptrs, instead of copying txn in ConnectTip (Matt Corallo)
6fdd43b
Add struct to track block-connect-time-generated info for callbacks (Matt Corallo)
2016-12-05 08:07:45 +01:00
Matt Corallo
a13fa4c80f
Remove unused CDiskBlockPos* argument from ProcessNewBlock
2016-12-04 00:23:17 -08:00
Matt Corallo
2d6e5619af
Switch pblock in ProcessNewBlock to a shared_ptr
...
This (finally) fixes a performance regression in
b3b3c2a562
2016-12-04 00:17:30 -08:00
Pieter Wuille
81e3228fcb
Make CTransaction actually immutable
2016-12-02 18:37:43 -08:00
Pieter Wuille
2efcfa5acf
Merge #9260 : Mrs Peacock in The Library with The Candlestick (killed main.{h,cpp})
...
76faa3c
Rename the remaining main.{h,cpp} to validation.{h,cpp} (Matt Corallo)
e736772
Move network-msg-processing code out of main to its own file (Matt Corallo)
87c35f5
Remove orphan state wipe from UnloadBlockIndex. (Matt Corallo)
2016-12-02 18:25:40 -08:00
Matt Corallo
76faa3cdfe
Rename the remaining main.{h,cpp} to validation.{h,cpp}
2016-12-02 09:42:51 -08:00
Matt Corallo
e736772c56
Move network-msg-processing code out of main to its own file
2016-12-02 09:42:51 -08:00