Wladimir J. van der Laan
a5b20edd3d
Merge #8494 : [init, wallet] ParameterInteraction() iff wallet enabled
...
fa5d276
[init] ParameterInteraction() iff wallet enabled (MarcoFalke)
2016-09-19 11:38:16 +02:00
Cory Fields
36fa01f217
net: only delete CConnman if it's been created
...
In the case of (for example) an already-running bitcoind, the shutdown sequence
begins before CConnman has been created, leading to a null-pointer dereference
when g_connman->Stop() is called.
Instead, Just let the CConnman dtor take care of stopping.
2016-09-13 22:43:23 -04:00
Wladimir J. van der Laan
6423116741
Merge #8085 : p2p: Begin encapsulation
...
0103c5b
net: move MAX_FEELER_CONNECTIONS into connman (Cory Fields)
e700cd0
Convert ForEachNode* functions to take a templated function argument rather than a std::function to eliminate std::function overhead (Jeremy Rubin)
d1a2295
Made the ForEachNode* functions in src/net.cpp more pragmatic and self documenting (Jeremy Rubin)
98591c5
net: move vNodesDisconnected into CConnman (Cory Fields)
fa2f8bc
net: add nSendBufferMaxSize/nReceiveFloodSize to CConnection::Options (Cory Fields)
a19553b
net: Introduce CConnection::Options to avoid passing so many params (Cory Fields)
bafa5fc
net: Drop StartNode/StopNode and use CConnman directly (Cory Fields)
e81a602
net: pass CClientUIInterface into CConnman (Cory Fields)
f60b905
net: Pass best block known height into CConnman (Cory Fields)
fdf69ff
net: move max/max-outbound to CConnman (Cory Fields)
8a59369
net: move semOutbound to CConnman (Cory Fields)
bd72937
net: move nLocalServices/nRelevantServices to CConnman (Cory Fields)
be9c796
net: move SendBufferSize/ReceiveFloodSize to CConnman (Cory Fields)
63cafa6
net: move send/recv statistics to CConnman (Cory Fields)
adf5d4c
net: SocketSendData returns written size (Cory Fields)
ee44fa9
net: move messageHandlerCondition to CConnman (Cory Fields)
960cf2e
net: move nLocalHostNonce to CConnman (Cory Fields)
551e088
net: move nLastNodeId to CConnman (Cory Fields)
6c19d92
net: move whitelist functions into CConnman (Cory Fields)
53347f0
net: create generic functor accessors and move vNodes to CConnman (Cory Fields)
c0569c7
net: Add most functions needed for vNodes to CConnman (Cory Fields)
8ae2dac
net: move added node functions to CConnman (Cory Fields)
502dd3a
net: Add oneshot functions to CConnman (Cory Fields)
a0f3d3c
net: move ban and addrman functions into CConnman (Cory Fields)
aaf018e
net: handle nodesignals in CConnman (Cory Fields)
b1a5f43
net: move OpenNetworkConnection into CConnman (Cory Fields)
02137f1
net: Move socket binding into CConnman (Cory Fields)
5b446dd
net: Pass CConnection to wallet rather than using the global (Cory Fields)
8d58c4d
net: Pass CConnman around as needed (Cory Fields)
d7349ca
net: Add rpc error for missing/disabled p2p functionality (Cory Fields)
cd16f48
net: Create CConnman to encapsulate p2p connections (Cory Fields)
d93b14d
net: move CBanDB and CAddrDB out of net.h/cpp (Cory Fields)
531214f
gui: add NodeID to the peer table (Cory Fields)
2016-09-09 11:52:22 +02:00
Cory Fields
0103c5b90f
net: move MAX_FEELER_CONNECTIONS into connman
2016-09-08 13:06:05 -04:00
Cory Fields
fa2f8bc47f
net: add nSendBufferMaxSize/nReceiveFloodSize to CConnection::Options
2016-09-08 13:06:00 -04:00
Cory Fields
a19553b992
net: Introduce CConnection::Options to avoid passing so many params
2016-09-08 13:04:29 -04:00
Cory Fields
bafa5fc5a1
net: Drop StartNode/StopNode and use CConnman directly
2016-09-08 12:24:07 -04:00
Cory Fields
e81a602cf0
net: pass CClientUIInterface into CConnman
2016-09-08 12:24:07 -04:00
Cory Fields
f60b9059e4
net: Pass best block known height into CConnman
...
CConnman then passes the current best height into CNode at creation time.
This way CConnman/CNode have no dependency on main for height, and the signals
only move in one direction.
This also helps to prevent identity leakage a tiny bit. Before this change, an
attacker could theoretically make 2 connections on different interfaces. They
would connect fully on one, and only establish the initial connection on the
other. Once they receive a new block, they would relay it to your first
connection, and immediately commence the version handshake on the second. Since
the new block height is reflected immediately, they could attempt to learn
whether the two connections were correlated.
This is, of course, incredibly unlikely to work due to the small timings
involved and receipt from other senders. But it doesn't hurt to lock-in
nBestHeight at the time of connection, rather than letting the remote choose
the time.
2016-09-08 12:24:06 -04:00
Cory Fields
fdf69ff21a
net: move max/max-outbound to CConnman
2016-09-08 12:24:06 -04:00
Cory Fields
bd72937dc4
net: move nLocalServices/nRelevantServices to CConnman
...
These are in-turn passed to CNode at connection time. This allows us to offer
different services to different peers (or test the effects of doing so).
2016-09-08 12:24:06 -04:00
Cory Fields
63cafa6329
net: move send/recv statistics to CConnman
2016-09-08 12:24:06 -04:00
Cory Fields
6c19d92361
net: move whitelist functions into CConnman
2016-09-08 12:24:06 -04:00
Cory Fields
502dd3a8a0
net: Add oneshot functions to CConnman
2016-09-08 12:12:57 -04:00
Cory Fields
02137f11e2
net: Move socket binding into CConnman
2016-09-08 12:06:24 -04:00
Cory Fields
cd16f48028
net: Create CConnman to encapsulate p2p connections
2016-09-08 12:04:35 -04:00
Cory Fields
d6a5dc4a2e
add waitfornewblock/waitforblock/waitforblockheight rpcs and use them for tests
...
waitfornewblock waits until a new block is received, or the timeout expires, then
returns the current block height/hash.
waitforblock waits for a specific blockhash, or until the timeout expires, then
returns the current block height/hash. If the target blockhash is the current
tip, it will return immediately.
waitforblockheight waits until the tip has reached a certain height or higher,
then returns the current height and hash.
waitforblockheight is used to avoid polling in the rpc tests.
2016-09-07 12:46:01 -04:00
Jorge Timón
cdd79eb70f
C++11: s/boost::scoped_ptr/std::unique_ptr/
2016-09-01 19:05:07 +02:00
Wladimir J. van der Laan
a5bb6387f7
Merge #8607 : [doc] Fix doxygen off-by-one comments, fix typos
...
fafe7b3
contrib: Make fix-copyright-headers.py more portable (MarcoFalke)
fa27c0a
[doc] Fix typos in comments, doxygen: Fix comment syntax (MarcoFalke)
fabfd5d
[qa] pull-tester: Don't mute zmq ImportError (MarcoFalke)
67a5502
init: Fix typo in help message for -whitelistforcerelay (Wladimir J. van der Laan)
2016-08-28 16:06:03 +02:00
MarcoFalke
fa6dc9f0e5
Remove unused variables
2016-08-25 14:59:38 +02:00
Wladimir J. van der Laan
f9167003d9
Merge #8445 : Move CWallet::setKeyPool to private section of CWallet.
...
8680d3a
Move wallet initialization logic from AppInit2 to CWallet::InitLoadWallet (Patrick Strateman)
e86eb71
Move CWallet::setKeyPool to private section of CWallet (Patrick Strateman)
2016-08-24 10:33:16 +02:00
Wladimir J. van der Laan
67a55025a1
init: Fix typo in help message for -whitelistforcerelay
...
Reported by pryds on Transifex in the Danish translation.
2016-08-22 10:51:13 +02:00
Patrick Strateman
8680d3aa80
Move wallet initialization logic from AppInit2 to CWallet::InitLoadWallet
2016-08-20 14:03:47 -07:00
Patrick Strateman
e86eb71604
Move CWallet::setKeyPool to private section of CWallet
2016-08-17 15:24:57 -07:00
Wladimir J. van der Laan
e753eaeb34
Merge #8505 : Trivial: Fix typos in various files
...
1aacfc2
various typos (leijurv)
2016-08-17 12:51:16 +02:00
instagibbs
edb6cf1432
remove no-longer-used InitError logic
2016-08-15 10:28:53 -04:00
Jonas Schnelli
c503863150
Merge #8192 : [trivial] Remove URLs from About dialog translations
...
208d37f
[trivial] Remove URLs from About dialog translations (fanquake)
2016-08-15 15:36:42 +02:00
Wladimir J. van der Laan
1030fa718c
Merge #8128 : Net: Turn net structures into dumb storage classes
...
9e9d644
net: fixup nits (Cory Fields)
8945384
net: Have LookupNumeric return a CService directly (Cory Fields)
21ba407
net: narrow include scope after moving to netaddress (Cory Fields)
21e5b96
net: move CNetAddr/CService/CSubNet out of netbase (Cory Fields)
1017b8a
net: Add direct tests for new CSubNet constructors (Cory Fields)
b6c3ff3
net: Split resolving out of CSubNet (Cory Fields)
f96c7c4
net: Split resolving out of CService (Cory Fields)
31d6b1d
net: Split resolving out of CNetAddr (Cory Fields)
2016-08-15 13:35:27 +02:00
leijurv
1aacfc2da5
various typos
2016-08-14 07:57:11 -06:00
MarcoFalke
fa5d276c90
[init] ParameterInteraction() iff wallet enabled
2016-08-10 08:40:57 +02:00
Cory Fields
8945384bca
net: Have LookupNumeric return a CService directly
...
Also fix up a few small issues:
- Lookup with "badip:port" now sets the port to 0
- Don't allow assert to have side-effects
2016-08-04 16:41:39 -04:00
Wladimir J. van der Laan
f97d335942
Merge #8392 : Fix several node initialization issues
...
9d4eb9a
Do diskspace check before import thread is started (Pieter Wuille)
aa59f2e
Add extra message to avoid a long 'Loading banlist' (Pieter Wuille)
0fd2a33
Use a signal to continue init after genesis activation (Pieter Wuille)
2016-08-04 12:33:21 +02:00
Pavel Janík
0fc00bea5d
Do not shadow previous local variable
2016-08-02 10:26:54 +02:00
Pavel Janík
115265bb10
Trivial: bip -> BIP in help text and comment
2016-08-02 10:26:05 +02:00
Cory Fields
21ba407a73
net: narrow include scope after moving to netaddress
...
Net functionality is no longer needed for CAddress/CAddrman/etc. now that
CNetAddr/CService/CSubNet are dumb storage classes.
2016-07-31 14:01:44 -04:00
Cory Fields
b6c3ff3dae
net: Split resolving out of CSubNet
2016-07-31 14:01:43 -04:00
Cory Fields
f96c7c4d91
net: Split resolving out of CService
2016-07-31 13:24:07 -04:00
Pieter Wuille
9d4eb9ad99
Do diskspace check before import thread is started
2016-07-30 02:17:51 +02:00
Pieter Wuille
0fd2a33648
Use a signal to continue init after genesis activation
2016-07-30 02:17:47 +02:00
Suhas Daftuar
56c87e9211
Allow changing BIP9 parameters on regtest
2016-07-29 09:41:58 -04:00
fanquake
208d37f116
[trivial] Remove URLs from About dialog translations
2016-07-21 16:21:08 +08:00
Pieter Wuille
ab942c15bd
Treat high-sigop transactions as larger rather than rejecting them
2016-07-19 12:31:49 +02:00
Suhas Daftuar
2c06bae39e
Rename "block cost" to "block weight"
2016-07-18 13:28:26 -04:00
Wladimir J. van der Laan
8cef5bd58a
mining: Improve -blockmaxcost
help message
...
One-word replacement to #8354 .
2016-07-18 10:56:25 +02:00
Wladimir J. van der Laan
f5660d381a
Merge #8295 : Mining-related fixups for 0.13.0
...
c1d61fb
Add warning if -blockminsize is used. (Suhas Daftuar)
27362dd
Remove -blockminsize option (Suhas Daftuar)
d2e46e1
Remove addScoreTxs() (Suhas Daftuar)
6dd4bc2
Exclude witness transactions in addPackageTxs() pre-segwit activation (Suhas Daftuar)
f15c2cd
CreateNewBlock: add support for size-accounting to addPackageTxs (Suhas Daftuar)
2016-07-18 08:23:45 +02:00
Wladimir J. van der Laan
396f9d6296
Merge #8273 : Bump -dbcache
default to 300MiB
...
efd1d83
doc: Mention dbcache increase in release notes (Wladimir J. van der Laan)
32cab91
Bump `-dbcache` default to 300MiB (Wladimir J. van der Laan)
2016-07-06 07:46:47 +02:00
Wladimir J. van der Laan
32cab91278
Bump -dbcache
default to 300MiB
...
Also cap the allocation for the leveldb-specific cache for the UTXO set
to 8MiB.
This avoids that the extra cache memory goes to the much less effective
leveldb cache instead of our application-level cache.
2016-07-06 07:44:51 +02:00
Wladimir J. van der Laan
042c323922
Merge #8275 : Remove bad chain alert partition check
...
ab8be98
Remove bad chain alert partition check (BtcDrak)
2016-07-06 07:35:54 +02:00
Suhas Daftuar
c1d61fbd08
Add warning if -blockminsize is used.
2016-07-05 19:57:45 -04:00
Suhas Daftuar
27362dda4d
Remove -blockminsize option
2016-06-30 11:41:13 -04:00