LBRYCommunity/lbrycrd
1
0
Fork 0
Code Issues 29 Pull requests 1 Projects Releases 32 Packages Wiki Activity
5732 commits 22 branches 42 tags 99 MiB
Commit graph

3779 commits

Author SHA1 Message Date
Luke Dashjr
c0e0b05aec Bugfix: configure: Look in libx32 subdirectory for boost libraries 2014-04-09 12:59:17 +00:00
Wladimir J. van der Laan
06d1fc6112
Merge pull request #4020 
71f82bf Restart-warning for spendZeroConfChange option (langerhans)
 2014-04-09 10:34:31 +02:00
Hector Jusforgues
ab643811ea Fix a typo in RPC signrawtransaction help 2014-04-08 22:53:41 +07:00
Wladimir J. van der Laan
a7101b13f7
Merge pull request #4019 
13a2283 build: Sync ax_boost_base.m4 with upstream. (Cory Fields)
 2014-04-08 10:24:26 +02:00
langerhans
71f82bf2ab Restart-warning for spendZeroConfChange option 
According to the options model, a restart is required after changing this option. So let's notify the user about it.
 2014-04-07 19:26:30 +02:00
Cory Fields
13a2283a6d build: Sync ax_boost_base.m4 with upstream. 
This should fix 32bit boost detection on Ubuntu Saucy+. Fixes #3945.
 2014-04-07 13:19:01 -04:00
Wladimir J. van der Laan
4ae5e72128
Show error message if ReadConfigFile fails 
A runaway exception was raised if ReadConfigFile fails (usually
due to a parse error in bitcoin.conf). Show an error message instead.

Fixes #4013.
 2014-04-07 10:16:09 +02:00
Wladimir J. van der Laan
f4e1c347cf
Merge pull request #3972 
fbf617a remove an assignment which is never used. (Yoichi Hirai)
 2014-04-07 08:09:42 +02:00
Gregory Maxwell
94c8bfb23b Move assert(pindexNew); to above where we dereference pindexNew. 2014-04-05 22:11:16 -07:00
Wladimir J. van der Laan
b12dcb2c9e
Merge pull request #3572 
f7257cf unified and better log/error messages for CDBEnv/CDB (Philip Kaufmann)
 2014-04-04 14:10:58 +02:00
Wladimir J. van der Laan
fecda6853d
Merge pull request #3929 
4c35366 Fix importwallet nTimeFirstKey (Cozz Lovan)
 2014-04-03 13:50:59 +02:00
Wladimir J. van der Laan
9bd1bdd08c
Merge pull request #3928 
3927836 [Qt] rescan progress (Cozz Lovan)
 2014-04-03 11:51:02 +02:00
Gavin Andresen
8556b0298d Merge pull request #3842 from ditto-b/master 
Fix for GetBlockValue() after block 13,440,000
 2014-04-02 21:31:17 -04:00
ditto-b
5cfd3a70a6 Edit subsidy_limit_test to account for BIP42 
Because no one wants 4 gold mines being discovered every mibillenium.
 2014-04-02 18:00:08 -05:00
Cozz Lovan
392783697c [Qt] rescan progress 2014-04-02 03:48:07 +02:00
Wladimir J. van der Laan
397521d632
Merge pull request #3931 
f61287c RPC command getmininginfo showing right genproclimit (Isidoro Ghezzi)
 2014-04-01 18:11:38 +02:00
Wladimir J. van der Laan
e5681a4fa8
Merge pull request #3986 
65adc3a qt: Don't require db_cxx.h when wallet disabled (Wladimir J. van der Laan)
4babd08 doc: Add note about memory reqs for compilation (Wladimir J. van der Laan)
25333a2 build: improve missing boost error reporting (Wladimir J. van der Laan)
 2014-04-01 15:48:50 +02:00
Philip Kaufmann
d34b958406 [Qt] small cleanup of coincontroldialog 
- use a little more Qt-style
- check for NULL pointers first and return in updateView()
- small space and formating changes
 2014-04-01 10:11:18 +02:00
Philip Kaufmann
f7257cfbd9 unified and better log/error messages for CDBEnv/CDB 2014-04-01 09:41:49 +02:00
Manuel Araoz
81bfb5aebf add checks for deserialization errors 2014-03-31 15:07:46 -03:00
Manuel Araoz
232aa9e034 Add code generating data/sighash.json test data 2014-03-31 12:39:32 -03:00
Manuel Araoz
43cb41859e Add sighash tests from data file 2014-03-31 11:19:19 -03:00
paveljanik
db3a5e4151
Use the new name Bitcoin Core Daemon instead of Bitcoin server 
Rebased-By: Wladimir J. van der Laan <laanwj@gmail.com>
Rebased-From-Github-Pull: #3801
 2014-03-31 12:05:16 +02:00
Brandon Dahler
2b7709dc84
Wrap create_directory calls in try...catch blocks. 
Ignores any exceptions thrown if directory exists, otherwise re-throws exception.

Rebased-By: Wladimir J. van der Laan <laanwj@gmail.com>
 2014-03-31 09:51:58 +02:00
Wladimir J. van der Laan
e3e3728f46
Fix typo in createmultisig help 
iCreateMultisig is not a thing.
 2014-03-31 09:04:51 +02:00
Wladimir J. van der Laan
b86ed6ff23
Merge pull request #3969 
ffeb473 Add nHighTransactionFeeWarning as per #3969. (Bardi Harborow)
 2014-03-31 09:01:16 +02:00
Wladimir J. van der Laan
ab88ed93ef Organize RPCCommands table 
Use sensible categories (overall control, P2P, blockchain/UTXO and
mining, wallet, wallet-enabled mining) and sort within each.

Also remove unnecessary #ifdef ENABLE_WALLET from `rpcnet.cpp`.

Functionality-neutral change.
 2014-03-31 08:41:45 +02:00
Wladimir J. van der Laan
65adc3a893 qt: Don't require db_cxx.h when wallet disabled 
Fix #3978.
 2014-03-31 06:13:40 +02:00
Wladimir J. van der Laan
25333a2619 build: improve missing boost error reporting 2014-03-31 05:24:45 +02:00
Wladimir J. van der Laan
09b9c2fcd5
Merge pull request #3980 
af4c2ac Fix `-printblocktree` output (Wladimir J. van der Laan)
 2014-03-31 04:47:32 +02:00
Wladimir J. van der Laan
8adb7bca21
Merge pull request #3875 
89d72f3 Add new DNS seed from bitnodes.io. (Addy Yeow)
 2014-03-29 19:38:23 +01:00
Wladimir J. van der Laan
af4c2ac8ce Fix -printblocktree output 
PrintBlockTree output was broken starting from e010af70.
Everything appears on one line.

PrintWallet() added the newline after a block, but this functionality
was removed and no newline was added.

Seemingly, no one noticed. Add a newline after the block information
to fix this.
 2014-03-29 16:25:47 +01:00
Bardi Harborow
ffeb47366d Add nHighTransactionFeeWarning as per #3969. 2014-03-29 05:17:28 -04:00
Wladimir J. van der Laan
55027a8c85
Merge pull request #3973 
a60ab0b Make GetAvailableCredit run GetHash() only once per transaction. (Gregory Maxwell)
 2014-03-29 09:35:11 +01:00
Wladimir J. van der Laan
e9d2e6ed90
Merge pull request #3922 
c17f0a5 [Qt] remove space from translation of client bitness (Philip Kaufmann)
 2014-03-29 06:03:08 +01:00
Gregory Maxwell
a60ab0ba89 Make GetAvailableCredit run GetHash() only once per transaction. 
This makes the first getbalance/getinfo 63x faster on my wallet.
 2014-03-28 09:58:40 -07:00
Yoichi Hirai
fbf617a5f1 remove an assignment which is never used. 2014-03-28 20:22:00 +09:00
Wladimir J. van der Laan
acac57b8af
Merge pull request #3730 
1d46fe3 'sendrawtransaction' improvements (Wladimir J. van der Laan)
 2014-03-28 09:53:49 +01:00
Wladimir J. van der Laan
e33cc87212
Merge pull request #3698 
5409404 add constant for shared (GUI/core) -par settings (Philip Kaufmann)
 2014-03-27 13:02:24 +01:00
Wladimir J. van der Laan
1d46fe3327 'sendrawtransaction' improvements 
- Make it report the reject code and reason
- Make it possible to re-send transactions that are already in the mempool
 2014-03-27 12:33:55 +01:00
Philip Kaufmann
5409404d75 add constant for shared (GUI/core) -par settings 
- introduce DEFAULT_SCRIPTCHECK_THREADS in main.h
- only show values from -"MAX_HW_THREADS" up to 16 for -par, as it
  makes no sense to try to leave more "cores free" than the system
  supports anyway
- use the new constant in optionsdialog and remove defaults from
  .ui file
 2014-03-27 11:54:13 +01:00
Wladimir J. van der Laan
ebb783a9f2
Merge pull request #3603 
a486abd replace custom GetFilesize() with boost::filesystem::file_size() (Philip Kaufmann)
 2014-03-27 11:38:34 +01:00
Wladimir J. van der Laan
77eaa6fc45
Merge pull request #3682 
3e0753b always show syncnode in getpeerinfo (fixes #2717) (Philip Kaufmann)
 2014-03-27 11:20:49 +01:00
Wladimir J. van der Laan
410c2fa317
Merge pull request #3619 
7398f4a improve command-line options output (Cozz Lovan)
 2014-03-27 11:07:37 +01:00
Philip Kaufmann
cfe4cad9e5 [Qt] fix style, formating, comment and indentation problems 
- introduced by #3920
 2014-03-27 09:22:15 +01:00
Wladimir J. van der Laan
47ef190637
Merge pull request #3958 
dfd3996 Remove duplicate from src/makefile.am (Wladimir J. van der Laan)
 2014-03-26 12:03:54 +01:00
Wladimir J. van der Laan
95f0af5cb1
Merge pull request #3951 
3cb1edb Update moved and dead links (Luke Dashjr)
 2014-03-26 10:44:47 +01:00
Wladimir J. van der Laan
dfd3996217 Remove duplicate from src/makefile.am 
chainparams.cpp should not be in both libbitcoin_common and
libbitcoin_server. Also re-sort the sources list.
 2014-03-26 10:22:01 +01:00
Cozz Lovan
7398f4a796 improve command-line options output 2014-03-25 13:09:20 +01:00
Wladimir J. van der Laan
c61fe44194 qt: Only override -datadir if different from the default 
Fixes #3905.
 2014-03-25 09:26:11 +01:00
Wladimir J. van der Laan
7e591c19e7 qt: Do proper boost::path conversion 
Convert from QString unicode from/to the OS-dependent locale
as used by boost::filesystem::path as needed.

Solves #3916.
 2014-03-25 09:20:10 +01:00
Wladimir J. van der Laan
e3f5d4338d
Fix test build after d138598 
Building the tests was giving some vague error message about a doubly-defined
symbol.

The solution is to define ShutdownRequested in test_bitcoin.cpp as well
so that init.cpp does not get pulled in.
 2014-03-25 07:54:53 +01:00
Luke Dashjr
3cb1edbfb6 Update moved and dead links 2014-03-24 20:26:02 +00:00
Gavin Andresen
d138598f63
Fix regression tests 
Taught bitcoind to close the HTTP connection after it gets a 'stop' command,
to make it easier for the regression tests to cleanly stop.
Move bitcoinrpc files to correct location.
Tidied up the python-based regression tests.
 2014-03-24 19:14:51 +01:00
Wladimir J. van der Laan
d3c3210fa3
Merge pull request #3927 
ab1edd4 [Qt] Fix enable/disable show and remove buttons (Cozz Lovan)
 2014-03-23 11:28:52 +01:00
Isidoro Ghezzi
f61287c9b1 RPC command getmininginfo showing right genproclimit 2014-03-22 15:03:06 +01:00
Chris Beams
6540025f10 Remove stale and redundant src/.gitignore file 
This commit removes completely the src/.gitignore file, given that the
precedent for ignoring artifacts within the `src` directory is to
add entries for them to the root .gitignore file.

Note also that the lone entry in src/.gitignore is stale anyway. As of
the switch to Autotools in 35b8af9, the build no longer build creates
artifacts in `src/test_bitcoin`. They are now written to
`src/test/test_bitcoin`, and this latter path is already ignored in the
root .gitignore file.
 2014-03-22 13:52:27 +01:00
Cozz Lovan
ab1edd44d8 [Qt] Fix enable/disable show and remove buttons 2014-03-21 17:13:00 +01:00
Cozz Lovan
4c35366bdc Fix importwallet nTimeFirstKey 2014-03-21 14:23:45 +01:00
Wladimir J. van der Laan
788590736d qt: translation update 2014-03-21 12:13:10 +01:00
Wladimir J. van der Laan
fc5d85c4bb
Merge pull request #3806 
9e2872c Adjust branding in datadir lock error message (Michagogo)
d30d379 Slightly tweak error when unable to bind port (Michagogo)
 2014-03-21 09:58:02 +01:00
Wladimir J. van der Laan
be0afe238b
Merge pull request #3850 
16d281b [Qt] add expert section to wallet tab in optionsdialog (Cozz Lovan)
 2014-03-21 09:26:30 +01:00
Wladimir J. van der Laan
162c33d246
Merge pull request #3892 
b8edf6c Qt: Fix ESC in disablewallet mode (Wladimir J. van der Laan)
 2014-03-21 09:24:20 +01:00
Philip Kaufmann
c17f0a58b4 [Qt] remove space from translation of client bitness 
- its rather easy to leave out the space on Transifex, so remove it from
  the string
 2014-03-21 08:49:51 +01:00
gubatron
8c29273ff0 [QT] Fixes feel when resizing the last column on tables (issue #2862) 
Re-submitting this pull request with a single commit.

This patch introduces a GUIUtil class that is used when setting up the 2 tables we have so far on the Qt-GUI.
In the past you could only resize the last column, which has BTC amounts from the right border of the column header, something that was rather unnatural.

If a new table were ever to be added to the interface, fixing the last columns resizing behavior is rather simple. Just look at how we initialize here a TableViewLastColumnResizingFixer object when setting up the table header's behavior, and then how we override the resize event of the component (can be the table, or the dialog) and we invoke columnResizingFixer->stretchColumnWidth(columnIndex);
 2014-03-21 01:45:47 -04:00
Wladimir J. van der Laan
5c80b9a7fb build: build qt tests after qt libs/executable 
Autotools defaults to a depth-first recursion which causes the qt tests
to be built before the executables and libraries.

This is inconvenient as make needs to be called twice to make sure the
tests are up to date after changing a source file.

Update the Makefile.am to change this order.
 2014-03-20 17:35:40 +01:00
peryaudo
b1b9c76262 Fix bloom filter not to use bit_mask 2014-03-20 13:21:23 +09:00
Wladimir J. van der Laan
0d8e80fe07
Merge pull request #3895 
74f66a5 Fixed compile error on Debian jessie (gcc version 4.8.2 (Debian 4.8.2-16)) (Meeh)
 2014-03-19 09:24:35 +01:00
Meeh
74f66a5e29 Fixed compile error on Debian jessie (gcc version 4.8.2 (Debian 4.8.2-16)) 2014-03-18 22:54:47 +01:00
Wladimir J. van der Laan
b8edf6c0d8 Qt: Fix ESC in disablewallet mode 
Fixes issue #3854
 2014-03-18 14:51:28 +01:00
Cozz Lovan
16d281ba84 [Qt] add expert section to wallet tab in optionsdialog 2014-03-18 13:48:59 +01:00
Wladimir J. van der Laan
3fc6846181 Add licenses for tests and test data 
- Add license headers to source files (years based on commit dates)
  in `src/test` as well as `qa`
- Add `README.md` to `src/test/data` specifying MIT license

Fixes #3848
 2014-03-18 10:20:55 +01:00
Wladimir J. van der Laan
61774f82b3
Merge pull request #3855 
0fde3bb [Qt] Fill in label from address book also for URIs (Cozz Lovan)
 2014-03-18 09:24:02 +01:00
Wladimir J. van der Laan
5b6e9811fa
Merge pull request #3867 
b40bdd6 qt: Show also value for options overridden on command line (Wladimir J. van der Laan)
 2014-03-17 10:38:37 +01:00
Wladimir J. van der Laan
ff0c0dd6a9
Merge pull request #3874 
caee92d qt: Enable and disable the Show and Remove buttons for requested payments history based on whether any entry is selected. (Haakon Nilsen)
 2014-03-17 10:17:39 +01:00
Cory Fields
a22e9a32b3 build: fix explicit --disable-qt-dbus 
It worked in the auto/yes cases, but an explicit disable actually forced
it on.
 2014-03-15 21:52:02 -04:00
Wladimir J. van der Laan
cb0c42e7da
Merge pull request #3876 
a1465ac qt: Show weeks as well as years behind for long timespans (Wladimir J. van der Laan)
 2014-03-15 16:40:02 +01:00
Wladimir J. van der Laan
acfe60677c
Merge pull request #3650 
2b45345 minor style cleanups (Philip Kaufmann)
 2014-03-15 10:24:04 +01:00
Wladimir J. van der Laan
a1465ac8e6 qt: Show weeks as well as years behind for long timespans 
Closes #3811.
 2014-03-15 10:13:37 +01:00
philsong
2834bc8013 qt: change CT_NOW string to CT_NEW in log message 
Closes #3852.

Rebased-By: Wladimir J. van der Laan <laanwj@gmail.com>
Rebased-From: 5f2907a, 88d3df4
 2014-03-15 09:00:48 +01:00
Wladimir J. van der Laan
a9801cf7ee
Merge pull request #3871 
b51700a [Qt] Dont set table color in coin control (Cozz Lovan)
 2014-03-15 07:41:13 +01:00
Addy Yeow
89d72f3d9b Add new DNS seed from bitnodes.io. 2014-03-15 14:15:40 +11:00
Haakon Nilsen
caee92dfa8 qt: Enable and disable the Show and Remove buttons for requested payments history 
based on whether any entry is selected.
 2014-03-15 00:41:23 +01:00
Cozz Lovan
b51700a852 [Qt] Dont set table color in coin control 2014-03-14 13:45:43 +01:00
Wladimir J. van der Laan
b40bdd6532 qt: Show also value for options overridden on command line 
Currently only the name of the option is shown for GUI options
overridden by command line (or configuration file). This commit
adds the value of the options as well, which is useful for
troubleshooting.
 2014-03-14 07:22:59 +01:00
Gregory Maxwell
1294cdc43f Add a "relayfee" field to getinfo. 
This shows the minimum relay fee for non-free transactions in btc/kb.

The armory developers requested this so that they can prevent users from
 creating transactions that not even their local bitcoind will relay.

This also slightly reorders the getinfo output so that the fee related
 lines are grouped and changes the help text to reflect that the units
 are btc/kb.
 2014-03-13 23:22:18 -07:00
Gavin Andresen
1e13f57f56 Merge pull request #3849 from cozz/cozz2 
Fix missing wallet lock in CWallet::SyncTransaction(..)
 2014-03-13 11:43:25 -04:00
Wladimir J. van der Laan
74502e753b
Merge pull request #3846 
3f2a017 [Qt] Fix coin control qt5 checkbox bug in tree mode (Cozz Lovan)
 2014-03-13 15:19:26 +01:00
Peter Todd
d3a33fc869
Test CHECKMULTISIG with m == 0 and n == 0 2014-03-12 21:18:07 -04:00
Peter Todd
b41e594773
Fix script test handling of empty scripts 
Previously an empty script would evaluate to OP_0
 2014-03-12 20:14:01 -04:00
Michagogo
9e2872c234 Adjust branding in datadir lock error message 2014-03-12 22:14:11 +02:00
Gavin Andresen
ca0b8acbf3 Merge pull request #3841 from schildbach/script-tests-OP_0 
Add script test to prove that OP_0 evaluates as the empty vector.
 2014-03-12 15:12:08 -04:00
Cozz Lovan
0fde3bbf07 [Qt] Fill in label from address book also for URIs 2014-03-12 17:08:00 +01:00
Cozz Lovan
53d56881a8 Fix missing wallet lock in CWallet::SyncTransaction(..) 2014-03-11 23:39:51 +01:00
Philip Kaufmann
2b45345aac minor style cleanups 2014-03-11 17:26:05 +01:00
Wladimir J. van der Laan
fbdf4e5efa
Merge pull request #3844 
c52c4e5 qt: Make it possible again to specify -testnet in config file (Wladimir J. van der Laan)
 2014-03-11 17:03:24 +01:00
Gavin Andresen
669264c176 Merge branch 'match_relay_fee' of git://github.com/mikehearn/bitcoin 2014-03-11 11:20:07 -04:00
Cozz Lovan
3f2a0172f5 [Qt] Fix coin control qt5 checkbox bug in tree mode 2014-03-11 14:16:48 +01:00
Wladimir J. van der Laan
1264b3647d
Merge pull request #3696 
c4656e0 Add progress to initial display of latest block downloaded. (R E Broadley)
75b8953 Display progress of rescan. (R E Broadley)
 2014-03-11 09:18:16 +01:00
Wladimir J. van der Laan
c52c4e5d14 qt: Make it possible again to specify -testnet in config file 
Changes for the datadir chooser have made it impossible to specify
the network (testnet/regtest) in the configuration file for the GUI.

Reorganize the initialization sequence to make this possible again.

- Moves the "datadir" QSetting so that is no longer dependent on the
  network-specific application name (doing otherwise would create a
  chicken-and-egg problem).

- Re-initialize translations after choosing network. There may be a
  different language configured in network-specific settings
  (slim chance, but handle it for sanity).

Fixes point 1 of #3840.
 2014-03-11 08:46:01 +01:00
ditto-b
c5a9d2ca9e Fix for GetBlockValue() after block 13,440,000 
Forces the block reward to zero when right shift in GetBlockValue() is
undefined, after 64 reward halvings (block height 13,440,000).
 2014-03-10 19:02:36 -05:00
Andreas Schildbach
ffd082a6a3 Add script test to prove that OP_0 evaluates as the empty vector, rather than [0]. 2014-03-11 00:59:33 +01:00
Pieter Wuille
6fd7ef2bbf Also switch the (unused) verification code to low-s instead of even-s. 
a81cd968 introduced a malleability breaker for signatures
(using an even value for S). In e0e14e43 this was changed to
the lower of two potential values, rather than the even one.
Only the signing code was changed though, the (for now unused)
verification code wasn't adapted.
 2014-03-10 20:38:32 +01:00
Mike Hearn
037b4f1485 Make mining fee policy match relay fee policy. 
This resolves a case in which a mismatch could be used to bloat up the
mempool by sending transactions that pay enough fee to relay, but not
to be mined, with the default policies.
 2014-03-10 19:17:18 +01:00
Jeff Garzik
a63f8b7b36 Merge pull request #3717 from djpnewton/wallet-txcount 
add getwalletinfo RPC call with wallet transaction count
 2014-03-10 13:37:03 -04:00
Wladimir J. van der Laan
0ffd87f1c1
qt: Remove control characters from ko_KR translation 
Last Transifex pull (064a690) introduced a few control characters
into the Korean translation, which sometimes causes the build to fail.

Manually remove these characters for now to get the build working --
they should still be removed at Transifex too.
 2014-03-10 17:04:35 +01:00
Wladimir J. van der Laan
636d8e4de6
Merge pull request #3815 
5283410 Remove unused includes of boost lexical_cast (Wladimir J. van der Laan)
 2014-03-10 16:32:50 +01:00
Wladimir J. van der Laan
064a690515 Transifex pull pre-0.9.0rc3/final 2014-03-10 14:15:46 +01:00
Wladimir J. van der Laan
b76733d8e8
Merge pull request #3514 
f59d8f0 Per-peer block download tracking and stalled download detection. (Pieter Wuille)
 2014-03-10 13:23:18 +01:00
Wladimir J. van der Laan
70b8cb9ce8
qt: Adjust BLOCK_CHAIN_SIZE to 20GB 
This increases the space requirement for selecting a data directory in
the UI.
As suggested by @bardiharborow, fixes #3830.
 2014-03-10 10:06:15 +01:00
Wladimir J. van der Laan
218be95903
Merge pull request #3685 
8e29623 [Qt] show number of in/out connections in debug console (Philip Kaufmann)
 2014-03-10 10:03:53 +01:00
Wladimir J. van der Laan
1cab453ff8
Merge pull request #3817 
e935293 Minor code cleanup: remove indentation (Mark Friedenbach)
 2014-03-10 09:33:19 +01:00
Mark Friedenbach
e935293e17 Minor code cleanup: remove indentation 
This indentation should have been stripped out when AreInputsStandard was made a top-level function instead of a CTransaction method.
 2014-03-08 00:43:35 -08:00
jtimon
89ec3a2911 MainNet is the special case for the GUI 2014-03-07 22:59:30 -08:00
Wladimir J. van der Laan
5283410568 Remove unused includes of boost lexical_cast 
We don't use lexical_cast anywhere, no need to include it.
 2014-03-07 17:55:13 +01:00
Wladimir J. van der Laan
09ec3af166 AddToWallet implies BindWallet 
Now that AddToWallet is called when loading transactions from the
wallet database, BindWallet can be integrated into that and does not
need to be an extra step.

Leaves behaviour unchanged, but makes the
fFromLoadWallet/!fFromLoadWallet paths in AddToWallet a bit more
symmetric.
 2014-03-07 09:20:11 +01:00
Wladimir J. van der Laan
c7c3262774
Merge pull request #3768 
fecba4e Total money limit test (Pieter Wuille)
 2014-03-07 08:59:03 +01:00
Wladimir J. van der Laan
9b7449bae6
Merge pull request #3805 
8a6894c Log which wallet is used during init (Wladimir J. van der Laan)
 2014-03-07 07:51:53 +01:00
Wladimir J. van der Laan
1bcf81e042 gui: Prevent status icons from being cut off 
After the Qt5 switch, status icons were being cut off by 1-2px.

Also fixes some other cases where the UI is slightly off mentioned in #3800.

Fixes #3800.
 2014-03-06 14:56:31 +01:00
Michagogo
d30d379beb Slightly tweak error when unable to bind port 
A slight improvement over 2d2d8fae3d -- we don't know that it's the daemon, it could be the GUI.
 2014-03-05 18:25:35 +02:00
Wladimir J. van der Laan
8a6894ca3e Log which wallet is used during init 
Now that the wallet can be selected using -wallet it is important
to log which wallet is being used for later troubleshooting.
 2014-03-05 16:15:04 +01:00
Cozz Lovan
ba51c7da40 Fix null pointer in IsTrusted() 2014-03-05 15:05:44 +01:00
Pieter Wuille
fecba4e269 Total money limit test 
Added bounds check by @il--ya.

Updated-by: Wladimir van der Laan <laanwj@gmail.com>
 2014-03-05 12:07:58 +01:00
paveljanik
2d2d8fae3d Clarify the error message when unable to bind to port 2014-03-05 10:42:52 +01:00
paveljanik
094eeff0ba Bitcoin is running fine... 
When bitcoind can't bind, bitcoin server (or Bitcoin Core Daemon) is probably already running. Add the missing word "server". Bitcoin itself is definitely running ;-)

Add _(...) so the string can be localized.

I apologize for such trivial changes, learning github interface.
 2014-03-05 00:02:18 +01:00
Wladimir J. van der Laan
c975e99ca9
Merge pull request #3784 
dc01ba7 Fix coin control sorts date as text (Cozz Lovan)
 2014-03-04 15:06:18 +01:00
Wladimir J. van der Laan
ad6ae48939
build: Version bump to 0.9.99, disable IS_RELEASE 
`master` is not a release. Use the same convention as before and label
these intermediate builds as x.x.99.
 2014-03-04 13:33:39 +01:00
Cozz Lovan
dc01ba7b0c Fix coin control sorts date as text 2014-03-03 23:26:00 +01:00
Philip Kaufmann
8e29623077 [Qt] show number of in/out connections in debug console 2014-03-03 22:35:02 +01:00
Philip Kaufmann
a486abd419 replace custom GetFilesize() with boost::filesystem::file_size() 2014-03-03 22:33:09 +01:00
Wladimir J. van der Laan
098316c70f English translation update 
A few new messages have been added since last update.
 2014-03-01 09:06:10 +01:00
Gavin Andresen
7be6ebcf08 Merge pull request #3744 from petertodd/document-isvalid-is-consensus-critical 
Document that CPubKey.IsValid() is consensus critical
 2014-02-28 15:27:58 -05:00
Gavin Andresen
829f822267 Merge pull request #3767 from laanwj/2014_02_tinyformat_errors_non_fatal 
Make tinyformat errors raise an exception instead of assert()ing
 2014-02-28 15:17:28 -05:00
Gavin Andresen
f60e49d49c Merge pull request #3694 from gavinandresen/vfspent 
Remove CWalletTx::vfSpent
 2014-02-28 15:16:25 -05:00
Wladimir J. van der Laan
f642fd9dd6 qt: Modernize 'confirmed' terminology in shown tx status 
These days we regard transactions with one confirmation to be
'Confirmed'.
Waiting for 6 confirmations is a recommendation but should not
keep the transaction shown as unconfirmed.

Misc code sanity:

- Merge maturity/status enums, they had become completely disjunct
- 'confirmed' flag is now called 'countsForBalance' for clarity
 2014-02-28 13:04:50 +01:00
Wladimir J. van der Laan
1b8fd35aad Make tinyformat errors raise an exception instead of assert()ing 
By default tinyformat errors such as 'wrong number of conversion
specifiers in format string' cause an assertion failure.

Raise an exception instead so that error handling can recover or can
show an appropriate error.
 2014-02-28 09:25:00 +01:00
Wladimir J. van der Laan
a270ca2b42 Transifex pull pre-0.9.0rc2 2014-02-27 14:18:53 +01:00
Wladimir J. van der Laan
dcb1280d8e
Merge pull request #3752 
5d5b0d2 Add shell null to else block (Wil Bown)
 2014-02-27 12:35:11 +01:00
Daniel Newton
a00ebb5117 move wallet info stuff to "getwalletinfo" rpc (left original wallet 
stuff in getinfo call for backwards compatibility)

add wallet transaction count to getwalletinfo rpc call
 2014-02-27 14:46:58 +13:00
Wladimir J. van der Laan
b81f9718df
Merge pull request #3749 
4423571 Replace PrintException with PrintExceptionContinue + throw (Wladimir J. van der Laan)
 2014-02-26 20:52:39 +01:00
Wil Bown
5d5b0d284a Add shell null to else block 
MinGW-W64-builds-4.2.0 shell doesn't like the empty else blocks.
 2014-02-26 12:39:57 -07:00
Gavin Andresen
ae7e5d7ceb Merge pull request #3737 from jgarzik/op-return-size 
script: reduce OP_RETURN standard relay bytes to 40
 2014-02-26 13:52:56 -05:00
Jeff Garzik
8175c790eb script: reduce OP_RETURN standard relay bytes to 40 
Per mailing list discussion.
 2014-02-26 12:58:08 -05:00
Gavin Andresen
e3e65d29b7 Merge pull request #3735 from laanwj/2014_02_remove_PRIx64_completely 
Remove PRIx64 usage completely
 2014-02-26 12:16:03 -05:00
Gavin Andresen
93a18a3650 Remove CWalletTx::vfSpent 
Use the spent outpoint multimap to figure out which wallet transaction
outputs are unspent, instead of a vfSpent array that is saved
to disk.
 2014-02-26 11:53:51 -05:00
Wladimir J. van der Laan
44235713ed Replace PrintException with PrintExceptionContinue + throw 
Just a pet peeve.

(PrintException has exactly the same body as PrintExceptionContinue but
does a re-throw at the end. Move these re-throws to the call
site, this aids understanding what is going on as well as eliminates a
bit of code duplication in util.cpp)
 2014-02-26 13:23:52 +01:00
Cozz Lovan
a719903804 Fix bitcoin-cli exit status code 2014-02-26 13:12:47 +01:00
Wladimir J. van der Laan
12f5787d45
Merge pull request #3559 
e6c6bc9 Adds additional zero checks for setCompact  These encoded values should all decode to zero (Noel Tiernan)
 2014-02-25 16:25:52 +01:00
Wladimir J. van der Laan
3198604293
Merge pull request #3712 
a3138ed add test of DecodeBase58 skipping whitespace (Christian von Roques)
 2014-02-25 16:24:03 +01:00
Peter Todd
5a986edac8
Document that CPubKey.IsValid() is consensus critical 2014-02-25 09:31:43 -05:00