Suhas Daftuar
b9f34e84be
Improve readability of segwit.py
2017-03-10 21:05:57 -05:00
MarcoFalke
21833f9456
Merge #9972 : Fix extended rpc tests broken by #9768
...
d055bd6
Fix extended rpc tests broken by 8910b4717e
(John Newbery)
Tree-SHA512: 30e019bd7e17013143e419777491ac0efd9760dddac7232d320c9afe80bc2fb383acd331e20cd5b3e21df1177c0e4a5221c99f831e90cf869d3affca206b9728
2017-03-10 23:06:18 +01:00
Cory Fields
c62475329e
depends: fix zlib build on osx
...
zlib is sneaky and expects ar to be libtool on darwin.
2017-03-10 16:53:05 -05:00
Russell Yanofsky
cc9503cec9
Make qt test compatible with TestChain100Setup framework
...
Reset global state after rpc tests, and remove unnecessary ECC initialization
to prevent assert error if it is initialized twice.
2017-03-10 15:52:29 -05:00
John Newbery
d055bd69cf
Fix extended rpc tests broken by 8910b4717e
2017-03-10 15:50:38 -05:00
Russell Yanofsky
91e303595b
Make test_bitcoin.cpp compatible with Qt Test framework
...
Move Boost.Test main function and global overrides to a new test_bitcoin_main.cpp file.
2017-03-10 15:47:41 -05:00
NicolasDorier
dcf2112de6
Add safe flag to listunspent result
2017-03-10 05:11:10 +00:00
Russell Yanofsky
af61d9f78b
Add COutput::fSafe member for safe handling of unconfirmed outputs
...
This exposes a value computed in CWallet::AvailableCoins so it can used for
other things, like inclusion in listunspent output.
2017-03-10 05:11:10 +00:00
MarcoFalke
8910b4717e
Merge #9768 : [qa] Add logging to test_framework.py
...
64c0800
Use logging in individual tests (John Newbery)
38ad281
Use logging in test_framework/comptool.py (John Newbery)
ff19073
Use logging in test_framework/blockstore.py (John Newbery)
2a9c7c7
Use logging in test_framework/util.py (John Newbery)
b0dec4a
Remove manual debug settings in qa tests. (John Newbery)
af1363c
Always enable debug log and microsecond logging for test nodes. (John Newbery)
6d0e325
Use logging in mininode.py (John Newbery)
553a976
Add logging to p2p-segwit.py (John Newbery)
0e6d23d
Add logging to test_framework.py (John Newbery)
Tree-SHA512: 42ee2acbf444ec32d796f930f9f6e272da03c75e93d974a126d4ea9b2dbaa77cc57ab5e63ce3fd33d609049d884eb8d9f65272c08922d10f8db69d4a60ad05a3
2017-03-09 21:16:39 +01:00
Matt Corallo
df5bae2e7b
Update trusted-sha512-root-commit for new bad tree hash
2017-03-09 09:53:19 -05:00
Matt Corallo
efc06c2c46
If GNU sha512sum is missing, try perl shasum in verify-commits
2017-03-09 09:53:19 -05:00
Matt Corallo
8ed849fbcd
Fix travis failing to fetch keys from the sks keyserver pool
...
Just use the "subset" pool for now, at least none of those are
currently broken, AFAIK.
2017-03-09 09:53:19 -05:00
Matt Corallo
fd5e905e21
Make verify-commits.sh non-recursive
2017-03-09 09:53:19 -05:00
John Newbery
64c080051b
Use logging in individual tests
2017-03-09 09:26:48 -05:00
John Newbery
38ad281b2a
Use logging in test_framework/comptool.py
2017-03-09 09:26:48 -05:00
John Newbery
ff190739be
Use logging in test_framework/blockstore.py
2017-03-09 09:26:48 -05:00
John Newbery
2a9c7c74dc
Use logging in test_framework/util.py
2017-03-09 09:26:48 -05:00
John Newbery
b0dec4a04a
Remove manual debug settings in qa tests.
...
-debug and -logtimemicros are now set by default. Individual test cases
no longer need to set these parameters manually.
2017-03-09 09:26:48 -05:00
John Newbery
af1363cb1c
Always enable debug log and microsecond logging for test nodes.
2017-03-09 09:26:48 -05:00
John Newbery
6d0e3250bb
Use logging in mininode.py
...
This commit adds a TestFramework.mininode Logger to the mininode module.
This is a child logger of TestFramework, so the handlers set up in
test_framework.py will receive records from this logger and emit them
to the log file and console as appropriate.
2017-03-09 09:26:48 -05:00
John Newbery
553a976929
Add logging to p2p-segwit.py
2017-03-09 09:26:48 -05:00
John Newbery
0e6d23dd53
Add logging to test_framework.py
...
This commit adds python logging to test_framework.py. By default this
will output all log levels (DEBUG-INFO-WARNING-ERROR-CRITICAL) to a
test_framework.log file in the temporary test directory, and higher
level logs (WARNING-ERROR-CRITICAL) to the console. The level of logging
to the console can be controlled by a new log-level parameter.
This should have no interaction with the existing trace-rpc parameter.
2017-03-09 09:26:48 -05:00
MarcoFalke
5703dff093
Merge #9962 : [trivial] Fix typo in rpc/protocol.h
...
9ea2490
[trival] Fix typo introduced into rpc/protocol.h in commit 338bf06
(practicalswift)
Tree-SHA512: bfa60dc9f40db867b09e60dbe803db79c86ff939048c91e551c0794a91428bde3aa42c4aabf915c640cd15565005608da10dae051942e806fdf5d28e9704d765
2017-03-09 12:32:46 +01:00
Wladimir J. van der Laan
e3e7db829e
Merge #9538 : [util] Remove redundant call to get() on smart pointer (thread_specific_ptr)
...
53a2ba3
[util] Remove redundant call to get() on smart pointer (thread_specific_ptr) (practicalswift)
Tree-SHA512: ec8ace4218ae0657d1aaf8ba7682b0cdd140fe0844173058d3cbf4575dee8d9ad5f241e5bacf1e9e4ad3f7dd282f56a8cb0f306de2093f2c0f6333daedd58261
2017-03-09 10:33:28 +01:00
Wladimir J. van der Laan
c71f0ca5f8
Merge #9960 : Trivial: Add const modifier to GetHDChain and IsHDEnabled
...
3cef950
Trivial: Add const modifier to GetHDChain and IsHDEnabled (NicolasDorier)
Tree-SHA512: 73126689e179d70e6823950b51aae4da0a1e348436bc72338814f3afeec27868bb479d9e8261f86e4fe851e84492778a30c5f1fe76c9d7dd91796d0e38baeaf0
2017-03-09 10:27:31 +01:00
practicalswift
53a2ba351a
[util] Remove redundant call to get() on smart pointer (thread_specific_ptr)
2017-03-09 10:22:35 +01:00
practicalswift
9ea249014a
[trival] Fix typo introduced into rpc/protocol.h in commit 338bf06
...
The typo was introduced in commit 338bf065a4
, which was merged yesterday.
Changes summarized to facilitate reviewing:
* exampled → example
2017-03-09 10:16:16 +01:00
Wladimir J. van der Laan
b403ec5c0f
Merge #9916 : Fix msvc compiler error C4146 (minus operator applied to unsigned type)
...
8e0720b
Fix msvc compiler error C4146 (unary minus operator applied to unsigned type) (kobake)
292112f
Fix msvc compiler error C4146 (minus operator applied to unsigned type) (kobake)
Tree-SHA512: 25f408daf7bf9ffe4b8b4bd62f6f6d326219189a9faf8f8c0a135c5a0cb0511af765aa2b6087a091c8863c701289bda49a2379b00cd9b10854d316a5c3fc3f8e
2017-03-09 10:02:55 +01:00
Wladimir J. van der Laan
02bd6e9bc6
Merge #9853 : Fix error codes from various RPCs
...
adaa281
Update release notes to include RPC error code changes. (John Newbery)
338bf06
Add commenting around JSON error codes (John Newbery)
dab804c
Return correct error codes in fundrawtransaction(). (John Newbery)
a012087
Return correct error codes in setban(). (John Newbery)
960bc7f
Return correct error codes in removeprunedfunds(). (John Newbery)
c119096
Return correct error codes in blockchain.cpp. (John Newbery)
6d07c62
Return correct error codes in bumpfee(). (John Newbery)
Tree-SHA512: 4bb39ad221cd8c83d98ac5d7ad642f3a8c265522720dc86b2eebc70e74439a85b06d6ddcd6a874e879d986511de3ab0878bb7fe58b50cb0546b78913632ea809
2017-03-09 10:02:17 +01:00
Wladimir J. van der Laan
6805c4112c
Merge #9575 : Remove unused, non-working RPC PostCommand signal
...
54fae05
Remove unreachable code (g_rpcSignals.PostCommand) (practicalswift)
Tree-SHA512: b416d63ffa1c35fa0434b6bc0a930ae1b04919a12114ef65154ce4621aa43d744eb4fc515f48eac2e96c0f528cedb4cdbe2349952d215c2c74e900a63e155e0a
2017-03-09 10:01:03 +01:00
practicalswift
54fae05dad
Remove unreachable code (g_rpcSignals.PostCommand)
2017-03-09 09:47:04 +01:00
Wladimir J. van der Laan
8152d3fe57
Merge #9476 : [refactor] Remove using namespace <xxx> from rpc/ & script/ sources
...
8cbfc4e
Refactor: Remove using namespace <xxx> from script/ (Karl-Johan Alm)
f3c264e
Refactor: Remove using namespace <xxx> from rpc/ (Karl-Johan Alm)
Tree-SHA512: 407e80eeda0b8e1df22c5fcba33572e117542fde83c67357f6c2d98fa60bcc7b21bb88ad9a1ee59062fbec17fadaa4836b69e8e6d18188b4027b794357634467
2017-03-09 08:15:44 +01:00
Wladimir J. van der Laan
c047b1663d
Merge #9643 : [refactor] Remove using namespace <xxx> from wallet/ & util*
...
a57845c
Refactor: Remove using namespace <xxx> from util* (Karl-Johan Alm)
8a52281
Refactor: Remove using namespace <xxx> from wallet/ (Karl-Johan Alm)
Tree-SHA512: cd06b569fee0ce25db753ade5ee694b582733a8883bfd62a27613020266d2a902af079ef23b58a5412f7af4afd7681e689af3c7780e5ea00c77b16d144d72db5
2017-03-09 08:12:59 +01:00
NicolasDorier
3cef95058c
Trivial: Add const modifier to GetHDChain and IsHDEnabled
2017-03-09 11:32:02 +09:00
Matt Corallo
819b513a54
Add missing braces in semaphore posts in net
2017-03-08 14:55:28 -05:00
Matt Corallo
e007b243c4
Fix shutdown hang with >= 8 -addnodes set
...
We previously would block waiting for a CSemaphoreGrant in
ThreadOpenAddedConnections, when we did not need to. This would
block as the posts in CConnman shutdown were both to the wrong
semaphore and in the wrong location.
2017-03-08 14:41:57 -05:00
John Newbery
adaa281da1
Update release notes to include RPC error code changes.
2017-03-08 14:23:16 -05:00
John Newbery
338bf065a4
Add commenting around JSON error codes
...
RPC_INVALID_REQUEST and RPC_METHOD_NOT_FOUND are mapped internally to
HTTP error codes and should not be used for application-layer errors.
This commit adds commenting around those definitions to warn not to use
them for application errors.
2017-03-08 14:22:55 -05:00
Karl-Johan Alm
a57845c20e
Refactor: Remove using namespace <xxx> from util*
2017-03-08 08:47:02 -08:00
Karl-Johan Alm
8a5228197c
Refactor: Remove using namespace <xxx> from wallet/
2017-03-08 08:46:59 -08:00
Karl-Johan Alm
8cbfc4e472
Refactor: Remove using namespace <xxx> from script/
2017-03-08 08:08:17 -08:00
Karl-Johan Alm
f3c264e9a6
Refactor: Remove using namespace <xxx> from rpc/
2017-03-08 08:07:55 -08:00
practicalswift
218d915445
[bench] Avoid function call arguments which are pointers to uninitialized values
2017-03-08 16:40:12 +01:00
Wladimir J. van der Laan
6996e066b5
Merge #9952 : Add historical release notes for 0.14.0
...
2de6930
Add historical release notes for 0.14.0 (Wladimir J. van der Laan)
Tree-SHA512: d75d0fafd5e7ae19dba8cc1525c64da9f3b028ce61d705ef5f79b9ea348012bcb2f3c240e22ac8f0d2ed590a19ab96e01688afeaf31904fc4cd65d583b2c88cf
2017-03-08 16:26:06 +01:00
Wladimir J. van der Laan
2de6930306
Add historical release notes for 0.14.0
2017-03-08 16:23:16 +01:00
MarcoFalke
8bfa13b15b
Merge #9936 : [trivial] Fix three typos introduced into walletdb.h in commit 7184e25
...
fdab309
[trivial] Fix typos introduced in 7184e25c80
(practicalswift)
Tree-SHA512: 091666f996267fc5d9f911e6ff25051df5c198851a9c2a6cae73692ffacc64f4275932260487aa48a224ca7f80c58f79933065c72d42aeccae540293c67bcee9
2017-03-08 14:15:47 +01:00
MarcoFalke
ac23a7c1f1
Merge #9945 : Improve logging in bctest.py if there is a formatting mismatch
...
6c1fb73
Improve logging in bctest.py if there is a formatting mismatch (John Newbery)
Tree-SHA512: ef33f4766df92a987cd714d73b98277616ff947ad0e43811013dda668e31464062816480bd654865231d56d37fb4d6e4ccdccbcb2f0e2f01f49572b843a232ae
2017-03-08 12:16:23 +01:00
kobake
8e0720bdb9
Fix msvc compiler error C4146 (unary minus operator applied to unsigned type)
...
On msvc14, int literal '-2147483648' is invalid, because '2147483648' is unsigned type and cant't apply minus operator to unsigned type.
To define the int literal correctly, use '-2147483647 - 1' formula that is also used to define INT_MIN in limits.h.
2017-03-08 15:43:40 +09:00
John Newbery
6c1fb73dd1
Improve logging in bctest.py if there is a formatting mismatch
2017-03-07 18:07:08 -05:00
John Newbery
dab804c18a
Return correct error codes in fundrawtransaction().
...
The fundrawtransaction() RPC was returning misleading or incorrect error
codes (for example RPC_INTERNAL_ERROR when funding the transaction
failed). This commit fixes those error codes:
- RPC_INTERNAL_ERROR should not be returned for application-level
errors, only for genuine internal errors such as corrupted data.
That error code has been replaced with RPC_WALLET_ERROR.
This commit also updates the test cases to explicitly test the error code.
2017-03-07 16:45:09 -05:00