Wladimir J. van der Laan
9b63758974
util: Don't set strMiscWarning on every exception
...
Fixes #6809 - run-of-the-mill exceptions should not get into
strMiscWarning (which is reported by `getinfo`).
2015-11-27 13:36:11 +01:00
Wladimir J. van der Laan
5ca149a3db
Merge pull request #7053
...
2e29e7e
Globals: Remove a bunch of Params() calls from main.cpp: (Jorge Timón)
2015-11-27 13:29:54 +01:00
Jonas Schnelli
a46f87f0c1
Initialize logging before we do parameter interaction
2015-11-27 13:26:28 +01:00
Jonas Schnelli
df66147613
Move -blocksonly parameter interaction to the new ParameterInteraction() function
2015-11-27 13:26:28 +01:00
Jonas Schnelli
68354e75e9
[QT] Call inits parameter interaction before we create the options model
2015-11-27 13:26:01 +01:00
Jonas Schnelli
411b05ac95
Refactor parameter interaction, call it before AppInit2()
2015-11-27 13:26:00 +01:00
Wladimir J. van der Laan
0e935865b9
Merge pull request #6871
...
63b5840
Fix usage of local python-bitcoinlib (Peter Todd)
16a2f93
Fix incorrect locking of mempool during RBF replacement (Peter Todd)
97203f5
Port test to rpc-test framework (Suhas Daftuar)
20367d8
Add test for max replacement limit (Suhas Daftuar)
73d9040
Improve RBF replacement criteria (Suhas Daftuar)
b272ecf
Reject replacements that add new unconfirmed inputs (Peter Todd)
fc8c19a
Prevent low feerate txs from (directly) replacing high feerate txs (Peter Todd)
0137e6f
Add tests for transaction replacement (Peter Todd)
5891f87
Add opt-in full-RBF to mempool (Peter Todd)
2015-11-27 13:20:39 +01:00
Wladimir J. van der Laan
e92377fa7f
Merge pull request #6134
...
e304432
Pass reference to estimateSmartFee and cleanup whitespace (Suhas Daftuar)
56106a3
Expose RPC calls for estimatesmart functions (Alex Morcos)
e93a236
add estimateSmartFee to the unit test (Alex Morcos)
6303051
EstimateSmart functions consider mempool min fee (Alex Morcos)
f22ac4a
Increase success threshold for fee estimation to 95% (Alex Morcos)
4fe2823
Change wallet and GUI code to use new smart fee estimation calls. (Alex Morcos)
22eca7d
Add smart fee estimation functions (Alex Morcos)
2015-11-27 12:59:37 +01:00
Wladimir J. van der Laan
05d591839f
Merge pull request #5967
...
072e2f8
Alter assumptions in CCoinsViewCache::BatchWrite (Alex Morcos)
2015-11-27 12:44:00 +01:00
Wladimir J. van der Laan
9a3e1a59df
Merge pull request #7058
...
ffacd27
zmq: prepend zmq to debug messages (Daniel Cousens)
14075b1
init: add zmq to debug categories (Daniel Cousens)
cdcd816
init: amend ZMQ flag names (Daniel Cousens)
2015-11-27 10:12:43 +01:00
Pieter Wuille
a9f3d3db5c
Fix and improve relay from whitelisted peers
...
This makes sure that retransmits by a whitelisted peer also actually
result in a retransmit.
Further, this changes the logic to never relay in case we would assign
a DoS score, as we expect to get DoS banned ourselves as a result.
2015-11-26 23:44:57 +01:00
Wladimir J. van der Laan
f8a8e27a6a
Merge pull request #7069
...
fa472f3
[trivial] Fix -maxmempool InitError (MarcoFalke)
2015-11-26 11:18:31 +01:00
Peter Todd
cde857f2d9
Connect to Tor hidden services by default
...
Adds 127.0.0.1:9050 for the .onion proxy if we can succesfully connect
to the control port.
Natural followup to creating hidden services automatically.
2015-11-26 05:14:31 -05:00
Wladimir J. van der Laan
be281d8a83
Merge pull request #7087
...
9cf6688
Document both the peerbloomfilters and enforcenodebloom options. (Patick Strateman)
0f4dc53
Add enforcenodebloom option. (Patick Strateman)
b3caa9b
Move bloom filter filtering logic outside of command "switch" (giant if/else). (Patick Strateman)
2015-11-26 08:43:21 +01:00
Wladimir J. van der Laan
4ec3561eb3
Replace scriptnum_test's normative ScriptNum implementation
...
Compare against the scriptnum from Bitcoin Core 0.10 instead of OpenSSL.
Closes #7086 .
2015-11-25 13:59:49 +01:00
Wladimir J. van der Laan
2b2ddc558e
Merge pull request #7088
...
5ad5463
Squashed 'src/secp256k1/' changes from 2bfb82b..6c527ec (MarcoFalke)
2015-11-25 11:31:59 +01:00
Wladimir J. van der Laan
348b281f8a
Merge pull request #7092
...
392d3c5
build: Set osx permissions in the dmg to make Gatekeeper happy (Cory Fields)
2015-11-25 10:01:58 +01:00
daniel
c434940e83
uint256::GetCheapHash bigendian compatibility
2015-11-25 16:19:24 +08:00
Jonas Schnelli
26af1ac7cb
Merge pull request #7006
...
f71bfef
add UI help for -resetguisettings (Jonas Schnelli)
ae98388
[Qt] add startup option to reset Qt settings (Jonas Schnelli)
2015-11-25 09:05:19 +01:00
Patick Strateman
1bb289fe1b
Assert now > 0 in GetTime GetTimeMillis GetTimeMicros
...
Previously all of these functions could return negative values (for different
readons). Large portions of the codebase currently assume that these
functions return positive values.
2015-11-24 18:39:19 -08:00
Cory Fields
392d3c5846
build: Set osx permissions in the dmg to make Gatekeeper happy
2015-11-24 16:22:24 -05:00
Wladimir J. van der Laan
b19fe277dd
Merge pull request #7075
...
4846543
Move time data log print to 'net' category to reduce log noise (tulip)
2015-11-24 16:02:02 +01:00
Suhas Daftuar
e30443244a
Pass reference to estimateSmartFee and cleanup whitespace
2015-11-24 08:53:14 -05:00
MarcoFalke
fa472f330f
[trivial] Fix -maxmempool InitError
2015-11-24 12:40:59 +01:00
Patick Strateman
9cf668844e
Document both the peerbloomfilters and enforcenodebloom options.
2015-11-24 02:08:00 -08:00
Patick Strateman
0f4dc53fd6
Add enforcenodebloom option.
...
Previously peers which implement a protocol version less than NO_BLOOM_VERSION
would not be disconnected for sending a filter command, regardless of the
peerbloomfilter option.
Many node operators do not wish to provide expensive bloom filtering for SPV
clients, previously they had to cherry pick the commit which enabled the
disconnect logic.
The default should remain false until a sufficient percent of SPV clients
have updated.
2015-11-24 02:08:00 -08:00
Wladimir J. van der Laan
02a0f348c2
Merge pull request #7066
...
5c2fd38
Add missing "blocktime" description to listtransactions help, fix formatting. (Pavel Janík)
2015-11-24 10:55:36 +01:00
Patick Strateman
b3caa9b7fa
Move bloom filter filtering logic outside of command "switch" (giant if/else).
...
Moving this logic outside of the "switch" makes it far simpler to
enable the forced disconnect by a parameter.
2015-11-24 01:50:53 -08:00
Wladimir J. van der Laan
72dccfc29d
Merge pull request #7045
...
2aa49ce
Bugfix: Use unique autostart filenames on Linux for testnet/regtest (Luke Dashjr)
2015-11-24 09:51:02 +01:00
Wladimir J. van der Laan
b1fcdec687
Merge pull request #7042
...
70899d7
[doc][trivial] Update Debian control description (fanquake)
2fcb849
[doc][trivial] Remove source forge from Debian watch. (fanquake)
2015-11-24 09:32:44 +01:00
Wladimir J. van der Laan
ed34e0577e
Merge pull request #7052
...
a0953cd
[qa] python-bitcoinrpc is no longer a subtree (MarcoFalke)
2015-11-24 09:29:46 +01:00
MarcoFalke
fa63e49b35
Merge commit '5ad54630935d1f340666de7bc9ffef9b8a1df296' into HEAD
2015-11-24 09:22:18 +01:00
MarcoFalke
5ad5463093
Squashed 'src/secp256k1/' changes from 2bfb82b..6c527ec
...
6c527ec Merge pull request #357
445f7f1 Fix for Windows compile issue
git-subtree-dir: src/secp256k1
git-subtree-split: 6c527eceee7f5105c33c98dfae24ffeffd71f7cf
2015-11-24 09:21:37 +01:00
MarcoFalke
faf12bc283
OpenSSL 1.1.0: Fix text variant of the version number
2015-11-24 09:07:26 +01:00
Wladimir J. van der Laan
f91e29fd4d
Merge pull request #7065
...
3522f49
http: add Boost 1.49 compatibility (Wladimir J. van der Laan)
2015-11-24 08:42:29 +01:00
Jorge Timón
2e29e7e247
Globals: Remove a bunch of Params() calls from main.cpp:
...
1) Chainparams: Explicit CChainParams arg for main:
-AcceptBlock
-AcceptBlockHeader
-ActivateBestChain
-ConnectTip
-InitBlockIndex
-LoadExternalBlockFile
-VerifyDB parametric constructor
2) Also pickup more Params()\. in main.cpp
3) Pass nPruneAfterHeight explicitly to new FindFilesToPrune() in main.cpp
2015-11-23 12:14:40 +01:00
Gregory Maxwell
ebb25f4c23
Limit setAskFor and retire requested entries only when a getdata returns.
...
The setAskFor duplicate elimination was too eager and removed entries
when we still had no getdata response, allowing the peer to keep
INVing and not responding.
2015-11-23 01:54:23 +00:00
kazcw
5029698186
prevent peer flooding request queue for an inv
...
mapAlreadyAskedFor does not keep track of which peer has a request queued for a
particular tx. As a result, a peer can blind a node to a tx indefinitely by
sending many invs for the same tx, and then never replying to getdatas for it.
Each inv received will be placed 2 minutes farther back in mapAlreadyAskedFor,
so a short message containing 10 invs would render that tx unavailable for 20
minutes.
This is fixed by disallowing a peer from having more than one entry for a
particular inv in mapAlreadyAskedFor at a time.
2015-11-23 01:18:54 +00:00
Gregory Maxwell
0b0fc179ab
Merge pull request #7028
...
e16ee1c
[qa] Extend README.md (MarcoFalke)
cc97574
[qa] Split README.md to /qa and /qa/rpc-tests (MarcoFalke)
2015-11-22 14:51:30 -08:00
Gregory Maxwell
9cdd407ca5
Merge pull request #7029
...
c800c95
Remove unmaintained example test script_test.py (Suhas Daftuar)
2015-11-22 14:47:40 -08:00
Gregory Maxwell
c322652b71
Merge pull request #7046
...
80ae230
Improve log messages for blocks only violations. (Patick Strateman)
08843ed
Add relaytxes status to getpeerinfo (Peter Todd)
d8aaa51
Bail early in processing transactions in blocks only mode. (Patick Strateman)
3587f6a
Fix relay mechanism for whitelisted peers under blocks only mode. (Patick Strateman)
2015-11-22 14:01:33 -08:00
tulip
4846543ac5
Move time data log print to 'net' category to reduce log noise
2015-11-22 06:48:25 +00:00
Patick Strateman
80ae230a52
Improve log messages for blocks only violations.
2015-11-21 16:09:52 -08:00
Gregory Maxwell
31de2414c6
Merge pull request #7011
...
6531f17
Add mediantime field to getblock and getblockheader (Peter Todd)
7259769
Document new mediantime field in getblockchaininfo (Peter Todd)
c277a63
Clarify nLockTime-by-time comment in CheckFinalTx() (Peter Todd)
748321e
Add mediantime field to getblockchaininfo RPC call (Peter Todd)
2015-11-21 14:00:55 -08:00
Gregory Maxwell
616d61b20d
Merge pull request #6851
...
3e7c891
Optimisation: Store transaction list order in memory rather than compute it every need (Luke Dashjr)
2015-11-20 18:52:44 -08:00
Luke Dashjr
3e7c89196c
Optimisation: Store transaction list order in memory rather than compute it every need
...
Huge performance improvement (450%) for zapwallettxes
2015-11-21 01:48:25 +00:00
Peter Todd
08843ed998
Add relaytxes status to getpeerinfo
2015-11-20 16:07:12 -08:00
Patick Strateman
d8aaa51bec
Bail early in processing transactions in blocks only mode.
...
Previously unsolicited transactions would be processed as normal.
2015-11-20 16:07:12 -08:00
Patick Strateman
3587f6a024
Fix relay mechanism for whitelisted peers under blocks only mode.
...
Previously in blocks only mode all inv messages where type!=MSG_BLOCK would be
rejected without regard for whitelisting or whitelistalwaysrelay.
As such whitelisted peers would never send the transaction (which would be
processed).
2015-11-20 16:07:12 -08:00
Peter Todd
63b5840257
Fix usage of local python-bitcoinlib
...
Previously was using the system-wide python-bitcoinlib, if it existed,
rather than the local copy that you check out in the README.
2015-11-20 16:23:01 -05:00