Peter Todd
36f60a5d5b
Add copyright/patent issues to possible NACK reasons
...
Adding in response to a Slack discussion where someone was unclear on the fact
that a NACK may be justified if code can't be accepted due to copyright/patent
issues. For example, it would be reasonable and prudent to NACK a contribution
of AGPL-licensed consensus code on the basis that the license terms are
incompatible with the MIT license used by the rest of the codebase.
2016-10-13 19:47:43 +02:00
Wladimir J. van der Laan
e2b8c394d6
Merge #8817 : update bitcoin-tx to output witness data
...
4408558
2016-10-13 18:56:43 +02:00
Wladimir J. van der Laan
e2a17e43e3
Merge #8904 : [qa] Fix compact block shortids for a test case
...
4cdece4
2016-10-13 18:48:13 +02:00
Wladimir J. van der Laan
8d46429c83
Merge #8911 : qt: Translate all files, even if wallet disabled
...
8aed5f6
2016-10-13 10:30:38 +02:00
Wladimir J. van der Laan
d270c30d55
Merge #8892 : doc: Add build instructions for FreeBSD
...
3f92bc9
2016-10-13 10:21:36 +02:00
Wladimir J. van der Laan
3f92bc9e83
doc: Add build instructions for FreeBSD
2016-10-13 10:16:17 +02:00
Wladimir J. van der Laan
8aed5f6c23
qt: Translate all files, even if wallet disabled
...
This passes all QT cpp files to the lupdate executable which extracts
translations, no matter what conditional functionality is enabled.
2016-10-11 17:46:46 +02:00
MarcoFalke
d075479969
Merge #8882 : [qa] Fix race conditions in p2p-compactblocks.py and sendheaders.py
...
b55d9416976db2
2016-10-11 10:50:22 +02:00
Dagur Valberg Johannsson
4cdece4041
[qa] Fix compact block shortids for a test case
2016-10-10 13:37:16 -04:00
Jonas Schnelli
bf8e68aba6
Merge #8821 : [qt] sync-overlay: Don't block during reindex
...
fa85e86faa4de2
2016-10-10 16:52:44 +02:00
Pieter Wuille
6429cfa8a7
Merge #8393 : Support for compact blocks together with segwit
...
27acfc1422fac6f5b9b8f6aa28abbe7555f06128da
2016-10-10 13:16:40 +02:00
MarcoFalke
072116fceb
Merge #8891 : [Doc] Update bips.md for Segregated Witness
...
ef28d8a
2016-10-08 21:28:26 +02:00
MarcoFalke
e66cc1d58e
Merge #8881 : Add some verbose logging to bitcoin-util-test.py
...
621441a
2016-10-08 21:23:42 +02:00
MarcoFalke
f137753a2d
Merge #8896 : Update INSTALL landing redirection notice for build instructions.
...
2920be2
2016-10-08 21:20:22 +02:00
Jonas Schnelli
b2fec4e9a1
Merge #8885 : gui: fix ban from qt console
...
cb78c60
2016-10-08 16:43:15 +02:00
Suhas Daftuar
b55d9411e7
[qa] Fix race condition in sendheaders.py
...
Also de-duplicates code that has been moved to mininode
2016-10-06 14:21:11 -04:00
MarcoFalke
61d191fbf9
Merge #8887 : [Doc] Improve GitHub issue template
...
7d8afb4
2016-10-06 09:27:25 +02:00
fanquake
ef28d8a899
[Doc] Update bips.md for Segregated Witness
2016-10-06 07:33:15 +04:00
fanquake
7d8afb4cde
[Doc] Improve GitHub issue template
2016-10-06 07:26:43 +04:00
randy-waterhouse
2920be2a69
Update INSTALL landing redirection notice for build instructions.
2016-10-06 12:27:23 +13:00
jnewbery
621441a7a7
add verbose mode to bitcoin-util-test.py
2016-10-05 09:16:08 -04:00
jonnynewbs
4408558843
Update bitcoin-tx to output witness data.
2016-10-05 09:00:34 -04:00
Wladimir J. van der Laan
223f4c2dd5
Merge #8884 : Bugfix: Trivial: RPC: getblockchaininfo help: pruneheight is the lowest, not highest, block
...
a78e542
2016-10-05 14:44:07 +02:00
Wladimir J. van der Laan
f92805025d
Merge #8879 : [doc] Rework docs
...
eeeebdd
2016-10-05 05:07:19 +02:00
Cory Fields
cb78c60534
gui: fix ban from qt console
...
Rather than doing a circle and re-resolving the node's IP, just use the one
from nodestats directly.
This requires syncing the addr field from CNode.
2016-10-04 19:43:53 -04:00
Luke Dashjr
a78e5428ac
Bugfix: Trivial: RPC: getblockchaininfo help: pruneheight is the lowest, not highest, block
2016-10-04 22:22:07 +00:00
Suhas Daftuar
6976db2f46
[qa] Another attempt to fix race condition in p2p-compactblocks.py
...
sync_with_ping() only guarantees that the node has processed messages
it's received from the peer, not that block announcements from the node have
made it back to the peer. Replace sync_with_ping() with an explicit check that
the node's tip has been announced.
2016-10-04 15:17:19 -04:00
Suhas Daftuar
27acfc1d2e
[qa] Update p2p-compactblocks.py for compactblocks v2
2016-10-04 19:10:49 +02:00
Suhas Daftuar
422fac649f
[qa] Add support for compactblocks v2 to mininode
2016-10-04 19:10:49 +02:00
Suhas Daftuar
f5b9b8f437
[qa] Fix bug in mininode witness deserialization
...
Also improve tx printing
2016-10-04 19:10:49 +02:00
Pieter Wuille
6aa28abf53
Use cmpctblock type 2 for segwit-enabled transfer
...
Contains version negotiation logic by Matt Corallo and bugfixes by
Suhas Daftuar.
2016-10-04 19:10:41 +02:00
Matt Corallo
be7555f0c0
Fix overly-prescriptive p2p-segwit test for new fetch logic
2016-10-04 18:24:10 +02:00
Matt Corallo
06128da751
Make GetFetchFlags always request witness objects from witness peers
...
This fixes a bug where we might (in exceedingly rare circumstances)
accidentally ban a node for sending us the first (potentially few)
segwit blocks in non-segwit mode.
2016-10-04 18:24:10 +02:00
MarcoFalke
eeeebdd3cb
[doc] Rework docs
...
* Minor formatting such as adjusting links
* Move sections of `doc/multiwallet-qt.md` to the source code and delete
the file, as it is outdated
* Fix typo in the release notes
* Amend release process to mention update of BLOCK_CHAIN_SIZE
2016-10-04 13:27:38 +02:00
Wladimir J. van der Laan
d7615af34e
Merge #8848 : Add NULLDUMMY verify flag in bitcoinconsensus.h
...
2fa0063
2016-10-04 12:18:16 +02:00
Wladimir J. van der Laan
d93f0c6184
Merge #8862 : Fix a few cases where messages were sent after requested disconnect
...
905bc68
2016-10-04 12:13:50 +02:00
Wladimir J. van der Laan
7dce175f5d
Merge #8850 : Implement (begin|end)_ptr in C++11 and add deprecation comment
...
f00705a47314e6
2016-10-04 11:08:06 +02:00
Wladimir J. van der Laan
a7e5cbb209
Merge #8856 : Globals: Decouple GetConfigFile and ReadConfigFile from global mapArgs
...
3450c18
2016-10-03 15:25:09 +02:00
MarcoFalke
76f3c02fb0
Merge #8860 : [qa] util: Move wait_bitcoinds() into stop_nodes()
...
fa7c35c
2016-10-03 10:12:42 +02:00
Wladimir J. van der Laan
eafc5f4fae
Merge #8863 : univalue: Pull subtree
...
2ca7faa
2016-10-03 08:45:13 +02:00
Wladimir J. van der Laan
6f3ef551fa
Merge #8858 : rpc: Generate auth cookie in hex instead of base64
...
1c80386
2016-10-03 07:57:41 +02:00
MarcoFalke
6013c73b33
Merge #8857 : [qa] mininode: Only allow named args in wait_until
...
fa66609
2016-10-02 23:14:17 +02:00
MarcoFalke
fa666094cf
[qa] mininode: Only allow named args in wait_until
2016-10-02 12:21:14 +02:00
MarcoFalke
fa7c35c4ec
[qa] util: Move wait_bitcoinds() into stop_nodes()
2016-10-02 11:16:44 +02:00
Wladimir J. van der Laan
f00705ae7f
serialize: Deprecate begin_ptr / end_ptr
...
Implement `begin_ptr` and `end_ptr` in terms of C++11 code,
and add a comment that they are deprecated.
Follow-up to developer notes update in 654a211622
2016-10-02 09:50:25 +02:00
Cory Fields
905bc68d05
net: fix a few cases where messages were sent rather than dropped upon disconnection
...
75ead758 turned these into crashes in the event of a handshake failure, most
notably when a peer does not offer the expected services.
There are likely other cases that these assertions will find as well.
2016-10-01 19:13:10 -04:00
Wladimir J. van der Laan
1c80386bce
rpc: Generate auth cookie in hex instead of base64
...
Base64 contains '/', and the '/' character in credentials is problematic
for AuthServiceProxy which represents the RPC endpoint as an URI with
user and password embedded.
Closes #8399 .
2016-10-01 16:57:25 +02:00
MarcoFalke
6faffb8a83
Merge #8854 : [qa] Fix race condition in p2p-compactblocks test
...
b5fd666
2016-10-01 11:19:22 +02:00
Jorge Timón
3450c18a12
Globals: Decouple GetConfigFile and ReadConfigFile from global mapArgs
2016-10-01 08:12:19 +02:00
Suhas Daftuar
b5fd666984
[qa] Fix race condition in p2p-compactblocks test
...
Also fix a bug in the sync_with_ping() helper function
2016-09-30 20:54:30 -04:00
