Gavin Andresen
d605bc4cd1
Exit cleanly if AppInit2 returns false
...
Bitcoin-Qt could core dump if application initialization failed in certain ways.
I double-fixed this:
1) qt/bitcoin.cpp now shuts down core threads cleanly if AppInit2 returns false
2) init.cpp now exits before StartNode() if strErrors is set (no reason to StartNode if we're just going to exit immediately anyway).
Tested by triggering all of the various ways AppInit2 can fail, either by passing bogus command-line arguments or just recompiling tweaked code to simulate failure.
This is a partial fix for #2480
2013-05-02 12:26:33 -04:00
Pieter Wuille
a9d9f0f5f7
Do not kill connections on recv buffer overflow
...
Instead of killing a connection when the receive buffer overflows,
just temporarily halt receiving before that happens. Also, no
matter what, always allow at least one full message in the receive
buffer (otherwise blocks larger than the configured buffer size
would pause indefinitely).
2013-05-01 20:56:50 +02:00
Pieter Wuille
2aceeb01a9
Bugfix: if no bestblock record is present, do a -rescan
...
It is possible to have a wallet.dat file without any bestblock
record at all (if created offline, for example), which - when
loaded into a client with a up-to-date chain - does no rescan and
shows no transactions.
Also make sure to write the current best block after a rescan, so
it isn't necessary twice.
2013-05-01 19:21:55 +02:00
Pieter Wuille
e31aa7c9d7
Improve gettxoutsetinfo command
...
* Bugfix: output the correct best block hash (during IBD, it can
differ from the actual current best block)
* Add height to output
* Add hash_serialized, which is a hash of the entire UTXO state.
Can be useful to compare two nodes.
* Add total_amount, the sum of all UTXOs' values.
2013-05-01 17:21:43 +02:00
Jeff Garzik
9f4976afe2
RPC: strictly require HTTP URI "/"
...
Previously, JSON-RPC clients accessed URI "/", and the JSON-RPC server
did not care about the URI at all, and would accept any URI as valid.
Change the JSON-RPC server to require URI "/" for all current accesses.
This changes enables the addition of future interfaces at different
URIs, such as pull request #1982 which demonstrates HTTP REST wallet
download.
Or, a future, breaking change in JSON-RPC interface could be introduced
by serving JSON-RPC calls from new URI "/v2/".
2013-05-01 10:41:24 -04:00
Gregory Maxwell
eef2091fe9
Merge pull request #2595 from sipa/noannloc
...
Don't announce to non-peer CNodes
2013-04-30 12:09:07 -07:00
Pieter Wuille
788064dd12
Don't announce to non-peer CNodes
2013-04-30 19:41:58 +02:00
Pieter Wuille
1c621e70be
Merge pull request #2583 from laanwj/2013_04_netbase_bitfield
...
netbase: fix !O_NONBLOCK where ~O_NONBLOCK was meant
2013-04-29 16:36:51 -07:00
Pieter Wuille
d2cefe1674
Merge pull request #2589 from sipa/win32ldberr
...
Some win32-leveldb related fixes
2013-04-29 16:36:25 -07:00
Gavin Andresen
67f93dc513
Merge pull request #2568 from sipa/rlimit
...
Try to increase file descriptor rlimit if necessary
2013-04-29 13:25:13 -07:00
Pieter Wuille
228b29cf8f
Merge pull request #2349 from dserrano5/master
...
Accept negative -par values to leave N CPUs free.
2013-04-29 10:54:04 -07:00
David Serrano
ebd7e8bf91
Accept negative -par values to leave N CPUs free.
2013-04-29 19:35:47 +02:00
Wladimir J. van der Laan
7226806e8d
Merge pull request #2569 from sipa/win1024fd
...
Allow select()ing up to 1024 file descriptors on Windows
2013-04-29 10:27:33 -07:00
Pieter Wuille
ba29a5590b
Try to increase file descriptor rlimit if necessary
...
As the default can be too low, especially on OSX.
2013-04-29 01:46:24 +02:00
Wladimir J. van der Laan
33029bcedd
Merge pull request #2586 from laanwj/2013_04_winsock_init
...
move WSAStartup to init
2013-04-28 08:00:53 -07:00
Pieter Wuille
551b367f19
Allow files to be opened for reading multiple times
2013-04-28 14:15:34 +02:00
Wladimir J. van der Laan
d23fa49c52
move WSAStartup to init
...
WSAStartup should be called before using any other socket
functions. BindListenPort is not called if not listening.
Closes #2585 .
2013-04-28 08:54:27 +02:00
Pieter Wuille
20d6f2013b
Checking whether closing succeeds
2013-04-27 20:07:22 +02:00
Pieter Wuille
67efbda4a2
Print actual Win32 error that occurred on file creation failure.
2013-04-27 18:28:41 +02:00
Wladimir J. van der Laan
85157ae018
Merge pull request #2584 from laanwj/2013_04_shrinkdebugfile_leak
...
Prevent prevent file descriptor leak in ShrinkDebugFile()
2013-04-27 07:03:20 -07:00
Tariq Bashir
6e34d9b12a
Prevent prevent file descriptor leak in ShrinkDebugFile()
2013-04-27 16:00:28 +02:00
Wladimir J. van der Laan
fe9e88cb06
fix !O_NONBLOCK where ~O_NONBLOCK was meant
...
Using ! on a non-zero value will always return 0.
Also remove some duplicate and superfluous code in other places.
2013-04-27 15:37:26 +02:00
Wladimir J. van der Laan
63888d43be
Merge pull request #2530 from jonasschnelli/mac_win_reopen_fix
...
fixes #1522 : GUI Disappearing (Mac OSX)
2013-04-27 02:15:54 -07:00
Wladimir J. van der Laan
6e40d79860
Merge pull request #2559 from maqifrnswa/manpages
...
added bitcoin-qt manpage and corrected a few minus signs
2013-04-27 02:08:43 -07:00
Wladimir J. van der Laan
aa9eee7eaf
Merge pull request #2564 from Diapolo/walletview
...
small updates for walletview.cpp
2013-04-27 02:08:08 -07:00
Wladimir J. van der Laan
baba312be0
Merge pull request #2582 from laanwj/2013_04_options_fee_recommendation
...
qt: remove fee recommendation in settings
2013-04-27 02:07:20 -07:00
Wladimir J. van der Laan
dffb535ead
qt: remove fee recommendation in settings
...
This value gets stale really quickly, do not hardcode it into a message.
Completely remove it for now.
Later on, a mechanism will be added to determine fees based on the mempool.
Closes #2576
2013-04-27 11:06:43 +02:00
Wladimir J. van der Laan
3c3164da73
Merge pull request #2572 from laanwj/2013_04_wasted_space
...
qt: remove extraneous padding introduced in multiwallet support patch
2013-04-26 07:10:35 -07:00
Wladimir J. van der Laan
88a18060f3
Merge pull request #2573 from fanquake/bitcoin-qt-app-gitignore
...
Add Bitcoin-Qt.app to .gitignore
2013-04-26 05:00:06 -07:00
Michael Ford
9055b0fb12
Add Bitcoin-Qt.app to .gitignore
...
Saves you from seeing everything in the Bitcoin-Qt.app/Contents/ dir
after compiling
2013-04-26 15:38:28 +08:00
Wladimir J. van der Laan
1a31428ec0
qt: remove extraneous padding introduced in multiwallet support patch
...
solve issue #2529
2013-04-26 07:38:24 +02:00
Pieter Wuille
33912d1f23
Allow select()ing up to 1024 file descriptors on Windows
2013-04-26 01:31:10 +02:00
Pieter Wuille
840e89e3a1
Merge pull request #2563 from Diapolo/translations
...
translations update 2013-04-25
2013-04-25 16:10:52 -07:00
Pieter Wuille
360cfe142c
Allow the default key to be unavailable
...
This solves the issue where no default key can be added after -salvagewallet.
2013-04-25 19:36:10 +02:00
Philip Kaufmann
9e334cfae3
translations update 2013-04-25
...
- new language "se"
- update bitcoin.qrc and bitcoin_en.ts
- fetch current translations from Transifex
2013-04-25 16:53:51 +02:00
Philip Kaufmann
46fd626b21
small updates for walletview.cpp
...
- make "&Export" translatable
- fix some includes
- small formatting changes
2013-04-25 16:15:31 +02:00
Pieter Wuille
ccda03b570
Remove database/ after clean shutdown
2013-04-24 22:38:56 +02:00
Scott Howard
ab20cd76f2
re-remove irc reference in bitcoin.conf.5
2013-04-24 14:10:07 -03:00
Gavin Andresen
77a1e12eed
Merge pull request #2554 from fanquake/qt-pro-brew-patch
...
bitcoin-qt.pro Brew patch
2013-04-24 08:48:06 -07:00
Gavin Andresen
fe15aa335c
Merge pull request #2557 from sipa/leveldb64
...
Reduce number of open LevelDB files to 64
2013-04-24 08:39:39 -07:00
Scott Howard
765f702310
added bitcoin-qt manpage and corrected a few minus signs used as hyphens in other manpages
2013-04-23 19:50:51 -04:00
Pieter Wuille
1859aafef0
Try moving database/ away in case of failure
2013-04-24 01:37:19 +02:00
Philip Kaufmann
e79110822e
remove duplicate bitdb.Open() code from init
...
- remove code from step 7, which we already have in step 5 of init
2013-04-24 00:49:50 +02:00
Pieter Wuille
2233fc5318
Reduce number of open LevelDB files to 64
2013-04-24 00:10:23 +02:00
Wladimir J. van der Laan
af10e3f6ac
Merge pull request #2526 from Diapolo/Qt_misc
...
Bitcoin-Qt: misc small changes
2013-04-23 09:27:30 -07:00
Wladimir J. van der Laan
e9d769d143
Merge pull request #2556 from APerson241/master
...
Some small grammar fixes
2013-04-23 09:27:12 -07:00
APerson241
6ee82ddb70
Update Tor.txt for grammar fixes
2013-04-23 13:17:59 -03:00
Michael Ford
0565b7122f
Update Qt Readme to include HomeBrew setup for OSX
2013-04-23 17:20:28 +08:00
Michael Ford
a3d0dec78e
Add bitcoin-qt.pro homebrew patch
2013-04-23 15:55:23 +08:00
Philip Kaufmann
61032f8942
remove obsolete and unused typedef for Windows
2013-04-23 09:54:29 +02:00