Wladimir J. van der Laan
fc9e3346e6
Merge #7904 : txdb: Fix assert crash in new UTXO set cursor
...
a3310b4
txdb: Fix assert crash in new UTXO set cursor (Wladimir J. van der Laan)
2016-04-19 10:23:38 +02:00
mrbandrews
87049e832d
Speed up getchaintips.
2016-04-18 12:10:47 -04:00
Wladimir J. van der Laan
b30fb42e49
test: Rename wallet.dat to wallet_test.dat
...
Indicate that the file name is not hardcoded, and a little bit of safety
so that it never nukes the main wallet.
Suggestion by Marco Falke.
2016-04-18 15:17:08 +02:00
Wladimir J. van der Laan
a25a4f5b04
wallet_ismine.h → script/ismine.h
...
Removes conditional dependency of `src/test` on wallet.
Makes multisig and P2SH tests complete without wallet built-in.
2016-04-18 15:14:36 +02:00
Wladimir J. van der Laan
f4eae2d910
test: Create test fixture for wallet
...
Removes all the `#ifdef ENABLE_WALLET` from `test_bitcoin` by
making the wallet tests use their own fixture.
2016-04-18 14:57:42 +02:00
MarcoFalke
fae1f4ebfe
[qa] rpc-tests: Fix link in comment and label error msg
2016-04-18 14:52:28 +02:00
Wladimir J. van der Laan
d289950180
Merge #7900 : fix spelling mistake
...
3107c47
fix spelling mistake (Chris Moore)
2016-04-18 14:15:12 +02:00
Wladimir J. van der Laan
9eb7565cdd
Merge #7897 : add missing newline
...
dc0693f
add missing newline (Chris Moore)
2016-04-18 14:14:30 +02:00
Wladimir J. van der Laan
de39c95c24
test: move accounting_tests and rpc_wallet_tests to wallet/test
...
Move the two other wallet tests to where they belong.
2016-04-18 14:04:40 +02:00
Wladimir J. van der Laan
88616d2008
Merge #7848 : Divergence between 32- and 64-bit when hashing >4GB affects gettxoutsetinfo
...
28b400f
doc: update release-notes for `gettxoutsetinfo` change (Wladimir J. van der Laan)
76212bb
rpc: make sure `gettxoutsetinfo` hash has txids (Wladimir J. van der Laan)
9ad1a51
crypto: bytes counts are 64 bit (Wladimir J. van der Laan)
2016-04-18 12:48:09 +02:00
Wladimir J. van der Laan
b1bf511af6
Merge #7833 : tests: Check Content-Type header returned from RPC server
...
5078ca4
tests: Check Content-Type header returned from RPC server (Wladimir J. van der Laan)
2016-04-18 12:45:04 +02:00
Wladimir J. van der Laan
ec870e1399
Merge #7888 : prevector: fix 2 bugs in currently unreached code paths
...
a7af72a
prevector::swap: fix (unreached) data corruption (Kaz Wesley)
4ed41a2
test prevector::swap (Kaz Wesley)
1e2c29f
prevector: destroy elements only via erase() (Kaz Wesley)
2016-04-18 12:42:14 +02:00
Wladimir J. van der Laan
a3310b4d48
txdb: Fix assert crash in new UTXO set cursor
...
Remove the mistaken assumption that GetKey returning false signifies
an internal database issue. It will return false when the key cannot
be deserialized into the (char,uint256) stanza, which indicates
that the cursor has reached a different kind of key.
Fixes bug #7890 introduced in #7756 .
2016-04-18 12:05:32 +02:00
Cory Fields
e9fc71e5fa
net: require lookup functions to specify all arguments
...
To make it clear where DNS resolves are happening
2016-04-17 17:37:36 -04:00
Chris Moore
3107c475a7
fix spelling mistake
2016-04-17 00:01:49 -07:00
Chris Moore
dc0693f637
add missing newline
...
Without the newline I see "bein" where the two lines are concatenated:
Note that all inputs selected must be of standard form and P2SH scripts must *bein* the wallet using importaddress or addmultisigaddress (to calculate fees).
2016-04-16 13:42:28 -07:00
Kaz Wesley
a7af72a697
prevector::swap: fix (unreached) data corruption
...
swap was using an incorrect condition to determine when to apply an optimization
(not swapping the full direct[] when swapping two indirect prevectors).
Rather than correct the optimization I'm removing it for simplicity. Removing
this optimization minutely improves performance in the typical (currently only)
usage of member swap(), which is swapping with a freshly value-initialized
object.
2016-04-16 08:05:11 -07:00
Kaz Wesley
4ed41a2b61
test prevector::swap
...
- add a swap operation to prevector tests (fails due to broken prevector::swap)
- fix 2 prevector test operation conditions that were impossible
2016-04-16 08:05:11 -07:00
Kaz Wesley
1e2c29f263
prevector: destroy elements only via erase()
...
Fixes a bug in which pop_back did not call the deleted item's destructor.
Using the most general erase() implementation to implement all the others
prevents similar bugs because the coupling between deallocation and destructor
invocation only needs to be maintained in one place.
Also reduces duplication of complex memmove logic.
2016-04-16 08:05:11 -07:00
Wladimir J. van der Laan
28b400f7d1
doc: update release-notes for gettxoutsetinfo
change
2016-04-15 18:03:10 +02:00
Wladimir J. van der Laan
76212bbc6a
rpc: make sure gettxoutsetinfo
hash has txids
...
The key (transaction id for the following outputs) should be serialized
to the HashWriter.
This is a problem as it means different transactions in the same
position with the same outputs will potentially result in the same hash.
Fixes primary concern of #7758 .
2016-04-15 18:03:05 +02:00
Wladimir J. van der Laan
9ad1a51857
crypto: bytes counts are 64 bit
...
Byte counts for SHA256, SHA512, SHA1 and RIPEMD160 must be 64 bits.
`size_t` has a different size per platform, causing divergent results
when hashing more than 4GB of data.
2016-04-15 16:44:23 +02:00
Wladimir J. van der Laan
73fc922ed6
Merge #7603 : Build System: Use PACKAGE_TARNAME in NSIS script
...
0528e30
Remove wxwidgets references from NSIS script. (JeremyRand)
26880c3
build: Use PACKAGE_TARNAME and new bin names in NSIS script. (JeremyRand)
0dbf6e4
build: define base filenames for use elsewhere in the buildsystem (Cory Fields)
2016-04-15 16:43:44 +02:00
Wladimir J. van der Laan
9e47fcec17
Merge #7756 : Add cursor to iterate over utxo set, use this in gettxoutsetinfo
...
509cb00
txdb: Add Cursor() method to CCoinsView to iterate over UTXO set (Wladimir J. van der Laan)
2016-04-15 16:43:21 +02:00
Wladimir J. van der Laan
509cb006d5
txdb: Add Cursor() method to CCoinsView to iterate over UTXO set
...
Add a method Cursor() to CCoinsView that returns a cursor which can be
used to iterate over the whole UTXO set.
- rpc: Change gettxoutsetinfo to use new Cursor method
- txdb: Remove GetStats method - Now that GetStats is implemented in
terms of Cursor, remove it.
2016-04-15 16:33:05 +02:00
Wladimir J. van der Laan
be14ca5e8c
Merge #7518 : Add multiple options to fundrawtransaction
...
f2d0944
Add lockUnspents option to fundrawtransaction (João Barbosa)
af4fe7f
Add change options to fundrawtransaction (João Barbosa)
41e835d
Add strict flag to RPCTypeCheckObj (João Barbosa)
2016-04-15 16:24:02 +02:00
João Barbosa
f2d0944eb3
Add lockUnspents option to fundrawtransaction
2016-04-15 15:36:05 +02:00
João Barbosa
af4fe7fd12
Add change options to fundrawtransaction
2016-04-15 15:36:05 +02:00
João Barbosa
41e835dd50
Add strict flag to RPCTypeCheckObj
...
Strict flag forces type check on all object keys.
2016-04-15 14:55:52 +02:00
Jonas Schnelli
de821d56e1
[ZMQ] refactor message string
2016-04-15 13:23:16 +02:00
Wladimir J. van der Laan
a4ca44d276
Merge #7870 : [contrib] Add MarcoFalke key and move all keys to contrib/gitian-keys
...
faf4c83
[gitian] Move keys to contrib/gitian-keys (MarcoFalke)
fa93936
[gitian] Add marcofalke-key.pgp (MarcoFalke)
2016-04-15 13:16:33 +02:00
MarcoFalke
faf4c837fb
[gitian] Move keys to contrib/gitian-keys
2016-04-15 11:58:46 +02:00
MarcoFalke
fa93936691
[gitian] Add marcofalke-key.pgp
2016-04-15 11:58:25 +02:00
Wladimir J. van der Laan
64e71b3721
Merge #7856 : Only send one GetAddr response per connection.
...
66b0724
Only send one GetAddr response per connection. (Gregory Maxwell)
2016-04-15 09:03:17 +02:00
Wladimir J. van der Laan
efc059322c
Merge #7877 : Change mapRelay to store CTransactions
...
38c3102
Change mapRelay to store CTransactions (Pieter Wuille)
2016-04-15 08:59:40 +02:00
Wladimir J. van der Laan
bbd210d927
Merge #7809 : depends: some base fixes/changes
...
11d9f6b
depends: qt/cctools: fix checksum checksum tests (Cory Fields)
bb717f4
depends: fix "unexpected operator" error during "make download" (Cory Fields)
fe740f1
depends: fix fallback downloads (Cory Fields)
dc4ec6d
depends: create a hostid and buildid and add option for salts (Cory Fields)
2016-04-15 08:58:30 +02:00
Wladimir J. van der Laan
cabba24a5b
Merge #7798 : [travis] Print the commit which was evaluated
...
fac9ca2
[travis] echo $TRAVIS_COMMIT_RANGE (MarcoFalke)
faef3b7
[travis] Print the commit which was evaluated (MarcoFalke)
2016-04-15 08:42:26 +02:00
Wladimir J. van der Laan
48c5adfbce
Merge #6215 : add bip32 pub key serialization
...
90604f1
add bip32 pubkey serialization (Jonas Schnelli)
2016-04-15 07:59:38 +02:00
Wladimir J. van der Laan
53adc8310d
Merge #7878 : [test] bctest.py: Revert faa41ee
...
fa7abe0
[test] bctest.py: Revert faa41ee
(MarcoFalke)
2016-04-15 07:56:07 +02:00
Jonas Schnelli
90604f16af
add bip32 pubkey serialization
...
CExtPubKey should be serializable like CPubKey
2016-04-14 20:56:33 +02:00
MarcoFalke
fa7abe0a00
[test] bctest.py: Revert faa41ee
2016-04-14 19:39:53 +02:00
Wladimir J. van der Laan
e6a4d48a9b
Merge #7874 : Improve AlreadyHave
...
c6cb6f7
Avoid unnecessary database access for unknown transactions (Alex Morcos)
2016-04-14 17:54:42 +02:00
Wladimir J. van der Laan
6ef5e000a2
Merge #7853 : [qa] py2: Unfiddle strings into bytes explicitly
...
faa41ee
[qa] py2: Unfiddle strings into bytes explicitly (MarcoFalke)
2016-04-14 17:40:31 +02:00
Wladimir J. van der Laan
430fffefaa
Merge #7812 : Tiny refactor of IsRBFOptIn
, avoid exception
...
4f7c959
Refactor IsRBFOptIn, avoid exception (Jonas Schnelli)
2016-04-14 16:35:02 +02:00
Pieter Wuille
38c310299c
Change mapRelay to store CTransactions
2016-04-14 16:24:56 +02:00
Wladimir J. van der Laan
d97101e5a8
Merge #7842 : RPC: do not print minping time in getpeerinfo when no ping received yet
...
62a6486
RPC: do not print ping info in getpeerinfo when no ping received yet, fix help (Pavel Janík)
2016-04-14 16:09:53 +02:00
Wladimir J. van der Laan
491171f929
Merge #7846 : Clean up lockorder data of destroyed mutexes
...
5eeb913
Clean up lockorder data of destroyed mutexes (Pieter Wuille)
2016-04-14 15:47:08 +02:00
Wladimir J. van der Laan
97d0b9889f
Merge #7862 : Use txid as key in mapAlreadyAskedFor
...
7e91f63
Use txid as key in mapAlreadyAskedFor (Suhas Daftuar)
2016-04-14 14:55:01 +02:00
Wladimir J. van der Laan
ab8586e667
Merge #7849 : tests: add varints_bitpatterns test
...
4521f00
tests: add varints_bitpatterns test (Wladimir J. van der Laan)
2016-04-14 14:46:13 +02:00
Wladimir J. van der Laan
229a17ca91
Merge #7850 : Removed call to TryCreateDirectory
from GetDefaultDataDir
in src/util.cpp
.
...
41dbc48
Removed call to `TryCreateDirectory` from `GetDefaultDataDir` in `src/util.cpp`. (Alexander Regueiro)
2016-04-14 13:38:49 +02:00