Russell Yanofsky
4e4d9e9f85
Remove use of CRPCTable::appendCommand in wallet code
...
This commit does not change behavior.
2019-03-05 10:20:00 -04:00
Russell Yanofsky
91868e6288
Remove use CValidationInterface in wallet code
...
This commit does not change behavior.
2019-03-05 10:20:00 -04:00
Russell Yanofsky
4d4e4c6448
Suggested interfaces::Chain cleanups from #15288
...
Mostly documentation improvements requested in the last review of #15288 before
it was merged
(https://github.com/bitcoin/bitcoin/pull/15288#pullrequestreview-210241864 )
2019-03-04 15:57:58 -05:00
Russell Yanofsky
a1df1b48a8
Remove use of IsInitialBlockDownload in wallet code
...
This commit does not change behavior.
2019-02-22 15:43:02 -04:00
Russell Yanofsky
1106a6fde4
Remove use of uiInterface.LoadWallet in wallet code
...
This also changes the uiInterface.LoadWallet signal argument type from
shared_ptr<CWallet> to unique_ptr<interfaces::Wallet> because CWallet is an
internal wallet class that shouldn't be used in non-wallet code (and also can't
be passed across process boundaries).
This commit does not change behavior.
2019-02-22 15:43:02 -04:00
Russell Yanofsky
d02b34c8a8
Remove use of AcceptToMemoryPool in wallet code
...
This commit does not change behavior.
2019-02-22 15:43:02 -04:00
Russell Yanofsky
e2c8ba9f6e
Remove uses of InitMessage/Warning/Error in wallet code
...
This commit does not change behavior.
2019-02-22 15:43:02 -04:00
Russell Yanofsky
c5e59a96a8
Remove uses of GetAdjustedTime in wallet code
...
This commit does not change behavior.
2019-02-22 15:43:02 -04:00
Russell Yanofsky
6d6bcc77c0
Remove use of g_connman / PushInventory in wallet code
...
This commit does not change behavior.
2019-02-22 15:43:02 -04:00
Russell Yanofsky
00dfb2a440
Remove uses of g_connman in wallet code
...
This commit does not change behavior.
2019-02-22 15:43:02 -04:00
Russell Yanofsky
cc3836e8f9
Remove uses of fPruneMode in wallet code
...
This commit does not change behavior.
2019-02-22 15:43:02 -04:00
Russell Yanofsky
cc02c796d3
Remove uses of fee globals in wallet code
...
This commit does not change behavior.
2019-02-22 15:43:02 -04:00
Russell Yanofsky
1fb0a4a04e
Remove use of CalculateMemPoolAncestors in wallet code
...
This commit does not change behavior.
2019-02-22 15:43:02 -04:00
Russell Yanofsky
cd32160af0
Remove use of GetTransactionAncestry in wallet code
...
This commit does not change behavior.
2019-02-22 15:43:02 -04:00
Russell Yanofsky
291276f7f4
Remove use of GetCountWithDescendants in wallet code
...
This commit does not change behavior.
2019-02-22 15:43:02 -04:00
Russell Yanofsky
bdc6628683
Remove use of IsRBFOptIn in wallet code
...
This commit does not change behavior.
2019-02-22 15:43:02 -04:00
Russell Yanofsky
80f52a2267
Remove uses of CheckFinalTx in wallet code
...
This commit does not change behavior.
2019-02-22 15:43:02 -04:00
Russell Yanofsky
aebafd0edf
Rename Chain getLocator -> getTipLocator
...
Suggested https://github.com/bitcoin/bitcoin/pull/14711#discussion_r252044389
2019-02-01 16:17:43 -05:00
Russell Yanofsky
44de1561aa
Remove remaining chainActive references from CWallet
...
This commit does not change behavior.
Co-authored-by: Ben Woosley <ben.woosley@gmail.com>
2019-01-15 08:42:00 -08:00
Russell Yanofsky
db21f02648
Convert CWallet::ScanForWalletTransactions and SyncTransaction to the new Chain apis
...
Only change in behavior is "Rescan started from block <height>" message
replaced by "Rescan started from block <hash>" message in
ScanForWalletTransactions.
Co-authored-by: Ben Woosley <ben.woosley@gmail.com>
2019-01-15 08:42:00 -08:00
Russell Yanofsky
2ffb07929e
Add findFork and findBlock to the Chain interface
...
And use them to remove uses of chainActive and mapBlockIndex in wallet code
This commit does not change behavior.
Co-authored-by: Ben Woosley <ben.woosley@gmail.com>
2019-01-15 08:42:00 -08:00
Russell Yanofsky
d93c4c1d6e
Add time methods to the Chain interface
...
And use them to remove uses of chainActive and mapBlockIndex in wallet code
This commit does not change behavior.
Co-authored-by: Ben Woosley <ben.woosley@gmail.com>
2019-01-15 08:42:00 -08:00
Russell Yanofsky
700c42b85d
Add height, depth, and hash methods to the Chain interface
...
And use them to remove uses of chainActive and mapBlockIndex in wallet code
This commit does not change behavior.
Co-authored-by: Ben Woosley <ben.woosley@gmail.com>
2019-01-15 12:42:00 -04:00
Russell Yanofsky
79d579f4e1
Remove uses of cs_main in wallet code
...
This commit does not change behavior.
It is easiest to review this change with:
git log -p -n1 -U0
2018-11-06 11:44:40 -04:00
Russell Yanofsky
7e2e62cf7c
Add skeleton chain and client classes
...
This commit does not change behavior. It just adds new skeleton classes that
don't do anything and aren't instantiated yet.
2018-11-06 11:44:40 -04:00