Pieter Wuille
5c1e798a8e
Make signature cache optional
2014-10-02 20:26:17 +02:00
SergioDemianLerner
f0fd00cb77
Switch testing framework from MAIN to new UNITTEST network
...
UNITTEST inherites from MAIN but allows synamically changing its parameters using the ModifiableParams() interface
2014-10-02 13:51:39 +02:00
Wladimir J. van der Laan
8d132431b4
Revert merge of pull #4845
...
It breaks the new mingw tests!
See
- https://travis-ci.org/bitcoin/bitcoin/jobs/36845581
- https://travis-ci.org/bitcoin/bitcoin/jobs/36845582
This reverts commit 4705902777
, 5e2e7fcb99
, a25fd6be13
.
2014-10-02 10:39:55 +02:00
Wladimir J. van der Laan
ad51e14583
Merge pull request #4845
...
4705902
Avoid introducing a virtual into CChainParams (Wladimir J. van der Laan)
5e2e7fc
Suggested corrections on comments, variable names. Also new test case testing the PoW skip in UNITTEST. (SergioDemianLerner)
a25fd6b
Switch testing framework from MAIN to new UNITTEST network (SergioDemianLerner)
2014-10-02 09:47:54 +02:00
Wladimir J. van der Laan
00eef5d6e9
Merge pull request #5017
...
f74fc9b
Print input index when signature validation fails, to aid debugging. (Mark Friedenbach)
217a5c9
When transaction outputs exceed inputs, show the offending amounts so as to aid debugging. (Mark Friedenbach)
2014-10-02 08:44:08 +02:00
Pieter Wuille
76c171033c
Merge pull request #4926
...
584a358
Do merkle root and txid duplicates check simultaneously (Pieter Wuille)
2014-10-02 06:10:19 +02:00
Mark Friedenbach
f74fc9b22d
Print input index when signature validation fails, to aid debugging.
2014-10-01 19:14:38 +02:00
Mark Friedenbach
217a5c9238
When transaction outputs exceed inputs, show the offending amounts so as to aid debugging.
2014-10-01 19:14:38 +02:00
Wladimir J. van der Laan
3fd192f8b4
Merge pull request #4234
...
c122f55
qt: Register CAmount metatype (Wladimir J. van der Laan)
a372168
Use a typedef for monetary values (Mark Friedenbach)
2014-10-01 11:28:55 +02:00
SergioDemianLerner
5e2e7fcb99
Suggested corrections on comments, variable names.
...
Also new test case testing the PoW skip in UNITTEST.
2014-09-29 13:03:23 +02:00
SergioDemianLerner
a25fd6be13
Switch testing framework from MAIN to new UNITTEST network
...
UNITTEST inherites from MAIN but allows synamically changing its parameters using the ModifiableParams() interface
2014-09-29 13:03:22 +02:00
Pieter Wuille
bf3a5dd7f0
Merge pull request #4796
...
e8b5f0d
Move CBlockIndex, CChain and related code out of main (jtimon)
6db83db
Decouple CChain from mapBlockIndex (jtimon)
2014-09-29 06:06:57 +02:00
Mark Friedenbach
a372168e77
Use a typedef for monetary values
2014-09-26 15:42:04 -07:00
Cory Fields
eee030f6bc
autofile: don't copy CAutoFile by value
2014-09-25 19:25:19 -04:00
Pieter Wuille
584a358997
Do merkle root and txid duplicates check simultaneously
...
Move the txid duplicates check into BuildMerkleTree, where it can be done
much more efficiently (without needing to build a full txid set to detect
duplicates).
The previous version (using the std::set<uint256> to detect duplicates) was
also slightly too weak. A block mined with actual duplicate transactions
(which is invalid, due to the inputs of the duplicated transactions being
seen as double spends) would trigger the duplicates logic, resulting in the
block not being stored on disk, and rerequested. This change fixes that by
only triggering in the case of duplicated transactions that can actually
result in an identical merkle root.
2014-09-24 19:17:02 +02:00
Pieter Wuille
ab15b2ec71
Avoid copying undo data
2014-09-17 20:38:20 +02:00
Wladimir J. van der Laan
438c7e4cd2
Merge pull request #4555
...
6dcfda2
Don't pass nHashType to EvalScript nor CheckSig (jtimon)
2b23a87
Don't pass nHashType to VerifyScript (jtimon)
ce3649fb
Remove CScriptCheck::nHashType (was always 0) (jtimon)
358562b
Remove unused function main:VerifySignature (jtimon)
2014-09-17 13:44:22 +02:00
Pieter Wuille
13168ea46c
Merge pull request #4903
...
efad808
Avoid reject message feedback loops (Pieter Wuille)
2014-09-16 18:54:46 +02:00
Wladimir J. van der Laan
f010344156
Merge pull request #4460
...
604ee2a
Remove tx from AlreadyAskedFor list once we receive it, not when we process it. (R E Broadley)
2014-09-16 11:31:54 +02:00
Pieter Wuille
765f398436
Merge pull request #4875
...
f7e3637
Eliminate extra assignment (Suhas Daftuar)
ec7eb0f
When reindexing check for file before trying to open (refactored) (Suhas Daftuar)
2014-09-16 03:21:21 +02:00
Suhas Daftuar
f7e36370f3
Eliminate extra assignment
2014-09-15 09:56:10 -04:00
ENikS
ec91092df8
Fixing compiler warning C4101
...
Github-Pull: #4856
2014-09-15 14:35:32 +02:00
Wladimir J. van der Laan
c362c57568
Merge pull request #4798
...
d920f7d
Move g_signals.SetBestChain(..) below SyncWithWallets (Cozz Lovan)
2014-09-15 10:32:59 +02:00
jtimon
6dcfda2dc4
Don't pass nHashType to EvalScript nor CheckSig
2014-09-12 20:04:31 +02:00
jtimon
2b23a87599
Don't pass nHashType to VerifyScript
2014-09-12 20:04:31 +02:00
jtimon
ce3649fb61
Remove CScriptCheck::nHashType (was always 0)
2014-09-12 20:03:03 +02:00
jtimon
358562b651
Remove unused function main:VerifySignature
2014-09-12 20:03:03 +02:00
Pieter Wuille
efad808aae
Avoid reject message feedback loops
2014-09-12 17:50:31 +02:00
Gavin Andresen
aa3c697e90
Store fewer orphan tx by default, add -maxorphantx option
...
There is no reason to store thousands of orphan transactions;
normally an orphan's parents will either be broadcast or
mined reasonably quickly.
This pull drops the maximum number of orphans from 10,000 down
to 100, and adds a command-line option (-maxorphantx) that is
just like -maxorphanblocks to override the default.
2014-09-10 14:09:40 -04:00
Gavin Andresen
c74332c678
Stricter handling of orphan transactions
...
Prevent denial-of-service attacks by banning
peers that send us invalid orphan transactions
and only storing orphan transactions given to
us by a peer while the peer is connected.
2014-09-10 14:09:40 -04:00
Suhas Daftuar
ec7eb0fa80
When reindexing check for file before trying to open (refactored)
2014-09-10 13:51:53 -04:00
Gavin Andresen
def2fdb4b9
Fix crashing bug caused by orphan(s) with duplicate prevout.hash
2014-09-10 16:53:54 +02:00
Wladimir J. van der Laan
d6af9856b0
Merge pull request #4878
...
540ac45
Avoid returning many "inv" orphans (Jeff Garzik)
d4168c8
Limit CNode::mapAskFor (Wladimir J. van der Laan)
2014-09-10 16:52:57 +02:00
Pieter Wuille
f7cdcb80ab
Merge pull request #4822
...
629d75f
Combine CCoinsViewCache's HaveCoins and const GetCoins into AccessCoins. (Pieter Wuille)
2014-09-10 01:44:30 +02:00
Pieter Wuille
1575c5171f
Merge pull request #4868
...
2c2cc5d
Remove some unnecessary c_strs() in logging and the GUI (Philip Kaufmann)
f7d0a86
netbase: Use .data() instead of .c_str() on binary string (Wladimir J. van der Laan)
2014-09-09 16:43:06 +02:00
Philip Kaufmann
2c2cc5dac1
Remove some unnecessary c_strs() in logging and the GUI
...
Includes `core: remove unneeded c_str() / Qt: replace c_str() with Qt code`
by P. Kaufmann.
2014-09-09 11:31:17 +02:00
Jeff Garzik
540ac4514d
Avoid returning many "inv" orphans
2014-09-09 09:26:52 +02:00
jtimon
e8b5f0d549
Move CBlockIndex, CChain and related code out of main
2014-09-08 22:17:19 +02:00
jtimon
6db83db3eb
Decouple CChain from mapBlockIndex
2014-09-08 22:14:24 +02:00
Wladimir J. van der Laan
89d91f6aa7
Avoid repeated lookups in mapOrphanTransactions and mapOrphanTransactionsByPrev
2014-09-08 17:38:43 +02:00
R E Broadley
346193bd93
Cleanup messy error messages
2014-09-06 14:18:32 +07:00
Pieter Wuille
145d5be896
Introduce BlockMap type for mapBlockIndex
2014-09-04 02:04:51 +02:00
Pieter Wuille
a0dbe433bd
checkpoints.cpp depends on main, it can use mapBlockIndex directly
2014-09-04 02:01:10 +02:00
Pieter Wuille
629d75faac
Combine CCoinsViewCache's HaveCoins and const GetCoins into AccessCoins.
...
The efficient version of CCoinsViewCache::GetCoins only works for known-to-exist
cache entries, requiring a separate HaveCoins call beforehand. This is
inefficient as both perform a hashtable lookup.
Replace the non-mutable GetCoins with AccessCoins, which returns a potentially-NULL
pointer. This also decreases the overloading of GetCoins.
Also replace some copying (inefficient) GetCoins calls with equivalent AccessCoins,
decreasing the copying.
2014-09-03 14:24:52 +02:00
Wladimir J. van der Laan
93f97aab62
Merge pull request #4768
...
2e28031
Perform CVerifyDB on pcoinsdbview instead of pcoinsTip (Wladimir J. van der Laan)
2014-09-01 09:42:10 +02:00
Cozz Lovan
d920f7dcf8
Move g_signals.SetBestChain(..) below SyncWithWallets
2014-08-31 16:17:39 +02:00
Jeff Garzik
135a43df7b
Merge pull request #4778
2014-08-29 20:22:06 -04:00
Jeff Garzik
309aa76d27
Merge pull request #4599
2014-08-29 15:23:13 -04:00
Wladimir J. van der Laan
0101483f46
Move CMerkleTx to wallet.cpp/h
...
It is only used by the wallet so it has no place in main.
2014-08-29 17:26:01 +02:00
Pieter Wuille
d1062e32fa
Merge pull request #4377
...
654871d
replace ComputeMinWork with CheckMinWork (jtimon)
b343c1a
Move CBlockIndex::GetBlockWork() to pow::GetProofIncrement(nBits) (jtimon)
c2c02f3
Move UpdateTime to pow (jtimon)
2014-08-27 22:39:28 +02:00