Gregory Maxwell
d1c3762ae8
Revert "Revert "Enable policy enforcing GetMedianTimePast as the end point of lock-time constraints""
...
This reverts commit 8537ecdfc4
.
2015-11-03 17:14:09 +00:00
Gregory Maxwell
e4e5334ef8
Restore MedianTimePast for locktime.
...
Revert "Revert "Add rules--presently disabled--for using GetMedianTimePast as endpoint for lock-time calculations""
This reverts commit 40cd32e835
.
After careful analysis it was determined that the change was, in fact, safe and several people were suffering
momentary confusion about locktime semantics.
2015-11-03 17:12:36 +00:00
MarcoFalke
268b79ef0c
[qt] rpcconsole: Scale monospace font to 95%
2015-11-03 12:34:51 +01:00
Wladimir J. van der Laan
42f339ef78
Merge pull request #6930
...
ff2a2af
build: don't distribute tests_config.py (Wladimir J. van der Laan)
2015-11-03 10:09:09 +01:00
MarcoFalke
53238ff0b1
Clarify what minrelaytxfee does
2015-11-03 08:53:37 +01:00
MarcoFalke
abd8b768ee
[qt] Properly display required fee instead of minTxFee
2015-11-03 08:53:37 +01:00
Alex Morcos
14470f9aa6
ModifyNewCoins saves database lookups
...
When processing a new transaction, in addition to spending the Coins of its txin's it creates a new Coins for its outputs. The existing ModifyCoins function will first make sure this Coins does not already exist. It can not exist due to BIP 30, but because of that the lookup can't be cached and always has to go to the database. Since we are creating the coins to match the new tx anyway, there is no point in checking if they exist first anyway. However this should not be used for coinbase tx's in order to preserve the historical behavior of overwriting the two existing duplicate tx pairs.
2015-11-02 21:27:15 -05:00
Alex Morcos
33c90cf197
Make skipping BIP30 check chain agnostic
2015-11-02 20:11:55 -05:00
Alex Morcos
06d81ad516
Skip BIP30 check after BIP34 activation
2015-11-02 20:10:24 -05:00
Wladimir J. van der Laan
8fe30fb4d1
Merge pull request #6928
...
40cd32e
Revert "Add rules--presently disabled--for using GetMedianTimePast as endpoint for lock-time calculations" (Gregory Maxwell)
8537ecd
Revert "Enable policy enforcing GetMedianTimePast as the end point of lock-time constraints" (Gregory Maxwell)
2015-11-02 04:44:47 +01:00
Wladimir J. van der Laan
a6d0d623fc
Merge pull request #6926
...
7497e80
tests: Initialize networking on windows (Wladimir J. van der Laan)
2015-11-02 04:29:45 +01:00
Wladimir J. van der Laan
ff2a2af64c
build: don't distribute tests_config.py
...
This file is dynamically generated by configure based on the platform,
it doesn't belong in the distribution archive.
Fixes #6929 .
2015-11-02 04:15:58 +01:00
Pieter Wuille
69d373ff66
Don't wipe the sigcache in TestBlockValidity
2015-11-02 02:01:45 +01:00
Gregory Maxwell
40cd32e835
Revert "Add rules--presently disabled--for using GetMedianTimePast as endpoint for lock-time calculations"
...
This reverts commit 9d55050773
.
As noted by Luke-Jr, under some conditions this will accept transactions which are invalid by the network
rules. This happens when the current block time is head of the median time past and a transaction's
locktime is in the middle.
This could be addressed by changing the rule to MAX(this_block_time, MTP+offset) but this solution and
the particular offset used deserve some consideration.
2015-11-01 20:05:18 +00:00
Gregory Maxwell
8537ecdfc4
Revert "Enable policy enforcing GetMedianTimePast as the end point of lock-time constraints"
...
This reverts commit dea8d21fc6
.
2015-11-01 20:05:16 +00:00
Wladimir J. van der Laan
02a95be977
qt: translation update prior to opening 0.12 translations
...
Also update transifex slug for new version.
2015-11-01 16:11:50 +01:00
Wladimir J. van der Laan
7497e805bd
tests: Initialize networking on windows
2015-11-01 11:45:06 +01:00
Wladimir J. van der Laan
a6e80e4017
Merge pull request #6883
...
c939792
Add BIP65 CHECKLOCKTIMEVERIFY to release notes (Peter Todd)
2015-10-31 11:07:24 +01:00
Pieter Wuille
0b9e9dca4e
Evict sigcache entries that are seen in a block
2015-10-31 01:15:11 +01:00
Pieter Wuille
830e3f3d02
Make sigcache faster and more efficient
2015-10-31 01:15:11 +01:00
Wladimir J. van der Laan
48b5b84ee5
Merge pull request #6906
...
30d9662
Reject invalid pubkeys when reading ckey items from the wallet. (Gregory Maxwell)
2015-10-31 00:39:50 +01:00
Wladimir J. van der Laan
d482c0a7b2
Merge pull request #6896
...
e9e6163
Make -checkmempool=1 not fail through int32 overflow (Pieter Wuille)
2015-10-31 00:38:31 +01:00
Jorge Timón
87cbdb8b41
Globals: Explicit Consensus::Params arg for main:
...
-CheckBlockIndex
-DisconnectTip
-GetTransaction
-InvalidateBlock
-ProcessGetData
-ReadBlockFromDisk
2015-10-30 14:07:30 +01:00
Luke Dashjr
a6efc01908
Bugfix: Omit wallet-related options from -help when wallet is disabled
2015-10-30 00:32:08 +01:00
Gregory Maxwell
30d9662bd7
Reject invalid pubkeys when reading ckey items from the wallet.
...
This makes the behavior more consistent with key objects and will
reject some corrupted pubkeys (e.g. zero length).
2015-10-29 18:24:49 +00:00
MarcoFalke
28313b83fc
[qt] Use fixed pitch font for the rpc console
...
Also:
* Preserve white space
* Make fixed font as large as default font
2015-10-29 18:01:39 +01:00
MarcoFalke
6342a4889b
Init: Use DEFAULT_TRANSACTION_MINFEE in help message
2015-10-29 16:52:40 +01:00
Wladimir J. van der Laan
725539ea03
Merge pull request #6863
...
0be387a
unittest: fix test for null tx input (Daniel Kraft)
2015-10-29 13:40:33 +01:00
Wladimir J. van der Laan
b28c229324
Merge pull request #6899
...
a83f3c2
Add explicit shared_ptr constructor due to C++11 error (Bob McElrath)
2015-10-29 13:39:56 +01:00
Wladimir J. van der Laan
b2ce2c1f0f
Merge pull request #6870
...
040c0ea
Init: Cleanup error and warning strings (MarcoFalke)
6782f58
[trivial] Latest config.guess (MarcoFalke)
bf68191
[trivial] rpcnet: fix typo (MarcoFalke)
95f4291
[trivial] Rewrite help text for feature enabled by default (MarcoFalke)
2015-10-29 13:30:42 +01:00
Wladimir J. van der Laan
26752767df
Merge pull request #6894
...
3e187f2
Fix BIP65 p2p test (Suhas Daftuar)
2015-10-29 13:12:47 +01:00
Bob McElrath
a83f3c2426
Add explicit shared_ptr constructor due to C++11 error
2015-10-28 22:25:32 -04:00
MarcoFalke
040c0ea093
Init: Cleanup error and warning strings
...
Also update doc/translation_strings_policy.md
2015-10-28 22:11:43 +01:00
MarcoFalke
a9c73a130e
[wallet] Add comments for doxygen
2015-10-28 11:15:48 +01:00
MarcoFalke
6b0e622c25
[wallet] Refactor to use new MIN_CHANGE
...
* Introduce new constant MIN_CHANGE and use it instead of the
hardcoded "CENT"
* Add test case for MIN_CHANGE
* Introduce new constant for -mintxfee default:
DEFAULT_TRANSACTION_MINFEE = 1000
2015-10-28 10:52:46 +01:00
Alex Morcos
971a4e6b86
Lower default policy limits
...
Reduce the default limits on maximum number of transactions and the cumulative size of those transactions in both ancestor and descendant packages to 25 txs and 101kb total size.
2015-10-27 23:59:19 -04:00
Pieter Wuille
e9e616323b
Make -checkmempool=1 not fail through int32 overflow
2015-10-28 03:07:59 +01:00
Pieter Wuille
8daffe227b
Merge pull request #6891
...
ad5aae1
constify missing catch cases (Philip Kaufmann)
2015-10-28 02:34:09 +01:00
Pieter Wuille
4764f5db9d
Merge pull request #6892
...
214de7e
[Trivial] ensure minimal header conventions (Philip Kaufmann)
2015-10-28 02:30:31 +01:00
Pieter Wuille
e06c14fb59
Merge pull request #6776
...
ab1f560
Support -checkmempool=N, which runs checks on average once every N transactions (Pieter Wuille)
2015-10-28 02:25:06 +01:00
Pieter Wuille
8756c98642
Merge pull request #6895
...
4252cd0
Update to my new key (Pieter Wuille)
2015-10-28 02:23:20 +01:00
Pieter Wuille
93521a4f56
Merge pull request #6875
...
6e800c2
Add Pieter's new PGP key to verify-commits/trusted-keys (Matt Corallo)
1d94b72
Whitelist commits signed with Pieter's now-revoked key (Matt Corallo)
27252b7
Fix pre-push-hook regexes (Matt Corallo)
2015-10-28 02:21:47 +01:00
Gregory Maxwell
d0badb916e
Merge pull request #6865
...
298e040
Fix chainstate serialized_size computation (Pieter Wuille)
2015-10-27 18:07:03 -07:00
Pieter Wuille
4252cd09fd
Update to my new key
2015-10-28 02:03:15 +01:00
Matt Corallo
6e800c2b41
Add Pieter's new PGP key to verify-commits/trusted-keys
2015-10-27 17:06:13 -07:00
Pieter Wuille
298e040bca
Fix chainstate serialized_size computation
2015-10-28 01:05:32 +01:00
Suhas Daftuar
3e187f2acd
Fix BIP65 p2p test
...
create_coinbase() was being called with the wrong arguments
2015-10-27 15:36:06 -04:00
Daniel Kraft
0be387a536
unittest: fix test for null tx input
...
Update the unittest that is meant to catch a transaction that is invalid
because it has a null input. The old test failed not because of that
but because it was considered a coinbase with too large script. This is
already checked with a different test, though.
The new test is *not* a coinbase since it has two inputs, but one of
them is null. This really checks the corresponding code path in
CheckTransaction.
2015-10-27 20:11:56 +01:00
Philip Kaufmann
214de7e54c
[Trivial] ensure minimal header conventions
...
- ensure header namespaces and end comments are correct
- add missing header end comments
- ensure minimal formatting (add newlines etc.)
2015-10-27 17:44:13 +01:00
Philip Kaufmann
ad5aae15b4
constify missing catch cases
...
- ensure all missing catch cases are constant where possible
2015-10-27 17:39:42 +01:00