Matt Corallo
1f668b6468
Expose if CScheduler is being serviced, assert its not in EmptyQueue
2017-07-10 21:08:19 -04:00
Alex Morcos
5e3b7b5686
Improve error reporting for estimaterawfee
2017-07-10 20:07:17 -04:00
Alex Morcos
1fafd704da
Add function to report highest estimate target tracked per horizon
2017-07-10 20:07:17 -04:00
Alex Morcos
9c85b91dc1
Change API to estimaterawfee
...
Report results for all 3 possible time horizons instead of specifying time horizon as an argument.
2017-07-10 20:07:13 -04:00
Pieter Wuille
475c08cb44
Add PR description to merge commit in github-merge.py
2017-07-10 13:18:31 -07:00
Alex Morcos
f135923ee2
Add RPC options for RBF, confirmation target, and conservative fee estimation.
...
Add support for setting each of these attributes on a per RPC call basis to sendtoaddress, sendmany, fundrawtransaction (already had RBF), and bumpfee (already had RBF and conf target).
2017-07-10 12:40:02 -04:00
Wladimir J. van der Laan
9edda0c5f5
Merge #10747 : [rpc] fix verbose argument for getblock in bitcoin-cli
...
58e9864
2017-07-10 17:50:21 +02:00
practicalswift
1e3a3200af
Simplify "!foo || (foo && bar)" as "!foo || bar"
2017-07-09 13:39:58 +02:00
practicalswift
49eb0916da
[tests] Avoid redundant assignments. Remove unused variables.
2017-07-09 13:05:01 +02:00
Jeremy Rubin
30ac7688e3
Fix subscript[0] potential bugs in key.cpp
2017-07-08 13:37:06 -07:00
Jeremy Rubin
4b1c0f2e2e
Remove unnecessary branches in utilstrencodings string constructors.
2017-07-08 13:33:01 -07:00
Jeremy Rubin
e19db7b5ad
Fix subscript[0] in utilstrencodings.cpp
2017-07-08 13:33:01 -07:00
Jeremy Rubin
bc2e7fd984
Fix subscript[0] in streams.h
2017-07-08 13:33:01 -07:00
Jeremy Rubin
4cac0d1e04
Fix subscript[0] in validation.cpp
2017-07-08 13:33:01 -07:00
Jeremy Rubin
ac658e55ff
Fix subscript[0] in torcontrol
2017-07-08 13:33:01 -07:00
Jeremy Rubin
b6856ebedc
Fix subscript[0] in netaddress.cpp
2017-07-08 13:33:01 -07:00
Jeremy Rubin
361d95265a
Fix subscript[0] in base58.cpp
2017-07-08 13:33:01 -07:00
Jeremy Rubin
6896dbf169
Cleanup (safe, it was checked) subscript[0] in MurmurHash3 (and cleanup MurmurHash3 to be more clear).
2017-07-08 13:33:01 -07:00
Jeremy Rubin
96f2119e6c
Fix subscript[0] in compressor.cpp
2017-07-08 13:33:01 -07:00
Jeremy Rubin
500710bd29
Fix 2 subscript[0] bugs in pubkey.cpp, and eliminate one extra size check
2017-07-08 13:31:47 -07:00
Jeremy Rubin
e0451e3e2a
Fix subscript[0] bug in net.cpp if GetGroup returns a 0-sized vector
2017-07-08 13:31:47 -07:00
romanornr
d9d1bd3267
nCheckDepth chain height fix
2017-07-08 19:49:11 +02:00
Pavel Janík
5618b7d1ad
Do not shadow upper local variable state.
2017-07-08 09:30:35 +02:00
Pieter Wuille
0aadc11fd8
Avoid dereference-of-casted-pointer
2017-07-07 10:45:31 -07:00
Matt Corallo
3192975f1d
Flush CValidationInterface callbacks prior to destruction
...
Note that the CScheduler thread cant be running at this point,
it has already been stopped with the rest of the init threadgroup.
Thus, just calling any remaining loose callbacks during Shutdown()
is sane.
2017-07-07 12:55:57 -04:00
Matt Corallo
08096bbbc6
Support more than one CScheduler thread for serial clients
...
This will be used by CValidationInterface soon.
This requires a bit of work as we need to ensure that most of our
callbacks happen in-order (to avoid synchronization issues in
wallet) - we keep our own internal queue and push things onto it,
scheduling a queue-draining function immediately upon new
callbacks.
2017-07-07 11:33:18 -04:00
Matt Corallo
2fbf2dbe15
Add default arg to CScheduler to schedule() a callback now
2017-07-07 11:33:18 -04:00
Matt Corallo
cda1429d5b
Give CMainSignals a reference to the global scheduler
...
...so that it can run some signals in the background later
2017-07-07 11:33:18 -04:00
MarcoFalke
1d4805ce04
Merge #10759 : Fix multi_rpc test for hosts that dont default to utf8
...
bc7d103
2017-07-07 13:28:47 +02:00
MarcoFalke
d3b58704d1
Merge #10761 : [tests] fix replace_by_fee.py
...
301fd51
2017-07-07 13:25:40 +02:00
MarcoFalke
ed88e3194c
Merge #10744 : Use method name via __func__ macro
...
9bbf600
2017-07-07 13:13:45 +02:00
John Newbery
301fd51b9e
[tests] fix replace_by_fee.py
...
fb915d5b18
2017-07-07 08:41:31 +01:00
Alex Morcos
f0bf33da83
Change default fee estimation mode.
...
Fee estimates will default to be non-conservative if the transaction in question is opt-in-RBF.
2017-07-06 22:20:23 -04:00
Alex Morcos
e0738e3d31
remove default argument from estimateSmartFee
2017-07-06 22:20:23 -04:00
Alex Morcos
d507c301bc
Introduce a fee estimate mode.
...
GetMinimumFee now passes the conservative argument into estimateSmartFee.
Call CalculateEstimateType(mode) before calling GetMinimumFee or estimateSmartFee to determine the value of this argument.
CCoinControl can now be used to control this mode.
2017-07-06 22:20:23 -04:00
Alex Morcos
cfaef69ace
remove default argument from GetMinimumFee
2017-07-06 22:20:23 -04:00
Matt Corallo
bc7d1032f8
Fix multi_rpc test for hosts that dont default to utf8
...
Otherwise the utf8 written to bitcoin.conf throws an exception when
read from get_auth_cookie
2017-07-06 22:04:46 -04:00
Wladimir J. van der Laan
5af6572534
Merge #10698 : Be consistent in calling transactions "replaceable" for Opt-In RBF
...
73c942efb915d5928c681
2017-07-06 20:37:40 +02:00
Wladimir J. van der Laan
30bc0f6726
Merge #10710 : REST/RPC example update
...
b8bb425
2017-07-06 18:17:51 +02:00
Suhas Daftuar
4ccc12a54a
[qa] Rewrite BIP66 functional tests
...
Rewrite the BIP66 functional tests to reflect height-based activation,
and move it out of the extended test suite.
Remove the unnecessary bipdersig.py test
2017-07-06 10:09:54 -04:00
Wladimir J. van der Laan
be82498462
Merge #10743 : [test] don't run dbcrash.py on Travis
...
bd00fa5
2017-07-06 15:55:11 +02:00
Wladimir J. van der Laan
a5cd829a0b
Merge branch qt-translations into master
...
Forgot the Tree-SHA512 on last commit, so add a merge commit to include
it.
Tree-SHA512: 3d8d644f1ef3f272a34ac5b1fc724ea23cdfa260e13bc1d3b8bd4a89bf841377771be2173bad96ee05be6bb64bb5ff13e6166a1de1b88d80feea09a3fa96179f
2017-07-06 11:58:23 +02:00
Wladimir J. van der Laan
191d12b073
qt: First translations update for 0.15
2017-07-06 09:43:05 +02:00
Matt Corallo
73c942ecd3
Use "replaceable" instead of "rbfoptin" in bitcoin-tx.
...
To be consistent with RPC naming
2017-07-05 18:11:22 -04:00
Matt Corallo
fb915d5b18
Use "replaceable" instead of "optIntoRbf" in fundrawtransaction.
...
To be consistent with other RPCs
2017-07-05 18:11:22 -04:00
Matt Corallo
928c6811f2
Use "replaceable" instead of "optintorbf" in createrawtransaction.
...
To be consistent with other places (and add the missing named
args entry for it).
2017-07-05 18:11:19 -04:00
John Newbery
58e9864083
[rpc] fix verbose argument for getblock in bitcoin-cli
2017-07-05 12:09:58 +01:00
darksh1ne
9bbf60047e
Use method name from __func__ macro
...
Use __func__ macro in std::runtime_exception to:
1. fix method name in CWalletTx::GetAvailableWatchOnlyCredit()
2. refactor CWalletTx::GetAvailableCredit()
2017-07-04 22:22:53 +03:00
John Newbery
bd00fa52a1
[test] don't run dbcrash.py on Travis
2017-07-04 17:27:46 +01:00
Wladimir J. van der Laan
6dbcc74a0e
Merge #10193 : scripted-diff: Remove #include <boost/foreach.hpp>
...
b1268a159957353eff82733aed5b300851e
2017-07-04 18:05:18 +02:00
