Luke Dashjr
84dcb45017
Bugfix: wallet: Fix warningStr, errorStr argument order
2017-06-06 21:17:09 +00:00
Luke Dashjr
008c360083
Wallet: Move multiwallet sanity checks to CWallet::Verify, and do other checks on all wallets
2017-06-06 21:17:09 +00:00
Luke Dashjr
0f08575be2
Wallet: Support loading multiple wallets if -wallet used more than once
2017-06-06 21:17:09 +00:00
Luke Dashjr
b124cf04ea
Wallet: Replace pwalletMain with a vector of wallet pointers
2017-06-06 21:17:09 +00:00
Luke Dashjr
19b3648bb5
CWalletDB: Store the update counter per wallet
2017-06-05 22:27:57 +00:00
Luke Dashjr
23fb9adaea
wallet: Move nAccountingEntryNumber from static/global to CWallet
2017-06-05 21:04:42 +00:00
Luke Dashjr
9d15d5548d
Bugfix: wallet: Increment "update counter" when modifying account stuff
2017-06-05 21:04:42 +00:00
Luke Dashjr
f28eb8020e
Bugfix: wallet: Increment "update counter" only after actually making the applicable db changes to avoid potential races
...
Also does all "update counter" access via IncrementUpdateCounter
2017-06-05 21:04:42 +00:00
Wladimir J. van der Laan
9fec4da0be
Merge #9740 : Add friendly output to dumpwallet
...
164019d9f82134#9564 (aideca)
Tree-SHA512: 913fcf18d42eebe34173f1f2519973494b1ad2d86d125ff4bf566d6c64aa501c02f8831e6f44812cd87a46916f61c6f510146af406865b31856d8336c173569f
2017-06-05 18:06:34 +02:00
Wladimir J. van der Laan
08d0390a5f
Merge #10403 : Fix importmulti failure to return rescan errors
...
4d2d604
2017-06-05 16:41:02 +02:00
Wladimir J. van der Laan
0747d33498
Merge #10455 : Simplify feebumper minimum fee code slightly
...
88b8f0b
2017-06-05 16:38:07 +02:00
Pieter Wuille
098b01dc58
Merge #10500 : Avoid CWalletTx copies in GetAddressBalances and GetAddressGroupings
...
b9b814a38
2017-06-02 16:10:33 -07:00
Russell Yanofsky
b9b814a38e
Avoid CWalletTx copies in GetAddressBalances and GetAddressGroupings
2017-06-01 11:48:29 -04:00
Wladimir J. van der Laan
b6b150b016
Merge #10469 : Fixing typo in rpcdump.cpp
...
16d94d3
2017-06-01 13:19:36 +02:00
Wladimir J. van der Laan
ef2d062c9f
Merge #10450 : Fix bumpfee rpc "errors" return value
...
1b6602f
2017-06-01 10:48:19 +02:00
James Evans
16d94d3d03
Fixing typo in rpcdump.cpp
2017-05-27 16:44:10 +01:00
Pieter Wuille
b40ceed98a
Merge #10419 : [trivial] Fix three recently introduced typos
...
efc2e3302
2017-05-26 11:56:21 -07:00
Russell Yanofsky
88b8f0b682
Simplify feebumper minimum fee code slightly
...
No change in behavior. Get rid of specifiedConfirmTarget if/else block and
rename specifiedConfirmTarget and ignoreUserSetFee variables to
ignoreGlobalPayTxFee.
2017-05-25 10:13:28 -04:00
Russell Yanofsky
1b6602fbe6
Fix bumpfee rpc "errors" return value
2017-05-24 16:15:26 -04:00
Pieter Wuille
f2f7e97e8c
Merge #10347 : Use range-based for loops (C++11) when looping over vector elements
...
211adc0
2017-05-23 14:08:20 -07:00
Wladimir J. van der Laan
ce8176d038
Merge #10295 : [qt] Move some WalletModel functions into CWallet
...
108f04f429aa9ed944bd7ef8ca17
2017-05-23 19:32:52 +02:00
Wladimir J. van der Laan
e76a3927c3
Merge #10410 : Fix importwallet edge case rescan bug
...
2a8e35a
2017-05-23 16:39:19 +02:00
practicalswift
efc2e3302d
[trivial] Fix three recently introduced typos
...
```
$ git blame src/policy/fees.cpp | grep becuase
3810e9762d2e1705a3878374
2017-05-23 13:22:40 +02:00
Wladimir J. van der Laan
e4775167cb
Merge #10390 : [wallet] remove minimum total fee option
...
091a9ae
2017-05-22 20:01:20 +02:00
practicalswift
211adc074a
Use range-based for loops (C++11) when looping over vector elements
2017-05-19 09:56:16 +02:00
Wladimir J. van der Laan
ea6fde3f1d
Merge #8329 : Consensus: MOVEONLY: Move functions for tx verification
...
618d07f
2017-05-18 21:01:49 +02:00
Jonas Schnelli
962cd3f058
Merge #9697 : [Qt] simple fee bumper with user verification
...
a387837479b9ca538c6ed4368f1be08fc39d2678d3dc62ec911f60fbf385cc8
2017-05-18 11:18:23 +02:00
Russell Yanofsky
108f04f2d9
Add missing LOCK2 in CWallet::GetAvailableBalance
2017-05-17 05:18:25 -04:00
Russell Yanofsky
429aa9eb51
[test] Move some tests from qt -> wallet
...
After previous refactoring, the tests make more sense here.
2017-05-17 05:18:25 -04:00
Russell Yanofsky
d944bd7a27
[qt] Move some WalletModel functions into CWallet
...
Motivation for moving these is to make supporting IPC simpler (#10102 ), so
these lookups can be one-shot IPC requests, instead of back-and-forth
interactions over the IPC channel.
Also these functions are potentially useful outside of the bitcoin GUI (e.g.
for RPCs).
2017-05-17 05:18:25 -04:00
Wladimir J. van der Laan
08ac35a7e3
Merge #10413 : Fix docs (there's no rpc command setpaytxfee)
...
0f1b26a
2017-05-17 10:46:24 +02:00
Pedro Branco
bc63d0ed3b
Add query options to listunspent rpc call
2017-05-17 08:37:34 +02:00
Ryan Havar
0f1b26a5aa
Fix docs (there's no rpc command setpaytxfee)
2017-05-16 21:13:40 -05:00
Russell Yanofsky
2a8e35a11d
Fix importwallet edge case rescan bug
...
Start importwallet rescans at the first block with timestamp greater or equal
to the wallet birthday instead of the last block with timestamp less or equal.
This fixes an edge case bug where importwallet could fail to start the rescan
early enough if there are blocks with decreasing timestamps or multiple blocks
with the same timestamp.
2017-05-16 11:34:28 -04:00
Russell Yanofsky
4d2d6045a4
Fix importmulti failure to return rescan errors
...
An off-by-one-block bug in importmulti rescan logic could cause it to return
success in an edge case even when a rescan was not successful. The case where
this would happen is if there were multiple blocks in a row with the same
GetBlockTimeMax() value, and the last block was scanned successfully, but one
or more of the earlier blocks was not readable.
2017-05-15 09:11:03 -04:00
Gregory Sanders
091a9ae21c
remove minimum total fee option
2017-05-11 22:28:46 -04:00
Wladimir J. van der Laan
94e52273f3
Merge #10308 : [wallet] Securely erase potentially sensitive keys/values
...
6c914ac
2017-05-11 19:57:33 +02:00
Wladimir J. van der Laan
18c9debe60
Merge #10341 : rpc/wallet: Workaround older UniValue which returns a std::string temporary for get_str
...
a637734
2017-05-11 19:19:30 +02:00
Jonas Schnelli
a38783747b
Make sure we re-check the conditions of a feebump during commit
2017-05-11 15:27:06 +02:00
Jonas Schnelli
2ec911f60d
Add cs_wallet lock assertion to SignTransaction()
2017-05-11 15:27:05 +02:00
Luke Dashjr
a637734ba2
rpc/wallet: Workaround older UniValue which returns a std::string temporary for get_str
2017-05-05 00:21:00 +00:00
Thomas Snider
6c914ac176
[wallet] Securely erase potentially sensitive keys/values
2017-05-03 11:35:51 -07:00
Jorge Timón
381a46e38f
Consensus: Policy: MOVEONLY: Move CFeeRate out of the consensus module
...
...from amount.o to policy/feerate.o
Policy, because it moves policy code to the policy directory (common module)
2017-05-03 18:00:13 +02:00
Jorge Timón
330bb5a456
Consensus: Minimal way to move dust out of consensus
2017-05-03 17:55:52 +02:00
Wladimir J. van der Laan
d3dce0eb67
Merge #10115 : Avoid reading the old hd master key during wallet encryption
...
185c7f0
2017-05-03 09:11:45 +02:00
Wladimir J. van der Laan
e7b90f78f5
Merge #10180 : [trivial] Fix typos (tempoarily → temporarily, inadvertantly → inadvertently)
...
66082e0
2017-05-02 14:49:04 +02:00
Gregory Sanders
7c588637d4
[Wallet] unset change position when there is no change on exact match
2017-05-01 08:07:09 -04:00
Wladimir J. van der Laan
4c924011f5
Merge #10075 : Remove unused C++ code not covered by unit tests
...
b51aaf1
2017-04-27 20:25:15 +02:00
Alex Morcos
3edbd79a65
cleanup: reduce to one GetMinimumFee call signature
2017-04-26 15:54:23 -04:00
practicalswift
b51aaf1c42
Remove unused C++ code not covered by unit tests
2017-04-26 21:20:02 +02:00
