Wladimir J. van der Laan
fadf078c9c
Merge #10104 : linearize script: Option to use RPC cookie
...
bd41d98
2017-04-05 07:58:45 +02:00
MarcoFalke
faafa801e8
init: Remove redundant logging code
2017-04-05 01:03:26 +02:00
MarcoFalke
faab6241d0
logging: Fix off-by-one for shrinkdebugfile
2017-04-05 00:42:48 +02:00
MarcoFalke
080d7c700f
Merge #10152 : [trivial] remove unused line in Travis config
...
16791c5
2017-04-05 00:23:31 +02:00
practicalswift
73b37219d4
Remove accidental trailing semicolons
2017-04-04 21:30:18 +02:00
practicalswift
b8d9a86dc3
Remove unused import
2017-04-04 21:30:18 +02:00
John Newbery
cd7f39467a
initialize flag variable to 0 (and continue if GetLogCategory() fails)
2017-04-04 14:59:35 -04:00
John Newbery
16791c5e27
[trivial] remove unused line in Travis config
2017-04-04 14:37:01 -04:00
Wladimir J. van der Laan
72bc7e1303
Merge #10146 : Better error handling for submitblock
...
30f30c04f15ea1ada0caa
2017-04-04 09:00:23 +02:00
Suhas Daftuar
9bef02e365
Bugfix: ancestor modifed fees were incorrect for descendants
...
If prioritisetransaction was called for a tx with in-mempool
descendants, the modified ancestor fee values for those descendants was
incorrect.
2017-04-03 15:50:15 -04:00
Suhas Daftuar
ba7dd8bf6f
Test prioritisetransaction and ancestor fee state
...
There is already a similar test for descendant fee state.
2017-04-03 15:48:55 -04:00
Wladimir J. van der Laan
471ed00fcd
Merge #10123 : Allow debug logs to be excluded from specified component
...
3bde556
2017-04-03 17:42:40 +02:00
Russell Yanofsky
bf1026412d
Run bitcoin_test-qt under minimal QPA platform
...
Fixes broken "make check" reported by Matt Corallo <git@bluematt.me> in
https://github.com/bitcoin/bitcoin/issues/10110
Fix was suggested and initially implemented by
Cory Fields <cory-nospam-@coryfields.com> in
https://github.com/bitcoin/bitcoin/pull/10117#issuecomment-290275236
2017-04-03 11:07:40 -04:00
John Newbery
3bde556429
Add -debugexclude option to switch off logging for specified components
2017-04-03 09:04:42 -04:00
Wladimir J. van der Laan
cb598cfba1
Merge #9533 : Allow non-power-of-2 signature cache sizes
...
7482781
2017-04-03 13:24:34 +02:00
Wladimir J. van der Laan
f110272dc9
Remove namespace fs=fs
...
Having these inside functions is silly and redundant now.
2017-04-03 12:33:14 +02:00
Wladimir J. van der Laan
75594bd7f2
torcontrol: Use fs::path instead of std::string for private key path
2017-04-03 12:33:14 +02:00
Wladimir J. van der Laan
2a5f574762
Use fsbridge for fopen and freopen
...
Abstracts away how a path is opened to a `FILE*`.
Reduces the number of places where path is converted to a string
for anything else but printing.
2017-04-03 12:32:32 +02:00
Wladimir J. van der Laan
bac5c9cf64
Replace uses of boost::filesystem with fs
...
Step two in abstracting away boost::filesystem.
To repeat this, simply run:
```
git ls-files \*.cpp \*.h | xargs sed -i 's/boost::filesystem/fs/g'
```
2017-04-03 12:32:32 +02:00
Wladimir J. van der Laan
7d5172d354
Replace includes of boost/filesystem.h with fs.h
...
This is step one in abstracting the use of boost::filesystem.
2017-04-03 12:32:32 +02:00
Wladimir J. van der Laan
19e36bbef6
Add fs.cpp/h
2017-04-03 12:32:32 +02:00
Wladimir J. van der Laan
a2cd0b0eec
Merge #10058 : No need to use OpenSSL malloc/free
...
6d5dd60
2017-04-03 12:06:02 +02:00
Gregory Maxwell
30f30c0f99
Add braces to submitblock per current style.
2017-04-03 07:23:07 +00:00
Gregory Maxwell
4f15ea102d
Check transaction count early in submitblock.
...
There is no point in even hashing a submitted block which doesn't have
a coinbase transaction.
This also results in more useful error reporting on corrupted input.
Thanks to rawodb for the bug report.
2017-04-03 07:15:36 +00:00
Wladimir J. van der Laan
e6033e00b1
Merge #10139 : [rpc] Remove auth cookie on shutdown
...
4b87973
2017-04-03 08:53:04 +02:00
Gregory Maxwell
ada0caa165
Make GetWitnessCommitmentIndex callable on blocks without a coinbase txn.
...
This isn't actually needed anywhere, but it's less brittle.
2017-04-02 21:28:17 +00:00
practicalswift
4b87973c32
[rpc] Remove auth cookie on shutdown
...
Accidentally removed in 40b556d374
2017-04-02 15:52:41 +02:00
Wladimir J. van der Laan
ebfd653798
Merge #10077 : [qa] Add setnetworkactive smoke test
...
fa697b7
2017-04-02 15:39:26 +02:00
Matthias Grundmann
31a14d4909
Correct indentation and remove unnecessary braces
2017-04-02 14:41:38 +02:00
MarcoFalke
12af74b289
Merge #10072 : Remove sources of unreliablility in extended functional tests
...
a4fd89f1f3d78b
2017-04-02 12:52:31 +02:00
Wladimir J. van der Laan
2b477e6aa1
Merge #10098 : Make qt wallet test compatible with qt4
...
e9a6461
2017-04-02 11:58:41 +02:00
Jonas Schnelli
5f59d3ecb7
Improve CFeeBumper interface, add comments, make use of std::move
2017-04-02 10:12:43 +02:00
Jonas Schnelli
0df22ed6fd
Cancel feebump is vErrors is not empty
2017-04-02 10:12:43 +02:00
Jonas Schnelli
44cabe6380
Use static calls for GetRequiredFee and GetMinimumFee, remove make_pair from emplace_back
2017-04-02 10:12:43 +02:00
Jonas Schnelli
bb78c1599e
Restore CalculateMaximumSignedTxSize function signature
2017-04-02 10:12:43 +02:00
Jonas Schnelli
51ea44f01c
Use "return false" instead assert() in CWallet::SignTransaction
2017-04-02 10:12:43 +02:00
Jonas Schnelli
bcc72cccc7
Directly abort execution in FeeBumper::commit if wallet or tx is not available
2017-04-02 10:12:42 +02:00
Jonas Schnelli
2718db0705
Restore invalid fee check (must be > 0)
2017-04-02 10:12:42 +02:00
Jonas Schnelli
0337a39d31
Refactor Bumpfee core functionality
2017-04-02 10:12:39 +02:00
Jonas Schnelli
d1a95e8d3d
Bumpfee move request parameter interaction to the top
2017-04-02 09:48:48 +02:00
Wladimir J. van der Laan
fbf36cae3a
Merge #10036 : Fix init README format to render correctly on github
...
b99fbad
2017-04-02 09:28:06 +02:00
Wladimir J. van der Laan
427d2fd04e
Merge #10128 : Speed Up CuckooCache tests
...
3f098cc
2017-04-02 09:04:03 +02:00
Wladimir J. van der Laan
1a5aaabb8a
Merge #9424 : Change LogAcceptCategory to use uint32_t rather than sets of strings.
...
6b3bb3d
2017-04-02 08:47:02 +02:00
Wladimir J. van der Laan
81da4c7b5b
Merge #10136 : build: Disable Wshadow warning
...
2c83911
2017-04-02 08:27:21 +02:00
Gregory Maxwell
6b3bb3d9ba
Change LogAcceptCategory to use uint32_t rather than sets of strings.
...
This changes the logging categories to boolean flags instead of strings.
This simplifies the acceptance testing by avoiding accessing a scoped
static thread local pointer to a thread local set of strings. It
eliminates the only use of boost::thread_specific_ptr outside of
lockorder debugging.
This change allows log entries to be directed to multiple categories
and makes it easy to change the logging flags at runtime (e.g. via
an RPC, though that isn't done by this commit.)
It also eliminates the fDebug global.
Configuration of unknown logging categories now produces a warning.
2017-04-01 18:53:29 +00:00
Wladimir J. van der Laan
2c83911401
build: Disable Wshadow warning
...
This warning was enabled by default in #8808 but it's a
[continuing](https://github.com/bitcoin/bitcoin/pull/9911#issuecomment-285171447 )
[source](https://github.com/bitcoin/bitcoin/pull/10089#issuecomment-289369688 ) of
[annoyance](https://github.com/bitcoin/bitcoin/pull/9911#issuecomment-285179129 ) for me
and other developers. I'm sick of sounding like a broken record, so disable it again.
2017-04-01 14:16:55 +02:00
Wladimir J. van der Laan
351d0ad404
Merge #10129 : scheduler: fix sub-second precision with boost < 1.50
...
e025246
2017-04-01 12:25:56 +02:00
Alex Morcos
1b55e07b7a
Make threshold for flushing more conservative.
...
Always leave a reasonable buffer of 50MB for usage from newly connected block (once over 50%) and increase the high water mark buffer to 200MB.
2017-03-31 14:30:31 -04:00
John Newbery
5d08c9c579
Send the correct error code in reject messages
2017-03-31 14:22:25 -04:00
Alex Morcos
f33afd3b2b
Lower default memory footprint slightly
2017-03-31 14:07:56 -04:00
