Jonas Schnelli
bcafca1077
Make sure we always generate one keypool key at minimum
2017-03-24 10:28:39 +01:00
Jonas Schnelli
d0a627a53a
Fix issue where CDataStream->nVersion was taken a CKeyPool record version
2017-03-24 10:28:39 +01:00
Jonas Schnelli
9af8f00a75
Make sure we hand out keypool keys if HD_SPLIT is not enabled
2017-03-24 10:28:38 +01:00
Jonas Schnelli
469a47b760
Make sure ReserveKeyFromKeyPool only hands out internal keys if HD_SPLIT is supported
2017-03-24 10:28:38 +01:00
Jonas Schnelli
05a9b493eb
Fix wrong keypool internal size in RPC getwalletinfo help
2017-03-24 10:28:38 +01:00
Jonas Schnelli
01de822c8d
Removed redundant IsLocked() check in NewKeyPool()
2017-03-24 10:28:38 +01:00
Jonas Schnelli
d59531ddfc
Immediately return setKeyPool's size if HD or HD_SPLIT is disabled or not supported
2017-03-24 10:28:37 +01:00
Jonas Schnelli
02592f4c5e
[Wallet] split the keypool in an internal and external part
2017-03-24 10:28:37 +01:00
John Newbery
0c1ade6a4b
Skip rpcbind_test if OS/network requirements are not met.
2017-03-24 00:05:30 -04:00
Thomas Snider
c59aedc1b0
[trivial] Dead code removal
2017-03-23 15:08:54 -07:00
Eric Shaw Jr
9ab9e7d1b3
Add a button to open the config file in a text editor
2017-03-23 12:54:36 -04:00
flack
cc995e26c2
add missing spaces so that markdown recognizes headline
2017-03-23 14:48:14 +01:00
MarcoFalke
a230b05887
Merge #9701 : Make bumpfee tests less fragile
...
f85ac540b94e491dfd64fe6b296394b528b
2017-03-23 12:21:10 +01:00
MarcoFalke
dfef6b6af0
Merge #10047 : [tests] Remove unused variables and imports
...
389745972163d4
2017-03-23 11:37:21 +01:00
Jonas Schnelli
3568b30ca3
Merge #9500 : [Qt][RPC] Autocomplete commands for 'help' command in debug console
...
6d8fe35
2017-03-23 08:27:16 +01:00
Jonas Schnelli
7b585cf70e
Merge #9558 : Clarify assumptions made about when BlockCheck is called
...
c4a6929
2017-03-23 08:18:43 +01:00
Jonas Schnelli
86f7d5b69b
Merge #10029 : Fix parameter naming inconsistencies between .h and .cpp files
...
97b8213
2017-03-23 08:16:27 +01:00
Karl-Johan Alm
5ba61f0034
[zmq] Call va_end() on va_start()ed args.
2017-03-22 12:56:44 -07:00
practicalswift
389745901a
[tests] Remove unused variables
2017-03-22 17:50:03 +01:00
practicalswift
72163d4585
[tests] Remove unused and duplicate imports
2017-03-22 17:49:23 +01:00
John Newbery
88e3aa0bcb
Run extended tests once daily
2017-03-22 10:49:11 -04:00
John Newbery
232b6665bc
Allow test cases to be skipped
...
Currently, functional test cases can either pass or fail. There are
occasions when it is helpful to skip tests, for example if the
system they are running on does not meet the requirements for the test.
The rest of the test suite can run without being marked as a failure.
This commit adds framework for tests to skip if their requirements
aren't met.
2017-03-22 10:26:02 -04:00
Wladimir J. van der Laan
02d64bd929
Merge #10017 : combine_logs.py - aggregates log files from multiple bitcoinds during functional tests.
...
8317a4561d75f5
2017-03-22 13:03:43 +01:00
Jonas Schnelli
90586b6897
Merge #10045 : [trivial] Fix typos in comments
...
dbf30ff
2017-03-22 08:38:24 +01:00
John Newbery
8317a45161
Python functional tests should log in UTC
...
bitcoind logs use UTC. Python functional tests should also log in UTC.
2017-03-21 17:30:13 -04:00
John Newbery
61d75f587d
Introduce combine_logs.py to combine log files from multiple bitcoinds.
...
This commit adds a tool for combining log files from multiple instances
of bitcoinds as well as the test_framework.log file. This gives a
combined view of what the test framework and all bitcoin instances were
doing during a qa test.
2017-03-21 17:30:13 -04:00
practicalswift
dbf30ff10f
[trivial] Fix typos in comments
2017-03-21 19:49:08 +01:00
Wladimir J. van der Laan
919aaf6508
Merge #10039 : Fix compile errors with Qt 5.3.2 and Boost 1.55.0
...
b5bec4ed5046e7
2017-03-21 11:46:55 +01:00
Russell Yanofsky
f85ac54e24
[qa] Expand bumpfee test docstring
2017-03-21 06:46:55 -04:00
Russell Yanofsky
0b94e49831
[qa] Rename python input variable to tx_input
...
input() is actually the name of a python built in function
2017-03-21 06:46:55 -04:00
Russell Yanofsky
1dfd64fadc
[qa] Make bumpfee.py test function order consistent
...
Run bumpfee tests in top-down order, now that the test fragility is fixed, and
they can actually run in order.
2017-03-21 05:46:55 -05:00
Russell Yanofsky
e6b2963241
[qa] Get rid of nondeterminism in bumpfee.py
...
Change bumpfee tests to use the spend_one_input function instead of the
create_fund_sign_send function. The latter function would choose transaction
inputs and fees in unpredictable ways depending on the order that tests ran,
which meant that adding new tests could cause old tests to fail, and in general
made bumpfee.py fragile and unpleasant to work with.
2017-03-21 05:46:55 -05:00
Russell Yanofsky
94b528bb0c
[qa] Remove bumpfee.py get_change_address hack
2017-03-21 05:46:55 -05:00
MarcoFalke
3192e5278a
Merge #9956 : Reorganise qa directory
...
63d66ba5b0bff4a9bd622c28ee9100902c4
2017-03-21 00:11:14 +01:00
Wladimir J. van der Laan
0c17afcbe7
Merge #9734 : Add updating of chainTxData to release process
...
41b8821
2017-03-20 17:59:20 +01:00
Russell Yanofsky
b5bec4e330
Avoid QTimer::singleShot compile error with Qt 5.3.2
...
Construct QTimer object directly, instead of relying on QTimer::singleShot
overloads accepting lambdas, which weren't introduced until Qt 5.4.
Avoids the following compile error in debian jessie:
```
qt/test/wallettests.cpp: In function ‘void {anonymous}::ConfirmSend()’:
qt/test/wallettests.cpp:34:6: error: no matching function for call to ‘QTimer::singleShot(int, Qt::TimerType, {anonymous}::ConfirmSend()::<lambda()>)’
});
^
qt/test/wallettests.cpp:34:6: note: candidates are:
In file included from /usr/include/x86_64-linux-gnu/qt5/QtCore/QTimer:1:0,
from ./qt/sendcoinsdialog.h:13,
from qt/test/wallettests.cpp:7:
/usr/include/x86_64-linux-gnu/qt5/QtCore/qtimer.h:81:17: note: static void QTimer::singleShot(int, const QObject*, const char*)
static void singleShot(int msec, const QObject *receiver, const char *member);
^
/usr/include/x86_64-linux-gnu/qt5/QtCore/qtimer.h:81:17: note: no known conversion for argument 2 from ‘Qt::TimerType’ to ‘const QObject*’
/usr/include/x86_64-linux-gnu/qt5/QtCore/qtimer.h:82:17: note: static void QTimer::singleShot(int, Qt::TimerType, const QObject*, const char*)
static void singleShot(int msec, Qt::TimerType timerType, const QObject *receiver, const char *member);
^
/usr/include/x86_64-linux-gnu/qt5/QtCore/qtimer.h:82:17: note: candidate expects 4 arguments, 3 provided
```
Error reported by Pavel Janík <Pavel@Janik.cz> in
https://github.com/bitcoin/bitcoin/pull/9974#issuecomment-287574436
2017-03-20 12:35:37 -04:00
Russell Yanofsky
d5046e72f4
Avoid scoped_connection compile error with boost 1.55.0
...
Construct scoped_connection directly instead of relying on copy initialization
and move constructor. Avoids the following compile error in debian jessie:
```
In file included from /usr/include/boost/signals2/signal.hpp:21:0,
from ./util.h:29,
from ./dbwrapper.h:11,
from ./txdb.h:10,
from ./test/test_bitcoin.h:11,
from qt/test/wallettests.cpp:11:
/usr/include/boost/signals2/connection.hpp: In function ‘uint256 {anonymous}::SendCoins(CWallet&, SendCoinsDialog&, const CBitcoinAddress&, CAmount)’:
/usr/include/boost/signals2/connection.hpp:234:7: error: ‘boost::signals2::scoped_connection::scoped_connection(const boost::signals2::scoped_connection&)’ is private
scoped_connection(const scoped_connection &other);
^
qt/test/wallettests.cpp:47:6: error: within this context
});
^
```
Error reported by Pavel Janík <Pavel@Janik.cz> in
https://github.com/bitcoin/bitcoin/pull/9974#issuecomment-287550034
2017-03-20 12:27:07 -04:00
John Newbery
63d66ba20a
Move src/test/bitcoin-util-test.py to test/util/bitcoin-util-test.py
2017-03-20 10:40:31 -04:00
John Newbery
5b0bff4581
Rename --enable-extended-rpc-tests to --enable-extended-functional-tests
2017-03-20 10:40:31 -04:00
John Newbery
a9bd622a65
Rename test/pull-tester/rpc-tests.py to test/functional/test_runner.py
2017-03-20 10:40:31 -04:00
John Newbery
c28ee91db0
Rename rpc-tests directory to functional
2017-03-20 10:40:31 -04:00
John Newbery
00902c48cd
Rename qa directory to test
2017-03-20 10:40:31 -04:00
Wladimir J. van der Laan
d34995a7ba
Merge #10038 : Add mallocinfo mode to getmemoryinfo RPC
...
e141aa4
2017-03-20 15:05:56 +01:00
MarcoFalke
7c7ddd9ead
Merge #10037 : Trivial: Fix typo in help getrawtransaction RPC
...
05a9f22
2017-03-20 10:42:58 +01:00
Wladimir J. van der Laan
e141aa4ba6
Add mallocinfo mode to getmemoryinfo RPC
...
This adds a mode argument to `getmemoryinfo`. By default the output
will remain the same. However if a mode argument of `mallocinfo` is
provided the result of glibc `malloc_info` (if available) will
be returned as a string, as-is.
This is useful for tracking heap usage over time or troubleshooting
memory fragmentation issues.
2017-03-20 10:30:18 +01:00
James Evans
05a9f22358
Trivial: Fix typo in help getrawtransaction RPC
2017-03-20 05:19:41 -03:00
Wladimir J. van der Laan
5c1a958124
Merge #10027 : Set to nullptr after delete
...
d93b97f
2017-03-20 08:39:18 +01:00
practicalswift
97b8213674
Fix parameter naming inconsistencies between .h and .cpp files
...
Inconsistencies prior to this commit:
* serializeFlags vs serialFlags
src/core_io.h:std::string EncodeHexTx(const CTransaction& tx, const int serializeFlags = 0);
src/core_write.cpp:std::string EncodeHexTx(const CTransaction& tx, const int serialFlags)
* statusOut vs outStatus
src/rpc/server.h:bool RPCIsInWarmup(std::string *statusOut);
src/rpc/server.cpp:bool RPCIsInWarmup(std::string *outStatus)
* hashesToUpdate vs vHashesToUpdate
src/txmempool.h: void UpdateTransactionsFromBlock(const std::vector<uint256> &hashesToUpdate);
src/txmempool.cpp:void CTxMemPool::UpdateTransactionsFromBlock(const std::vector<uint256> &vHashesToUpdate)
* nPruneUpToHeight vs nManualPruneHeight
src/validation.h:void PruneBlockFilesManual(int nPruneUpToHeight);
src/validation.cpp:void PruneBlockFilesManual(int nManualPruneHeight);
2017-03-19 16:14:29 +01:00
Jameson Lopp
b99fbadfad
Fix init README format to render correctly on github
2017-03-19 09:09:25 -04:00
MarcoFalke
10b930dde8
Merge #10033 : Trivial: Fix typo in key.h comment
...
f490dae
2017-03-19 11:26:55 +01:00
