Wladimir J. van der Laan
f5ef8e9dd2
Merge #9867 : Replace remaining sprintf with snprintf
...
19cafc60a17714
2017-02-28 12:02:44 +01:00
Wladimir J. van der Laan
30bdcfca2b
Merge #9865 : Change bitcoin address in RPC help message
...
83ac719
2017-02-28 11:59:34 +01:00
Wladimir J. van der Laan
d75e8cb44d
Merge #9879 : [doc] Update doc/bips.md for BIP90 implementation
...
fe71661
2017-02-28 11:44:11 +01:00
Wladimir J. van der Laan
65fdc37ac3
Merge #9856 : Terminate immediately when allocation fails
...
d4ee7bac5f008a
2017-02-28 11:37:36 +01:00
Matt Corallo
a4b02f4275
Add Pieter's old signed commits to revsig-commits
2017-02-27 20:24:20 -05:00
MarcoFalke
88c2ae3ed2
Merge #9350 : [Trivial] Adding label for amount inside of tx_valid/tx_invalid.json
...
988ce2d
2017-02-27 22:33:55 +01:00
Luke Dashjr
d678771c66
Wallet: Sanitise -wallet parameter
2017-02-27 20:45:18 +00:00
Luke Dashjr
9756be382e
Wallet/RPC: Use filename rather than CWallet pointer, for lockwallet RPCRunLater job name
...
The job name is logged, and could pose as an information leak to someone attacking the process, helping them counteract ASLR protections
2017-02-27 20:45:18 +00:00
Luke Dashjr
86be48a77c
More tightly couple EnsureWalletIsAvailable with GetWalletForJSONRPCRequest where appropriate
2017-02-27 20:45:18 +00:00
Luke Dashjr
a4356328e0
Move wallet RPC declarations to rpcwallet.h
2017-02-27 20:45:18 +00:00
Luke Dashjr
ad1573472e
RPC: Pass on JSONRPCRequest metadata (URI/user/etc) for "help" method
2017-02-27 20:45:18 +00:00
Luke Dashjr
bf8a04a165
Reformat touched lines with C++11
2017-02-27 20:45:18 +00:00
Luke Dashjr
2e518e313b
Move nWalletUnlockTime to CWallet::nRelockTime, and name timed task unique per CWallet
2017-02-27 20:45:17 +00:00
Luke Dashjr
d77ad6d416
RPC: Do all wallet access through new GetWalletForJSONRPCRequest
2017-02-27 20:45:17 +00:00
Luke Dashjr
eca550f250
RPC/Wallet: Pass CWallet as pointer to helper functions
2017-02-27 20:45:17 +00:00
Cory Fields
d4ee7baef7
prevector: assert successful allocation
2017-02-27 14:52:15 -05:00
Suhas Daftuar
fe71661ae1
[doc] Update doc/bips.md for BIP90 implementation
2017-02-27 12:21:40 -05:00
Alex Morcos
ad727f4eaf
[rpc] sendrawtransaction no longer bypasses minRelayTxFee
...
The prioritisetransaction API can always be used if a transaction needs to be submitted that bypasses minRelayTxFee.
2017-02-27 11:23:51 -05:00
Alex Morcos
fe282acd76
[cleanup] Remove estimatePriority and estimateSmartPriority
...
Unused everywhere now except one test.
2017-02-27 11:23:51 -05:00
Alex Morcos
400b15147c
[debug] Change -printpriority option
...
-printpriority output is now changed to only show the fee rate and hash of transactions included in a block by the mining code.
2017-02-27 11:23:50 -05:00
Alex Morcos
272b25a6a9
[mining] Remove -blockprioritysize.
...
Remove ability of mining code to fill part of a block with transactions sorted by coin age.
2017-02-27 11:23:50 -05:00
Alex Morcos
12839cdd56
[rpc] Remove estimatepriority and estimatesmartpriority.
...
The RPC calls were already deprecated.
2017-02-27 11:23:50 -05:00
MarcoFalke
ddf58c7573
wallet: Remove sendfree
...
This removes the option from the wallet to not pay a fee on "small"
transactions which spend "old" inputs.
This code is no longer worth keeping around, as almost all miners
prefer not to include transactions which pay no fee at all.
2017-02-27 11:23:50 -05:00
Russell Yanofsky
306bd72157
Fix importmulti returning rescan errors for wrong keys
...
Bug was a missing ++i line in a new range for loop added in commit e2e2f4c
2017-02-27 07:38:51 -05:00
Wladimir J. van der Laan
94e5ba9ba2
Merge #9875 : tests: Fix dangling pwalletMain pointer in wallet tests
...
75a1093
2017-02-27 13:38:51 +01:00
Wladimir J. van der Laan
75a109338f
tests: Fix dangling pwalletMain pointer in wallet tests
2017-02-27 13:15:39 +01:00
Wladimir J. van der Laan
19cafc6239
test: Replace remaining sprintf with snprintf
...
Use of `sprintf` is seen as a red flag as many of its uses are insecure.
OpenBSD warns about it while compiling, and some modern platforms, e.g.
[cloudlibc from cloudabi](https://github.com/NuxiNL/cloudlibc ) don't
even provide it anymore.
Although our uses of these functions are secure, it can't hurt to
replace them anyway. There are only 3 occurences left, all in the
tests.
2017-02-27 10:03:20 +01:00
Wladimir J. van der Laan
0a177148e7
uint256: replace sprintf with HexStr and reverse-iterator
...
Instead of calling sprintf for every byte, format the hex bytes
ourselves by help of HexStr and a reverse_iterator.
2017-02-27 10:02:45 +01:00
Wladimir J. van der Laan
c7e57ce981
Merge #9839 : [qa] Make import-rescan.py watchonly check reliable
...
864890a
2017-02-27 08:46:19 +01:00
Pieter Wuille
fa89670d34
Add SHA512 tree hash to merge commits
2017-02-26 17:31:28 -08:00
Pieter Wuille
277b472fb2
Run miner_tests with fixed options
2017-02-26 16:13:51 -08:00
Pieter Wuille
48faf0bf63
Abstract out BlockAssembler options
2017-02-26 16:13:17 -08:00
Marijn Stollenga
83ac719d34
Change bitcoin address in RPC helpaddress to an invalid address, so people don't accidentally send coins there (like I did).
2017-02-26 14:01:05 +01:00
Wladimir J. van der Laan
6206252e50
Merge #9847 : Extra test vector for BIP32
...
30aedcb
2017-02-25 10:43:29 +01:00
Cory Fields
c5f008a416
don't throw std::bad_alloc when out of memory. Instead, terminate immediately
2017-02-25 01:09:11 -05:00
Wladimir J. van der Laan
f19afdbfb4
Merge #9612 : [trivial] Rephrase the definition of difficulty.
...
dc222f8
2017-02-24 12:48:56 +01:00
Wladimir J. van der Laan
dd6e0d6301
Merge #9833 : Trivial: fix comments referencing AppInit2
...
ef9f495
2017-02-24 10:53:32 +01:00
Wladimir J. van der Laan
00285cece8
Merge #9840 : Update sendfrom RPC help to correct coin selection misconception
...
f81f0d0
2017-02-24 10:22:04 +01:00
Karl-Johan Alm
dc222f8f63
Trivial: Rephrase the definition of difficulty in the code.
2017-02-23 22:06:37 -08:00
Pieter Wuille
30aedcbdb4
BIP32 extra test vector
2017-02-23 17:59:52 -08:00
Marko Bencun
ef9f495e93
Trivial: fix comments referencing AppInit2
...
It was refactored into multiple functions in
0cc8b6bc44
2017-02-24 09:19:29 +09:00
John Newbery
b23dcd2bf9
Fix segwit getblocktemplate test.
2017-02-23 18:01:37 -05:00
Russell Yanofsky
864890adf5
[qa] Make import-rescan.py watchonly check reliable
...
Send payments during the test from a different node than the node generating
keys to be imported, so the spending node doesn't create transactions that
inadvertently involve (spend funds from) the imported keys.
Fixes #9826
2017-02-23 14:09:43 -05:00
Russell Yanofsky
f81f0d0030
Update sendfrom RPC help to correct coin selection misconception
2017-02-23 13:44:12 -05:00
Wladimir J. van der Laan
692c9eddba
Merge #9831 : build: force a c++ standard to be specified
...
9829c54
2017-02-23 19:03:14 +01:00
MarcoFalke
a13a417cdc
Merge #9823 : qa: Set correct path for binaries in rpc tests
...
3333ad0
2017-02-23 17:36:02 +01:00
MarcoFalke
d6064a89ac
Merge #9577 : Fix docstrings in qa tests
...
3f95a80
2017-02-23 16:39:22 +01:00
MarcoFalke
7146d96de3
Merge #9766 : Add --exclude option to rpc-tests.py
...
c578408
2017-02-23 16:34:07 +01:00
John Newbery
3f95a806b1
Fix docstrings in qa tests
...
This commit fixes the module-level docstrings for the tests and helper
modules in qa. Many of these tests were uncommented previously - this
commit ensures that every test case has at least a minimum level of
commenting.
2017-02-23 10:31:04 -05:00
Wladimir J. van der Laan
e68c266f3d
Merge #9789 : build: add --enable-werror and warn on vla's
...
205830ab602fe0
2017-02-23 10:48:46 +01:00
