LBRYCommunity/lbrycrd
1
0
Fork 0
Code Issues 29 Pull requests 1 Projects Releases 32 Packages Wiki Activity
2321 commits 22 branches 42 tags 99 MiB
Commit graph

1248 commits

Author SHA1 Message Date
Gavin Andresen
940e22fd81 Fix OSX build errors. 2012-04-12 11:14:46 -04:00
Wladimir J. van der Laan
4ac24cf59e Merge pull request #855 from sje397/ToggleHide 
Toggle UI hide
 2012-04-11 23:02:18 -07:00
Pieter Wuille
ee12c3d60c Use filesystem::path instead of manual string tinkering 
Where possible, use boost::filesystem::path instead of std::string or
char* for filenames. This avoids a lot of manual string tinkering, in
favor of path::operator/.

GetDataDir is also reworked significantly, it now only keeps two cached
directory names (the network-specific data dir, and the root data dir),
which are decided through a parameter instead of pre-initialized global
variables.

Finally, remove the "upgrade from 0.1.5" case where a debug.log in the
current directory has to be removed.
 2012-04-11 22:30:23 +02:00
Wladimir J. van der Laan
bcaa5f1c04 Merge pull request #1083 from laanwj/2012_04_connectionicon 
Make 4th bar of connection icon green
 2012-04-11 11:06:26 -07:00
Gavin Andresen
2232717cba Remove path.make_preferred() calls, and fix compiler error in bitcoinrpc RE: boost::system 2012-04-11 14:00:48 -04:00
Wladimir J. van der Laan
5ca4f13b87 by popular request, make 4th bar of connection icon green 2012-04-11 19:59:15 +02:00
Pieter Wuille
4577167170 Fix build.h dependencies 
For Qt builds, the build.h file is moved to build/build.h. For regular
builds, it is moved to obj/build.h. This allows the Qt build to be done
in a different directory than the source, and without interfering with
other builds.
 2012-04-11 14:04:42 +02:00
Pieter Wuille
702764f53b Merge pull request #1054 from sipa/buildinfo 
Build identification strings
 2012-04-10 13:31:12 -07:00
Wladimir J. van der Laan
b56772e5df Merge pull request #1046 from laanwj/2012_04_rpcporterror 
Show error message instead of exception crash when unable to bind RPC port
 2012-04-10 13:14:47 -07:00
Pieter Wuille
a20c0d0f67 Build identification strings 
All client version information is moved to version.cpp, which optionally
(-DHAVE_BUILD_INFO) includes build.h. build.h is automatically generated
on supporting platforms via contrib/genbuild.sh, using git describe.

The git export-subst attribute is used to put the commit id statically
in version.cpp inside generated archives, and this value is used if no
build.h is present.

The gitian descriptors are modified to use git archive instead of a
copy, to create the src/ directory in the output. This way,
src/src/version.cpp will contain the static commit id. To prevent
gitian builds from getting the "-dirty" marker in their git-describe
generated identifiers, no touching of files or running sed on the
makefile is performed anymore. This does not seem to influence
determinism.
 2012-04-10 18:16:53 +02:00
sje397
86d5634941 Toggle main window hide on tray icon click 
- converted openBictoinAction to toggleHideAction
- put GUIUtil functions into a namespace instead of a class
- put window-related functions together in optionsdialog

Reasoning:
- toggle is more typical behaviour
- it's more functional
- better UX

The typical issue with toggling visibility is that when a window
is obscured by other windows but in the 'shown' state, hiding it
isn't what you want. I've added an 'isObscured' function to GUIUtil
that checks several pixels in the window to see if they are visible
on the desktop so that an obscured but shown window can be raised.

Conflicts:

	src/qt/guiutil.cpp
	src/qt/guiutil.h
 2012-04-11 00:07:32 +10:00
Pieter Wuille
1a275bac2b Merge pull request #1052 from sipa/scopedlocks 
Use scoped locks instead of CRITICAL_BLOCK
 2012-04-09 13:25:17 -07:00
Gavin Andresen
1044391135 Merge branch 'filesystem' of https://github.com/Diapolo/bitcoin 2012-04-09 10:41:59 -04:00
Pieter Wuille
f342dac1cb Do not report spurious deadlocks caused by TRY_LOCK 2012-04-09 01:59:57 +02:00
Pieter Wuille
908037fe16 Support for parametrized locks in deadlock detector 2012-04-09 01:59:57 +02:00
Pieter Wuille
f8dcd5ca6f Use scoped locks instead of CRITICAL_BLOCK 2012-04-09 01:59:46 +02:00
Luke Dashjr
fa2544e79f Bugfix: Replace "URL" with "URI" where we aren't actually working with URLs 2012-04-06 12:53:37 -04:00
Wladimir J. van der Laan
3e34352222 Show error message instead of exception crash when unable to bind RPC port 
Fixes issue #875
 2012-04-06 18:41:23 +02:00
Philip Kaufmann
42c63d3ad2 fixed small error in bitcoinrpc.cpp 2012-04-06 15:31:28 +02:00
Philip Kaufmann
36949554ab updated util.cpp to use make_preferred() 2012-04-06 15:29:20 +02:00
Philip Kaufmann
93fb7489a7 updated bitcoinrpc.cpp to use make_preferred() and removed double inclusion of boost/filesystem.hpp 2012-04-06 15:29:19 +02:00
Philip Kaufmann
9c24588e73 updated db.cpp to use make_preferred() 2012-04-06 15:29:18 +02:00
Pieter Wuille
9362da78b0 Merge pull request #1033 from sipa/wait 
Condition variables instead of polling
 2012-04-06 04:11:14 -07:00
graingert
f9781fc62e Change sign message bitcoin address tooltip to "The address to sign the message with" Closes #1050 2012-04-06 04:08:16 +02:00
Pieter Wuille
e88ed65a39 Flush on log size instead of transaction count 2012-04-05 20:29:47 +02:00
Gavin Andresen
399ff1fe05 Merge pull request #1043 from Diapolo/misc 
removed obsolete boost workaround (boost ticket #4258)
 2012-04-05 07:36:23 -07:00
Gavin Andresen
895c12943b Merge pull request #1042 from gavinandresen/use_ssl_cleanup 
Remove USE_SSL #define
 2012-04-05 07:34:45 -07:00
Gavin Andresen
ea2cc8fc4a Merge pull request #1037 from gavinandresen/addmultisigenable 
Enable addmultisigaddress RPC call for main network
 2012-04-05 07:34:19 -07:00
Gavin Andresen
c7fa55bb87 Merge pull request #1036 from gavinandresen/pubsubcleanup 
Remove half-implemented publish/subscribe system
 2012-04-05 07:33:54 -07:00
Gavin Andresen
78494ffecc Merge pull request #1035 from gavinandresen/osxbuild 
Add ifdef RELEASE to makefile.osx as the compile-for-older-macs flags
 2012-04-05 07:33:00 -07:00
Gregory Maxwell
4a8d0f3b10 Merge pull request #1039 from sipa/fix_955 
Fix #955: Verify status of encrypt/decrypt calls to detect failed padding
 2012-04-05 06:17:05 -07:00
Philip Kaufmann
7f10522c43 removed obsolete boost workaround (boost ticket #4258) 2012-04-05 08:34:31 +02:00
Gavin Andresen
5ce4c2a23a Remove USE_SSL #define 2012-04-04 21:19:27 -04:00
Gavin Andresen
723cafcbcf Bug fix listtransactions from/count handling. 2012-04-04 20:56:13 -04:00
Pieter Wuille
e5c027b49b Verify status of encrypt/decrypt calls to detect failed padding 2012-04-05 02:07:53 +02:00
Philip Kaufmann
fc42e9fae2 removed an unused / obsolete tag from bitcoin.qrc 2012-04-05 00:11:22 +02:00
Gavin Andresen
ea8c55cfd7 Enable addmultisigaddress RPC call for main network 2012-04-04 16:01:27 -04:00
Gavin Andresen
f487746ded Remove half-implemented publish/subscribe system 2012-04-04 15:56:00 -04:00
Gavin Andresen
3a8ca61bd0 Add ifdef RELEASE to makefile.osx as the compile-for-older-macs flags 2012-04-04 15:45:31 -04:00
Pieter Wuille
092631f0ba Condition variable for outbound connection slots 
Keep a global counter for nOutbound, protected with its own waitable
critical section, and wait when all outbound slots are filled, rather
than polling.

This removes the (on average) 1 second delay between a lost connection
and a new connection attempt, and may speed up shutdowns.
 2012-04-04 17:24:13 +02:00
Pieter Wuille
712fd182b7 Locking system overhaul, add condition variables 
This commit simplifies the locking system: CCriticalSection becomes a
simple typedef for boost::interprocess::interprocess_recursive_mutex,
and CCriticalBlock and CTryCriticalBlock are replaced by a templated
CMutexLock, which wraps boost::interprocess::scoped_lock.

By making the lock type a template parameter, some critical sections
can now be changed to non-recursive locks, which support waiting via
condition variables. These are implemented in CWaitableCriticalSection
and WAITABLE_CRITICAL_BLOCK.

CWaitableCriticalSection is a wrapper for a different Boost mutex,
which supports waiting/notification via condition variables. This
should enable us to remove much of the used polling code. Important
is that this mutex is not recursive, so functions that perform the
locking must not call eachother.

Because boost::interprocess::scoped_lock does not support assigning
and copying, I had to revert to the older CRITICAL_BLOCK macros that
use a nested for loop instead of a simple if.
 2012-04-04 16:21:08 +02:00
Pieter Wuille
b0a7e05a45 Merge pull request #1019 from laanwj/2012_03_uirefactor 
Streamline UI ↔ Core interface
 2012-04-04 05:03:07 -07:00
Wladimir J. van der Laan
cadae3588c Merge pull request #1025 from Diapolo/GUI-BlockDL 
modified block DL progressbar to be more informative and precise
 2012-04-04 04:36:09 -07:00
Wladimir J. van der Laan
5cccb13dad Move from noui.h / ui.h to one ui_interface.h with dummy implementation for the daemon. 2012-04-04 13:19:30 +02:00
Wladimir J. van der Laan
5a60b66a9d Use a messagebox to display the error when -server is provided without providing a rpc password 2012-04-04 09:37:26 +02:00
Wladimir J. van der Laan
7cfbe1fee4 qtui.h/noui.h interface cleanup 
- rename wxMessageBox, remove redundant arguments to noui/qtui calls
- also, add flag to force blocking, modal dialog box for disk space warning etc
- clarify function naming
- no more special MessageBox needed from AppInit2, as window object is created before calling AppInit2
 2012-04-04 09:37:25 +02:00
Wladimir J. van der Laan
1a3f0da922 support RPC stop and encryptwallet with UI 2012-04-04 09:35:01 +02:00
Wladimir J. van der Laan
5d7cebdadc move translation function _ to qtui.h/noui.h instead of util.h 2012-04-04 09:35:01 +02:00
Wladimir J. van der Laan
6cb6d62347 remove dependency on serialize.h and util.h for SecureString 2012-04-04 09:35:01 +02:00
Wladimir J. van der Laan
f0b5e9e116 remove unused CalledSetStatusBar and UIThreadCall notifications 2012-04-04 09:35:01 +02:00
Wladimir J. van der Laan
98e6175874 Update UI through async calls MainFrameRepaint and AddressBookRepaint instead of a timer. 
- Overall, this is better design
- This fixes problems with the address book UI not updating when the address book is changed through RPC
- Move Statusbar change detection responsibility to ClientModel
 2012-04-04 09:35:01 +02:00
Philip Kaufmann
75b6323200 remove HTML code around "Wallet" (displayed on overview page) and use Qt tags for font settings 2012-04-04 09:07:55 +02:00
Wladimir J. van der Laan
7e7bcce2d9 Code deduplication: make function in GUIUtil to get connection type to call object slot in GUI thread 
with invokeMethod.
 2012-04-04 08:46:12 +02:00
Wladimir J. van der Laan
55f69a4700 move QT_PLUGINS stuff to qt main file, where it belongs 2012-04-04 08:46:12 +02:00
Wladimir J. van der Laan
52d3a48128 VC2010 compile fixes 2012-04-03 20:22:41 +02:00
Philip Kaufmann
853a4a81b3 clarified comment why we use an own progressbar style / included "~" in the tr() call 2012-04-03 09:42:34 +02:00
Philip Kaufmann
ec9a4904f3 changed percentage done in tooltip to float to be more precise / allowed plurals in translation for "x block(s) remaining" 2012-04-03 08:30:13 +02:00
Gregory Maxwell
3263a245bb Merge pull request #1026 from laanwj/2012_04_increase_up_to_date_time 
Increase time ago of last block for "up to date" status from 30 to 90 minutes
 2012-04-02 20:35:44 -07:00
Philip Kaufmann
a7a69cd07a polished code and fixed progress display (was very jerky at the end of a sync) 2012-04-02 23:51:40 +02:00
Philip Kaufmann
e9de46c436 color update for progress bar 2012-04-02 23:48:24 +02:00
Philip Kaufmann
c7c0c93172 implemented OS independent progress bar style / moved one-time functions used on the bar to a better code location 2012-04-02 23:48:23 +02:00
Philip Kaufmann
5519660a0d changed progressbar text to "~n blocks remaining" 2012-04-02 23:48:22 +02:00
Philip Kaufmann
068ed1e838 removed relative progressbar display and moved re-worked network detection code to setNumBlocks() 2012-04-02 23:48:22 +02:00
Philip Kaufmann
9ceae8acea modified block DL progressbar to be dynamic and more precise 2012-04-02 23:48:21 +02:00
Wladimir J. van der Laan
2675fe6218 Increase time ago of last block for "up to date" status from 30 to 90 minutes 
It was too hyperactive.
gmaxwell: I mean that right now when the block gap goes over an hour it starts showing synchronizing. Increasing that to 90 minutes or so would make it only happen about 6.4 times per year
 2012-04-02 20:37:55 +02:00
Gavin Andresen
85ea8b4f43 Merge pull request #951 from TheBlueMatt/headerslimit 
Limit getheaders to a hard 2000.
 2012-04-02 11:22:11 -07:00
Pieter Wuille
91c5132ab5 Merge pull request #998 from Diapolo/transactiontable 
removed an ugly line break in a transaction tooltip
 2012-04-02 07:19:22 -07:00
Pieter Wuille
d3f220b2c2 Merge pull request #1022 from Diapolo/fix#1020 
fix for #1020
 2012-04-02 07:08:14 -07:00
Pieter Wuille
fdef04e77b Merge pull request #995 from Diapolo/master 
fixed typo in comment in netbase.h and bignum.h
 2012-04-02 07:07:48 -07:00
Pieter Wuille
542a1380aa Merge pull request #1006 from Diapolo/tr-tray 
made tray icon tooltip translatable
 2012-04-02 07:07:21 -07:00
Gavin Andresen
f3da2a88c9 Bump version to 0.6.0.99 for 0.6.1 merge window 2012-04-02 10:03:26 -04:00
Philip Kaufmann
b5271c8861 hide Delete button (only) on ReceivingTab / hide Sign message button (only) on SendingTab 2012-04-01 13:22:34 +02:00
Philip Kaufmann
7e05b97229 fixed typo in comment in netbase.h and bignum.h 2012-03-30 07:44:35 +02:00
Gavin Andresen
a1c3d8f14d Merge branch 'master' of github.com:bitcoin/bitcoin 2012-03-29 15:11:04 -04:00
Gavin Andresen
f146061d24 Merge pull request #1010 from sipa/fastblocks2 
Use transactions-updated as flush condition
 2012-03-29 12:10:30 -07:00
Pieter Wuille
25c5eca893 Use transactions-updated as flush condition 
The normal checkpointing during the block chain download is reduced
to every five minutes only, but forced every 200000 updated transactions.
 2012-03-29 21:00:31 +02:00
Gavin Andresen
f3f9da868e Bump version to 0.6.0rc6 2012-03-29 13:58:22 -04:00
Gavin Andresen
6293a9f87f Workaround hangs when upgrading old addr.dat files 2012-03-29 13:34:07 -04:00
Gavin Andresen
83e914c1d5 Merge pull request #1007 from gavinandresen/log_auto_remove 
Auto-remove logs, and decrease logfile size to 10M
 2012-03-29 10:13:42 -07:00
Gavin Andresen
9f18347034 Auto-remove logs, and decrease logfile size to 10M 2012-03-29 09:03:11 -04:00
Philip Kaufmann
3d1d5fafc1 made tray icon tooltip translatable 2012-03-29 07:59:15 +02:00
Philip Kaufmann
0b637e0b86 removed an ugly line break in a transaction tooltip for case TransactionStatus::Mature 2012-03-27 23:20:09 +02:00
Philip Kaufmann
7b2eecd428 update translations from transifex 2012-03-27 10:13:38 +02:00
Gavin Andresen
8d29329f93 Update version to 60005 (0.6.0rc5) 2012-03-26 15:42:06 -04:00
Gavin Andresen
c698633447 Merge branch 'master' of github.com:bitcoin/bitcoin 2012-03-26 15:31:32 -04:00
Gavin Andresen
c289d95d6b Merge pull request #991 from gavinandresen/disableWinURI 
Disable bitcoin: URI handling on Windows for the 0.6 release
 2012-03-26 12:31:06 -07:00
Wladimir J. van der Laan
57de7cd603 Merge pull request #990 from sipa/doc 
Begin doxygen-compatible comments
 2012-03-26 12:27:49 -07:00
Gavin Andresen
bf5b80a8ae Merge branch 'deladdr' of https://github.com/sipa/bitcoin 2012-03-26 14:32:26 -04:00
Pieter Wuille
53cb1a49e7 Use erase instead of rewrite to remove old addr entries 2012-03-26 20:22:38 +02:00
Gavin Andresen
7b90edb5a6 Disable bitcoin: URI handling on Windows for the 0.6 release 2012-03-26 12:18:24 -04:00
Pieter Wuille
6b8de05d0a Begin doxygen-compatible comments 2012-03-26 16:48:23 +02:00
Philip Kaufmann
4004b9a40b make sure Window is shown when clicking bitcoin: Links to get user attention 2012-03-26 09:19:49 +02:00
Pieter Wuille
01a196e08d Merge pull request #974 from sipa/walletupgrade 
Introduce explicit -walletupgrade option
 2012-03-25 19:44:52 -07:00
Pieter Wuille
59e659fcc0 Merge pull request #983 from laanwj/2012_03_removeunusedutil 
Remove unused functions from util.h/util.cpp (EOM)
 2012-03-25 19:31:03 -07:00
Pieter Wuille
bf1afb02ca Give DNS seeds a random age between 3 and 7 days old 
This speeds up initial connections with an old/large addr.dat a lot.
 2012-03-25 16:06:16 +02:00
Wladimir J. van der Laan
a6aee96c7e remove unused functions from util.h/util.cpp 2012-03-25 12:33:30 +02:00
Pieter Wuille
439e1497e1 Introduce explicit -walletupgrade option 
Do not automatically change the wallet format unless the user takes an
explicit action that implies an upgrade (encrypting, for now), or uses
-walletupgrade.

-walletupgrade optionally takes an integer argument: the client version
up to which upgrading is allowed. Without an argument, it is upgraded
to latest supported version. If an argument to -walletupgrade is
provided at the time the wallet is created, the new wallet will initially
not use features beyond that version.

Third, the current wallet version number is reported in getinfo.
 2012-03-22 23:47:29 +01:00
Gavin Andresen
958fe01c32 Merge branch 'checklevel' of https://github.com/sipa/bitcoin 2012-03-22 12:18:56 -04:00
Gavin Andresen
e12d131734 Merge pull request #975 from sipa/versioncheck 
Check minversion before loading the rest of the wallet
 2012-03-22 09:18:11 -07:00
Gavin Andresen
a6b4a11385 Merge branch 'addrman' of https://github.com/sipa/bitcoin 2012-03-22 09:19:01 -04:00
Gavin Andresen
0e894be626 Merge pull request #964 from sipa/fastblocks 
Speed up block downloading
 2012-03-22 06:17:44 -07:00
Gavin Andresen
e53f03172a Merge branch 'master' of github.com:bitcoin/bitcoin 2012-03-22 08:51:37 -04:00
Wladimir J. van der Laan
5cd806a03e Merge pull request #969 from laanwj/2012_03_printconsole_error 
replace call to PrintConsole with call to error()
 2012-03-21 23:42:20 -07:00
Pieter Wuille
ef12c2184d Check minversion before loading the rest of the wallet 
When a 0.6 wallet with compressed pubkeys is created, it writes a
minversion record to prevent older clients from reading it. If the 0.5
loading it sees a key record before seeing the minversion record however,
it will fail with DB_CORRUPT instead of DB_TOO_NEW.
 2012-03-22 04:59:59 +01:00
Pieter Wuille
4538e45c46 Add -checklevel and improve -checkblocks 
-checkblocks now takes a numeric argument: the number of blocks that must
be verified at the end of the chain. Default is 2500, and 0 means all
blocks.

-checklevel specifies how thorough the verification must be:
0: only check whether the block exists on disk
1: verify block validity (default)
2: verify transaction index validity
3: check transaction hashes
4: check whether spent txouts were spent within the main chain
5: check whether all prevouts are marked spent
6: check whether spent txouts were spent by a valid transaction that consumes them
 2012-03-22 03:19:23 +01:00
Gavin Andresen
8f188ece3c Remove -bip16 and -paytoscripthashtime command-line arguments 2012-03-21 15:45:58 -04:00
Wladimir J. van der Laan
4a43dfbf3e replace call to PrintConsole with call to error() 
As these are equivalent functions, this cleans up the source a bit.
Also remove PrintConsole() as this was the only use.
 2012-03-21 20:33:53 +01:00
Gavin Andresen
2e2c04e250 Merge pull request #947 from ali1234/master 
When disconnecting a node, the receive buffer should be cleared
 2012-03-21 12:24:57 -07:00
Gavin Andresen
b2fe3a5ca6 Merge pull request #948 from sipa/unstuck 
Prevent stuck block download in large reorganisations
 2012-03-21 12:16:28 -07:00
Gavin Andresen
c2b1ab072c Merge pull request #965 from khorben/master 
The generic UNIX Makefile builds with lots of warnings
 2012-03-21 07:45:49 -07:00
Pieter Wuille
a1a0469f91 More debug output for failed reorganizations 2012-03-21 13:15:27 +01:00
Michael
246c20e8a9 Correct date 2012-03-21 15:56:38 +08:00
Wladimir J. van der Laan
4046bdf18a Merge pull request #954 from Diapolo/master 
language updates for source file bitcoin_en.ts + remove cs_CZ (issue #958)
 2012-03-21 00:18:58 -07:00
Pieter Wuille
0aa89c08ff Prevent stuck block download in large reorganisations 
In cases of very large reorganisations (hundreds of blocks), a situation
may appear where an 'inv' is sent as response to a 'getblocks', but the
last block mentioned in the inv is already known to the receiver node.
However, the supplying node uses a request for this last block as a
trigger to send the rest of the inv blocks. If it never comes, the block
chain download is stuck.

This commit makes the receiver node always request the last inv'ed block,
even if it is already known, to prevent this problem.
 2012-03-21 05:09:02 +01:00
Pieter Wuille
89516bd4e0 Speed up block downloading 2012-03-21 01:32:00 +01:00
Pierre Pronchery
7868808b2f Avoid some pointless warnings while compiling 2012-03-21 00:08:19 +01:00
Gavin Andresen
eae82d8ee5 Use last checkpoint instead of hard-coded 140,700. Fixes #913. 2012-03-20 13:45:45 -04:00
p2k
3f1bb1ac78 Proper support for Growl 1.3 notifications 2012-03-20 12:54:51 -04:00
Pieter Wuille
9aa459b294 assertion in CBlock::SetBestChainInner was too strong 2012-03-20 16:41:36 +01:00
Philip Kaufmann
d6b08f6f2c remove bitcoin_cs_CZ from bitcoin.qrc and delete bitcoin_cs_CZ.ts 2012-03-20 09:07:05 +01:00
Philip Kaufmann
603061a7e5 updated english language source file via lupdate 2012-03-19 14:08:41 +01:00
Nils Schneider
4ac3eea027 Merge pull request #953 from Diapolo/master 
german translation update
 2012-03-19 05:13:08 -07:00
Philip Kaufmann
8afd4699e6 fixed a capitalization error in the german translation 2012-03-19 10:28:10 +01:00
Philip Kaufmann
7c4fabde60 update german translation from transifex 2012-03-19 09:21:11 +01:00
Wladimir J. van der Laan
bd9c6f88be Merge pull request #928 from jojkaart/master 
Make send coins dialog honor the configured unit type even on the first attempt.
 2012-03-19 01:08:43 -07:00
Matt Corallo
ecf07f2729 Limit getheaders to a hard 2000. 
Previously getheaders would return any number of headers up to
2000 + the distance the locator parameter was back (which is up to
~ the number of items in the locator ^ 2).

The only client I was able to find which actually handles the headers
message is BitcoinJ, and it clearly expects no more than 2000 headers
See:
http://code.google.com/p/bitcoinj/source/browse/core/src/main/java/com/google/bitcoin/core/HeadersMessage.java#35

Additionally, the wiki clearly states that getheaders will only ever
return 2000 headers: https://en.bitcoin.it/wiki/Network#Messages
 2012-03-19 00:13:15 -04:00
Gregory Maxwell
0b99d1b574 Merge pull request #931 from luke-jr/dbg_loaderr 
Wallet loading diagnostic prints to debug.log
 2012-03-18 20:11:09 -07:00
Joel Kaartinen
aa3d4c0221 Make the sendcoins dialog use the configured unit type, even on the first attempt. 2012-03-18 23:04:17 +02:00
Alistair Buxton
bb13d056ea When disconnecting a node, clear the received buffer so that we do 
not process any already received messages.

The primary reason to do this is if a node spams hundreds of messages
and we ban them, we don't want to continue processing the rest of it.
 2012-03-18 03:03:24 +00:00
Philip Kaufmann
652856fb63 update german translation from transifex 2012-03-17 00:48:03 +01:00
Gregory Maxwell
44b69cf25e Bump CLIENT_VERSION for rc4 release 2012-03-16 15:08:57 -04:00
Nils Schneider
98ff031eb8 update translations from transifex 2012-03-16 19:05:25 +01:00
Wladimir J. van der Laan
08ed96d856 Yet another attempt at implementing "minimize to tray" that works on all OSes 2012-03-16 08:17:11 +01:00
Gavin Andresen
e318b99d99 Bump CLIENT_VERSION for rc3 release 2012-03-13 09:31:37 -04:00
Pieter Wuille
d68dcf741e Limit the impact of reorganisations on the database 
Sometimes a new block arrives in a new chain that was already the
best valid one, but wasn't marked that way. This happens for example
when network rules change to recover after a fork.

In this case, it is not necessary to do the entire reorganisation
inside a single db commit. These can become huge, and exceed the
objects/lockers limits in bdb. This patch limits the blocks the
actual reorganisation is applied to, and adds the next blocks
afterwards in separate db transactions.
 2012-03-12 20:31:56 +01:00
Luke Dashjr
3cc0624932 Print more diagnostic info for the various DB_CORRUPT conditions 2012-03-12 14:01:15 -04:00
Luke Dashjr
21e875c958 Print wallet load errors (to debug.log) 2012-03-11 17:57:47 -04:00
Gregory Maxwell
82a10c8170 Resolves issue #922 - "wallet passphrase timeout of several years doesn't work" 
2^31 milliseconds is only about 25 days. Also clamps Sleep() to 10 years,
because it currently sleeps for 0 seconds when the sleep time would cross
2^31 seconds since the epoch. Hopefully boost will be fixed by 2028.
 2012-03-10 17:38:37 -05:00
nomnombtc
f8c478c4fb fix typo src/net.cpp 2012-03-05 19:33:24 +01:00
Pieter Wuille
a206b0ea12 Do not allow overwriting unspent transactions (BIP 30) 
Introduce the following network rule:
 * a block is not valid if it contains a transaction whose hash
   already exists in the block chain, unless all that transaction's
   outputs were already spent before said block.

Warning: this is effectively a network rule change, with potential
risk for forking the block chain. Leaving this unfixed carries the
same risk however, for attackers that can cause a reorganisation
in part of the network.

Thanks to Russell O'Connor and Ben Reeves.
 2012-03-03 18:26:36 +01:00
Gavin Andresen
142e604184 DoS fix for mapOrphanTransactions 2012-02-29 11:46:46 -05:00
Gavin Andresen
722d9387be Merge branch 'mruinventory' of https://github.com/sipa/bitcoin 2012-02-28 11:48:44 -05:00
Gavin Andresen
6dd5ae41ac Merge branch '2012_02_getspecialfolderpath_overflow' of https://github.com/laanwj/bitcoin 2012-02-28 11:45:14 -05:00
Michael Ford
27adfb2e0c "February" 2012-02-28 20:31:56 +08:00
Gavin Andresen
07ed49a472 Do not start bitcoin: thread on OSX. fixes #889 2012-02-27 16:08:08 -05:00
Gavin Andresen
21503e4556 Merge branch 'nodosbip16' of https://github.com/sipa/bitcoin 2012-02-27 15:47:27 -05:00
Pieter Wuille
c4341fa6ab Add mruset and use it for setInventoryKnown 2012-02-27 21:04:32 +01:00
Gavin Andresen
46aa2a6bdd Move BIP16 switchover time to April 1 2012-02-27 11:41:20 -05:00
Gavin Andresen
90d78142c0 Merge branch 'nooptionsinwallet+fixproxysetting' of https://github.com/sipa/bitcoin 2012-02-27 11:30:05 -05:00
Wladimir J. van der Laan
fbbd42a535 Merge pull request #853 from laanwj/2012_02_altminimizetray 
Yet another alternative "minimize to tray" implementation

Fixes problems with window positioning.
 2012-02-26 22:27:25 -08:00
Pieter Wuille
42c8b56f62 Store addrProxy port in settings 2012-02-26 23:39:32 +01:00
Gavin Andresen
3f8cb2c565 Reworked QT settings 2012-02-26 23:38:28 +01:00
Gavin Andresen
972060ce0e bitcoind changes to stop storing settings in wallet.dat. 2012-02-26 23:21:33 +01:00
Wladimir J. van der Laan
21ae37d215 Simplify MyGetSpecialFolderPath and fix possible buffer overflow (#901) 2012-02-26 17:11:38 +01:00
Pieter Wuille
88c41c43ea Move 'Backup Wallet' to file menu 2012-02-26 03:04:25 +01:00
Pieter Wuille
4a10d4c6dc Fix addrProxy setting 
Before 0.6 addrProxy was a CAddress, but netbase changed it to CService.
Retain compatibility by wrapping/unwrapping with a CAddress when saving
or loading.

This commit retains compatibility with 0.6.0rc1 (which wrote the setting
as a CService) by trying to parse twice.
 2012-02-25 21:13:34 +01:00
Wladimir J. van der Laan
da9ab62fb7 Merge pull request #897 from laanwj/2012_02_fixnegativesecs 
In UI, handle cases in which the last received block was generated in the future
 2012-02-25 10:14:37 -08:00
Wladimir J. van der Laan
71ba9abba6 In UI, handle cases in which the last received block was generated in the future (secs<0) 
Fixes #874.
 2012-02-25 19:11:25 +01:00
Pieter Wuille
db9f2e0117 Do not invoke anti-DoS system for invalid BIP16 transactions 
Doing so would allow an attack on old nodes, which would relay a
standard transaction spending a BIP16 output in an invalid way,
until reaching a new node, which will disconnect their peer.

Reported by makomk on IRC.
 2012-02-25 19:05:50 +01:00
Chris Moore
ec4efde40c Add option "-splash" so we can disable the splash screen. 
Don't show splash screen when -min is specified on the command line.
 2012-02-24 19:17:22 -08:00
Pieter Wuille
5fee401fe1 CAddrMan: stochastic address manager 
Design goals:
 * Only keep a limited number of addresses around, so that addr.dat does not grow without bound.
 * Keep the address tables in-memory, and occasionally write the table to addr.dat.
 * Make sure no (localized) attacker can fill the entire table with his nodes/addresses.

See comments in addrman.h for more detailed information.
 2012-02-24 13:41:04 +01:00
Gavin Andresen
8c12851ed4 Checkpoint block 168,000 2012-02-23 13:33:30 -05:00
Gavin Andresen
fc4f4c2e9a Merge branch 'getblock_cleanup' of https://github.com/luke-jr/bitcoin 2012-02-23 12:41:26 -05:00
Luke Dashjr
34f8788915 Cleanup JSON-RPC getblock output to be consistent 
- Add "size" and "bits"
- Rename "blockcount" to "height"
- Rename "hashprevious" and "hashnext" to "previousblockhash" and "nextblockhash" (respectively)
 2012-02-22 12:31:28 -05:00
Gavin Andresen
5c03282521 Merge branch 'testnetirc' of https://github.com/sipa/bitcoin 2012-02-22 11:26:19 -05:00
Gavin Andresen
6fe8c45375 Merge branch 'fixnullpfrom' of https://github.com/sipa/bitcoin 2012-02-22 11:25:08 -05:00
Gavin Andresen
e7e6ae2104 Merge branch 'postfeb20' of https://github.com/sipa/bitcoin 2012-02-22 11:06:44 -05:00
Gavin Andresen
8c7358e1dd Merge branch 'reorginfo' of https://github.com/sipa/bitcoin 2012-02-22 11:03:19 -05:00
Gavin Andresen
e1bad25fee Merge branch 'fix_616' of https://github.com/sipa/bitcoin 2012-02-22 11:00:38 -05:00
Gavin Andresen
de737806b5 Merge branch 'fix_626' of https://github.com/sipa/bitcoin 2012-02-22 10:52:14 -05:00
Gavin Andresen
1af97c95f3 Merge branch 'bugfix_bip14_ez' of https://github.com/luke-jr/bitcoin 2012-02-22 10:44:44 -05:00
Gavin Andresen
f246fc648a Merge branch '201202_guiaddsuffix' of https://github.com/laanwj/bitcoin 2012-02-22 10:41:11 -05:00
Luke Dashjr
c170d03e03 Bugfix: Instead of reporting "bitcoin-qt" for both bitcoind and Bitcoin-Qt, report "Satoshi" which is at least correct 2012-02-22 10:36:19 -05:00
Pieter Wuille
92d5864b80 Leave IRC enabled by default on testnet 
As testnet has neither DNS seeds or built-in seed addresses to
bootstrap from.
 2012-02-22 05:19:09 +01:00
Pieter Wuille
18c0fa97d0 Post-feb20 simplifications 
Now the entire network upgraded to (initial) protocol version 209,
crtainl simplifications in the source code are possible.
 2012-02-21 20:46:39 +01:00
Pieter Wuille
73aa0421a7 ProcessBlock is sometimes called with pfrom==NULL 2012-02-20 22:35:08 +01:00
Pieter Wuille
0d56f11ada Fix tests after 38067c18 2012-02-20 18:32:33 +01:00
Wladimir J. van der Laan
f7b8f824de Merge pull request #857 from laanwj/2012_02_fixhelpwindow 
On windows, show message box with help, as there is no stderr (fixes #702)
 2012-02-20 08:56:41 -08:00
Wladimir J. van der Laan
7b88a61706 Merge pull request #858 from laanwj/2012_02_uisendlabelfix 
Only fill in label from address book if no label is filled in yet (fixes #840)
 2012-02-20 08:55:49 -08:00
Luke Dashjr
5a5cc6ac09 Sign message description changes discussed in #bitcoin-dev 2012-02-19 22:36:59 -05:00
Pieter Wuille
9fa042a96c Typo fix 2012-02-20 04:17:00 +01:00
Pieter Wuille
3a4d81724e Merge pull request #864 from sipa/fix_856 
Make compressed pubkeys require client >=0.5.99
 2012-02-19 18:21:19 -08:00
Pieter Wuille
49355d9993 Merge pull request #868 from sipa/fix_650 
Fix #650: CKey::SetSecret BIGNUM leak
 2012-02-19 18:04:46 -08:00
Wladimir J. van der Laan
8a949dd6c3 Merge pull request #867 from laanwj/2012_02_hidetrayicononquit 
Hide tray icon in destructor, as deleting will let it linger until quit (on ubuntu)
 2012-02-19 11:30:32 -08:00
Pieter Wuille
ceaa13eff2 Report number of (dis)connected blocks in reorganization 
Also report old and new best, and fork point.
 2012-02-19 20:06:04 +01:00
Pieter Wuille
46245b4782 Fix #616: remove base_uint::operator&=(uint64 b) 2012-02-19 19:12:41 +01:00
Pieter Wuille
a3342d096f Fix #626: RecvLine wrong error message 
Also moved RecvLine to net.cpp.
 2012-02-19 19:06:42 +01:00
Pieter Wuille
a09f101f14 Fix #650: CKey::SetSecret BIGNUM leak 2012-02-19 18:45:56 +01:00
Pieter Wuille
e0b8d459b1 Merge pull request #863 from sipa/bn2mpifix 
Workaround for BN_bn2mpi reading/writing out of bounds
 2012-02-19 09:22:11 -08:00
Pieter Wuille
59b1b181e9 Merge pull request #865 from sipa/del_pwalletdb 
Free pwalletdbEncryption after encryping wallet
 2012-02-19 09:05:40 -08:00
Wladimir J. van der Laan
27a0ed8a0a Hide tray icon in destructor, as deleting will let it linger until quit (on Ubuntu) 2012-02-19 12:07:07 +01:00
Pieter Wuille
fcfd7ff8f8 Free pwalletdbEncryption after encryping wallet 
Fixes a memory leak.
 2012-02-18 15:44:34 +01:00
Pieter Wuille
38067c18f8 Make compressed pubkeys require 0.6.0 2012-02-18 15:42:38 +01:00
Pieter Wuille
9976cf070f Move GenerateNewKey back to CWallet 2012-02-18 15:42:38 +01:00
Pieter Wuille
0b807a417f Add SetMinVersion to CWallet 2012-02-18 15:42:29 +01:00
Pieter Wuille
e9a041c536 Merge pull request #862 from TheBlueMatt/warnings 
Fix compilation warning.
 2012-02-18 04:56:58 -08:00
Pieter Wuille
a06113b0c5 Workaround for BN_bn2mpi reading/writing out of bounds 
When OpenSSL's BN_bn2mpi is passed a buffer of size 4, valgrind
reports reading/writing one byte past it. I am unable to find
evidence of this behaviour in BN_bn2mpi's source code, so it may
be a spurious warning. However, this change is harmless, as only
the bignum with value 0 results in an mpi serialization of size 4.
 2012-02-18 13:32:25 +01:00
Wladimir J. van der Laan
2d36b60f92 Merge pull request #859 from laanwj/2012_02_guilanguagearg 
Make it possible to set UI language from commandline (implements #678)
 2012-02-18 01:33:56 -08:00
Matt Corallo
db1a5609a0 Fix compilation warning. 2012-02-18 01:22:22 -05:00
Wladimir J. van der Laan
17690ea5a7 Do show/showNormal only when needed. 2012-02-17 23:19:52 +01:00
Wladimir J. van der Laan
328512876a Merge pull request #854 from laanwj/2012_02_qtipc 
Restructure IPC URL handling (fixes #851)
 2012-02-17 12:54:07 -08:00
Gavin Andresen
d3a4b85670 Merge branch 'nolisten_bitcoin_conf_2' of https://github.com/dooglus/bitcoin 2012-02-17 13:50:40 -05:00
Gavin Andresen
0a6b081cca Merge branch 'testnetmining' of github.com:gavinandresen/bitcoin-git 2012-02-17 13:48:01 -05:00
Gavin Andresen
25bc37f8a2 Merge branch 'threadid' of https://github.com/sipa/bitcoin 2012-02-17 13:40:42 -05:00
Wladimir J. van der Laan
ec2ed58232 Merge pull request #834 from sje397/BackupWallet 
Added 'Backup Wallet' menu option to GUI
 2012-02-17 10:30:15 -08:00
Wladimir J. van der Laan
72075edafb Allow setting UI language from commandline (implements #678) 2012-02-17 18:47:31 +01:00
Wladimir J. van der Laan
f9f75f320e Only fill in label from address book, if no label is filled in yet, fixes #840 2012-02-17 18:25:14 +01:00
Wladimir J. van der Laan
a3f3e54eee Change #ifdef GUI to #ifdef QT_GUI, GUI is not defined anymore... 2012-02-17 18:01:01 +01:00
Wladimir J. van der Laan
bc5e6b9f21 On windows, show message box with help, as there is no stderr (fixes #702) 2012-02-17 17:55:46 +01:00
Wladimir J. van der Laan
83d1d1a906 Hide window from taskbar when "minimize to tray" active by making window into Tool window 2012-02-17 17:14:02 +01:00
Wladimir J. van der Laan
23b3cf9d10 Restructure IPC URL handling (fixes #851) 2012-02-17 15:32:51 +01:00
Wladimir J. van der Laan
39231e9105 don't allow -daemon in bitcoin-qt (changes only #defines) 2012-02-17 14:47:56 +01:00
Wladimir J. van der Laan
d3896211d2 fix typo in CNetAddr::IsRFC4843() (fixes #850) 2012-02-17 14:40:21 +01:00
Chris Moore
d64e124cf4 Fix #846. Allow negative options such as "nolisten=1" in bitcoin.conf as well as on the command line. 2012-02-16 12:08:58 -08:00
Gavin Andresen
0f8cb5db73 Fix issue #848 : broken mining on testnet 2012-02-16 11:37:54 -05:00
Pieter Wuille
b7c25e0c13 Merge pull request #843 from TheBlueMatt/qrcodedoc 
Fix one compile-time warning and fix libqrcode linking in releases
 2012-02-16 03:50:59 -08:00
Pieter Wuille
c59881eaee Symbolic names for threads 
Introduce an enum threadId, and use symbolic indices when accessing
vnThreadsRunning.
 2012-02-16 12:43:06 +01:00
Pieter Wuille
999b4cacaf Merge pull request #844 from sipa/shutdownfix 
Several shutdown-related fixes
 2012-02-16 03:34:11 -08:00
Pieter Wuille
2030fc6bc2 Merge pull request #842 from sipa/checkaf 
Do not create CAddress for invalid accepts
 2012-02-16 03:31:14 -08:00
Pieter Wuille
711d5038f5 Merge pull request #828 from sipa/fixwalletlock 
Fix wallet locking locking
 2012-02-16 03:30:26 -08:00
Matt Corallo
7dcd200489 Properly include $*_LIB_PATH in makefile.unix 2012-02-15 16:39:02 -05:00
Matt Corallo
32af6b16f1 Fix compilation warning. 2012-02-15 16:38:57 -05:00
Pieter Wuille
cc201e01f8 Several shutdown-related fixes 
* do not let vnThreadsRunning[1] go negative
* do not perform locking operations while vnThreadsRunning[1] is decreased
* check vnThreadsRunning[1] at exit
 2012-02-15 21:17:15 +01:00
Pieter Wuille
25ab17585e Bugfix: do not create CAddress for invalid accepts 2012-02-15 20:56:29 +01:00
Wladimir J. van der Laan
303a47c095 fix default suffixes in save dialog in GNOME, make it more clear that PNG is used (solves #833) 2012-02-15 17:22:00 +01:00
Wladimir J. van der Laan
c85c37acb1 increase BitcoinAddressValidator::MaxAddressLength from 34 to 35 
needed for sending BIP16 transactions on test network through GUI
 2012-02-15 17:09:47 +01:00
sje397
4efbda3f25 Added 'Backup Wallet' menu option 
- icon from the LGPL Nuvola set (like the tick) - http://www.icon-king.com/projects/nuvola/
- include 'boost/version.hpp' in db.cpp so that the overwrite version of copy can be used
- catch exceptions in BackupWallet (e.g. filesystem_error thrown when trying to overwrite without the overwrite flag set)
- include db.h in walletmodel.cpp for BackupWallet function
- updated doc/assets-attribution.txt and contrib/debian/copyright with copyright info for new icon
 2012-02-15 23:29:59 +11:00
Wladimir J. van der Laan
1df182ff88 (trivial) regularize coding style 2012-02-15 13:14:16 +01:00
Wladimir J. van der Laan
15b87b2ec4 Merge pull request #807 from TheBlueMatt/bip21 
Add req- prefixes to comply with BIP21.
 2012-02-12 05:52:34 -08:00
Wladimir J. van der Laan
d27b4576f3 Add export action to file menu (as long as we have a file menu, export certainly should be there) 2012-02-12 12:54:33 +01:00
Wladimir J. van der Laan
2aa3429899 Merge pull request #826 from laanwj/2012_02_fixminimizetotray 
Fix Minimize to the tray instead of the taskbar (rework)
 2012-02-12 01:49:18 -08:00
gmaxwell
9f3de58d83 Merge pull request #817 from TheBlueMatt/dpiversionfix 
Get ext. IP from UPnP, make sure addrMe IsRoutable() in version.
 2012-02-11 15:14:02 -08:00
Pieter Wuille
7c39b56c3b Merge pull request #827 from sipa/fixencrypt 
Fix wallet encryption with compressed pubkeys
 2012-02-11 15:02:05 -08:00
Pieter Wuille
aa625ed6ed Extra wallet locking fixes 
* Fix sign error in calculation of seconds to sleep
* Do not mix GetTime() (seconds) and Sleep() (milliseconds)
* Do not sleep forever if walletlock() is called
* Do locking within critical section
 2012-02-11 21:59:39 +01:00
Pieter Wuille
b0529ffd95 Fix wallet locking locking 2012-02-11 21:59:39 +01:00
Pieter Wuille
88bc5f9485 Macros for manual critical sections 2012-02-11 21:59:33 +01:00
Janne Pulkkinen
6af93ee2ea Fix Minimize to the tray instead of the taskbar 2012-02-11 18:24:49 +01:00
Pieter Wuille
cd5ee3bbb4 Fix wallet encryption with compressed pubkeys 2012-02-11 16:42:44 +01:00
Pieter Wuille
402deef944 Fix #822 2012-02-11 15:25:42 +01:00
Matt Corallo
245484679a Add Bitcoin-Qt test suite with some bitcoin: URL Tests to start. 2012-02-10 17:47:00 -05:00
Matt Corallo
cce89ead18 Add -req prefixes to comply with BIP21. 2012-02-10 17:44:52 -05:00
Wladimir J. van der Laan
26d9e2c19d Merge pull request #818 from laanwj/2012_02_win32_qtaccessible 
Enable accessible widgets Qt module on win32
 2012-02-10 09:31:21 -08:00
Wladimir J. van der Laan
2e5a781c64 Enable accessible widgets Qt module on win32, so that people with screen readers such as NVDA can make sense of it. 2012-02-10 08:28:32 +01:00
Matt Corallo
baba6e7de2 Get ext. IP from UPnP, make sure addrMe IsRoutable() in version. 
This fixes a potential bug where some NATs may replace the node's
interal IP with its external IP in version messages, causing
incorrect checksums when version messages begin being checksummed
on February 14, 2012.
 2012-02-10 00:54:11 -05:00
Chris Moore
74f28bf1fd Fix #794. Only remove transactions from memory pool when they're actually in the memory pool. 2012-02-09 05:21:41 -08:00
Gavin Andresen
882164196e Update all copyrights to 2012 2012-02-07 11:28:30 -05:00
Gavin Andresen
6bf4253a68 Increase client version to 0.6 2012-02-07 11:22:09 -05:00
Gavin Andresen
9d952d17bb Look for flushwallet/listen/irc/dnsseed/upnp instead of noflushwallet/etc. And switch default for irc to 0. 2012-02-07 09:14:31 -05:00
Gavin Andresen
3ad9f8a70f New GetArg features: allow --, and booleans can be -foo or -nofoo 2012-02-07 09:14:31 -05:00
Gavin Andresen
3ae0735553 Unit tests for the GetArg() methods 2012-02-07 09:14:31 -05:00
Gavin Andresen
0b452dff5e Merge branch 'standardScriptSigs' of github.com:gavinandresen/bitcoin-git 2012-02-07 09:04:56 -05:00
Gavin Andresen
7bf8b7c25c -bip16 option (default: 1) to support / not support BIP 16. And bumped default BIP16 switchover date from Feb 15 to Mar 1 2012-02-06 16:27:05 -05:00
Gavin Andresen
0b9a05a2bc Merge branch 'rpcpassword' of https://github.com/gmaxwell/bitcoin 2012-02-06 15:10:30 -05:00
Gavin Andresen
30999ec6f9 Merge branch 'decomposetransfix' of https://github.com/laanwj/bitcoin 2012-02-06 14:50:59 -05:00
Wladimir J. van der Laan
ab07866c8d Restructure credit transaction decomposition (solves issue #689) 
When a transaction has multiple outputs that go to the wallet, list these
as multiple transactions in the UI. This is also applied to generated
(coinbase) transactions. Also makes the code shorter and easier
to understand.
 2012-02-06 18:13:01 +01:00
Nils Schneider
9d4b05c0dc fetch translations from transifex 
* fixes issue #742
* new translations: cs_CZ fa fi fr_FR hr pl ro_RO sv tr
 2012-02-05 16:40:27 +01:00
Wladimir J. van der Laan
f69b82e78a Change up/down increment in UI to 0.001 BTC (issue #760) 2012-02-05 12:15:16 +01:00
Gregory Maxwell
b04f301c8e Have bitcoind recommend a secure RPC password. Increase invalid password delay. 
Help users avoid insecure configurations a bit by recommending a
secure RPC password and increasing the incorrect password delay.

This may open up a RPC DOS for users with exposed RPC ports and
short passwords. Since users shouldn't have exposed RPC ports OR
short passwords, the DOS risk is preferable to the compromise
risk.

Also logs the client IP address for incorrect attempts.
 2012-02-05 02:58:35 -05:00
Gregory Maxwell
5d1b8f1725 Avoid advertising the node's address when it is not listening or IsInitialBlockDownload(). 
This also avoids flushing setAddrKnown until 24 hours has passed,
and avoids contacting the external IP services when not listening.

Advertising non-listening nodes is just addr message spam.
It doesn't help the network, in fact it hurts the network,
and it also hurts user's privacy.

Advertising far out of sync nodes doesn't help the network—
they can't even forward (most) transactions and wastes nodes
outbound slots.
 2012-02-01 18:08:03 -05:00
Wladimir J. van der Laan
d2291cce92 Remove loose amp; from Portugese translation (issue #701) 2012-02-01 20:14:13 +01:00
Gavin Andresen
8beb917c6c Allow -upnp to override setting in wallet (and simplify logic a bit) 2012-02-01 13:24:15 -05:00
Matt Corallo
177dbcaace Fix UPnP by reannouncing every 20 minutes. 2012-01-31 17:42:15 -05:00
Gavin Andresen
c52296a73e Testnet difficulty calculation changes, to take effect Feb 15 2012 
Allow mining of min-difficulty blocks if 20 minutes have gone by without mining a regular-difficulty block.
Normal rules apply every 2016 blocks, though, so there may be a very-slow-to-confirm block at the difficulty-adjustment blocks.
 2012-01-31 13:20:01 -05:00
Gavin Andresen
4477b17f15 Merge branch 'checkkeys' of https://github.com/sipa/bitcoin 2012-01-31 12:19:26 -05:00
Gavin Andresen
68649bef93 CreateNewBlock was not adding in transaction fees. 2012-01-28 10:16:21 -05:00
Luke Dashjr
2bc4fd609c Bitcoin-Qt signmessage GUI (pull request #582) 2012-01-27 08:41:55 +01:00
Pieter Wuille
91f43a33f8 Full checking of all loaded keys 2012-01-26 19:26:43 +01:00
Wladimir J. van der Laan
70f55355e2 Merge pull request #593 (Full URL Support in bitcoin-qt) 2012-01-26 19:00:02 +01:00
Gavin Andresen
4c932cca6f Merge pull request #782 from sipa/checkkeys 
Check consistency of private keys
 2012-01-25 05:43:44 -08:00
Gavin Andresen
b6a35d2d52 Merge pull request #773 from gavinandresen/p2shSigOpCount 
Simplify counting of P2SH sigops to match BIP 16
 2012-01-25 05:21:20 -08:00
Pieter Wuille
b25cc627a3 Check consistency of private keys 
Reported by onlineproof on IRC: Bitcoin does not verify whether private
keys and public keys correspond, when loading a wallet.
 2012-01-25 03:05:16 +01:00
Gavin Andresen
341519523f Support makefile.osx building test_bitcoin with dynamic boost 2012-01-23 15:58:06 -05:00
Gavin Andresen
2a9b46cf4b Merge branch 'bugfix_shared_boost_test' of https://github.com/luke-jr/bitcoin 2012-01-23 15:16:59 -05:00
Luke Dashjr
34c69036da Rename src/obj/test to src/obj-test to workaround bug in older GNU Make 2012-01-23 14:27:08 -05:00
Gavin Andresen
a702ceaafc Merge branch 'lockcontention' of https://github.com/TheBlueMatt/bitcoin 2012-01-23 13:15:43 -05:00
Gavin Andresen
b8056dc5d0 Merge branch 'bugfix_areinpstd' of https://github.com/luke-jr/bitcoin 2012-01-23 13:09:34 -05:00
Gavin Andresen
149f580c82 Only store transactions with missing inputs in the orphan pool. 
All previous versions of bitcoin could store some types of
invalid transactions in the orphan-transaction list.
 2012-01-23 12:54:32 -05:00
Gavin Andresen
dc77dce07c Fixed addmultisigaddress if looking up public keys from locked wallets. 2012-01-23 12:04:34 -05:00
Luke Dashjr
ca9afa8401 Bugfix: Support building test_bitcoin with shared-object boost test framework 2012-01-23 11:37:48 -05:00
Matt Corallo
198fb229a4 Add DEBUG_LOCKCONTENTION, to warn each time a thread waits to lock. 
If compiled with -DDEBUG_LOCKCONTENTION, Bitcoin will print to
debug.log each time a thread has to wait for a lock to continue.
 2012-01-21 16:16:28 -05:00
Luke Dashjr
575bdcde93 Sanitize AreInputsStandard slightly 
Correct comment for why the check is unnecessary for coinbases
Move testnet check out, to AcceptToMemoryPool where everything else checks it
 2012-01-20 21:00:08 -05:00
Gavin Andresen
137d0685a4 Simplify counting of P2SH sigops to match BIP 16 (thanks to Matt Corallo for prompting this). 
This also removes an un-needed sigops-per-byte check when accepting transactions to the memory pool (un-needed assuming only standard transactions are being accepted). And it only counts P2SH sigops after the switchover date.
 2012-01-20 17:07:40 -05:00
Gavin Andresen
1240a1b0a8 Back out spacing changes to json spirit code 2012-01-19 14:32:45 -05:00
Gavin Andresen
7012b124bc Merge branch 'updateseednodes' of https://github.com/nanotube/bitcoin 2012-01-19 14:23:49 -05:00
Gavin Andresen
c55fd06b99 Merge branch 'tabs-to-space' of https://github.com/larsr/bitcoin 2012-01-19 14:22:26 -05:00
Gavin Andresen
aacefd2795 Merge branch 'getmemorypool_blockflagstime' of https://github.com/forrestv/bitcoin 2012-01-19 14:14:41 -05:00
Gavin Andresen
39f0d96860 Make transactions with extra data in their scriptSig's non-standard. 2012-01-19 13:30:54 -05:00
Daniel Folkinshteyn
b2f76e9ded Update seednodes, pick long-uptime nodes with version >= 0.4.0 2012-01-19 01:54:14 -05:00
Wladimir J. van der Laan
06706ab8ef Remove erroneous ":" in front of port in options dialog (introduced with network refactor) 2012-01-17 09:34:24 +01:00
Wladimir J. van der Laan
be4d08b261 fix the build (port IP validation in options to network refactoring) 2012-01-17 09:27:03 +01:00
Wladimir J. van der Laan
b2a967cd0b Revert to global progress indication (see #753) 2012-01-17 09:19:58 +01:00
Pieter Wuille
c981d768b3 Fix handling of default ports 2012-01-17 02:12:35 +01:00
Gavin Andresen
8498c59144 Merge branch 'keepnode' of https://github.com/TheBlueMatt/bitcoin 2012-01-16 16:45:43 -05:00
Forrest Voight
ab84512258 Added mintime and curtime to RPC getmemorypool 2012-01-14 19:23:37 -05:00
Forrest Voight
52a3d2635c Separated COINBASE_FLAGS out into main.h and made RPC getmemorypool return it 2012-01-14 19:22:24 -05:00
Janne Pulkkinen
29b7273153 *Clear all has a tooltip now *About dialog updated 2012-01-14 21:31:49 +02:00
Lars Rasmusson
b985efaac1 Replace tabs with four spaces to comply with coding standard in doc/coding.txt 2012-01-14 12:14:36 +01:00
Gavin Andresen
9e8818ec9d Remove base58 encoding from validateaddress/addmultisigaddress 
base58-encoding of full/compressed public keys needs more thought; it probably makes sense to define a base58 encoding that includes a version byte and a checksum. So just support hex and bitcoin-address encodings for now.
 2012-01-13 10:22:24 -05:00
Gavin Andresen
4063460534 Refactor: needing to call ConnectInputs to process coinbase transactions was counter-intuitive 2012-01-13 10:22:24 -05:00
Gavin Andresen
8d7849b6db Refactored ConnectInputs, so valid-transaction-checks are done before ECDSA-verifying signatures. 2012-01-13 10:22:24 -05:00