Russell Yanofsky
654e0443fb
[trivial] Add comment documenting CWalletTx::mapValue
2016-12-12 11:40:00 -05:00
Russell Yanofsky
d8c0b9f525
[qa] Add test for rescan feature of wallet key import RPCs
...
Covers importaddress, importpubkey, importprivkey, and importmulti RPCs.
2016-12-12 10:18:11 -05:00
Jonas Schnelli
ed6b377ae2
[Qt] Console: add security warning
2016-12-12 15:58:40 +01:00
Gregory Maxwell
bae1eef752
Fix wallet/test/crypto_tests.cpp for OpenSSL 1.1 API.
...
This avoids a compile failure on newly installed debian stretch systems.
2016-12-12 08:10:27 +00:00
MarcoFalke
fa615d39b5
[qa] Don't set unknown rpcserialversion
2016-12-11 14:18:07 +01:00
MarcoFalke
76fcd9d503
Merge #9309 : [qa] Wallet needs to stay unlocked for whole test
...
9359f8a
Wallet needs to stay unlocked for whole test (Alex Morcos)
2016-12-10 18:47:36 +01:00
MarcoFalke
faf4ca84e4
[wallet] Disable free transactions when relay is disabled
2016-12-10 17:45:23 +01:00
Pieter Wuille
a1dcf2e108
Merge #9240 : Remove txConflicted
...
a874ab5
remove internal tracking of mempool conflicts for reporting to wallet (Alex Morcos)
bf663f8
remove external usage of mempool conflict tracking (Alex Morcos)
2016-12-09 16:31:03 -08:00
Pieter Wuille
d38b0d7a6b
Merge #9307 : Remove undefined FetchCoins method declaration
...
fe41f58
Remove undefined FetchCoins method declaration (Russell Yanofsky)
2016-12-09 16:21:28 -08:00
Pieter Wuille
815640ec6a
Merge #9295 : [Wallet] Bugfix: Fundrawtransaction: don't terminate when keypool is empty
...
1a6eacb
[QA] add fundrawtransaction test on a locked wallet with empty keypool (Jonas Schnelli)
c24a4f5
[Wallet] Bugfix: FRT: don't terminate when keypool is empty (Jonas Schnelli)
2016-12-09 16:14:54 -08:00
Alex Morcos
01fea7a048
If we don't allow free txs, always send a fee filter
2016-12-09 15:25:46 -05:00
Alex Morcos
5f0e27f1a8
Increase mempool expiry time to 2 weeks
2016-12-09 14:39:04 -05:00
Alex Morcos
06329393c7
Flush wallet after abandontransaction
2016-12-09 13:36:42 -05:00
Alex Morcos
9359f8ad3b
Wallet needs to stay unlocked for whole test
2016-12-09 11:42:23 -05:00
MarcoFalke
72bf1b3d09
Merge #9303 : Update comments in ctaes
...
8501bed
Squashed 'src/crypto/ctaes/' changes from cd3c3ac..003a4ac (Pieter Wuille)
2016-12-09 10:22:21 +01:00
Karl-Johan Alm
8c1dbc5e9d
Refactor: Removed begin/end_ptr functions.
2016-12-09 13:15:19 +09:00
Pieter Wuille
760765d5a9
Update ctaes
2016-12-08 17:09:07 -08:00
Pieter Wuille
8501bedd75
Squashed 'src/crypto/ctaes/' changes from cd3c3ac..003a4ac
...
003a4ac Merge #5 : fix typo
5254f14 [trivial] Fix typo
e7c0aab Merge #4 : Fix some comments
d07cead Fix some comments
git-subtree-dir: src/crypto/ctaes
git-subtree-split: 003a4acfc273932ab8c2e276cde3b4f3541012dd
2016-12-08 17:09:07 -08:00
Alex Morcos
f8d43b8081
Avoid rollingMinimumFeeRate never being able to decay below half
2016-12-08 15:40:14 -05:00
Alex Morcos
eab8e1b172
fix a bug if the min fee is 0 for FeeFilterRounder
2016-12-08 15:40:14 -05:00
BtcDrak
c5c92c46fb
Update python tests for default tx version=2
2016-12-08 20:12:00 +00:00
BtcDrak
dab207e4e6
Preserve tx version=1 for certain tests
...
Without this change, the tests would be affected by default
tx version increases.
2016-12-08 20:11:51 +00:00
Alex Morcos
c5d746ace7
tiny test fix for mempool_tests
2016-12-08 20:11:39 +00:00
BtcDrak
1f0ca1ae1c
Bump default transaction version to 2
2016-12-08 20:11:27 +00:00
Pieter Wuille
b3a74100b8
Return txid even if ATMP fails for new transaction
2016-12-08 11:55:32 -08:00
jonnynewbs
d29505db22
Fix transaction size comments. Size now refers to virtual size as defined in BIP141.
2016-12-08 17:03:57 +00:00
Wladimir J. van der Laan
86017842d6
Merge #9291 : Remove mapOrphanTransactionsByPrev from DoS_tests
...
819ca3f
Remove mapOrphanTransactionsByPrev from DoS_tests (Pieter Wuille)
2016-12-08 08:38:15 +01:00
Wladimir J. van der Laan
9851a8461d
Merge #9255 : qt: layoutAboutToChange signal is called layoutAboutToBeChanged
...
f36349e
qt: Remove on_toggleNetworkActiveButton_clicked from RPCConsole (Wladimir J. van der Laan)
297cc20
qt: layoutAboutToChange signal is called layoutAboutToBeChanged (Wladimir J. van der Laan)
2016-12-08 08:14:16 +01:00
Wladimir J. van der Laan
2044e37beb
Merge #9266 : Bugfix: Qt/RPCConsole: Put column enum in the right places
...
df17fe0
Bugfix: Qt/RPCConsole: Put column enum in the right places (Luke Dashjr)
2016-12-08 08:13:15 +01:00
Wladimir J. van der Laan
d52ce89bd2
Merge #9299 : Remove no longer needed check for premature v2 txs
...
b919179
remove no longer needed check for premature v2 txs (Alex Morcos)
2016-12-08 07:51:35 +01:00
Wladimir J. van der Laan
ea33f197ef
Merge #9276 : Some minor testing cleanups
...
30b620c
remove obsolete run-bitcoind-for-test.sh (Alex Morcos)
2a99522
remove relaypriority from rpc tests (Alex Morcos)
e2184cc
Reorder RPC tests for running time (Alex Morcos)
2016-12-08 07:50:56 +01:00
Russell Yanofsky
fe41f58365
Remove undefined FetchCoins method declaration
2016-12-07 15:41:56 -05:00
Alex Morcos
b919179cbb
remove no longer needed check for premature v2 txs
2016-12-07 09:58:20 -05:00
Jonas Schnelli
1a6eacbf3b
[QA] add fundrawtransaction test on a locked wallet with empty keypool
2016-12-07 15:20:40 +01:00
Wladimir J. van der Laan
f36349e898
qt: Remove on_toggleNetworkActiveButton_clicked from RPCConsole
...
There is no network toggle button (anymore?) in the RPC console.
Removes another warning (#9250 ).
2016-12-07 05:55:16 +01:00
Pieter Wuille
09c4fd157c
Merge #9268 : Fix rounding privacy leak introduced in #9260
...
9b9324e
Fix rounding privacy leak introduced in #9260 (Matt Corallo)
2016-12-06 13:33:01 -08:00
Wladimir J. van der Laan
fde7d99c4d
Merge #9296 : Fix missed change to WalletTx structure
...
28f8ae8
Fix missed change to WalletTx structure (Alex Morcos)
2016-12-06 15:41:43 +01:00
Alex Morcos
28f8ae8adf
Fix missed change to WalletTx structure
2016-12-06 08:56:12 -05:00
Jonas Schnelli
c24a4f5981
[Wallet] Bugfix: FRT: don't terminate when keypool is empty
2016-12-06 13:45:56 +01:00
Jonas Schnelli
e15660c16f
Merge #9280 : [Qt] Show ModalOverlay by pressing the progress bar, allow hiding
...
89a3723
[Qt] Show ModalOverlay by pressing the progress bar, disabled show() in sync mode (Jonas Schnelli)
2016-12-06 13:03:33 +01:00
MarcoFalke
919db037f1
Merge #9274 : [qa] Use cached utxo set to fix performance regression
...
fab1af3
[qa] maxuploadtarget: Use cached utxo set (MarcoFalke)
fa2ecc4
[qa] pruning: Use cached utxo set to run faster (MarcoFalke)
2016-12-06 12:08:27 +01:00
Gregory Maxwell
f692fce8a4
Make RelayWalletTransaction attempt to AcceptToMemoryPool.
...
This resolves an issue where a wallet transaction which failed to
relay previously because it couldn't make it into the mempool
will not try again until restart, even though mempool conditions
may have changed.
Abandoned and known-conflicted transactions are skipped.
Some concern was expressed that there may be users with many
unknown conflicts would waste a lot of CPU time trying to
add them to their memory pools over and over again. But I am
doubtful these users exist in any number, if they do exist
they have worse problems, and they can mitigate any performance
issue this might have by abandoning the transactions in question.
2016-12-06 08:01:27 +00:00
Pieter Wuille
80d073c9bc
Complain when unknown rpcserialversion is specified
2016-12-05 23:26:32 -08:00
Wladimir J. van der Laan
ed8d693c71
Merge #9194 : Add option to return non-segwit serialization via rpc
...
412bab2
Adapt ZMQ/rest serialization to take rpcserialversion arg (instagibbs)
bc7ff8d
Add option to return non-segwit serialization via rpc (Gregory Sanders)
2016-12-06 08:21:57 +01:00
Pieter Wuille
819ca3f18e
Remove mapOrphanTransactionsByPrev from DoS_tests
...
This is another violation of the one definition rule, as the type
for mapOrphanTransactionsByPrev did not match the one in
net_processing.cpp anymore. As it now depends on a custom Iterator,
it seems too much hassle to correctly expose it to the tests.
Instead, this commit just removes the one test it was referenced in.
2016-12-05 23:04:50 -08:00
Russell Yanofsky
07df40babb
[test] Add CCoinsViewCache Access/Modify/Write tests
...
Add more comprehensive unit tests for CCoinsViewCache. Right now it is hard to
refactor caching code or fix bugs in the caching logic because you have to try
to mentally enumerate all the different states the cache might be in to make
sure a change doesn't cause unintended consequences. The new tests explicitly
enumerate relevant cache states, documenting and verifying the behavior in each
state, so it will be safer and easier to make changes to the caching code in
the future.
2016-12-05 18:30:46 -05:00
Alex Morcos
a874ab5ccf
remove internal tracking of mempool conflicts for reporting to wallet
2016-12-05 13:41:25 -05:00
Alex Morcos
bf663f8e93
remove external usage of mempool conflict tracking
2016-12-05 13:41:25 -05:00
Jonas Schnelli
89a3723bdc
[Qt] Show ModalOverlay by pressing the progress bar, disabled show() in sync mode
2016-12-05 13:58:00 +01:00
instagibbs
412bab22b2
Adapt ZMQ/rest serialization to take rpcserialversion arg
2016-12-05 07:43:22 -05:00