Matt Corallo
c32a486f4b
Add more data-driven tests.
2014-01-30 03:53:52 -05:00
Wladimir J. van der Laan
9b818ed8bf
Merge pull request #3588
...
df966d1
2014-01-30 08:47:10 +01:00
Gavin Andresen
3581abdd46
Merge pull request #3370 from sipa/headersfirst3
...
Prepare block connection logic for headers-first
2014-01-29 13:49:15 -08:00
Luke Dashjr
c117d9e93a
Support for error messages and a few more rejection reasons
2014-01-29 17:39:24 +00:00
Luke Dashjr
14e7ffcc64
Use standard BIP 22 rejection reasons where applicable
2014-01-29 17:39:18 +00:00
Wladimir J. van der Laan
a7f3aedec3
Re-add BTC/KB in help message for settxfee
...
Commit a22eed6a
2014-01-29 17:25:04 +01:00
Wladimir J. van der Laan
de9b4c7abc
qt: Add closing newline to help message
...
`bitcoin-qt --help` was missing a final newline.
2014-01-29 17:20:26 +01:00
Wladimir J. van der Laan
f9a2f08882
Bump version numbers for 0.9.0rc1 release
2014-01-29 16:09:11 +01:00
Wladimir J. van der Laan
9bbbfe188c
qt: Fix Windows/Darwin executable metadata
...
.rc's should be linked into the executable directly,
not through a helper library.
2014-01-29 15:05:42 +01:00
Wladimir J. van der Laan
c3d966690c
qt: Transifex pull before 0.9.0rc1
2014-01-29 14:51:44 +01:00
Wladimir J. van der Laan
3160a9b92d
Merge pull request #3586
...
4412c5a
2014-01-29 14:47:06 +01:00
Wladimir J. van der Laan
4412c5a759
Fix getaddednodeinfo RPC call with dns=false
...
The getaddednodeinfo RPC call, when invoked with the dns flag set to
false, returns a malformed JSON object with duplicate keys.
Change this to return an array of objects with one key as
shown in the help message.
Fixes #3581 .
2014-01-29 14:46:06 +01:00
Wladimir J. van der Laan
e16ee005ec
Merge pull request #3598
...
69d03bc79fb055
2014-01-29 14:43:48 +01:00
Wladimir J. van der Laan
69d03bc6e2
qt: Fix tab order in send and receive tab
2014-01-29 14:41:41 +01:00
Cozz Lovan
79fb0557cf
[Qt] minor receive tab improvements
2014-01-29 14:20:15 +01:00
Wladimir J. van der Laan
624154114f
Merge pull request #3597
...
3cf1f43
2014-01-29 14:17:20 +01:00
Philip Kaufmann
c78bd93701
[Qt] extend validate line edit and btc address validator
...
- remove btc address length from address validator
- add an optional btc address check in validated line edit that defaults
to off and is used in GUIUtil::setupAddressWidget()
- an isAcceptable() check is added to validated line edit on focus out
which only kicks in, when a validator is used with that widget
- remove an isAcceptable() check from sendcoinsentry.cpp
- remove obsolete attributes from ui files, which are set by calling
GUIUtil::setupAddressWidget()
- move some more things to GUIUtil::setupAddressWidget() and remove them
from normal code e.g. placeholder text
2014-01-29 14:15:55 +01:00
Wladimir J. van der Laan
3cf1f43694
Mention * value for account in documentation for getbalance RPC
2014-01-29 13:43:47 +01:00
Wladimir J. van der Laan
aab8fc58c6
Merge pull request #3450
...
4c0b2cd
2014-01-29 09:09:50 +01:00
Wladimir J. van der Laan
2383e4883d
Re-add newline to error() messages
...
As reported by @Subo1978, error messages don't have a trailing newline
anymore after commit b77dfdc9
2014-01-29 08:46:15 +01:00
Wladimir J. van der Laan
0524bdd636
Merge pull request #3582
...
e5aadb2
2014-01-29 07:50:45 +01:00
Wladimir J. van der Laan
6ebcec7d3c
Merge pull request #3593
...
c7f9332
2014-01-28 18:38:31 +01:00
Wladimir J. van der Laan
7ff13ef2d2
Merge pull request #3590
...
edd735d
2014-01-28 11:00:40 +01:00
Wladimir J. van der Laan
f9355f1f2b
Merge pull request #3594
...
d7aa1ec
2014-01-28 10:54:17 +01:00
Philip Kaufmann
d7aa1ec8dd
[Qt] fix bitcoin: URI strings (spelling fixes)
2014-01-28 10:48:41 +01:00
Wladimir J. van der Laan
c7f9332596
Add check for valid keys in importprivkey
...
The base58 armoring was checked, but not the resulting private key,
which could be out of range. Fix this by adding a check.
2014-01-28 09:57:57 +01:00
Wladimir J. van der Laan
dfd0d38fae
Merge pull request #3591
...
6986861
2014-01-28 09:40:12 +01:00
Jeff Garzik
12e1fcc34e
Merge pull request #3589 from Diapolo/english-reason
...
use english for all reason strings in IsStandardTx()
2014-01-27 23:58:24 -08:00
Philip Kaufmann
b34e88a88f
use english for all reason strings in IsStandardTx()
2014-01-28 07:45:42 +01:00
Cory Fields
6986861fda
build: use -mwindows for gui targets when linking with mingw
2014-01-27 15:30:51 -05:00
Pieter Wuille
75f51f2a63
Prepare block connection logic for headers-first.
...
This changes the block processing logic from "try to atomically switch
to a new block" to a continuous "(dis)connect a block, aiming for the
assumed best chain".
This means the smallest atomic operations on the chainstate become
individual block connections or disconnections, instead of entire
reorganizations. It may mean that we try to reorganize to one block,
fail, and rereorganize again to the old block. This is slower, but
doesn't require unbounded RAM.
It also means that a ConnectBlock which fails may be no longer called
from the ProcessBlock which knows which node sent it. To deal with that,
a mapBlockSource is kept, and invalid blocks cause asynchronous "reject"
messages and banning (if necessary).
2014-01-27 21:20:41 +01:00
Pieter Wuille
0ec16f35d6
Move only: extract WriteChainState and UpdatedTip from SetBestChain.
2014-01-27 21:13:48 +01:00
Cozz Lovan
edd735da4e
[Qt] Fix coin control labels update
2014-01-27 19:16:31 +01:00
Philip Kaufmann
df966d1b24
log parameter interactions to debug.log
2014-01-27 12:08:48 +01:00
Wladimir J. van der Laan
ca1913e8f6
Merge pull request #2342
...
665bdd3
2014-01-27 10:16:54 +01:00
Wladimir J. van der Laan
b571a8c708
qt: Translation update
...
Update English .ts file from source as well as pull changes from transifex
to current translation.
2014-01-27 09:56:35 +01:00
Wladimir J. van der Laan
86fa1c9cf2
Merge pull request #3579
...
f3005c8
2014-01-27 09:53:51 +01:00
Philip Kaufmann
f3005c82b1
[Qt] harmonize strings used when exporting in addressbookpage
2014-01-27 08:36:14 +01:00
Peter Todd
665bdd3bc9
Fix off-by-one errors in use of IsFinalTx()
...
Previously CreateNewBlock() didn't take into account the fact that
IsFinalTx() without any arguments tests if the transaction is considered
final in the *current* block, when both those functions really needed to
know if the transaction would be final in the *next* block.
Additionally the UI had a similar misunderstanding.
Also adds some basic tests to check that CreateNewBlock() is in fact
mining nLockTime-using transactions correctly.
Thanks to Wladimir J. van der Laan for rebase.
2014-01-26 21:50:15 -05:00
Gavin Andresen
e5aadb25c5
Updated fallback seed nodes from sipa's DNS seeds
2014-01-24 17:09:20 -05:00
Gavin Andresen
d3d753578c
Merge pull request #3578 from gavinandresen/unittest_debuglockorder
...
Unit test fixes for AssertLockHeld / -DDEBUG_LOCKORDER
2014-01-24 11:46:00 -08:00
Gavin Andresen
fd67424c82
Unit test fixes for AssertLockHeld / -DDEBUG_LOCKORDER
...
Unit tests would fail if compiled with -DDEBUG_LOCKORDER (AssertLockHeld()
would fail; AssertLockHeld() relies on the DEBUG_LOCKORDER code to keep
track of locks held).
Fixed by LOCK'ing the wallet mutex in the unit tests that manipulate the
wallet.
2014-01-24 10:47:29 -05:00
Wladimir J. van der Laan
d0a94f2c2f
Merge pull request #3571
...
57feb1b
2014-01-24 11:38:13 +01:00
Wladimir J. van der Laan
57feb1ba5a
ui: Clarify help messages for 'message' fields
...
Add or amend tooltips to clarify what the message is for and that it
doesn't go over the network.
2014-01-24 11:37:20 +01:00
Wladimir J. van der Laan
6403c6c835
Merge pull request #3549
...
7d9d134b77dfdc
2014-01-23 17:25:39 +01:00
Wladimir J. van der Laan
7d9d134bf9
Remove redundant .c_str()s
...
After the tinyformat switch sprintf() family functions support passing
actual std::string objects.
Remove unnecessary c_str calls (236 of them) in logging and formatting.
2014-01-23 16:05:01 +01:00
Wladimir J. van der Laan
b77dfdc9e3
Typesafe strprintf/error/LogPrint functions
...
Switch to tinyformat-based formatting.
Tinyformat is a typesafe drop-in replacement for C99 printf functions:
https://github.com/c42f/tinyformat
2014-01-23 16:05:00 +01:00
Wladimir J. van der Laan
53e9d3aa44
build: fix typo in configure help message
...
--with-qt-libdir etc, not --with-gui-libdir.
The typo was introduced in a9dbcf036b
2014-01-23 14:05:43 +01:00
Wladimir J. van der Laan
22650b7d40
Merge pull request #3577
...
17b409b
2014-01-23 12:58:06 +01:00
Wladimir J. van der Laan
17b409b2e6
qt: Fix richtext detection hang issue on very old Qt versions
...
Alternative implementation. Thanks to @awoland for the original.
Fixes #3486 .
2014-01-23 12:44:28 +01:00
