Wladimir J. van der Laan
8206835cc1
Merge #7974 : More comments on the design of AttemptToEvictConnection.
...
d90351f
More comments on the design of AttemptToEvictConnection. (Gregory Maxwell)
2016-05-04 15:52:13 +02:00
Wladimir J. van der Laan
fc23fee690
Merge #7975 : [doc] Update bitcoin-core GitHub links
...
faf3d11
[doc] Update bitcoin-core GitHub links (MarcoFalke)
2016-05-04 14:28:38 +02:00
Wladimir J. van der Laan
08d7b563e9
util: switch LogPrint and error to variadic templates
2016-05-04 14:21:04 +02:00
fanquake
47eda2d882
[depends] Add -stdlib=libc++ to darwin CXX flags
2016-05-04 19:03:59 +08:00
Wladimir J. van der Laan
9eaa0afa6e
tinyformat: force USE_VARIADIC_TEMPLATES
...
Now that we started using c++11, force use of variadic templates.
The autodetection may be wonky on some compilers, see discussion
[here](https://github.com/bitcoin/bitcoin/pull/7982#issuecomment-216222357 )
and is unnecessary for us anyhow.
2016-05-04 11:37:10 +02:00
Wladimir J. van der Laan
559fbae8c6
Merge #7982 : build: No need to check for leveldb atomics
...
de98290
build: No need to check for leveldb atomics (Cory Fields)
2016-05-04 11:34:42 +02:00
Wladimir J. van der Laan
da46f9fd66
Merge #7989 : bitcoin-cli.cpp: Use symbolic constant for exit code
...
9a8a7d0
bitcoin-cli.cpp: Use symbolic constant for exit code (Puru)
2016-05-04 11:33:53 +02:00
MarcoFalke
88b77c7da0
Merge #7980 : [qa] smartfees: Properly use ordered dict
...
43bbcd0
[qa] Fix typos in doc and comments (Pavel Janík)
fa17f93
[qa] smartfees: Properly use ordered dict (MarcoFalke)
2016-05-03 13:13:25 +02:00
Pavel Janík
43bbcd0753
[qa] Fix typos in doc and comments
2016-05-02 22:31:00 +02:00
MarcoFalke
fa17f93fbd
[qa] smartfees: Properly use ordered dict
2016-05-02 19:36:06 +02:00
Puru
9a8a7d0115
bitcoin-cli.cpp: Use symbolic constant for exit code
2016-05-02 22:33:04 +05:45
Wladimir J. van der Laan
03cf6e8675
Merge #7959 : fix race that could fail to persist a ban
...
f4ac02e
fix race that could fail to persist a ban (Kaz Wesley)
2016-05-02 14:48:50 +02:00
Wladimir J. van der Laan
86b800c6a2
Merge #7964 : Minor changes for c++11 consistency
...
07e4edb
auto_ptr → unique_ptr (Wladimir J. van der Laan)
073225c
chain: define enum used as bit field as uint32_t (Wladimir J. van der Laan)
2016-05-02 13:08:02 +02:00
Cory Fields
de98290155
build: No need to check for leveldb atomics
...
They're guaranteed with c++11
2016-04-30 17:46:35 -04:00
21E14
c8b92486c4
Remove obsolete reference to CValidationState from UpdateCoins.
2016-04-30 15:14:22 -04:00
Daniel Kraft
f7c4f79f07
[trivial] Add missing const qualifiers.
...
Add some const qualifiers to references that are not modified and should
be marked as const.
2016-04-30 19:25:00 +02:00
Gregory Maxwell
d90351f050
More comments on the design of AttemptToEvictConnection.
...
Some developers clearly don't get this and have been posting
"improvements" that create clear vulnerabilities. It should
have been better explained in the code, since the design
is somewhat subtle and getting it right is important.
2016-04-29 23:15:23 +00:00
MarcoFalke
faf3d11ad7
[doc] Update bitcoin-core GitHub links
2016-04-29 23:07:06 +02:00
MarcoFalke
0ad1041904
Merge #7807 : Fixed miner test values, gave constants for less error-prone values.
...
f8536a6
Corrected values (instagibbs)
617deeb
Gave miner test values constants for less error-prone values. (instagibbs)
2016-04-29 22:02:59 +02:00
Andrew Chow
7db0ecb90c
Test for signing messages
...
New rpc test for signing and verifying messages.
2016-04-28 14:58:14 -04:00
Wladimir J. van der Laan
20f9ecd343
Merge #7962 : CalculateNextWorkRequired Cleanup
...
c7aac2d
Deprecating the remaining LogPrintf dependencies that were made obsolete in PR #7459 . (21E14)
2016-04-28 15:33:28 +02:00
Pieter Wuille
1953c40aa9
More efficient bitsliced rolling Bloom filter
...
This patch changes the implementation from one that stores 16 2-bit integers
in one uint32_t's, to one that stores the first bit of 64 2-bit integers in
one uint64_t and the second bit in another. This allows for 450x faster
refreshing and 2.2x faster average speed.
2016-04-28 14:56:32 +02:00
Pieter Wuille
aa62b68745
Benchmark rolling bloom filter
2016-04-28 14:56:32 +02:00
Wladimir J. van der Laan
5725807402
Merge #7926 : [RPC] push back getaddednodeinfo dead value
...
9c0bcb6
push back getaddednodeinfo dead value (instagibbs)
2016-04-28 14:35:40 +02:00
Wladimir J. van der Laan
a9c8b744e8
Merge #7952 : Log invalid block hash to make debugging easier.
...
61c0170
Log invalid block hash to make debugging easier. (Pavel Janík)
2016-04-28 13:53:01 +02:00
Wladimir J. van der Laan
07e4edb056
auto_ptr → unique_ptr
...
Change the few occurrences of the deprecated `auto_ptr` to c++11 `unique_ptr`.
Silences the deprecation warnings.
Also add a missing `std::` for consistency.
2016-04-28 13:43:32 +02:00
Wladimir J. van der Laan
073225cb01
chain: define enum used as bit field as uint32_t
...
Bitwise logic combined with `<` with undefined signedness will
potentially results in undefined behavior. Fix this by defining the type
as a c++11 typed enum.
Fixes #6017 .
2016-04-28 13:35:16 +02:00
Wladimir J. van der Laan
d9594bfe0c
Merge #7514 : Fix IsInitialBlockDownload for testnet
...
8aa7226
Fix IsInitialBlockDownload to play nice with testnet (jmacwhyte)
2016-04-28 12:55:35 +02:00
Wladimir J. van der Laan
574ddc63d6
Merge #7939 : qt: Make it possible to show details for multiple transactions
...
f135e3c
qt: Add transaction hash to details window title (Wladimir J. van der Laan)
17a6a21
qt: Make it possible to show details for multiple transactions (Wladimir J. van der Laan)
2016-04-28 12:21:29 +02:00
Wladimir J. van der Laan
06162f19d7
Merge #7165 : build: Enable C++11 in build, require C++11 compiler
...
7df9224
doc: Add note about new build/test requirements to release notes (Wladimir J. van der Laan)
2aacc72
build: update ax_cxx_compile_stdcxx to serial 4 (Wladimir J. van der Laan)
a398549
depends: use c++11 (Cory Fields)
67969af
build: Enable C++11 build, require C++11 compiler (Wladimir J. van der Laan)
2016-04-28 10:51:49 +02:00
Wladimir J. van der Laan
7df92242a9
doc: Add note about new build/test requirements to release notes
...
[skip ci]
2016-04-28 10:47:41 +02:00
Wladimir J. van der Laan
2aacc72727
build: update ax_cxx_compile_stdcxx to serial 4
2016-04-28 10:18:06 +02:00
21E14
c7aac2d557
Deprecating the remaining LogPrintf dependencies that were made obsolete in PR #7459 .
2016-04-27 22:36:45 -04:00
Kaz Wesley
f4ac02ee7c
fix race that could fail to persist a ban
...
DumpBanList currently does this:
- with lock: take a copy of the banmap
- perform I/O (write out the banmap)
- with lock: mark the banmap non-dirty
If a new ban is added during the I/O operation, it may never be persisted to
disk.
Reorder operations so that the data to be persisted cannot be older than the
time at which the banmap was marked non-dirty.
2016-04-27 09:41:13 -07:00
Pavel Janík
b02119e463
Remove useless argument to AlertNotify.
...
It is always 'true', so useless.
2016-04-27 18:04:02 +02:00
Wladimir J. van der Laan
08b37c5e06
Merge #7954 : build: quiet annoying warnings without adding new ones
...
63b3111
build: quiet annoying warnings without adding new ones (Cory Fields)
2016-04-27 12:57:41 +02:00
Cory Fields
a398549b3b
depends: use c++11
2016-04-27 12:47:41 +02:00
Andrew
f90efbfeef
Create signmessagewithprivkey rpc
...
New rpc 'signmessagewithprivkey' which takes a private key to sign a message without using the wallet.
2016-04-27 06:43:39 -04:00
MarcoFalke
5c7df7022b
Merge #7951 : [qa] test_framework: Properly print exception
...
fada064
[qa] test_framework: Properly print exceptions and assert empty dict (MarcoFalke)
5555528
[qa] mininode: Unfiddle strings into bytes (MarcoFalke)
2016-04-27 10:53:09 +02:00
Cory Fields
63b3111f84
build: quiet annoying warnings without adding new ones
...
Disabling warnings can be tricky, because doing so can cause a different
compiler to create new warnings about unsupported disable flags. Also, some
warnings don't surface until they're paired with another warning (gcc). For
example, adding "-Wno-foo" won't cause any trouble, but if there's a legitimate
warning emitted, the "unknown option -Wno-foo" will show up as well.
Work around this in 2 ways:
1. When checking to see if -Wno-foo is supported, check for "-Wfoo" instead.
2. Enable -Werror while checking 1.
If "-Werror -Wfoo" compiles, "-Wno-foo" is almost guaranteed to be supported.
-Werror itself is also checked. If that fails to compile by itself, it likely
means that the user added a flag that adds a warning. In that case, -Werror
won't be used while checking, and the build may be extra noisy. The user would
need to fix the bad input flag.
Also, silence 2 more additional warnings that can show up post-c++11.
2016-04-27 01:17:14 -04:00
Pavel Janík
61c01706cd
Log invalid block hash to make debugging easier.
2016-04-26 22:22:59 +02:00
MarcoFalke
fada064f67
[qa] test_framework: Properly print exceptions and assert empty dict
2016-04-26 18:04:26 +02:00
Wladimir J. van der Laan
67969af09f
build: Enable C++11 build, require C++11 compiler
...
Implements #6211 .
2016-04-26 16:15:02 +02:00
Wladimir J. van der Laan
f135e3c943
qt: Add transaction hash to details window title
2016-04-26 16:05:10 +02:00
Wladimir J. van der Laan
e26b62093a
Merge #7933 : Fix OOM when deserializing UTXO entries with invalid length
...
1e44169
Add tests for CCoins deserialization (Pieter Wuille)
5d0434d
Fix OOM bug: UTXO entries with invalid script length (Pieter Wuille)
4bf631e
CDataStream::ignore Throw exception instead of assert on negative nSize. (Patrick Strateman)
4f87af6
Treat overly long scriptPubKeys as unspendable (Pieter Wuille)
f8e6fb1
Introduce constant for maximum CScript length (Pieter Wuille)
2016-04-26 13:23:05 +02:00
Wladimir J. van der Laan
0ea3941886
Merge #7941 : Fixing comment in script_test.json test case
...
62a9abd
Fixing comment in script_test.json test case (Chris Stewart)
2016-04-26 13:21:33 +02:00
Wladimir J. van der Laan
c3e3cfb5d1
Merge #7920 : Switch Travis to Trusty
...
a33b7c9
travis: temporarily disable qt to avoid timeouts (Cory Fields)
174023c
travis: Don't disable writing ccache for pull-requests (Cory Fields)
cf77fcd
travis: drop MAKEJOBS=2 for windows compilers (Cory Fields)
9267a47
depends: enable pre-compiled headers for qt (Cory Fields)
06fdffd
travis: switch to Trusty (Cory Fields)
a6666b2
depends: mac deploy Py3 compatibility (Wladimir J. van der Laan)
2016-04-26 13:20:16 +02:00
Wladimir J. van der Laan
a4078071e0
Merge #7944 : Re-instate TARGET_OS=linux in configure.ac. Removed by 351abf9e03
.
...
89c844d
Re-instate TARGET_OS=linux in configure.ac. Removed by 351abf9e03
. (randy-waterhouse)
2016-04-26 13:19:27 +02:00
randy-waterhouse
89c844df14
Re-instate TARGET_OS=linux in configure.ac. Removed by 351abf9e03
.
2016-04-26 19:43:14 +12:00
Cory Fields
a33b7c9cb5
travis: temporarily disable qt to avoid timeouts
...
These builds take longer than they did on precise. Disable them now to keep
things working, we can re-enable them after experimentation
2016-04-26 02:25:22 -04:00