LBRYCommunity/lbrycrd
1
0
Fork 0
Code Issues 29 Pull requests 1 Projects Releases 32 Packages Wiki Activity
5179 commits 22 branches 42 tags 99 MiB
Commit graph

5179 commits

This branch
This branch
All branches
Author SHA1 Message Date
Wladimir J. van der Laan
d3ef9b00ec Prevent empty transactions from being added to vtxPrev 
CWalletTx::AddSupportingTransactions() was adding empty transaction
to vtxPrev in some cases. Skip over these.

Part one of the solution to #3190. This prevents invalid vtxPrev from
entering the wallet, but not current ones being transmitted.
 2013-12-04 15:30:23 +01:00
Wladimir J. van der Laan
5094f8d46f Split off rpc_wallet_tests 
Split wallet tests from other RPC tests.
Now no #ifdef ENABLE_WALLET are needed anymore in either file.
 2013-12-04 12:46:14 +01:00
Wladimir J. van der Laan
829c920387 Move CCryptoKeyStore to crypter.cpp 
This breaks the dependency on crypter for disable-wallet builds.
 2013-12-04 12:46:13 +01:00
Wladimir J. van der Laan
ae6ea5a6fa Update build-unix.md to mention --disable-wallet 
Mention the new --disable-wallet mode.
Also, correct the BDB entry in the dependencies table.
 2013-12-04 12:46:13 +01:00
Wladimir J. van der Laan
4f9e993bc9 Add --disable-wallet option to build system 
Make it possible to build Bitcoin without wallet
(and thus without BDB) so that it only functions as node.
 2013-12-04 12:46:13 +01:00
Wladimir J. van der Laan
d004d7279f Move CAddrDB frrom db to net 
This was a leftover from the times in which
peers.dat depended in BDB.

Other functions in db.cpp still depend on BerkelyDB,
to be able to compile without BDB this (small)
functionality needs to be moved to another file.
 2013-12-04 12:46:13 +01:00
Wladimir J. van der Laan
48ba56cdfd Delimit code with #ifdef ENABLE_WALLET 
Delimit all code that uses the wallet functions
in implementation files that conditionally use the wallet.
 2013-12-04 12:46:13 +01:00
Wladimir J. van der Laan
991685d3dc Move getinfo to rpcnet.cpp 
Where to place `getinfo` is a difficult issue
as it shows information from the wallet, net and
block chain. However, I moved it out of rpcwallet
as the command needs also to be available without
wallet.
 2013-12-04 12:46:13 +01:00
Wladimir J. van der Laan
bbb093652e Move HelpExample* from rpcwallet to rpcserver 
General functions used throughout the RPC framework
don't belong in rpcwallet.
 2013-12-04 12:46:12 +01:00
Wladimir J. van der Laan
00cfc9f074
Merge pull request #3355 
6c98cca qt: use deleteLater to remove send entries (Wladimir J. van der Laan)
 2013-12-04 09:42:09 +01:00
Wladimir J. van der Laan
6c98cca9e4 qt: use deleteLater to remove send entries 
Use deleteLater() instead of delete, as it is not allowed
to delete widgets directly in an event handler.
Should solve the MacOSX random crashes on send with coincontrol.
 2013-12-04 08:17:57 +01:00
Gavin Andresen
1e01f7c506 Payment request URI syntax changed, from request=... to r=... 
BIP 72 was changed to save six bytes in bitcoin: URIs.
 2013-12-04 13:18:09 +10:00
Wladimir J. van der Laan
f15bd3c96f
Merge pull request #3285 
d3207b6 [Qt] coin-control features GUI cleanup 3 (Philip Kaufmann)
834e14e [Qt] coin-control features GUI cleanup 2 (Philip Kaufmann)
 2013-12-03 17:26:45 +01:00
Philip Kaufmann
ccd1372dd0 [Qt] small notificator and style changes 
- remove default arguments for notificator
- re-order some calls to use same ordering in Qt files
- style police changes (spaces, comments and such)
 2013-12-03 14:01:53 +01:00
Gavin Andresen
cf74e8cb5e Merge pull request #3320 from laanwj/2013_11_cli_split 
bitcoin-cli: remove unneeded dependencies (only minor code movement)
 2013-12-03 03:47:44 -08:00
Wladimir J. van der Laan
0b47fe6bdc bitcoin-cli: remove unneeded dependencies (only code movement) 
Remove unnecessary dependencies for bitcoin-cli
(leveldb, berkelydb, wallet, RPC server)

Build system changes:
- split libbitcoin.a into libbitcoin_common.a, libbitcoin_server.a and
  libbitcoin_cli.a

Code changes (movement only):
- split up HelpMessage into HelpMessage in init.cpp and HelpMessageCli
  in rpcclient.cpp
- move uiInterface from init.cpp to util.cpp
 2013-12-03 09:07:13 +01:00
Gavin Andresen
0563ee952c Merge pull request #3345 from Michagogo/gitian-descriptor-deps-input-typo 
Fix file hash verification error in deps-win32.yml
 2013-12-02 22:54:46 -08:00
Gavin Andresen
2aed2b30b1 Merge pull request #3344 from gmaxwell/assert_hazards 
Sanitize assert usage and refuse to compile with NDEBUG.
 2013-12-02 16:56:46 -08:00
Michagogo
c51e49b1a3 Fix file hash verification error in deps-win32.yml 
libpng was being sha256summed twice, and miniupnpc wasn't being checked at all.
 2013-12-03 02:04:50 +02:00
Gregory Maxwell
9b59e3bda8 Sanitize assert usage and refuse to compile with NDEBUG. 
There were quite a few places where assert() was used with side effects,
 making operation with NDEBUG non-functional.  This commit fixes all the
 cases I know about, but also adds an  #error on NDEBUG because the code
 is untested without assertions and may still have vulnerabilities if
 used without assert.
 2013-12-02 11:33:44 -08:00
Philip Kaufmann
d3207b6fa8 [Qt] coin-control features GUI cleanup 3 
- remove style sheets from ui files and use Qt attributes instead
- make some more strings untranslatable, to make life for translators
  easier
- split up long tooltips an rework the texts a little
 2013-12-02 13:36:19 +01:00
Philip Kaufmann
834e14e57f [Qt] coin-control features GUI cleanup 2 
- remove monospace labels from sendcoinsdialog also
- use a validated line edit for the change address
- add a tooltip to change address switch
- ensure we have a valid change address in
  CoinControlDialog::coinControl->destChange or just CNoDestination()
- some small ui file changes
 2013-12-02 13:32:46 +01:00
Pieter Wuille
9ab7a0609e Merge pull request #3341 from Need4Video/master 
Lossless image optimization
 2013-12-02 04:25:05 -08:00
Sined
d6cb85d50d Lossless image optimization 
less bytes, same images
 2013-12-02 10:10:22 +01:00
Wladimir J. van der Laan
b9988c9e74
Merge pull request #3339 
bae6c7e Fix a rare crash on Mac OS X, by removing a setFocus on the payTo field that was not necessary, as the field still receives focus without it. (Ryan Niebur)
 2013-12-02 08:52:54 +01:00
Ryan Niebur
bae6c7e32b Fix a rare crash on Mac OS X, by removing a setFocus on the payTo field that was not necessary, as the field still receives focus without it. 2013-12-01 20:31:10 -08:00
Gavin Andresen
49dc3a0f1a Make unit tests succeed with -DDEBUG_LOCKORDER 2013-12-02 13:11:21 +10:00
Gavin Andresen
a65edb104d Merge pull request #3329 from gavinandresen/syncdebug 
mutex debugging routines: LocksHeld() and AssertLockHeld()
 2013-12-01 17:43:37 -08:00
Wladimir J. van der Laan
40ad6e7f35
Merge pull request #3306 
84b695c [Qt] allow deletion of payment-requests in sendcoins (Philip Kaufmann)
 2013-12-01 13:02:14 +01:00
Gavin Andresen
b78d1cdf82 Merge pull request #3239 from gavinandresen/mempool_verbose 
Add verbose flag to getrawmempool
 2013-11-29 22:04:18 -08:00
Gavin Andresen
4d707d5120 Add verbose boolean to getrawmempool 
Also changes mempool to store CTxMemPoolEntries
to keep track of when they enter/exit the pool.
 2013-11-30 15:42:10 +10:00
Gavin Andresen
0733c1bde6 Refactor: move GetValueIn(tx) to tx.GetValueIn() 
GetValueIn makes more sense as a CTransaction member.
 2013-11-30 15:42:10 +10:00
Gavin Andresen
98c7c8fd1d Remove dead transaction replacement code 
This dead code can be resurrected from git history if
transaction replacement is ever implemented. Keeping
dead code in the source is a bad idea, because it implies
it was tested and worked at some point, which is not true.
 2013-11-30 15:42:10 +10:00
Gavin Andresen
ad898b40aa Increase default -blockmaxsize/prioritysize to 750K/50K 2013-11-30 14:38:15 +10:00
Wladimir J. van der Laan
e7e8a7537a
Merge pull request #3309 
9ac5a01 Move types.h include before ifaddres.h for u_int declaration (Robert Backhaus)
 2013-11-29 10:34:38 +01:00
Gavin Andresen
c649637b6c mutex debugging routines: LocksHeld() and AssertLockHeld() 2013-11-29 17:46:19 +10:00
Wladimir J. van der Laan
5c56ee1ace
Merge pull request #3328 
9d2b73d bitcoin-cli: Add missing SelectParamsFromCommandLine (Wladimir J. van der Laan)
 2013-11-29 07:56:05 +01:00
Wladimir J. van der Laan
207cfbfbf1
Merge pull request #3295 
9e7776b Integration tests via RPC calls (Gavin Andresen)
 2013-11-28 18:28:42 +01:00
Wladimir J. van der Laan
9d2b73d19f bitcoin-cli: Add missing SelectParamsFromCommandLine 
The SelectParamsFromCommandLine call was missing in bitcoin-cli,
which caused `-testnet` and `-regtest` to be ignored. Add this
call just like in bitcoind.cpp.
 2013-11-28 17:37:01 +01:00
Wladimir J. van der Laan
4ae42d43a4
Merge pull request #3321 
0078841 prevent Windows redefinition warning cause by compat.h (Philip Kaufmann)
 2013-11-28 08:41:23 +01:00
Josh Triplett
26d1b65c53 src/Makefile.am: Simplify clean of leveldb 2013-11-27 18:17:17 -08:00
Josh Triplett
a26a367629 configure.ac: Check for miniupnpc headers, not just -lminiupnpc 
This protects against broken systems which have libminiupnpc.a or
libminiupnpc.so installed but don't have the miniupnpc headers.
 2013-11-27 18:16:16 -08:00
Josh Triplett
82ccb05b07 autogen.sh: Stop passing --verbose to autoreconf 
This quiets down the autotools build, making warnings much more visible.
 2013-11-27 17:29:00 -08:00
Josh Triplett
e12dafd7bb autogen.sh: Use long options to autoreconf, for self-documentation 2013-11-27 17:27:16 -08:00
Josh Triplett
19b9adda52 autogen.sh: Support running from outside the source directory 
Initial steps towards supporting out-of-tree builds.
 2013-11-27 17:25:58 -08:00
Josh Triplett
97d285ab51 autogen.sh: Use set -e to fail if any command fails 
In preparation for expanding autogen.sh.
 2013-11-27 17:24:26 -08:00
Josh Triplett
f80b723c66 autogen.sh: Add a /bin/sh shebang. 2013-11-27 17:21:40 -08:00
Philip Kaufmann
0078841617 prevent Windows redefinition warning cause by compat.h 2013-11-27 21:28:31 +01:00
Wladimir J. van der Laan
5f083afde1
Merge pull request #3284 
fb78cc2 Split up bitcoinrpc (code movement only) (Wladimir J. van der Laan)
 2013-11-27 14:16:36 +01:00
Wladimir J. van der Laan
e1169d7eea
Merge pull request #3296 
a946aa8 Store and use a sanitized subVer (Mike Hearn)
ba6a4ea Add some additional logging to give extra network insight. (Mike Hearn)
 2013-11-27 10:40:54 +01:00