MarcoFalke
fa62dadabe
[qa] fundrawtx: Fix shutdown race
2017-06-06 01:23:01 +02:00
Luke Dashjr
9a5a1d7d45
RPC/rawtransaction: createrawtransaction: Check opt_into_rbf when provided with either value
2017-06-05 23:14:34 +00:00
Luke Dashjr
23b0fe34f5
bitcoin-tx: rbfoptin: Avoid touching nSequence if the value is already opting in
2017-06-05 23:14:34 +00:00
Luke Dashjr
b005bf21a7
Introduce MAX_BIP125_RBF_SEQUENCE constant
2017-06-05 23:14:34 +00:00
Jonas Schnelli
575cde4605
[bitcoin-tx] add rbfoptin command
2017-06-05 23:13:24 +00:00
Jonas Schnelli
5d26244148
[Tests] extend the replace-by-fee test to cover RPC rawtx features
2017-06-05 23:13:24 +00:00
Luke Dashjr
36bcab2356
RPC/Wallet: Add RBF support for fundrawtransaction
2017-06-05 23:12:29 +00:00
Luke Dashjr
891c5eeec2
Wallet: Refactor FundTransaction to accept parameters via CCoinControl
2017-06-05 23:12:03 +00:00
Luke Dashjr
578ec80d4f
RPC: rawtransaction: Add RBF support for createrawtransaction
2017-06-05 23:09:01 +00:00
Luke Dashjr
19b3648bb5
CWalletDB: Store the update counter per wallet
2017-06-05 22:27:57 +00:00
Luke Dashjr
74e8738961
Bugfix: ForceSetArg should replace entr(ies) in mapMultiArgs, not append
2017-06-05 21:04:42 +00:00
Luke Dashjr
23fb9adaea
wallet: Move nAccountingEntryNumber from static/global to CWallet
2017-06-05 21:04:42 +00:00
Luke Dashjr
9d15d5548d
Bugfix: wallet: Increment "update counter" when modifying account stuff
2017-06-05 21:04:42 +00:00
Luke Dashjr
f28eb8020e
Bugfix: wallet: Increment "update counter" only after actually making the applicable db changes to avoid potential races
...
Also does all "update counter" access via IncrementUpdateCounter
2017-06-05 21:04:42 +00:00
Suhas Daftuar
76f74811c4
Add timeout for headers sync
...
At startup, we choose one peer to serve us the headers chain, until
our best header is close to caught up. Disconnect this peer if more
than 15 minutes + 1ms/expected_header passes and our best header
is still more than 1 day away from current time.
2017-06-05 16:33:35 -04:00
Pieter Wuille
efee1db21a
scripted-diff: use insecure_rand256/randrange more
...
-BEGIN VERIFY SCRIPT-
sed -i "s/\<GetRandHash(/insecure_rand256(/" src/test/*_tests.cpp
sed -i "s/\<GetRand(/insecure_randrange(/" src/test/*_tests.cpp src/test/test_bitcoin.cpp
sed -i 's/\<insecure_rand() % \([0-9]\+\)/insecure_randrange(\1)/g' src/test/*_tests.cpp
-END VERIFY SCRIPT-
2017-06-05 12:45:44 -07:00
Pieter Wuille
1119927df0
Add various insecure_rand wrappers for tests
2017-06-05 12:44:44 -07:00
Pieter Wuille
124d13a58c
Merge test_random.h into test_bitcoin.h
2017-06-05 12:44:44 -07:00
Pieter Wuille
90620d66c9
scripted-diff: Rename cuckoo tests' local rand context
...
-BEGIN VERIFY SCRIPT-
sed -i 's/insecure_rand/local_rand_ctx/g' src/test/cuckoocache_tests.cpp
-END VERIFY SCRIPT-
2017-06-05 12:44:44 -07:00
Pieter Wuille
37e864eb9f
Add FastRandomContext::rand256() and ::randbytes()
...
FastRandomContext now provides all functionality that the real Rand* functions
provide.
2017-06-05 12:44:44 -07:00
Pieter Wuille
8b22af3ee5
Replace bytes_serialized with bogosize
2017-06-05 12:43:45 -07:00
Jorge Timón
1238f13cf6
scripted-diff: Remove PAIRTYPE
...
-BEGIN VERIFY SCRIPT-
sed -i 's/PAIRTYPE(\([^,]*\), \([^\)]*\))/std::pair<\1, \2>/' ./src/*.h ./src/*.cpp ./src/*/*.h ./src/*/*.cpp ./src/*/*/*.h ./src/*/*/*.cpp ;
sed -i ':a;N;$!ba;s/#define std::pair<t1, t2> std::pair<t1, t2>\n//' ./src/utilstrencodings.h ;
-END VERIFY SCRIPT-
2017-06-05 20:14:53 +02:00
Jorge Timón
18dc3c3962
scripted-diff: Remove Q_FOREACH
...
-BEGIN VERIFY SCRIPT-
sed -i 's/Q_FOREACH *(\(.*\),/for (\1 :/' ./src/*.h ./src/*.cpp ./src/*/*.h ./src/*/*.cpp ./src/*/*/*.h ./src/*/*/*.cpp ;
-END VERIFY SCRIPT-
2017-06-05 20:11:01 +02:00
Jorge Timón
7c00c26726
scripted-diff: Fully remove BOOST_FOREACH
...
-BEGIN VERIFY SCRIPT-
sed -i 's/BOOST_FOREACH *(\(.*\),/for (\1 :/' ./src/*.h ./src/*.cpp ./src/*/*.h ./src/*/*.cpp ./src/*/*/*.h ./src/*/*/*.cpp ;
-END VERIFY SCRIPT-
2017-06-05 20:10:50 +02:00
Jorge Timón
a5410ac5ec
Small preparations for Q_FOREACH, PAIRTYPE and #include <boost/foreach.hpp> removal
2017-06-05 20:02:30 +02:00
Wladimir J. van der Laan
9fec4da0be
Merge #9740 : Add friendly output to dumpwallet
...
164019d9f82134#9564 (aideca)
Tree-SHA512: 913fcf18d42eebe34173f1f2519973494b1ad2d86d125ff4bf566d6c64aa501c02f8831e6f44812cd87a46916f61c6f510146af406865b31856d8336c173569f
2017-06-05 18:06:34 +02:00
Russell Yanofsky
4f92b5fb30
Run Qt wallet tests on travis
...
Currently these test failures are not caught by travis leading to bugs like:
https://github.com/bitcoin/bitcoin/pull/10506
2017-06-05 11:47:25 -04:00
MarcoFalke
bea5b00cfe
Merge #10509 : Remove xvfb configuration from travis
...
e4bc19f
2017-06-05 17:47:25 +02:00
Russell Yanofsky
9bb66ab660
Add RescanFromTime method and use from rpcdump
...
No change in behavior.
2017-06-05 09:59:58 -05:00
Wladimir J. van der Laan
e654d61d94
Merge #10489 : build: silence gcc7's implicit fallthrough warning
...
cf390df
2017-06-05 16:59:58 +02:00
Russell Yanofsky
ccf84bb9c1
Move birthday optimization out of ScanForWalletTransactions
...
This change has no effect on wallet behavior.
On wallet startup, the transaction scan avoids reading any blocks with
timestamps older than the wallet birthday (less than nTimeFirstKey -
TIMESTAMP_WINDOW). This block skipping code currently resides in
CWallet::ScanForWalletTransactions but it doesn't really belong there because
it makes the implementation unnecessarily fragile and hard to understand, and
it never has any effect except at startup (because all other callers do their
rescans based on timestamps other than, but always greater or equal to,
nTimeFirstKey).
2017-06-05 09:59:58 -05:00
Wladimir J. van der Laan
08d0390a5f
Merge #10403 : Fix importmulti failure to return rescan errors
...
4d2d604
2017-06-05 16:41:02 +02:00
Wladimir J. van der Laan
0747d33498
Merge #10455 : Simplify feebumper minimum fee code slightly
...
88b8f0b
2017-06-05 16:38:07 +02:00
MarcoFalke
c871f323b4
Merge #10515 : [test] Add test for getchaintxstats
...
cc36b5e
2017-06-05 16:25:18 +02:00
Wladimir J. van der Laan
cec9e1ea61
Merge #10422 : Fix timestamp in fee estimate debug message
...
8d4f401
2017-06-05 16:24:26 +02:00
Wladimir J. van der Laan
e103b3ff1e
Merge #10514 : Bugfix: missing == 0 after randrange
...
9aa215b
2017-06-05 16:09:59 +02:00
Wladimir J. van der Laan
296928eb38
Merge #10478 : rpc: Add listen address to incoming connections in getpeerinfo
...
3457331a7e3c28
2017-06-05 15:39:35 +02:00
Wladimir J. van der Laan
3457331386
test: Add test for getpeerinfo bindaddr field
2017-06-05 13:57:13 +02:00
Wladimir J. van der Laan
a7e3c2814c
rpc: Add listen address to incoming connections in getpeerinfo
...
This adds the listening address on which incoming connections were received to the
CNode and CNodeStats structures.
The address is reported in `getpeerinfo`.
This can be useful for distinguishing connections received on different listening ports
(e.g. when using a different listening port for Tor hidden service connections)
or different networks.
2017-06-05 13:35:30 +02:00
Florian Schmaus
16be7ddbaa
Improve bitcoind systemd service file
...
Add comment how further options can be added or existing ones
modified. Use /run/${RuntimeDirectory} for PID file.
Remove TimeoutStopSec, TimeoutStartSec, StartLimitInterval,
StartLimitBurst directives as those should be set indivdually.
Remove Group to user the bitcoin user's default group.
Changed Restart from 'always' to 'on-failure' (can also be overwritten
individually).
2017-06-05 12:10:08 +02:00
practicalswift
90593ed92c
Limit variable scope
2017-06-05 00:52:36 +02:00
Pieter Wuille
400fdd08cc
Merge #10471 : Denote functions CNode::GetRecvVersion() and CNode::GetRefCount() as const
...
5f672ca8c
2017-06-04 11:32:06 -07:00
practicalswift
656dbd871a
Perform member initialization in initialization lists where possible
2017-06-04 01:09:48 +02:00
practicalswift
a8c09affce
Remove unused variables
2017-06-03 23:54:24 +02:00
Jimmy Song
cc36b5e3d7
[test] Add test for getchaintxstats
2017-06-02 21:48:32 -07:00
Pieter Wuille
098b01dc58
Merge #10500 : Avoid CWalletTx copies in GetAddressBalances and GetAddressGroupings
...
b9b814a38
2017-06-02 16:10:33 -07:00
Pieter Wuille
9aa215bff9
Bugfixes: missing == 0 after randrange
2017-06-02 13:47:59 -07:00
Russell Yanofsky
e4bc19f6f8
Remove xvfb configuration from travis
...
Should no longer be needed after #10142 :
bf10264
2017-06-02 09:32:04 -04:00
MarcoFalke
329fc1dce7
Merge #10359 : [tests] functional tests should call BitcoinTestFramework start/stop node methods
...
53f6775a433d8ad8c218f
2017-06-02 12:10:41 +02:00
MarcoFalke
1aefc94dd7
Merge #10423 : [tests] skipped tests should clean up after themselves
...
930deb9
2017-06-02 11:33:18 +02:00
