Wladimir J. van der Laan
8d8f28dd52
refactor: Move RPCNotifyBlockChange out of rpc/server.h
2017-03-27 16:23:22 +02:00
Wladimir J. van der Laan
e6dcfeec05
refactor: Move GetDifficulty out of rpc/server.h
...
It has no business in `rpcserver.h`. Define it in the interface header
of the implementation unit `rpcblockchain` where it is defined.
Also modernize the signature to:
double GetDifficulty(const CBlockIndex* blockindex = nullptr);
(remove `extern`, replace `NULL` with `nullptr`)
2017-03-27 12:21:35 +02:00
MarcoFalke
fa4535df57
[qa] combine_logs: Use ordered list for logfiles
2017-03-27 11:26:31 +02:00
Wladimir J. van der Laan
5114f81136
Merge #10057 : [init] Deduplicated sigaction() boilerplate
...
81a3857
2017-03-27 10:36:57 +02:00
Wladimir J. van der Laan
e6156a0aa3
Merge #10056 : [zmq] Call va_end() on va_start()ed args.
...
5ba61f0
2017-03-27 10:34:18 +02:00
Jonas Schnelli
0ddea4430d
Merge #10060 : [Qt] Ensure an item exists on the rpcconsole stack before adding
...
4df76e2
2017-03-27 09:55:17 +02:00
Jonas Schnelli
9382f0425e
Do not break backward compatibility during wallet encryption
2017-03-27 09:51:55 +02:00
Wladimir J. van der Laan
b1a4f27576
Merge #10073 : Actually run assumevalid.py
...
717ad13
2017-03-27 09:50:42 +02:00
Wladimir J. van der Laan
db1ae5470b
Merge #10085 : Docs: remove 'noconnect' option
...
d5690f1
2017-03-27 09:35:00 +02:00
Wladimir J. van der Laan
c044f03f99
Merge #10083 : [QA] Renaming rawTx into rawtx
...
dd5be2c
2017-03-27 09:24:39 +02:00
Jameson Lopp
0fb288725b
Move several relay options into the Relay help group
2017-03-26 15:02:26 -04:00
Jameson Lopp
1403b1a689
move rpcserialversion into RPC option group
2017-03-26 10:25:17 -04:00
Jameson Lopp
d5690f1ab8
remove 'noconnect' option from documentation
2017-03-26 09:13:20 -04:00
MarcoFalke
fa55853219
rpc: Rename first named arg of createrawtransaction
2017-03-26 12:08:44 +02:00
NicolasDorier
dd5be2c7b3
[QA] Renaming rawTx into rawtx
2017-03-26 05:47:27 +00:00
MarcoFalke
111849345b
Merge #10069 : [QA] Fix typo in fundrawtransaction test
...
803e6a3
2017-03-25 16:11:02 +01:00
MarcoFalke
fa697b7192
[qa] Add setnetworkactive smoke test
2017-03-25 15:33:01 +01:00
Wladimir J. van der Laan
90dd9e6c4c
Merge #9946 : Fix build errors if spaces in path or parent directory
...
b1f584d
2017-03-25 12:15:06 +01:00
Wladimir J. van der Laan
5d7eb39aec
Merge #10067 : [trivial] Dead code removal
...
c59aedc
2017-03-25 09:10:03 +01:00
Wladimir J. van der Laan
530fcbd49b
Merge #10063 : add missing spaces so that markdown recognizes headline
...
cc995e2
2017-03-25 09:07:51 +01:00
Andrew Chow
4df76e270c
Ensure an item exists on the rpcconsole stack before adding
...
Ensures that there is an item on the rpcconsole stack before adding something to the current stack so that a segmentation fault does not occur.
2017-03-24 21:41:34 -04:00
Matthew Zipkin
b1f584dbc1
fix build if spaces in src dir path
2017-03-24 18:22:34 -07:00
John Newbery
717ad131f6
Actually run assumevalid.py.
...
assumevalid was merged as part of PR 9484, but was not added to the
test_runner, so is not run even as part of the extended tests.
This commit adds assumevalid to the list of tests in test_runner. It
also clarifies the code in assumevalid considerably.
2017-03-24 18:23:36 -04:00
Thomas Snider
81a3857c4e
Deduplicated sigaction() boilerplate
2017-03-24 10:32:56 -07:00
MarcoFalke
a0b1e57b20
Merge #10052 : [test] Run extended tests once daily in Travis
...
88e3aa0
2017-03-24 14:02:58 +01:00
MarcoFalke
ca209230c8
Merge #10053 : [test] Allow functional test cases to be skipped
...
0c1ade6232b666
2017-03-24 13:58:03 +01:00
Nicolas Dorier
803e6a3503
[QA] Fix typo in fundrawtransaction test
...
Ping @jnewbery introduced on dab804c18a
2017-03-24 19:10:09 +09:00
Jonas Schnelli
1df08d1580
Add assertion for CanSupportFeature(FEATURE_HD_SPLIT)
2017-03-24 10:57:55 +01:00
Jonas Schnelli
cd468d07d5
Define CWallet::DeriveNewChildKey() as private
2017-03-24 10:57:31 +01:00
Jonas Schnelli
ed79e4f497
Optimize GetOldestKeyPoolTime(), return as soon as we have both oldest keys
2017-03-24 10:54:48 +01:00
Jonas Schnelli
771a304ffe
Make sure we set the wallets min version to FEATURE_HD_SPLIT at the very first point
2017-03-24 10:53:35 +01:00
Jonas Schnelli
1b3b5c6f8f
Slightly modify fundrawtransaction.py test (change getnewaddress() into getrawchangeaddress())
2017-03-24 10:28:41 +01:00
Jonas Schnelli
003e197498
Remove FEATURE_HD_SPLIT bump TODO
2017-03-24 10:28:40 +01:00
Jonas Schnelli
d9638e5aa4
Overhaul the internal/external key derive switch
2017-03-24 10:28:40 +01:00
Jonas Schnelli
1090502c3e
Fix superfluous cast and code style nits in RPC wallet-hd.py test
2017-03-24 10:28:40 +01:00
Jonas Schnelli
58e148333e
CKeyPool avoid "catch (...)" in SerializationOp
2017-03-24 10:28:40 +01:00
Jonas Schnelli
e138876f0a
Only show keypoolsize_hd_internal if HD split is enabled
2017-03-24 10:28:40 +01:00
Jonas Schnelli
add38d9b83
GetOldestKeyPoolTime: if HD & HD Chain Split is enabled, response max(oldest-internal-key, oldest-external-key)
2017-03-24 10:28:39 +01:00
Jonas Schnelli
dd526c2a2d
Don't switch to HD-chain-split during wallet encryption of non HD-chain-split wallets
2017-03-24 10:28:39 +01:00
Jonas Schnelli
79df9df348
Switch to 100% for the HD internal keypool size
2017-03-24 10:28:39 +01:00
Jonas Schnelli
bcafca1077
Make sure we always generate one keypool key at minimum
2017-03-24 10:28:39 +01:00
Jonas Schnelli
d0a627a53a
Fix issue where CDataStream->nVersion was taken a CKeyPool record version
2017-03-24 10:28:39 +01:00
Jonas Schnelli
9af8f00a75
Make sure we hand out keypool keys if HD_SPLIT is not enabled
2017-03-24 10:28:38 +01:00
Jonas Schnelli
469a47b760
Make sure ReserveKeyFromKeyPool only hands out internal keys if HD_SPLIT is supported
2017-03-24 10:28:38 +01:00
Jonas Schnelli
05a9b493eb
Fix wrong keypool internal size in RPC getwalletinfo help
2017-03-24 10:28:38 +01:00
Jonas Schnelli
01de822c8d
Removed redundant IsLocked() check in NewKeyPool()
2017-03-24 10:28:38 +01:00
Jonas Schnelli
d59531ddfc
Immediately return setKeyPool's size if HD or HD_SPLIT is disabled or not supported
2017-03-24 10:28:37 +01:00
Jonas Schnelli
02592f4c5e
[Wallet] split the keypool in an internal and external part
2017-03-24 10:28:37 +01:00
John Newbery
0c1ade6a4b
Skip rpcbind_test if OS/network requirements are not met.
2017-03-24 00:05:30 -04:00
Thomas Snider
c59aedc1b0
[trivial] Dead code removal
2017-03-23 15:08:54 -07:00
