Gregory Maxwell
f8b7aa8625
Longer term workaround for chainstate corruption from negative versions.
...
This also makes negative transaction versions non-standard.
This avoids an issue triggered in block 256818 where transactions with
negative version numbers were incorrectly serialized into the UTXO set.
On restart nodes detect the inconsistency and refuse to start so long as
a block with these transactions is inside the self-consistency check
window, logging "coin database inconsistencies found". The software
recommends reindexing, but reindexing does not correct the problem.
This should be fixed by changing the chainstate serialization, but
working around it seems harmless for now because the version is not
used by any network rule currently.
A patch free workaround is to start with -checklevel=2 which skips
the consistency checks, but the IsStandard change is important for
miners in order to protect unpatched nodes.
2013-09-09 02:11:11 -07:00
Gavin Andresen
4c723841e2
Merge pull request #2968 from TheBlueMatt/master
...
Don't warn about forks while fIsInitialDownload
2013-09-08 17:48:42 -07:00
Gavin Andresen
8394f4a2dc
Merge pull request #2977 from laanwj/2013_09_release_process_protobuf
...
Add protobuf 2.5.0 download to gitian release process
2013-09-08 17:31:04 -07:00
Jeff Garzik
12564aa166
configure.ac: remove superfluous bracket
...
Reported-by: Cory Fields
2013-09-07 19:42:32 -04:00
Jeff Garzik
15fd245b9a
Merge pull request #2943 from theuni/autotools-final
...
Autotools buildsystem
2013-09-06 17:09:55 -07:00
Wladimir J. van der Laan
495242c1ad
Merge pull request #2976 from laanwj/2013_09_txid_details
...
qt: add vout index to transaction id in transactions details dialog
2013-09-06 04:21:45 -07:00
Wladimir J. van der Laan
9d6b60cf50
Merge pull request #2973 from Diapolo/qDebug
...
Bitcoin-Qt: Use qDebug() for printing to debug.log
2013-09-06 03:26:02 -07:00
Wladimir J. van der Laan
ed4c7fd4fd
qt: add vout index to transaction id in transactions details dialog
2013-09-06 12:12:18 +02:00
Philip Kaufmann
42018eff07
Bitcoin-Qt: Use qDebug() for printing to debug.log
...
- removes all usages of PrintDebugStringF from Qt code
- ensure same format for all debug.log messages "functionname : Message"
2013-09-06 10:32:07 +02:00
Gavin Andresen
d22d9753cc
Merge pull request #2978 from gmaxwell/rpc_settxfee_doc
...
Make settxfee clear that units are btc/kb.
2013-09-05 21:57:52 -07:00
Cory Fields
35b8af9226
autotools: switch to autotools buildsystem
2013-09-05 21:31:03 -04:00
Gregory Maxwell
a22eed6a1e
Make settxfee clear that units are btc/kb.
2013-09-05 17:56:13 -07:00
Wladimir J. van der Laan
51c2fa16bb
Qt 4.8.3 r2 in gitian and release process
...
Also needed to add `unzip` package for the added unzip command for
OpenSSL in the Qt build.
2013-09-05 14:38:59 +02:00
Wladimir J. van der Laan
af079f0b21
Add protobuf 2.5.0 download to gitian release process
2013-09-05 14:02:04 +02:00
Gavin Andresen
2fee100f03
Merge pull request #2944 from gavinandresen/acceptheader
...
Set Accept: application/bitcoin-paymentrequest header
2013-09-03 19:52:38 -07:00
Matt Corallo
55ed3f1475
Don't warn about forks while fIsInitialDownload
2013-09-03 22:22:13 -04:00
Gregory Maxwell
dd30937ce3
Merge pull request #2948 from jgarzik/changeaddr
...
RPC: add getrawchangeaddress, for raw transaction change destinations
2013-09-02 20:29:02 -07:00
Wladimir J. van der Laan
f4f048ee58
Merge pull request #2958 from laanwj/2013_08_txfee2
...
[Qt] Display txfee in first sendCoinsDialog message box
2013-09-02 09:48:10 -07:00
Pieter Wuille
2c27bbca81
Merge pull request #2967 from tstranex/master
...
Fix typo in a comment: it's base58, not base48.
2013-09-02 09:04:06 -07:00
Timothy Stranex
ccf3af77c1
Fix typo in a comment: it's base58, not base48.
2013-09-02 17:27:27 +02:00
Wladimir J. van der Laan
1537d174d7
Merge pull request #2951 from laanwj/2013_08_addressbook_purpose
...
[Qt] Handle address purpose in incremental updates
2013-09-02 05:47:58 -07:00
Wladimir J. van der Laan
2534d05c63
Merge pull request #2963 from Diapolo/log-qt
...
Bitcoin-Qt: allow to differentiate Qt log entries from core
2013-09-02 04:21:19 -07:00
Philip Kaufmann
e664c3d70c
Bitcoin-Qt: allow to differentiate Qt log entries from core
...
- prepend "Bitcoin-Qt" in front of debug.log entries, which come from Qt
- move DebugMessageHandler installation upwards to the event handler
installation, which fits much better
2013-08-31 15:35:39 +02:00
Jonas Schnelli
9e8904f6ae
qt: Display txfee in first sendCoinsDialog message box
...
Signed-off-by: Jonas Schnelli <jonas.schnelli@include7.ch>
2013-08-31 12:41:47 +02:00
Pieter Wuille
f19eda1d57
Merge pull request #2959 from jmcorgan/fix-typo
...
fix the typo fix in linearize.py
2013-08-30 13:19:21 -07:00
Johnathan Corgan
71bc3a4b9f
fix the typo fix in linearize.py
2013-08-30 13:06:16 -07:00
Wladimir J. van der Laan
1b63ea872e
Merge pull request #2957 from Rav3nPL/patch-1
...
fix help prompt
2013-08-30 10:37:05 -07:00
Rav3nPL
63dc00d104
fix help prompt
2013-08-30 18:44:40 +02:00
Wladimir J. van der Laan
329de9bb64
Merge pull request #2955 from laanwj/2013_08_htmlescape
...
qt: Use GUIUtil::HtmlEscape to escape HTML
2013-08-30 05:44:52 -07:00
Wladimir J. van der Laan
9d2fee17e0
qt: Use GUIUtil::HtmlEscape to escape HTML
...
This is why we created this function. Avoids some #ifdef.
2013-08-30 14:38:09 +02:00
Jeff Garzik
df6c5433e7
contrib/misc/mkbootstrap: rename to linearize.py
2013-08-30 07:41:29 -04:00
Jeff Garzik
0a0970fa0e
Merge branch 'mkbootstrap'
2013-08-30 07:38:03 -04:00
Jeff Garzik
701f6c35bc
Add "mkbootstrap" script to contrib, for creating bootstrap.dat.
2013-08-30 07:37:26 -04:00
Wladimir J. van der Laan
5da998e887
qt: Add comment to sorting step in refreshAddressTable
2013-08-30 08:25:25 +02:00
Wladimir J. van der Laan
1a12b3e090
Merge pull request #2930 from Diapolo/displayUnit
...
Bitcoin-Qt: fixes for using display unit from options
2013-08-29 07:37:30 -07:00
Wladimir J. van der Laan
dcd0b0775e
qt: Handle address purpose in incremental updates
...
Correctly use the purpose of addresses that are added after the start
of the client. Addresses with purpose "refund" and "change" should not
be visible in the GUI. This is now handled correctly.
2013-08-29 16:25:51 +02:00
Pieter Wuille
ae6eac667b
Merge pull request #2940 from Diapolo/checkpoint
...
move Checkpoints:fEnabled from step 2 to step 3 in init
2013-08-29 01:59:35 -07:00
Philip Kaufmann
bdd0c59ab0
Bitcoin-Qt: fixes for using display unit from options
...
- extend PaymentServer with setOptionsModel() and rework initNetManager()
to make use of that
- fix all other places in the code to use display unit from options and no
hard-coded unit
2013-08-29 10:38:51 +02:00
Gregory Maxwell
9d14e689c8
[raw] reject insanely high fees by default in sendrawtransaction
...
There have been several incidents where mainnet experimentation with
raw transactions resulted in insane fees. This is hard to prevent
in the raw transaction api because the inputs may not be known.
Since sending doesn't work if the inputs aren't known, we can catch
it there.
This rejects fees > than 10000 * nMinRelayTxFee or 1 BTC with the
defaults and can be overridden with a bool at the rpc.
2013-08-28 15:49:51 -07:00
Jeff Garzik
e5e9904c1c
RPC: add getrawchangeaddress, for raw transaction change destinations
2013-08-28 16:29:52 -04:00
Wladimir J. van der Laan
ff33a3470d
Merge pull request #2931 from Diapolo/intro
...
Bitcoin-Qt: add testnet check and icon to intro dialog
2013-08-28 12:17:17 -07:00
Gregory Maxwell
1ef0067eab
Merge pull request #2904 from gmaxwell/newaddr-no-passphrase
...
[QT] Don't ask for a passphrase to getnewaddress.
2013-08-28 11:20:09 -07:00
Gavin Andresen
b773da064d
Set Accept: application/bitcoin-paymentrequest header
...
Suggestion from BitPay: set an Accept: HTTP header when
fetching payment requests / payment ACKs.
2013-08-28 11:48:39 +10:00
Jeff Garzik
bb7d0fc12f
Merge pull request #2928 from jgarzik/cnb-txout
...
CreateNewBlock / getblocktemplate cleaning
2013-08-25 18:49:25 -07:00
Gavin Andresen
b62dc051aa
Merge pull request #2938 from petertodd/op-reserved-weirdness
...
Document and test OP_RESERVED weirdness
2013-08-25 18:17:59 -07:00
Jeff Garzik
f1dbed9233
miner: constify CreateNewBlock() arg scriptPubKeyIn
2013-08-25 20:16:23 -04:00
Peter Todd
214d45b6b9
Document and test OP_RESERVED weirdness
...
Seems it was forgotten about when IsPushOnly() and the unittests were
written. A particular oddity is that OP_RESERVED doesn't count towards
the >201 opcode limit unlike every other named opcode.
2013-08-25 12:37:07 -04:00
Pieter Wuille
8a9e538227
Merge pull request #2935 from sipa/obounds
...
Fix out-of-bounds check
2013-08-25 07:42:21 -07:00
Philip Kaufmann
60fc1b4034
move Checkpoints:fEnabled from step 2 to step 3 in init
...
- it belongs to parameter-to-internal flags step, not parameter
interactions phase
2013-08-25 13:25:21 +02:00
Jeff Garzik
3d86e7cd48
Merge pull request #2618 from fcicq/solaris-support
...
Partial solaris support
2013-08-24 20:19:24 -07:00