Implement a hard fork for extended/infinite claim expiration times #112

Closed

lbrynaut wants to merge 247 commits from claim-expiration into master

lbrynaut commented

2018-04-01 15:57:54 +02:00

(Migrated from github.com)

No description provided.

kaykurokawa commented

2018-04-02 04:30:29 +02:00

(Migrated from github.com)

Nice.

I think we first need to get a version of this that is not mainnet altering so that downstream LBRY devs can finally test expiration better using regtest and maybe testnet (they haven't been able to because of the long expiration time that was fixed and generating that many blocks take too long).

I made some alterations on this branch: https://github.com/lbryio/lbrycrd/commits/claim-expiration

This branch changes mainnet chainparams so that there should be no forking change in expiration on the mainnet
3539af2a2b

I made it so that it claim expiration is not disabled by default, and utilized a #define statement, I made the if statement a bit easier to understand by using nCurrentHeight on CClaimTrie
c3646afb63

I was succesfully able to resync to the main-net with these changes. Let me know what you think.

Nice. I think we first need to get a version of this that is not mainnet altering so that downstream LBRY devs can finally test expiration better using regtest and maybe testnet (they haven't been able to because of the long expiration time that was fixed and generating that many blocks take too long). I made some alterations on this branch: https://github.com/lbryio/lbrycrd/commits/claim-expiration This branch changes mainnet chainparams so that there should be no forking change in expiration on the mainnet https://github.com/lbryio/lbrycrd/commit/3539af2a2bc419bc0ca66121efd3bb3f7776a554 I made it so that it claim expiration is not disabled by default, and utilized a #define statement, I made the if statement a bit easier to understand by using nCurrentHeight on CClaimTrie https://github.com/lbryio/lbrycrd/commit/c3646afb63eb378d31eabc87d738d78552ea9c7a I was succesfully able to resync to the main-net with these changes. Let me know what you think.

lbrynaut commented

2018-04-02 14:18:33 +02:00

(Migrated from github.com)

@kaykurokawa Thanks for looking at this!

Explicitly disabling on mainnet is a fine idea so long as we're not looking to hard fork. The testnet/regtest params were already independent, so they could be tested at any reasonable heights. I agree picking an arbitrary mainnet fork height needs discussion, so for now, disabling is a fair option to move ahead with any testing required.

@kaykurokawa Thanks for looking at this! Explicitly disabling on mainnet is a fine idea so long as we're not looking to hard fork. The testnet/regtest params were already independent, so they could be tested at any reasonable heights. I agree picking an arbitrary mainnet fork height needs discussion, so for now, disabling is a fair option to move ahead with any testing required.

kaykurokawa commented

2018-04-04 22:37:56 +02:00

(Migrated from github.com)

Closing this and continuing here: https://github.com/lbryio/lbrycrd/pull/115

Pull request closed

This pull request cannot be reopened because the branch was deleted.

No reviewers

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbrycrd#112

No description provided.