Claimid rpc updates #15

Merged
jimmykiselak merged 8 commits from claimid_rpc_updates into master 2016-08-07 03:25:33 +02:00
jimmykiselak commented 2016-07-11 06:12:35 +02:00 (Migrated from github.com)

this starts to switch rpc functions over to using claimids. i have not yet tested to see if it actually works.

this starts to switch rpc functions over to using claimids. i have not yet tested to see if it actually works.
kaykurokawa commented 2016-07-16 02:32:35 +02:00 (Migrated from github.com)

I can look over this and test in the next couple of days

I can look over this and test in the next couple of days
kaykurokawa commented 2016-08-01 20:25:45 +02:00 (Migrated from github.com)

notes on commits

31008a8

  • use update instead of claim for rpc command updateclaim
  • rpc command listnameclaims returns claimid instead of txout and n
  • fix rpc command supportclaim to use claimid

0551e88

  • fix rpc command getvalueforname to work on updates
  • fix rpc command listnameclaim to work on updates
  • fix rpc command supportclaim's script

e713501

  • add rpc command getclaimsforname (returns all claims for name)

80bb42c
a186aaa

  • work on rpc command getclaimforname (could be squashed to e713501)

FOUND ISSUES:

a186aaa073/src/wallet/rpcwallet.cpp (L836)
a186aaa073/src/wallet/rpcwallet.cpp (L757)

  • needs doc update

31008a84b2/src/wallet/rpcwallet.cpp (L681)

  • bug OP_SUPPORT size is 2

Submitted pull request on this pull request https://github.com/jimmykiselak/lbrycrd/pull/1 to fix the above issues. Otherwise I think we can merge this, Jack used this commit to make a real support transaction.

notes on commits 31008a8 - use update instead of claim for rpc command updateclaim - rpc command listnameclaims returns claimid instead of txout and n - fix rpc command supportclaim to use claimid 0551e88 - fix rpc command getvalueforname to work on updates - fix rpc command listnameclaim to work on updates - fix rpc command supportclaim's script e713501 - add rpc command getclaimsforname (returns all claims for name) 80bb42c a186aaa - work on rpc command getclaimforname (could be squashed to e713501) FOUND ISSUES: https://github.com/jimmykiselak/lbrycrd/blob/a186aaa073f01fe29bf8e7f8b35ade7243beb268/src/wallet/rpcwallet.cpp#L836 https://github.com/jimmykiselak/lbrycrd/blob/a186aaa073f01fe29bf8e7f8b35ade7243beb268/src/wallet/rpcwallet.cpp#L757 - needs doc update https://github.com/lbryio/lbrycrd/blob/31008a84b2662adc2469e45c2fd62e2fa88f902d/src/wallet/rpcwallet.cpp#L681 - bug OP_SUPPORT size is 2 Submitted pull request on this pull request https://github.com/jimmykiselak/lbrycrd/pull/1 to fix the above issues. Otherwise I think we can merge this, Jack used this commit to make a real support transaction.
kaykurokawa commented 2016-08-02 19:15:06 +02:00 (Migrated from github.com)

ACK, should be merged after testing downstream for the new rpc commands

ACK, should be merged after testing downstream for the new rpc commands
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbrycrd#15
No description provided.