The old code looked more correct to me. Why the change to an allocation? The modern c++ says that the new keyword is generally deprecated. Use std/boost::make_unique or make_shared if you really need to allocate on the heap, but try to avoid it generally.

The old code looked more correct to me. Why the change to an allocation? The modern c++ says that the `new` keyword is generally deprecated. Use `std/boost::make_unique` or `make_shared` if you really need to allocate on the heap, but try to avoid it generally.

bvbfan (Migrated from github.com) reviewed 2018-07-18 16:39:16 +02:00

src/test/claimtrieupdatebuffer_tests.cpp

bvbfan (Migrated from github.com) commented

2018-07-18 16:39:15 +02:00

Children are vector of shared pointers. new is not deprecated or so on

kaykurokawa commented

2018-07-19 19:12:17 +02:00

(Migrated from github.com)

I had some problem rebasing this, there is basically a commit here:
7d321ec0ea which looks like a failed merge commit that contained elements from unrelated commits.

I've resolved this in https://github.com/lbryio/lbrycrd/pull/175 so will be closing this one.

In the future, I suggest that you rebase commits that you are working on top of master instead of merging it.

I had some problem rebasing this, there is basically a commit here: 7d321ec0eac0a9cb14a3ef078f134a87f6aed956 which looks like a failed merge commit that contained elements from unrelated commits. I've resolved this in https://github.com/lbryio/lbrycrd/pull/175 so will be closing this one. In the future, I suggest that you rebase commits that you are working on top of master instead of merging it.

Pull request closed

This pull request cannot be reopened because the branch was deleted.

No reviewers

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbrycrd#160

No description provided.