LBRYCommunity/lbrycrd
1
0
Fork 0
Code Issues 29 Pull requests 1 Projects Releases 32 Packages Wiki Activity

Support for CLion Intellisense #177

Merged
BrannonKing merged 1 commit from clion_intellisense into master 2018-08-03 22:35:38 +02:00
Conversation 5 Commits 1 Files changed 2 +58
BrannonKing commented 2018-07-23 23:44:28 +02:00 (Migrated from github.com)
Copy link

(not to be used for a full compile of the project)

(not to be used for a full compile of the project)
lbrynaut commented 2018-07-26 21:03:24 +02:00 (Migrated from github.com)
Copy link

@BrannonKing I'm not sure why this is needed, but since it doesn't impact any existing code (and so long as it continues not to) and you're willing to maintain it, I don't see the harm. Perhaps it makes more sense to be moved into contrib/devtools though? If it must exist in the root directory, could it be sym-linked in autogen.sh or something?

@BrannonKing I'm not sure why this is needed, but since it doesn't impact any existing code (and so long as it continues not to) and you're willing to maintain it, I don't see the harm. Perhaps it makes more sense to be moved into contrib/devtools though? If it must exist in the root directory, could it be sym-linked in autogen.sh or something?
BrannonKing commented 2018-07-26 22:39:26 +02:00 (Migrated from github.com)
Copy link

@lbrynaut , it's needed for the CLion code navigation features to work. It does need to be in the root to work. I'm okay putting it into devtools plus a symlink as you suggest, although I would like to make it actually compile the full project once you're done merging in the current bitcoin codebase. At that point I think it's a legitimate part of the project; it would not require you to run autotools first.

@lbrynaut , it's needed for the CLion code navigation features to work. It does need to be in the root to work. I'm okay putting it into devtools plus a symlink as you suggest, although I would like to make it actually compile the full project once you're done merging in the current bitcoin codebase. At that point I think it's a legitimate part of the project; it would not require you to run autotools first.
lbrynaut commented 2018-07-26 22:42:06 +02:00 (Migrated from github.com)
Copy link

@BrannonKing Ok, makes sense. Will it still be self-contained in a single file in the root, or would it need additional structure?

@BrannonKing Ok, makes sense. Will it still be self-contained in a single file in the root, or would it need additional structure?
BrannonKing commented 2018-07-26 22:53:02 +02:00 (Migrated from github.com)
Copy link

Some people do argue for a CMakeLists.txt file in each subfolder, which is a possible approach. For myself, though, I like to keep it all in one at the parent level; it's easier to navigate that way.

Some people do argue for a CMakeLists.txt file in each subfolder, which is a possible approach. For myself, though, I like to keep it all in one at the parent level; it's easier to navigate that way.
👍 2
kaykurokawa (Migrated from github.com) reviewed 2018-08-03 13:27:06 +02:00
CMakeLists.txt
@ -0,0 +1,56 @@
cmake_minimum_required(VERSION 3.7)
project(lbrycrd_clion) # not expecting a full compile -- just something that allows clion syntax checking
kaykurokawa (Migrated from github.com) commented 2018-08-03 13:27:06 +02:00
Copy link

maybe make this more explicit, so people don't get confused what this file is for ?
"Do not use for full compile. This is for CLion syntax checking only".

maybe make this more explicit, so people don't get confused what this file is for ? "Do not use for full compile. This is for CLion syntax checking only".
kaykurokawa commented 2018-08-03 13:27:42 +02:00 (Migrated from github.com)
Copy link

a small nit,
untested but looks good to me.

a small nit, untested but looks good to me.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
area: devops

   
area: discovery

   
area: docs

   
area: livestream

   
area: proposal

Work is part of a proposal

  
consider soon

Discuss this issue at the next planning meeting, then remove this label

  
Epic

   
good first issue

   
hacktoberfest

Welcome to Hacktoberfest

  
hard fork

   
help wanted

   
icebox

Long-term storage

  
Invalid

   
level: 0

   
level: 1

No knowledge of the existing code required

  
level: 2

Some knowledge of the existing code is recommended

  
level: 3

Significant knowledge of the existing code is recommended

  
level: 4

Intimate knowledge of the existing code is recommended

  
needs: exploration

Solution unclear, needs research

  
needs: grooming

Issue needs to be groomed before work can start

  
needs: priority

Priority level needs to be defined

  
needs: repro

Issue needs step-by-step instructions on how to reproduce in latest code

  
needs: tech design

Needs technical design signoff before implementation can begin

  
on hold

Temporarily paused

  
priority: blocker

Issue is blocking release, do ASAP

  
priority: high

Work needs to be moved into sprint ASAP

  
priority: low

Work should be done but can stay in the backlog for now

  
priority: medium

Work needs to be done within 2-3 sprints

  
resilience

   
soft fork

   
Tom's Wishlist

   
type: bug

Existing functionality is wrong or broken

  
type: discussion

A conversation. No specific changes requested

  
type: improvement

Existing (or partially existing) functionality needs to be changed

  
type: new feature

New functionality that does not exist yet

  
type: refactor

Minimal user-visible changes, but significant internal work

  
type: task

Either work that's not related to the code, or a small chore that does not fit into other categories

  
type: testing

Solution needs additional user testing

  
unplanned

Work that was not planned into the spirnt, took priority over planned work

  
work in progress

The proposed solution is still incomplete.

No labels
area: devops
area: discovery
area: docs
area: livestream
area: proposal
consider soon
Epic
good first issue
hacktoberfest
hard fork
help wanted
icebox
Invalid
level: 0
level: 1
level: 2
level: 3
level: 4
needs: exploration
needs: grooming
needs: priority
needs: repro
needs: tech design
on hold
priority: blocker
priority: high
priority: low
priority: medium
resilience
soft fork
Tom's Wishlist
type: bug
type: discussion
type: improvement
type: new feature
type: refactor
type: task
type: testing
unplanned
work in progress
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbrycrd#177
No description provided.
Delete branch "clion_intellisense"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?