moved claimtrie_tests into claimtriebranching_tests #183

Merged

BrannonKing merged 1 commit from unify_claimtrie_tests into master

2018-08-08 00:03:54 +02:00

BrannonKing commented

2018-07-31 17:38:27 +02:00

(Migrated from github.com)

... to take advantage of the test fixture there. I also added other checks to the tests for the claimtrie root hash and some checks for the current claim count.

kaykurokawa (Migrated from github.com) reviewed

2018-07-31 17:38:27 +02:00

lbrynaut (Migrated from github.com) reviewed

2018-07-31 17:38:27 +02:00

kaykurokawa commented

2018-08-03 13:06:35 +02:00

(Migrated from github.com)

Looks good to Merge.

I think one thing to consider though regarding the tests that were brought in from claimtrie_tests that are similar to existing ones in claimtriebranching_tests:

insert_update_claim_test duplicates some tests on claimtrie_update_test and claim_test

claim_expiration_test duplicates some tests on claimtrie_expire_test

supporting_claims_test , supporting_claims_test_2 duplicates each other and some tests on support_test

I think combining these tests together so that there are less redundant tests would be nice. Would be nice to see in a separate PR but I think its not a huge priority.

Looks good to Merge. I think one thing to consider though regarding the tests that were brought in from claimtrie_tests that are similar to existing ones in claimtriebranching_tests: insert_update_claim_test duplicates some tests on claimtrie_update_test and claim_test claim_expiration_test duplicates some tests on claimtrie_expire_test supporting_claims_test , supporting_claims_test_2 duplicates each other and some tests on support_test I think combining these tests together so that there are less redundant tests would be nice. Would be nice to see in a separate PR but I think its not a huge priority.

No reviewers

lbrynaut

kaykurokawa

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

LBRYCommunity/lbrycrd!183

No description provided.

Rows
Columns