refactor getValueForClaim #191

Closed

shyba wants to merge 293 commits from getValueForClaim into master

shyba commented

2018-08-20 15:34:32 +02:00

(Migrated from github.com)

No description provided.

kaykurokawa commented

2018-08-20 20:34:03 +02:00

(Migrated from github.com)

This LGTM with me ( I will just fix formatting and merge)

Adding here that the original conditional statement before the || has off by one error (outpoint.n could be equal to vout.size()) and than the following statement after the || could cause a segfault :

coin->vout.size() < itClaims->outPoint.n || coin->vout[itClaims->outPoint.n].IsNull()

This LGTM with me ( I will just fix formatting and merge) Adding here that the original conditional statement before the || has off by one error (outpoint.n could be equal to vout.size()) and than the following statement after the || could cause a segfault : coin->vout.size() < itClaims->outPoint.n || coin->vout[itClaims->outPoint.n].IsNull()

kaykurokawa commented

2018-08-20 20:44:05 +02:00

(Migrated from github.com)

This has been merged 368a7389f4

This has been merged https://github.com/lbryio/lbrycrd/commit/368a7389f4917534a6c9370d1ce5b104b8934a32

Pull request closed

This pull request cannot be reopened because the branch was deleted.

No reviewers

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbrycrd#191

No description provided.