LBRYCommunity/lbrycrd
1
0
Fork 0
Code Issues 29 Pull requests 1 Projects Releases 32 Packages Wiki Activity

Do not create transactions with incorrect claims #192

Merged
bvbfan merged 1 commit from verify_claimid into master 2018-09-04 15:17:48 +02:00
Conversation 6 Commits 1 Files changed 1 +19
bvbfan commented 2018-08-20 16:45:01 +02:00 (Migrated from github.com)
Copy link

Signed-off-by: Anthony Fieroni bvbfan@abv.bg

Signed-off-by: Anthony Fieroni <bvbfan@abv.bg>
kaykurokawa (Migrated from github.com) reviewed 2018-08-20 16:45:01 +02:00
bvbfan commented 2018-08-20 16:47:41 +02:00 (Migrated from github.com)
Copy link

https://github.com/lbryio/lbrycrd/issues/116

https://github.com/lbryio/lbrycrd/issues/116
kaykurokawa (Migrated from github.com) reviewed 2018-08-21 04:11:41 +02:00
src/wallet/rpcwallet.cpp
@ -426,6 +426,10 @@ UniValue claimname(const UniValue& params, bool fHelp)
);
kaykurokawa (Migrated from github.com) commented 2018-08-21 04:11:40 +02:00
Copy link

while it is unintuitive, an empty claim name is actually valid (you can make claim for empty names when you use double quotes: "" in the RPC claimname command) so this check is not needed

while it is unintuitive, an empty claim name is actually valid (you can make claim for empty names when you use double quotes: "" in the RPC claimname command) so this check is not needed
kaykurokawa (Migrated from github.com) reviewed 2018-08-21 04:13:02 +02:00
src/wallet/rpcwallet.cpp
@ -849,2 +860,4 @@
string sName = params[0].get_str();
string sClaimId = params[1].get_str();
const size_t claimLength = 40;
kaykurokawa (Migrated from github.com) commented 2018-08-21 04:13:02 +02:00
Copy link

same here

same here
kaykurokawa (Migrated from github.com) reviewed 2018-08-21 04:15:32 +02:00
src/wallet/rpcwallet.cpp
@ -849,2 +860,4 @@
string sName = params[0].get_str();
string sClaimId = params[1].get_str();
const size_t claimLength = 40;
kaykurokawa (Migrated from github.com) commented 2018-08-21 04:15:31 +02:00
Copy link

There is actually a function created to check claimId here:
https://github.com/lbryio/lbrycrd/blob/master/src/rpc/claimtrie.cpp#L10

There is actually a function created to check claimId here: https://github.com/lbryio/lbrycrd/blob/master/src/rpc/claimtrie.cpp#L10
kaykurokawa (Migrated from github.com) reviewed 2018-08-21 04:20:49 +02:00
src/wallet/rpcwallet.cpp
@ -536,1 +544,4 @@
{
if (op == OP_SUPPORT_CLAIM)
continue;
kaykurokawa (Migrated from github.com) commented 2018-08-21 04:20:49 +02:00
Copy link

good catch.. I think this would have been problematic if the decoded claim script was a support...

good catch.. I think this would have been problematic if the decoded claim script was a support...
bvbfan commented 2018-08-21 09:32:36 +02:00 (Migrated from github.com)
Copy link

rpc/claimtrie.cpp is a part of libbitcoin_server while rpcwallet of libbitcoin_wallet that's why i'm including only 2 checks from ParseClaimtrieId not compete one.

rpc/claimtrie.cpp is a part of libbitcoin_server while rpcwallet of libbitcoin_wallet that's why i'm including only 2 checks from ParseClaimtrieId not compete one.
lbrynaut (Migrated from github.com) requested changes 2018-08-29 20:18:02 +02:00
lbrynaut (Migrated from github.com) left a comment
Copy link

Please fix the travis issue.

Please fix the travis issue.
src/wallet/rpcwallet.cpp
lbrynaut (Migrated from github.com) commented 2018-08-29 19:50:26 +02:00
Copy link

"value must be hexadecimal" or something like that is a fine description (typos above: contains, hexdecimal, also omit the omit warning)

"value must be hexadecimal" or something like that is a fine description (typos above: contains, hexdecimal, also omit the omit warning)
src/wallet/rpcwallet.cpp
lbrynaut (Migrated from github.com) commented 2018-08-29 19:50:49 +02:00
Copy link

Same as above, just a wording difference/typo fix.

Same as above, just a wording difference/typo fix.
src/wallet/rpcwallet.cpp
lbrynaut (Migrated from github.com) commented 2018-08-29 19:52:36 +02:00
Copy link
if (op == OP_SUPPORT_CLAIM)
    continue;
``` if (op == OP_SUPPORT_CLAIM) continue; ```
src/wallet/rpcwallet.cpp
lbrynaut (Migrated from github.com) commented 2018-08-29 19:53:18 +02:00
Copy link

Reverse these (non-standard style otherwise)

Reverse these (non-standard style otherwise)
lbrynaut (Migrated from github.com) commented 2018-08-29 19:57:58 +02:00
Copy link

Since 40 is not declared as a fixed constexpr, but used as a fixed constexpr, either declare it as something const (not constexpr since not C++11) and use that, or just change this to something like:

"claimid must be of length 40"
Since 40 is not declared as a fixed constexpr, but used as a fixed constexpr, either declare it as something const (not constexpr since not C++11) and use that, or just change this to something like: ``` "claimid must be of length 40" ```
bvbfan commented 2018-08-30 09:35:01 +02:00 (Migrated from github.com)
Copy link

Fix addressed issues.

Fix addressed issues.
bvbfan commented 2018-08-30 09:43:28 +02:00 (Migrated from github.com)
Copy link

Mac build looks broken again.

Mac build looks broken again.
lbrynaut (Migrated from github.com) reviewed 2018-08-30 19:53:36 +02:00
lbrynaut (Migrated from github.com) left a comment
Copy link

Untested, but looks good to me, pending a travis build fix.

Untested, but looks good to me, pending a travis build fix.
lbrynaut (Migrated from github.com) approved these changes 2018-08-30 19:53:50 +02:00
lbrynaut (Migrated from github.com) requested changes 2018-08-30 19:58:02 +02:00
lbrynaut (Migrated from github.com) left a comment
Copy link

I'll leave this on 'request changes' instead of 'approve' until the travis issue is resolved.

I'll leave this on 'request changes' instead of 'approve' until the travis issue is resolved.
BrannonKing commented 2018-08-30 22:33:23 +02:00 (Migrated from github.com)
Copy link

Rebase off master again and the OSX build will be fixed.

Rebase off master again and the OSX build will be fixed.
bvbfan commented 2018-08-31 11:44:30 +02:00 (Migrated from github.com)
Copy link

Done

Done
Sign in to join this conversation.
Reviewers
No reviewers
kaykurokawa
lbrynaut
Labels
Clear labels   
area: devops

   
area: discovery

   
area: docs

   
area: livestream

   
area: proposal

Work is part of a proposal

  
consider soon

Discuss this issue at the next planning meeting, then remove this label

  
Epic

   
good first issue

   
hacktoberfest

Welcome to Hacktoberfest

  
hard fork

   
help wanted

   
icebox

Long-term storage

  
Invalid

   
level: 0

   
level: 1

No knowledge of the existing code required

  
level: 2

Some knowledge of the existing code is recommended

  
level: 3

Significant knowledge of the existing code is recommended

  
level: 4

Intimate knowledge of the existing code is recommended

  
needs: exploration

Solution unclear, needs research

  
needs: grooming

Issue needs to be groomed before work can start

  
needs: priority

Priority level needs to be defined

  
needs: repro

Issue needs step-by-step instructions on how to reproduce in latest code

  
needs: tech design

Needs technical design signoff before implementation can begin

  
on hold

Temporarily paused

  
priority: blocker

Issue is blocking release, do ASAP

  
priority: high

Work needs to be moved into sprint ASAP

  
priority: low

Work should be done but can stay in the backlog for now

  
priority: medium

Work needs to be done within 2-3 sprints

  
resilience

   
soft fork

   
Tom's Wishlist

   
type: bug

Existing functionality is wrong or broken

  
type: discussion

A conversation. No specific changes requested

  
type: improvement

Existing (or partially existing) functionality needs to be changed

  
type: new feature

New functionality that does not exist yet

  
type: refactor

Minimal user-visible changes, but significant internal work

  
type: task

Either work that's not related to the code, or a small chore that does not fit into other categories

  
type: testing

Solution needs additional user testing

  
unplanned

Work that was not planned into the spirnt, took priority over planned work

  
work in progress

The proposed solution is still incomplete.

No labels
area: devops
area: discovery
area: docs
area: livestream
area: proposal
consider soon
Epic
good first issue
hacktoberfest
hard fork
help wanted
icebox
Invalid
level: 0
level: 1
level: 2
level: 3
level: 4
needs: exploration
needs: grooming
needs: priority
needs: repro
needs: tech design
on hold
priority: blocker
priority: high
priority: low
priority: medium
resilience
soft fork
Tom's Wishlist
type: bug
type: discussion
type: improvement
type: new feature
type: refactor
type: task
type: testing
unplanned
work in progress
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbrycrd#192
No description provided.
Delete branch "verify_claimid"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?