Rebase lbry on to Bitcoin 0.17. #266

2019-05-02T18:40:35+02:00

lbrynaut commented

2019-05-02 18:40:35 +02:00

(Migrated from github.com)

This contains significant rebase / merge / testing work by Naut
lbrynaut@protonmail.com, Anthony Fieroni bvbfan@abv.bg and Brannon
King countprimes@gmail.com.

This contains significant rebase / merge / testing work by Naut <lbrynaut@protonmail.com>, Anthony Fieroni <bvbfan@abv.bg> and Brannon King <countprimes@gmail.com>.

BrannonKing (Migrated from github.com) requested changes 2019-05-02 19:43:09 +02:00

src/test/denialofservice_tests.cpp

					
				@ -150,0 +152,4 @@

				    // NOTE: STALE_CHECK_INTERVAL is static that why we use raw value 10 * 60, sync may need in future

				    auto time = std::max({static_cast<int64_t>(10 * 60), 3 * consensusParams.nPowTargetSpacing});

BrannonKing (Migrated from github.com) commented

2019-05-02 19:39:08 +02:00

braces?

src/util.cpp

BrannonKing (Migrated from github.com) commented

2019-05-02 19:32:05 +02:00

Why is this removed?

src/wallet/wallet.cpp

BrannonKing (Migrated from github.com) commented

2019-05-02 19:36:49 +02:00

This seems wrong; we don't want to count our held claims as available change.

src/wallet/wallet.cpp

BrannonKing (Migrated from github.com) commented

2019-05-02 19:36:18 +02:00

I don't think we want this. We don't want to count our claims as spendable change. The old wallet didn't have it.

lbrynaut (Migrated from github.com) reviewed 2019-05-02 20:22:41 +02:00

src/util.cpp

lbrynaut (Migrated from github.com) commented

2019-05-02 20:22:40 +02:00

OpenSSL was removed from the core code. Every project should remove it.

lbrynaut (Migrated from github.com) reviewed 2019-05-02 20:28:49 +02:00

src/wallet/wallet.cpp

lbrynaut (Migrated from github.com) commented

2019-05-02 20:28:48 +02:00

Not sure what you mean. https://github.com/lbryio/lbrycrd/blob/legacy_master/src/wallet/wallet.cpp#L1152

lbrynaut (Migrated from github.com) reviewed 2019-05-02 20:28:59 +02:00

src/wallet/wallet.cpp

lbrynaut (Migrated from github.com) commented

2019-05-02 20:28:59 +02:00

https://github.com/lbryio/lbrycrd/blob/legacy_master/src/wallet/wallet.cpp#L1004

BrannonKing (Migrated from github.com) reviewed 2019-05-02 20:35:12 +02:00

src/wallet/wallet.cpp

BrannonKing (Migrated from github.com) commented

2019-05-02 20:35:12 +02:00

My bad. I was looking in the wrong spot.

BrannonKing (Migrated from github.com) approved these changes 2019-05-02 20:40:30 +02:00

lbrynaut (Migrated from github.com) reviewed 2019-05-02 20:40:57 +02:00

src/test/denialofservice_tests.cpp

					
				@ -150,0 +152,4 @@

				    // NOTE: STALE_CHECK_INTERVAL is static that why we use raw value 10 * 60, sync may need in future

				    auto time = std::max({static_cast<int64_t>(10 * 60), 3 * consensusParams.nPowTargetSpacing});

lbrynaut (Migrated from github.com) commented

2019-05-02 20:40:57 +02:00

Could be wrong, but I think this was a test @bvbfan worked on. In any case, std::max can take an initializer list, so there's really no difference (functionally) if they're removed other than style preference.

Pull request closed

This pull request cannot be reopened because the branch was deleted.

Sign in to join this conversation.

No reviewers

BrannonKing

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbrycrd#266