repair bad hash computation in miner #283

Merged

BrannonKing merged 1 commit from bad_hash_in_miner into master

2019-06-17 17:40:35 +02:00

BrannonKing commented

2019-06-12 21:09:21 +02:00

(Migrated from github.com)

fixed ancestors not all in claim trie on packageFees condition

lbrynaut (Migrated from github.com) reviewed 2019-06-12 21:09:21 +02:00

bvbfan (Migrated from github.com) reviewed 2019-06-13 09:41:36 +02:00

src/miner.cpp

bvbfan (Migrated from github.com) commented

2019-06-13 07:46:46 +02:00

Break or return does not make any difference. After the loop we end up with function return. I don't think we should throw away all txs after a low fee one.

BrannonKing (Migrated from github.com) reviewed 2019-06-13 17:04:47 +02:00

src/miner.cpp

BrannonKing (Migrated from github.com) commented

2019-06-13 17:04:46 +02:00

As I understand it, this is a miner's feature. We're reading in transactions in order of highest fee density to lowest fee density. You can configure the minimum fee per byte, and if we go below that we're done. Miners want the privilege of being able to ignore transactions below a certain fee; it's to their advantage to hash less data. This will become more important as the mined block payment reduces over time.

bvbfan (Migrated from github.com) reviewed 2019-06-13 17:16:56 +02:00

src/miner.cpp

bvbfan (Migrated from github.com) commented

2019-06-13 17:16:56 +02:00

Ah, i see get it by ancestor_score it will be from high to low, so after that all other txs are with lowest fee - then ok, we can keep return as well.

No reviewers

lbrynaut

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbrycrd#283

No description provided.