Change max block decrement amount to 50 #56

Merged
kaykurokawa merged 1 commit from change_block_decrements into master 2017-01-13 16:35:24 +01:00
kaykurokawa commented 2017-01-04 23:59:25 +01:00 (Migrated from github.com)

Increase the maximum amount that a rpc call is allowed to decrement blocks from 20 to 50. This affects how far RPC command getprooforname, used by lbryum, can go back in blocks.

Calling getproofforname and going back 50 blocks takes about 0.009 seconds (going back 20 blocks takes about 0.007) which should not be too much of a load increase.

This should decrease cases where we get the error "Block too deep to generate proof" from lbryum when calling its getvalueforname command.

Increase the maximum amount that a rpc call is allowed to decrement blocks from 20 to 50. This affects how far RPC command getprooforname, used by lbryum, can go back in blocks. Calling getproofforname and going back 50 blocks takes about 0.009 seconds (going back 20 blocks takes about 0.007) which should not be too much of a load increase. This should decrease cases where we get the error "Block too deep to generate proof" from lbryum when calling its getvalueforname command.
jobevers commented 2017-01-06 19:13:07 +01:00 (Migrated from github.com)

dumb question - what have a limit at all?

dumb question - what have a limit at all?
kaykurokawa commented 2017-01-06 19:58:58 +01:00 (Migrated from github.com)

Going back too many blocks will take too long. You don't want lbryum instances requesting the value for block index 1, causing lbrycrd to roll back thousands of blocks and holding up all other requests.

Ideally, we should store proofs for past blocks on lbryum server , instead of getting it from lbrycrd.

Going back too many blocks will take too long. You don't want lbryum instances requesting the value for block index 1, causing lbrycrd to roll back thousands of blocks and holding up all other requests. Ideally, we should store proofs for past blocks on lbryum server , instead of getting it from lbrycrd.
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbrycrd#56
No description provided.