9fececb2cb
This removes another callback from block connection logic, making it easier to reason about the wallet-RPCs-returns-stale-info issue. UpdatedTransaction was previously used by the GUI to display coinbase transactions only after they have a block built on top of them. This worked fine for in most cases, but only worked due to a corner case if the user received a coinbase payout in a block immediately prior to restart. In that case, the normal process of caching the most recent coinbase transaction's hash would not work, and instead it would only work because of the on-load -checkblocks calling DisconnectBlock and ConnectBlock on the current tip. In order to make this more robust, a full mapWallet loop after the first block which is connected after restart was added.
85 lines
4.1 KiB
C++
85 lines
4.1 KiB
C++
// Copyright (c) 2009-2010 Satoshi Nakamoto
|
|
// Copyright (c) 2009-2016 The Bitcoin Core developers
|
|
// Distributed under the MIT software license, see the accompanying
|
|
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
|
|
#ifndef BITCOIN_VALIDATIONINTERFACE_H
|
|
#define BITCOIN_VALIDATIONINTERFACE_H
|
|
|
|
#include <boost/signals2/signal.hpp>
|
|
#include <memory>
|
|
|
|
#include "primitives/transaction.h" // CTransaction(Ref)
|
|
|
|
class CBlock;
|
|
class CBlockIndex;
|
|
struct CBlockLocator;
|
|
class CBlockIndex;
|
|
class CConnman;
|
|
class CReserveScript;
|
|
class CValidationInterface;
|
|
class CValidationState;
|
|
class uint256;
|
|
|
|
// These functions dispatch to one or all registered wallets
|
|
|
|
/** Register a wallet to receive updates from core */
|
|
void RegisterValidationInterface(CValidationInterface* pwalletIn);
|
|
/** Unregister a wallet from core */
|
|
void UnregisterValidationInterface(CValidationInterface* pwalletIn);
|
|
/** Unregister all wallets from core */
|
|
void UnregisterAllValidationInterfaces();
|
|
|
|
class CValidationInterface {
|
|
protected:
|
|
virtual void UpdatedBlockTip(const CBlockIndex *pindexNew, const CBlockIndex *pindexFork, bool fInitialDownload) {}
|
|
virtual void TransactionAddedToMempool(const CTransactionRef &ptxn) {}
|
|
virtual void BlockConnected(const std::shared_ptr<const CBlock> &block, const CBlockIndex *pindex, const std::vector<CTransactionRef> &txnConflicted) {}
|
|
virtual void BlockDisconnected(const std::shared_ptr<const CBlock> &block) {}
|
|
virtual void SetBestChain(const CBlockLocator &locator) {}
|
|
virtual void Inventory(const uint256 &hash) {}
|
|
virtual void ResendWalletTransactions(int64_t nBestBlockTime, CConnman* connman) {}
|
|
virtual void BlockChecked(const CBlock&, const CValidationState&) {}
|
|
virtual void GetScriptForMining(std::shared_ptr<CReserveScript>&) {};
|
|
virtual void NewPoWValidBlock(const CBlockIndex *pindex, const std::shared_ptr<const CBlock>& block) {};
|
|
friend void ::RegisterValidationInterface(CValidationInterface*);
|
|
friend void ::UnregisterValidationInterface(CValidationInterface*);
|
|
friend void ::UnregisterAllValidationInterfaces();
|
|
};
|
|
|
|
struct CMainSignals {
|
|
/** Notifies listeners of updated block chain tip */
|
|
boost::signals2::signal<void (const CBlockIndex *, const CBlockIndex *, bool fInitialDownload)> UpdatedBlockTip;
|
|
/** Notifies listeners of a transaction having been added to mempool. */
|
|
boost::signals2::signal<void (const CTransactionRef &)> TransactionAddedToMempool;
|
|
/**
|
|
* Notifies listeners of a block being connected.
|
|
* Provides a vector of transactions evicted from the mempool as a result.
|
|
*/
|
|
boost::signals2::signal<void (const std::shared_ptr<const CBlock> &, const CBlockIndex *pindex, const std::vector<CTransactionRef> &)> BlockConnected;
|
|
/** Notifies listeners of a block being disconnected */
|
|
boost::signals2::signal<void (const std::shared_ptr<const CBlock> &)> BlockDisconnected;
|
|
/** Notifies listeners of a new active block chain. */
|
|
boost::signals2::signal<void (const CBlockLocator &)> SetBestChain;
|
|
/** Notifies listeners about an inventory item being seen on the network. */
|
|
boost::signals2::signal<void (const uint256 &)> Inventory;
|
|
/** Tells listeners to broadcast their data. */
|
|
boost::signals2::signal<void (int64_t nBestBlockTime, CConnman* connman)> Broadcast;
|
|
/**
|
|
* Notifies listeners of a block validation result.
|
|
* If the provided CValidationState IsValid, the provided block
|
|
* is guaranteed to be the current best block at the time the
|
|
* callback was generated (not necessarily now)
|
|
*/
|
|
boost::signals2::signal<void (const CBlock&, const CValidationState&)> BlockChecked;
|
|
/** Notifies listeners that a key for mining is required (coinbase) */
|
|
boost::signals2::signal<void (std::shared_ptr<CReserveScript>&)> ScriptForMining;
|
|
/**
|
|
* Notifies listeners that a block which builds directly on our current tip
|
|
* has been received and connected to the headers tree, though not validated yet */
|
|
boost::signals2::signal<void (const CBlockIndex *, const std::shared_ptr<const CBlock>&)> NewPoWValidBlock;
|
|
};
|
|
|
|
CMainSignals& GetMainSignals();
|
|
|
|
#endif // BITCOIN_VALIDATIONINTERFACE_H
|